- ๐ฌ๐งUnited Kingdom catch
This still needs design review. Either from the Olivero team or from a product manager I think.
- ๐ณ๐ดNorway eiriksm Norway
That being said, it's still possible to trigger in other ways than with a constant. It was just randomly how I discovered it back in the day (can't even remember reporting it hehe time flies)
- ๐จ๐ญSwitzerland saschaeggi Zurich
We have scrollable tables with scroll indicators in Gin
So we might want to consider re-using Ginโs implementation here also to avoid potential conflicts and issues
- ๐บ๐ธUnited States smustgrave
Left 1 comment on the MR. Think adding a small example would be nice as I don't know if the text I provide if the code is auto generating the selector (.) to the front.
Rest of the feedback appears to be addresses so believe this is 98% there.
- ๐ฆ๐บAustralia acbramley
I'm not really sure this is something we should support. It's also been 9 years since there was work done here that wasn't a reroll. The fix seems to apply to a much broader scope than defining constants. Generally we would discourage global constants now anyway as they can be placed in various OO contexts (or Enums). I think this should be closed as won't fix.
- ๐ฌ๐งUnited Kingdom oily Greater London
The comments seem clearer now in line with recommendations.
- ๐บ๐ธUnited States smustgrave
Feedback for this one appears to be addressed.
- ๐บ๐ธUnited States smustgrave
This came up as a daily bugsmash target.
When I triaged it in 2022 I probably should of tagged it. But will need a clear issue summary using the standard template.
Fixes are in MRs now and test coverage will still be needed.
- @bhanu951 opened merge request.
- First commit to issue fork.
- ๐ณ๐ฟNew Zealand quietone
This is changing the UI so tagging for Usability and, as such, screenshots should be available to reviewers and committers from the Issue Summary.
The comment in #12/#19 still needs to be addressed but adding more details is expanding the scope of this issue. I think that should be in another issue. And while #8 is right that the machine name is removed, it is overall, an improvement for users of the uninstall page. This is a acceptable incremental step to improving the page for the user.
I do think this should be tested so there is no regression. There are many sibling issues which will be changing the text on the uninstall page so we should test as we go along. There is an existing test for the uninstall page, so hopefully, this will be straightforward,
\Drupal\Tests\system\Functional\Module\UninstallTest::testUninstallPage - ๐ฎ๐ณIndia mohit_aghera Rajkot
Hi @xjm
I've fixed the following issues from comment #19- Point 1
- Point 2
Comment is updated for both the cases.
Regarding point 3:
- I've added the new test that validates both the points.
Fixed few more things in the MRAbout the
custom_url
option:
- Primarily it is visible on the block plugin display and other non-page display.
So I believe we should hide it from the page display?Probably we can use the inputs from the sub-system maintainer.
This might cause confusion to people as `More` link on the page display might not make sense.I notice that there is no option to configure the link, it just allows to enable/disable link.
Which is correct if we want to keep option.I'm happy to walk you through the views setup, feel free to ping me in #bugsmash.
Regarding #20
I agree with you for this one.
We can disable it from the page display and keep it active for block display.Hiding the patches since we have a MR now.
Keeping issue in needs works since there are a few unrelated test failures that I'm looking into it. -
alexpott โ
committed 9e7842eb on 11.x
Issue #2927338 by berdir, anmolgoyal74, swatichouhan012, smustgrave,...
-
alexpott โ
committed 9e7842eb on 11.x
-
alexpott โ
committed 045cc0e4 on 11.1.x
Issue #2927338 by berdir, anmolgoyal74, swatichouhan012, smustgrave,...
-
alexpott โ
committed 045cc0e4 on 11.1.x
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed 9e7842eb89c to 11.x and 045cc0e43f6 to 11.1.x. Thanks!
- ๐จ๐พCyprus alex.bukach
Agree @vidorado, the proper fix is to find the formatter(s) that return NULL and fix them.
- @mohit_aghera opened merge request.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
@joseph.olstad Perhaps what you expect is only valid for your specific use case?
When creating a node in French, the preview displays the original, not-yet-saved French translation of the node, and the tag is shown in the entity's language. Isn't that the expected behavior?
- ๐บ๐ธUnited States smustgrave
Since it's been 6+ months without a follow up for steps going to close out. If still an issue please reopen
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
I believe we shouldn't suppress errors caused by a contrib or custom
FieldFormatter
. The return type ofFieldFormatterInterface::viewElements()
is explicitly defined asarray
, so no formatter should returnNULL
.I would close this as "Works as designed."
- ๐ฉ๐ชGermany harkonn
There was a bug with #45. Adding references to empty fields caused
Warning: Undefined variable $existing_target_ids in Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator->validate() (Line 140 in project\docroot\core\lib\Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator.php)
I fixed this bug by initialising the variable properly and i commited these changes to the issue fork / merge request.
- ๐บ๐ธUnited States nicxvan
The children are in this can be updated.
We can't remove the deprecated but we can make it easier in the future.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
The last MR commit was silencing the filesize test, which was failing after the fix, so I've restored it. Additionally, I've tested also that the file size is only validated over new files.
@kim.pepper, thanks for pointing the deprecation out. I've seen that it was already addressed in the existing MR commit.
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐บ๐ธUnited States smustgrave
Opened ๐ Fix BlockViewBuilder to handle NULL and [] Active per #23
Ran the test-only feature to show the coverage
Looking at the change don't see anything else pending. LGTM
Has anyone updated the patch for Drupal 10.4.x?
2950869-139.patch ๐ Entity queries querying the latest revision very slow with lots of revisions Needs work fails on 10.4.1.Thanks
- ๐ฌ๐งUnited Kingdom nicrodgers Monmouthshire, UK
Changing back to a bug as per #28
TODO steps as per #61