#Needs Review Queue Initiative

Hello,
I would like to separate JS, CSS and PHP directories in the public files, into a "sites/default/files/assets" folder, for example.

I've used, in Drupal 10.4.5, $settings['file_assets_path'] but it does'nt works: no CSS/JS/PHP files are created, even after cache_rebuild.

Not sure that all the used "assets://css" or "assets://js" are found.
When I load a page, the css, js or oho folders aren't created.

How does $settings['file_assets_path'] is supposed to work please ?

Thank you by advance for an answer.

Regards

All right, perhaps it's most efficient, if you update the Issue Summary to more precisely reflect the remaining tasks? The other issue probably then also needs to be updated.

I've opened a new MR against 11.x with the implementation from https://git.drupalcode.org/project/drupal/-/merge_requests/9108 and then test coverage from https://git.drupalcode.org/project/drupal/-/merge_requests/1529

IMO the implementation is a bit clearer with the indexes added directly in getEntitySchema

acbramley → changed the visibility of the branch 11.x to hidden.

acbramley → changed the visibility of the branch 10.1.x to hidden.

In #44 I expected that we would do the deprecation (but not the removal) here. That's why I suggested a new change record.

I created 📌 Deprecate and remove Olivero Medium date format Active .

Rebased changes on 11.x and added a new test case for this issue

clement.ferrier → changed the visibility of the branch 2941073-entityquery-doesnt-support-OR-with-langcodes to hidden.

clement.ferrier → closed merge request !1342

clement.ferrier → changed the visibility of the branch 2941073-9.3.x to hidden.

clement.ferrier → changed the visibility of the branch 2941073-entityquery-doesnt-support to hidden.

Thanks for fixing that, seems like good test coverage. LGTM.

MR is green now.
Moving back to NR

Patch #56 works on 10.4.2

Adding "Review Change record Default date formats have been expanded with date only formats → " in Issue summary under Remaining tasks".

But the Olivero format is not touched, please check my last comment or the MR.

I'm not sure how we deprecate a config entity. But definitely we should have a specific change record for the olivero date format.

#28 doesn’t seem to be explored.

Summary and solution don’t line up

So moving to NW

I was working with @gayathri09 on one of the mentoring session and misunderstood the issue (Sorry gayathri09). We are still missing the setPlugin in interface and can't inheritdoc. I added the docbock in the MR.

This method has been removed from the interface in core 11.2.x

set plugin method is in core/modules/system/src/Entity/Action.php below is the document link about it. https://api.drupal.org/api/drupal/core%21modules%21system%21src%21Entity%21Action.php/function/Action%3A%3AsetPlugin/11.x

Great catch @mstrelan, and @penyaskito also noticed this ("olivero_medium shouldn't be deleted. We know how it's being used in core, but not how could be used in contrib/custom sites.")

So In the end, "Olivero Medium" was not removed. The only Olivero theme-related change was Olivero theme using a new format:

But since the "Olivero Medium" date format stays, and you documented many more places where olivero_medium is in use, I removed the Olivero theme update as well. (And great way to use GitLab to search the code base of all contrib projects, BTW!)

So now this MR only adds three new date only date formats, and updates the Announcements feed to use short_date_only.

But this may need a change record? I have created a draft Default date formats have been expanded with date only formats → .

Do we need a CR for the new formats and the removal of Olivero Medium? We had one last time formats changed - https://www.drupal.org/node/3467774 →

In general I agree with removing Olivero Medium, but isn't it possible there are existing configs depending on this? I found at least 38 references in code after filtering out the cruft - https://git.drupalcode.org/search?group_id=2&scope=blobs&search=olivero_...

These tend to be in recipes, formatter config, views fields and tokens.

I think maybe we need a follow up to deprecate and remove it.

I've just done some profiling of a site that was relying on this behaviour - a very large menu with about 180 enabled links and 1500+ disabled links, the disabled links are being used so that menu_breadcrumb will match the disabled links to the enabled parent items.

That set-up is causing other problems but would definitely break as a result of the fix here, so on the basis that potentially more than one site might be doing some version of this, I think we need a release note and a change record.

Thanks for working on this!

On a related note, I recently noticed that an empty prefix for a language, which is not the default language, can get restored when you add another language, and I created an issue.