- Issue created by @ressa
- 🇺🇸United States smustgrave
Going to have and look at this later. Not sure why migration test had to be updated
- 🇩🇰Denmark ressa Copenhagen
Thanks for looking at this so fast.
It's the function below. And since there are three more date formats, the
date_format
count increases from 12 to 15:/** * {@inheritdoc} */ protected function getEntityCounts(): array { return [ 'block' => 37, 'block_content' => 2, 'block_content_type' => 1, [...] 'date_format' => 15, 'entity_form_display' => 23, 'entity_form_mode' => 1, 'entity_view_display' => 33, 'entity_view_mode' => 11, 'base_field_override' => 2, ]; }
In:
/core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6Test.php
/core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php
- 🇺🇸United States smustgrave
Seems like a fine addition and no objection. I didn't see any recipe that was installing datetime formats
Also doesn't feel like something that would need test coverage as just offering more options.
- 🇩🇰Denmark ressa Copenhagen
At the risk of repeating myself, the Needs Review Queue Initiative is among the best things to happen to Drupal the last few years, and the community can't be grateful enough, so thank you @smustgrave!
- 🇬🇧United Kingdom catch
Very minor but I'm wondering if these could be e.g. 'Medium date (without time)', rather than starting with 'no time'.
Since this is user-facing tagging for product manager review.
- 🇩🇰Denmark ressa Copenhagen
Thanks @catch, great suggestion and I updated the id's and labels. Perhaps you can review and check if "Needs Review" by product manager is still the case?
- 🇬🇧United Kingdom catch
@ressa yes it changes out of the box behaviour so I think it could use it.
- 🇩🇰Denmark ressa Copenhagen
Sorry if it wasn't clear, I just meant that if it still looks good to you after my update, then you should feel free to change status to Needs Review :)
- Status changed to Needs review
17 days ago 9:13pm 8 April 2025 - 🇫🇮Finland lauriii Finland
Seems fine from product perspective. I've wondered several times myself why we don't have these out of the box 🥲