🇺🇸United States @smustgrave

Account created on 30 June 2015, over 9 years ago
  • Software Engineer at Mobomo 
#

Merge Requests

More

Recent comments

🇺🇸United States smustgrave

Can the CR be tweaked some. The code snippets are those suppose to be before/after?

🇺🇸United States smustgrave

Curious why does this not affect 11.x? Code appears to be the same.

🇺🇸United States smustgrave

@longwave going to go on a limb and say this is good. The lock file seems to only show the new dependency I believe.

🇺🇸United States smustgrave

Yea the new MR dropped the test coverage from the original MR. One should also be close.d

🇺🇸United States smustgrave

Believe all feedback has been addressed

🇺🇸United States smustgrave

Eh I’ll take your word. Don’t want to increase LOE for something that seems to make sense I think. And doesn’t break anything.

Going to take a swing

🇺🇸United States smustgrave

The one out of scope change if it's being suggested it fixes 🐛 Big Pipe, logged-in users and 4xx pages Active then think test coverage here should be expanded to include that ticket scenario too. And if that's the case we can close the other issue and move over credit.

3349201 also mentions once it's solved 🐛 Requests are pushed onto the request stack twice, popped once Needs work would be solved too so curious if this hits 3 issues actually?

🇺🇸United States smustgrave

Got here from 📌 Make language switcher block cacheable Postponed but noticed it needs a rebase. Wonder if during the rebase if also can get the CR?

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

🇺🇸United States smustgrave

Left 1 small comment on MR

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

🇺🇸United States smustgrave

Left 1 comment on the MR. Think adding a small example would be nice as I don't know if the text I provide if the code is auto generating the selector (.) to the front.

Rest of the feedback appears to be addresses so believe this is 98% there.

🇺🇸United States smustgrave
  *   - "create".
   *   - "update".
   *   - "delete".

We sure this is an improvement? Seems odd to have periods after a single word.

🇺🇸United States smustgrave

Issue summary needs some work as the proposed solution is not flushed out.

Left a comment on the MR.

🇺🇸United States smustgrave

Rebased as it was 590 commits back. Still green.

@rkoller do you want to open the follow up you mentioned?

Seems like there could be some net gain here even if not 100% perfecrt.

🇺🇸United States smustgrave

@mstrelan mention in the meta the gain may be minimal but still think worth to it. Believe all threads have been resolved and merge conflicts addressed. Going to go on a limb and say this is good.

🇺🇸United States smustgrave

@berdir you opened several threads. Looking for feedback on those or just general comments?

🇺🇸United States smustgrave

Thank you for reporting

So you had it right the first time pointing to 11.x, think of that as the main branch. Fixes will have to land there first.

Also as a bug we will need some test coverage also

Thanks.

🇺🇸United States smustgrave

can the steps be written out don't really follow adding the fields as steps. If no steps can be provided think this will be closed out.

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

This came up as a daily bugsmash target.

When I triaged it in 2022 I probably should of tagged it. But will need a clear issue summary using the standard template.

Fixes are in MRs now and test coverage will still be needed.

🇺🇸United States smustgrave

@ksenzee fixed it for me too. Think it's fine to mark

🇺🇸United States smustgrave

Assuming NR for feedback for approach? Could the issue summary be filled out to clear up for proposed solution. Easier for reviews

It only fixes the problem for the datetime-local element but datetime element also uses the 'html_datetime' format and would break the same way

I'm 50/50 that this should be fixed here too or could be it's own issue. Guess it depends if the code is the same spot.

We should introduce tests

100% thanks for tagging for that!

🇺🇸United States smustgrave

Can summary be updated. The title mentions deprecating getFormNames() pretty straight forward. But the MR appears to be doing extra stuff, so think that should be marked so easier to review.

🇺🇸United States smustgrave

There's nothing to commit so odds are this can be closed out as outdated or unable to reproduce. Putting to PNMI for someone to provide steps if they are still seeing this issue before closing out.

🇺🇸United States smustgrave

Would recommend adding test coverage to show the solution works.

🇺🇸United States smustgrave

Removing tests tag as the test-only run shows the coverage

1) Drupal\KernelTests\Components\ComponentRenderTest::testRender
Drupal\Core\Render\Component\Exception\InvalidComponentDataException: Unable to render component "sdc_test:my-banner". A render array or a scalar is expected for the slot "banner_body" when using the render element with the "#slots" property

Summary seems clear with clear proposal that lines up with the code change.

Code change seems pretty straightforward and see no objection.

LGTM

🇺🇸United States smustgrave

If I’m looking at the code correctly if the setting is TRUE there will be a warning on the status page

🇺🇸United States smustgrave

Appears to need rebase

@borisson wonder if it will be caught by ?

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

🇺🇸United States smustgrave

Appears to be other instances in the api file that are using label but correct key may be title. That needs to be verified too.

🇺🇸United States smustgrave

Used the script provided and believe all instances have been found.

🇺🇸United States smustgrave

Can you update MR for 3.0.x

🇺🇸United States smustgrave

Probably checking that the setting does what described. And message appears on the status report page

🇺🇸United States smustgrave

Should ckrina or plopsec be one to review

🇺🇸United States smustgrave

Could we add test coverage for this?

Only concern is I know the new development settings was meant to not be captured in config/repo. This change can kinda undo that

🇺🇸United States smustgrave

First glance should have test coverage for the update hook. Simple check schema, run updates, check schema again

🇺🇸United States smustgrave

Since it's been 6+ months without a follow up for steps going to close out. If still an issue please reopen

🇺🇸United States smustgrave

Seems good now

🇺🇸United States smustgrave

Reviewed the MR and don't see any open discussions or tasks. Believe this one should be good to include in 11.2

🇺🇸United States smustgrave

Thanks. Not sure if we need replacements for any of those but think this addresses the task.

🇺🇸United States smustgrave

Thanks for the explanation. That was my only comment/concern.

🇺🇸United States smustgrave

Ran the tests locally to show the test coverage

Looking at the code nothing seems off.

Seems like a good change!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Since there hasn't been an update in 6+ months going to close out. If still an issue in D11 please reopen.

🇺🇸United States smustgrave

Confirming from our slack chat. The fix in the MR did fix the issue for me THANKS!

🇺🇸United States smustgrave

Error: Call to a member function entityClassImplements() on null in Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase->getEntityBundleFieldMetadataEntityReference() (line 241 of /home/ide/project/docroot/modules/contrib/ui_patterns/src/Plugin/Derivative/EntityFieldSourceDeriverBase.php).

🇺🇸United States smustgrave

Full stack trace

#0 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Plugin/Derivative/EntityFieldSourceDeriverBase.php(296): Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase->getEntityBundleFieldMetadataEntityReference()
#1 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Plugin/Derivative/EntityFieldSourceDeriverBase.php(329): Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase->getEntityBundleFieldsMetadata()
#2 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Plugin/Derivative/EntityFieldSourceDeriverBase.php(59): Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase->getEntityFieldsMetadata()
#3 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Plugin/Derivative/EntityFieldSourceDeriverBase.php(66): Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase->__construct()
#4 /home/ide/project/docroot/core/lib/Drupal/Core/Plugin/Discovery/ContainerDerivativeDiscoveryDecorator.php(25): Drupal\ui_patterns\Plugin\Derivative\EntityFieldSourceDeriverBase::create()
#5 /home/ide/project/docroot/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(99): Drupal\Core\Plugin\Discovery\ContainerDerivativeDiscoveryDecorator->getDeriver()
#6 /home/ide/project/docroot/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(87): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDerivatives()
#7 /home/ide/project/docroot/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(337): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDefinitions()
#8 /home/ide/project/docroot/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(213): Drupal\Core\Plugin\DefaultPluginManager->findDefinitions()
#9 /home/ide/project/docroot/core/lib/Drupal/Core/Plugin/Context/ContextAwarePluginManagerTrait.php(23): Drupal\Core\Plugin\DefaultPluginManager->getDefinitions()
#10 /home/ide/project/docroot/modules/contrib/ui_patterns/src/ContextMatcherPluginManagerTrait.php(61): Drupal\ui_patterns\SourcePluginManager->getDefinitionsForContexts()
#11 /home/ide/project/docroot/modules/contrib/ui_patterns/src/ContextMatcherPluginManagerTrait.php(43): Drupal\ui_patterns\SourcePluginManager->getDefinitionsMatchingContexts()
#12 /home/ide/project/docroot/modules/contrib/ui_patterns/src/SourcePluginManager.php(154): Drupal\ui_patterns\SourcePluginManager->getDefinitionsMatchingContextsAndTags()
#13 /home/ide/project/docroot/modules/contrib/ui_patterns/src/SourcePluginManager.php(122): Drupal\ui_patterns\SourcePluginManager->getNativeDefinitionsForPropType()
#14 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Element/ComponentFormBase.php(166): Drupal\ui_patterns\SourcePluginManager->getDefinitionsForPropType()
#15 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Element/ComponentSlotForm.php(318): Drupal\ui_patterns\Element\ComponentFormBase::getSources()
#16 /home/ide/project/docroot/modules/contrib/ui_patterns/src/Element/ComponentSlotForm.php(163): Drupal\ui_patterns\Element\ComponentSlotForm::buildAddSourceButton()
#17 [internal function]: Drupal\ui_patterns\Element\ComponentSlotForm::buildForm()
#18 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1006): call_user_func_array()
#19 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#20 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#21 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#22 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#23 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#24 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(1069): Drupal\Core\Form\FormBuilder->doBuildForm()
#25 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(579): Drupal\Core\Form\FormBuilder->doBuildForm()
#26 /home/ide/project/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(326): Drupal\Core\Form\FormBuilder->processForm()
#27 /home/ide/project/docroot/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(215): Drupal\Core\Form\FormBuilder->buildForm()
#28 /home/ide/project/docroot/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\views_ui\Form\Ajax\ViewsFormBase->Drupal\views_ui\Form\Ajax\{closure}()
#29 /home/ide/project/docroot/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(217): Drupal\Core\Render\Renderer->executeInRenderContext()
#30 /home/ide/project/docroot/core/modules/views_ui/src/Form/Ajax/ViewsFormBase.php(127): Drupal\views_ui\Form\Ajax\ViewsFormBase->ajaxFormWrapper()
#31 /home/ide/project/docroot/core/modules/views_ui/src/Form/Ajax/Display.php(46): Drupal\views_ui\Form\Ajax\ViewsFormBase->getForm()
#32 [internal function]: Drupal\views_ui\Form\Ajax\Display->getForm()
#33 /home/ide/project/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#34 /home/ide/project/docroot/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#35 /home/ide/project/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#36 /home/ide/project/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#37 /home/ide/project/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#38 /home/ide/project/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#39 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#40 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#41 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#42 /home/ide/project/docroot/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#43 /home/ide/project/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(116): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#44 /home/ide/project/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(90): Drupal\page_cache\StackMiddleware\PageCache->pass()
#45 /home/ide/project/docroot/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle()
#46 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle()
#47 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#48 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#49 /home/ide/project/docroot/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#50 /home/ide/project/docroot/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#51 /home/ide/project/docroot/index.php(19): Drupal\Core\DrupalKernel->handle()
#52 {main}

🇺🇸United States smustgrave

Not sure if you forgot to push but don’t see any test added to the MR

🇺🇸United States smustgrave

For me this didn’t resolve the issue.

May be good to opt into other versions in the gitlab file?

🇺🇸United States smustgrave

Opened 📌 Fix BlockViewBuilder to handle NULL and [] Active per #23

Ran the test-only feature to show the coverage

Looking at the change don't see anything else pending. LGTM

🇺🇸United States smustgrave

@craigmullins would try updating your settings.php to $settings['allow_authorize_operations'] to TRUE or try out project browser.

🇺🇸United States smustgrave

Thanks, will need test coverage.

🇺🇸United States smustgrave

Believe feedback has been addressed for this one.

🇺🇸United States smustgrave

Seems to need another rebase

@finnsky or @VladimirAus feel free to self RTBC after

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

🇺🇸United States smustgrave

So believe trying to get to a structure like

allowed_types:
book:
child_type:
- article
- page

This opens it up that maybe in the future we can have multiple children. But need to verify this all can be validated in config.

🇺🇸United States smustgrave

Since there hasn't been a follow up in 6+ months going to close out. If still an issue please close out.

🇺🇸United States smustgrave

Seems more like a feature request about updating the documents.

I'm leaving open because the page doesn't appear to have changed much.

Production build 0.71.5 2024