🇺🇸United States @smustgrave

So really just need 1 MR pointed at 11.x as that's the development branch.

Left some comments and questions.

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

If this is still needed can we update summary/title?

If no follow up we could close out in 3+ months.

@catch following up on what follow up you were referring to 6 years ago?

#1978714: Entity reference doesn't update its field settings when referenced entity bundles are deleted → was the issue this code was added to, but don't see anything in that ticket about this being a security issue. So can the issue where this was a security issue? If no follow up I say we close out.

Hello this came up as a daily BSI target, since it's been a few years wonder if still experiencing this in D11?

Also tried testing on a standard profile install and could not reproduce.

Since it's been 3+ months since #9 without a follow up going to close out, but if still experiencing this in D11 please reopen.

Thanks all

Been about a month without additional review. Will RTBC but leaving the one thread open.

Appears to be 1 open thread.

Seems straight forward, searched for generateAbsoluteString and generateString and all replaced.

Seems straight forward, been told since navigation is experimental then a CR isn't needed. Also believe this qualifies for not needing test coverage

Was wondering what for XB this was impacting haha :)

That was all the feedback I had thanks!

Appears to have a pipeline issue. Would you say the 2 threads are good to resolve? If they are and you can't I can do it for you.

Hiding patches and closing old MRs

Following the steps I get a request like

https://drupal-11x.ddev.site/views/ajax?status=All&title=&type=All&_wrapper_format=drupal_ajax&title=&type=All&status=All&view_name=content&view_display_id=page_1&view_args=&view_path=%2Fadmin%2Fcontent&view_base_path=admin%2Fcontent&view_dom_id=163f73bb84d4e170f0b939de25d6c337ec0daf0d5e472897f73c099a6e1eb94f&pager_element=0&_drupal_ajax=1&ajax_page_state%5Btheme%5D=claro&ajax_page_state%5Btheme_token%5D=U8_NBi2POrE9U1ELs8h7ziadng1Svy8k__iIvXtLat0&ajax_page_state%5Blibraries%5D=eJx9j20OwjAIhi_UbWfwJIZ2ZKuy0gCdH6e36hqjS_zTwMMDeevjdMwx4-C3wgUC4WGUkoH6BGtn4HWjE7EH6tRuFNPkAifDqxWg5n9IV42z_leMmTxIlQTbGILFFV_bX7ymIJwRRpQ9F9TMSevifqZIGOzNE8sCFO_odGaxUKyprXdbpqFl--l71AAZD-MSkyuK0g486z7Wz6lbI150eL09nOD6BRYeC-EDDheR7w

After applying the MR

I get

https://drupal-11x.ddev.site/views/ajax?_wrapper_format=drupal_ajax&title=&type=All&status=All&view_name=content&view_display_id=page_1&view_args=&view_path=%2Fadmin%2Fcontent&view_base_path=admin%2Fcontent&view_dom_id=6bd75558a30df1be7b7f74ebc9fc473a68a2dc3c5e496a831679f7aed2d7155a&pager_element=0&_drupal_ajax=1&ajax_page_state%5Btheme%5D=claro&ajax_page_state%5Btheme_token%5D=U8_NBi2POrE9U1ELs8h7ziadng1Svy8k__iIvXtLat0&ajax_page_state%5Blibraries%5D=eJx9j20OwjAIhi_UbWfwJIZ2ZKuy0gCdH6e36hqjS_zTwMMDeevjdMwx4-C3wgUC4WGUkoH6BGtn4HWjE7EH6tRuFNPkAifDqxWg5n9IV42z_leMmTxIlQTbGILFFV_bX7ymIJwRRpQ9F9TMSevifqZIGOzNE8sCFO_odGaxUKyprXdbpqFl--l71AAZD-MSkyuK0g486z7Wz6lbI150eL09nOD6BRYeC-EDDheR7w

Not the best with nightwatch review and test-only pipeline doesn't work with nightwatch But

browser.assert.strictEqual(
              url.searchParams.getAll('title').length,
              1,
              'Duplicate title parameter',
            );

Should show the duplicates so believe it's valid coverage

Going to mark.

smustgrave → created an issue.

1) Drupal\Tests\system\Functional\System\StatusProfileWithoutVersionTest::testStatusPage
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.
/builds/issue/drupal-3511868/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3511868/vendor/behat/mink/src/WebAssert.php:145
/builds/issue/drupal-3511868/core/modules/system/tests/src/Functional/System/StatusProfileWithoutVersionTest.php:46

Shows the test coverage

Manually tested following the steps
Deleted version from minimal
Destroyed my local ddev and rebuilt
Visited admin/reports/status and verified the error
Applied the MR and it fixed the issue

LGTM

Looking at the steps I would assume a test could be written.

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

So just following up if this should be closed?

Actually going to close this one out as there hasn't been a follow up originally in 5 years. If still a valid task please re-open

Looking at #14 again and believe this is a duplicate so will close out. If I'm wrong please reopen.

Took another look and believe this one is good.

RTBC as 10.5 looks good.

Know this is a bug but do we push version updates to releases?

Since there hasn't been a follow up going to close out, if still an issue in D11 please reopen

Thanks all!

Came up as a daily BSI target

Can anyone confirm this is still an issue in D11?

Opened up 📌 Consider falling back to webp based on filesize Active for that discussion.

smustgrave → created an issue.

Opened 🌱 META: Use dependency injections in permission callbacks Active to track others

Change here though seems pretty straightforward though, good deprecation.

LGTM

smustgrave → created an issue.

Not 100% sure putting into review will grab the attention.

Though it's good to have the hard part done in a test.

Will post in slack though to try and kick start it.

1) Drupal\KernelTests\Components\ComponentRenderTest::testRender
Drupal\Core\Render\Component\Exception\InvalidComponentDataException: Unable to render component "sdc_test:my-banner". A render array or a scalar is expected for the slot "banner_body" when using the render element with the "#slots" property
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Element/ComponentElement.php:118
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Element/ComponentElement.php:65
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php:107
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Renderer.php:830
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Renderer.php:387
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Renderer.php:459
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Renderer.php:203
/builds/issue/drupal-3504477/core/tests/Drupal/KernelTests/Components/ComponentKernelTestBase.php:95
/builds/issue/drupal-3504477/core/lib/Drupal/Core/Render/Renderer.php:593
/builds/issue/drupal-3504477/core/tests/Drupal/KernelTests/Components/ComponentKernelTestBase.php:95
/builds/issue/drupal-3504477/core/tests/Drupal/KernelTests/Components/ComponentRenderTest.php:313
/builds/issue/drupal-3504477/core/tests/Drupal/KernelTests/Components/ComponentRenderTest.php:45
ERRORS!

Shows the test coverage

Believe this would solve a problem I see on my patterns theme were I have to pass #markup => content, in the twig file.

Change makes sense.

Can't re-run the test but failure appears to be in nightwatch /builds/project/drupal/core/modules/toolbar/tests/src/Nightwatch/Tests/toolbarTest.js:50

So pretty sure it's random.

Left a comment on the MR.

You’re completely good! And doesn’t bother anyone

If you click into the pipeline you’ll see a functional test for big auth is failing so the change may need to be tweaked

The functional JavaScript failure is most likely random and just needs to be re ran

I’d recommend rebasing too

Haven’t reviewed but issue summary appears incomplete

Seems like a good upgrade

No worries @dcam happens all the time.

Am moving back to NW as there should be an MR and test

Big auth appears to be failing.
New parameters should be typehinted also

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

@twod mind switching the branch

Seems like a simple change, IS is clear

1) Drupal\Tests\node\Functional\NodeEditFormTest::testNodeAuthorDisplayName
Behat\Mink\Exception\ExpectationException: The string "<em>3</em>" was not found anywhere in the HTML response of the current page.
/builds/issue/drupal-3183509/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3183509/vendor/behat/mink/src/WebAssert.php:363
/builds/issue/drupal-3183509/core/tests/Drupal/Tests/WebAssert.php:559
/builds/issue/drupal-3183509/core/modules/node/tests/src/Functional/NodeEditFormTest.php:320
FAILURES!
Tests: 4, Assertions: 105, Failures: 1.

Shows the test coverage

See no issue.

Added to the top of my list for tomorrow!

Ok in that case should this land now? Know there was a comment in the other about combining.

Applied the MR though and text-align right still appears to be working as before so marking RTBC if this should still land before.

Thanks for reporting.

Something that will be needed is a test case showing the issue.

Right but maybe we should.

Just to announce the new validation type that contrib modules can now use.

Seems like a good backport.

Some of the responses were from over a year ago but vs trying to get everyone to confirm again lets go with this. Verified all the names in the summary appear to have responded here.

mradcliffe → credited smustgrave → .

Will need a test then as I can’t replicate

Compromise if we keep the ignore can we add a comment why

This should probably have a CR right?

Fixed and added test coverage

Actually been a few years without movement wonder still needed feature?

Less steps the better I think as this could potentially break something, edge cases

Can we add post_update test coverage

Should this be postponed on 📌 Remove the views-align-* CSS classes Active

Thanks believe feedback has been addressed and solution seems to address the issue.

Compromise lets add a small comment as to why are keeping

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Believe to still be valid

Seems pretty straight forward.

Believe feedback has been addressed.

Should have a test case showing the issue.

Also issue summary is incomplete.

Since it's been 2 years going to close out as things have changed.

But to answer, probably would use the settings to make sure sitemap and this line up. As far as automation there are a few sitemap modules out there so probably be hard to implement a one size fits all.

Odd request, could you add my company name to the module page with "Sponsoring co-maintainer + maintenance - smustgrave" helps justify paying for contribution time.

This appears to be opened against D7 of drupal which has seen hit EOL. If this needs to be reopened we can.

This appears to be opened against D7 of drupal which has seen hit EOL. If this needs to be reopened we can.

Doing the same over in https://www.drupal.org/project/cacheexclude/issues/3516075#comment-16047107 📌 Start a new branch + update gitlab Active to also expand gitlab

Going to mark this one as fixed and updating the gitlab pipeline file to run against different version of core.

Seemed to be answered in #2

So this issue appears to have been opened against D7, which has since hit EOL. Going to close out since it's been untouched in 12 years. But if we need to reopen we can.

Test failure seems relevant to the change.

So this issue appears to have been opened against D7, which has since hit EOL. Going to close out since it's been untouched in 12 years. But if we need to reopen we can.

So this issue appears to have been opened against D7, which has since hit EOL. Going to close out since it's been untouched in 12 years. But if we need to reopen we can.

smustgrave → created an issue.

Since there hasn't been a follow up going to close out. If still a valid request for D11 we can always reopen

Going to close this one out since there hasn't been a follow up and from what I can tell the installer has been working with php8

So I actually don't see any examples either, so wonder if this should be closed out or scope expanded? But yea that would be an undertaking and not sure needed? Could be wrong