🇺🇸United States @smustgrave

Yes the JS behind still uses jquery but the datapicker itself is ui_slider. https://www.drupal.org/project/jquery_ui_datepicker → was removed

Version 6.0.x using jquery ui

Version 7.0.x uses ui slider

Thanks @shalini_jha!

Rebase seems good.

With D7 officially EOL, started closing out the D7 issues for quicktabs as it will be unsupported. Unfortunately didn't make it.

Thanks!

Following up for IS update else could be closed out.

smustgrave → created an issue.

Rebase seems valid.

Still needs tests but tried an alternative approach to add the attribute via code vs twig. Now we don't need a CR for the twig changes.

Before

After

Attaching before/after screenshots to show this is working. Seems like a small enough tweak I don't know if tests are fully needed so going to move it forward.

So from what I can tell it's majority moving things around and adding dependency injection and string translation stuff (nice!).

I did have 2 questions on the MR that @dww addressed.

Don't see anything wrong here. +1 for RTBC but will refers to @dww review in #12

Tour_ui is no longer supported and it's functionality is rolled into tour.

MRs are welcome

Tried to follow the steps but not sure I'm able to replicate or don't fully understand the issue.

Can the issue summary be cleaned up to include clear steps for how to replicate in D11.

If no update in 3 months this could be closed out.

Thanks

Should this be re-scoped to maybe expand the test coverage?

Rebase seems fine

Thanks feedback appears to be addressed

Will disagree if the ticket isn’t correct it can’t move forward and won’t be accepted by committers. Thus delaying it further

Seems like a good re-roll for 10.5

All feedback on this one appears to be resolved.

#10 still applies

Also all fixes should be in MRs vs patches for tests to run.

Can't re-run test failure but appears to be random javascript.

Seems like a fine refactor.

Left comments on MR.

IS seems to be incomplete.

Proposed solution is missing (MR coming isn't valid)
User Interface mentions performance improvements, wrong section but how does this improve performance?

So reading the title first thought was this sounds like entity browser bug. But if it's not, per #9 then title should reflect the core bug

Issue summary appears to be incomplete

For core may need test coverage, if possible.

Should we take this opportunity to add typehints and return types?

Small comment on MR

Looking at the CR, believe it should be fine but personally I'm big fan of before/after snippets.

Super close and will keep an eye out for this one.

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Opened 📌 Replace use of 'menu items' in tests Active

Moving this to RTBC because I'm wonder if it should be marked fixed for all the work that happened 10 years ago

smustgrave → created an issue.

Oops forgot to save benjifisher

Threads appear to be captured. Credited users.

Left comments on MR.

Going to leave in review but what's the purpose of breaking out the different formatter settings into their own files?

Going to leave in review but not 100% it'll be accepted with the eslint ignores.

And I can help with that but I for some reason can’t trigger the error

Thanks! Think only thing now we will need is simple test coverage

MR should be against 7.0.x

I’m not not denying it. But if going to do it I’m going to revisit all groups. And been thinking of putting components into folders

I think falling back to alphabetically makes sense.

Is that not what menu links in general do?

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Issue summary appears incomplete, recommend using default template

Fixes should be in MRs also.

Seems like a good refactor.

Per #8

Just did the first 10!

https://www.drupal.org/project/issues/search?issue_tags=stale-issue-cleanup →

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for 8+ years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Feedback in MR seems legit.

Wonder if we have to worry about backwards compatibility and add a trigger_error

For feedback on MR.

For feedback in MR.

Had to tweak a few things but think this is a good spot to least do a quick deploy for D11 + ck5

Lets add some test coverage

Pipeline needs a good amount of work and needs to work with ck5 but this seems good.

Is this not a duplicate of the 2 issues mentioned? Feels like something that would need configuration options too because this seems to make the assumption that all the media item holds is a file but it could be whatever.

Will need test coverage

I'm for it, lets add a simple test assertion for it.

Per #3 if an issue in the 2.0.x branch please reopen.

Per #3

Will include in 2.0.x thanks.

This doesn't appear to be working on linkit 7.0.x

smustgrave → made their first commit to this issue’s fork.

This has failures because it doesn't work with ckeditor5 right now :)

Adding to 📌 Add gitlab file Active

smustgrave → created an issue.

This will allow you to install it but won't work in linkit and ckeditor5 there are other tickets for that

Maybe a checklist could help?

1. Are they verified
2. Are they part of a company on the community radar for concern?

And there may need to be some governance around if the DA can remove someone. If a maintainer isn’t paying attention and adds such a user, like your example, and they do something that impacts 35K sites. DA should remove them till criteria is met.

Thanks for keeping up with it. I’ll admit I wanted to get this into 3.1 but little over my head

For me it was an existing site locally. I pulled latest changes and ran drush cr and got the warning.

Second cr no warning

Since it's been 6+ months going to close out. If still a valid issue in D11+ please reopen.

Updated phrase to be 8 years since that's what I believe we have agreed upon.

I will start tomorrow!

Excited to see how this goes.

So we are in agreement to try a trial run?

I’ll do 10 a day
Oldest issues sorting by update date.
And I’ll use the phrase in the summary
And tag “stale-issue-cleanup””

That tag I just made up

Can confirm I saw that this too this morning after doing drush cr. Didn't know where it came from thanks @lauriii

Thanks for checking!

So applied the MR and did a search for "$namespaces, $module_handler, 'Drupal\Core\" to make sure those were converted and all instances were.

@godotislate there is 1 thread I wasn't 100% should be resolved but your comment in #10 made think it maybe could? Could you close it.

There are 2 threads but really it's 1.

Rest of the feedback appears to be addressed so going to mark it.

@asawari and @sagarmohite0031 there were already screenshots added #63 additional ones weren't needed.

Removed the follow up tag as not sure what was needed.

All feedback appears to be complete just needs CR updates.