🇺🇸United States @smustgrave

This had a lot of comments so giving 1 final bump.

With

    if (!$this->lock->acquire('cron', 900.0)) {
      // Cron is still running normally.
      $this->logger->warning('Attempting to re-run cron while it is already running.');
    }

Is this still needed?

Moving back to active then.

Since there's been no follow up and a feature request going to close out. Can always be re-opened

Thanks.

Wanted to bump this 1 more time before closing.

Seems there was a number of -1 for this and reading the summary I don't see what's to be gained? Since there's been no follow up going to close out. If still valid please re-open

Thanks all

Since there's been no follow up and was a feature request going to close out. Can always be re-opened

Thanks

Probably still valid. Not 100% we need a meta for it but will leave open.

Since there's been no follow up and was a feature request going to close out. Can always be re-opened.

Thanks all!

I believe this one is outdated. The (now) render function has several checks for cache before hand and has gone through numerous changes in the last 12 years. If still valid please re-open.

Okay I'll leave for you to review then

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Since there's been no follow up going to close out. If still desired it can always be re-opened

Thanks!

This came up as the daily BSI

Seems patch should be converted to an MR, know it doesn't apply cleanly.

But looking at the proposed solution what's the BC concern?

Still seems to be valid.

Since there's been no follow up in 6+ months going to close out. If still valid please re-open

Thanks!

@avpaderno

Does the change in the merge request have effect also on sites using those views?

no this should not affect existing sites.

Seems we got a few people who have mentioned to using glossary so think we should keep that? Seems to definitely be used in the tests.

Pretty straight forward, also came here from 📌 Revert Ignore VariableComment.Missing from 3477614 Active

Outside \Drupal\views\Plugin\views\argument\Date mentioned in #5 appears to be 2 more instances in PagerPluginBase

Wouldn't we see an impact in the OpenTelementary test?

Thanks

Seems straight forward. Working off the screenshots provided

Fair point. I’m going to mark as this does seem to be a net gain plus.

Thanks for making those changes!

@oily because I get the emails. If you are going to post the test-only run it should also be with a code review please. Just running the test job and posting the results will not result in credit if that's the end goal and I've got a number of emails of just the posting. Again if you see me do 9/10 times I won't get credit either so just FYI

Actually not able to replicate is this still an issue?

Works for me.

smustgrave → made their first commit to this issue’s fork.

Works for me.

Rebased because something weird was going on with cspell. Seems to have been resolved

Ran the test-only

1) Drupal\Tests\views\Unit\Plugin\argument\NumericArgumentTitleTest::testTitleWithBreakPhraseAndTokenValue
TypeError: Cannot assign null to property Drupal\views\Plugin\views\argument\ArgumentPluginBase::$operator of type string
/builds/issue/drupal-3546894/core/modules/views/src/Plugin/views/argument/NumericArgument.php:75
/builds/issue/drupal-3546894/core/modules/views/tests/src/Unit/Plugin/argument/NumericArgumentTitleTest.php:50
ERRORS!
Tests: 3, Assertions: 2, Errors: 1.
Exiting with EXIT_CODE=2

Which shows the test for the scenario described here. Nice to see additional test coverage get added!

Manually testing following the steps I do see the warning and the fix does seem to address it.

LGTM!

Yea we could hide the "Create new" checkbox if it's part of a book already.

Got some guidance and a path forward. Was hoping to unblock this one but seems 📌 Decouple text_with_summary from tests and migrations Needs review is still needed as some random tests will now fail. But MR is much simpler and no migration changes.

Thank you @quietone for all the guidance in slack.

I kept the fixtures as is and believe I have a path forward with the deprecations when we get to the last step.

I did remove any text_with_summary assertions from the field module (there were a good number) and cloned those tests to the text module. So coverage is not lost here.

Tests are failing though. And HEAD to my knowledge is not broken so it has to be related to the change here

smustgrave → made their first commit to this issue’s fork.

Tempted to tag for tests coverage to show this is needed.

But could we get profiling stats to show this is an improvement please

can we add test coverage

After reading the thread agree I don’t see why this is needed.

Oops not my module

smustgrave → created an issue.

Can we get a test case showing the bug please.

Since there's been no follow up and as a feature request, going to close out. Can always be re-opened

Thanks!

Think this is outdated as TranslationWrapper is no more and now TranslatableMarkup()

Wanted to bump 1 more time before closing.

Not much to go on here, specifically why this is needed. So going to close out on that. If still valid please re-open updating the summary.

Thanks!

Still seems to be a number of \Drupal calls in UserSession.php so this appears to still be valid.

Re-postponing this on #1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core → but not sure this one is needed.

Re-postponing this on #1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core →

Wanted to bump this 1 more time before closing.

Still seems worth doing to me.

Looks like good coverage to me. Glad to see some good from the stale-issue work :) Thanks for picking this up!

Before

After

Tested manually following the steps in the summary and I was able to reproduce.
After applying the MR the fix appears to be working

MR LGTM

Sorry can we update the summary with how this is suppose to work?
I created 2 workspaces
Added content to the first workspace

But I don't see anything about how to move that content to workspace 2

Idea sounds very interesting so definitely will keep an eye out.

Are we losing coverage in core/tests/Drupal/Tests/Core/Site/SettingsTest.php by removing those 3 scenarios?

Thanks for reporting! All fixes need to land in 11.x first as that's the current development branch

As a bug will need a test case showing the issue

Confirmed this does fix the problem, we were seeing this on the book module too.

Hoping to do a new deploy soon with updated npm packages but I wasn't able to replicate this.

The token still exists but will be moved to a deprecated text_with_summary module eventually

Believe feedback has been addressed.

Left some comments. But shouldn't the descriptions be updated too to match what's being changed?

Appears the MR has some issues, unit tests are failing for this change.

Also as a bug we will need test coverage to show it's fixed please.

Issue summary is incomplete, solution section is required.

Thanks!

Thanks but why inheritdocs on emailfieldCallback? That's not a function with docs anywhere.

Pipeline still has errors.

Believe feedback for this one has been addressed

This issue came up as the daily BSI target.

Looking at the function hasColumnChanges() it hasn't been touched since 2015 and the patch in #2 still applies here. So believe this is probably still valid.

@mohit_aghera for 🐛 File rest permission issue Active

Since there's been no follow up going to close out as working as designed. Can always be re-opened if needed.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Wanted to bump 1 more time before closing.

Since there's been no follow up in 6 additional months and was a feature request that didn't seem heavily desired going to close out. Can always be re-opened

smustgrave → created an issue.

Lets close this one as a duplicate then thanks for following up!

Nice! Seems to have some pipeline errors so the tests didn’t run

Per #18

Should have mentioned 11.x is the development branch for core. So things need to land there first. And depending on what they are it’ll backported

The current MR you have you should be able to change the target branch.

You will have to rebase though as 11.2.x and 11.x are very different

Let’s do it! Didn’t seem to break anything

Thanks for finding. MR needs to be pointed to 11.x

Also would be good to search if there are other instances of this typo

Experienced this on a contrib theme where I'm trying to mimic core standards and noticed couldn't update to eslint 9. And noticed eslint-config-airbnb-base still hasn't done a release in 4 years.

eslint-config-airbnb-extended looks nice just not sure how to get it working with existing eslint-json config. I converted it to a .mjs file and tried eslint-config-airbnb-extended auto create .mjs file just merging the two has been tricky. But that's a me problem.

I'm +1 for moving away from eslint-config-airbnb-base

I'm embarrassed that took me so long but it should be updated and will be part of my deployment checks going forward.

Also added a little warning that you may be able to get away with updating the theme even if the USWDS library version doesn't match but that's on you.

Started a new column for new features.

Looks like a good clean up to me!

Works for me! Thanks for following up!

Since the proposed solution is to decide if this approach should be used should it be tagged sub-maintainer review?

Left some additional comments on the MR.

Circling back to this one. I'm going to mark it because the change actually looks better to use the tokens vs concating the strings.

Failure in InstallerIsolationLevelExistingSettingsTest seems completely unrelated.

Gotcha lets see what the committers think since it's a small MR to take a look at!

So I'm not sure anyone keeps an eye on that tag? I could be wrong just don't see it often and not sure who the design team is.

Can you post what you're seeing? I just downloaded the recipe and it applied fine