🇺🇸United States @smustgrave

Not in front of my computer does facets happen to have a test we can steal?

Appears to need a rebase.

Was about say didn't know we used BETA release but then saw "symfony/serializer": "~v7.3.0-BETA1", so nvm

lets do it!

Well this did break UserPasswordResetTest, so maybe is needed.

Either way IS is incomplete.

@acbramley I don't think DI have been blocker for these tickets. @nicxvan may know the ticket where that's being tracked?

Sounds like good novice tasks for a dev day to go back and add DI to these conversions!

1 comments I do want to make, not 100% phpstan and all is running on hook folders yet but will it ding the empty docs for __construct()? Not a blocker just mentioning.

Looking at the MR seems like a good conversion though

Will need UX sign off, but the issue summary seems to be void of screenshots to assist the UX team. Tagging for such

Thanks!

The issue summary for this one appears incomplete.

This seems to still be relevant.

Will need an issue summary and tagging novice as should be a good task for new users.

So in agreement to close?

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Just following up if this is still needed, if no follow up in 3 months could close out.

@catch for 🐛 CssOptimizer silently drop the attached library when a CSS file @include an external CSS. Postponed: needs info

Since there hasn't been a follow up for reasoning to add in a few years going to close out.

Thanks

So should this be closed out as won't fix?

Since there's been no follow up going to close this one out. If still a bug please re-open updating the issue summary with steps to reproduce.

If the bug can't be reproduced in core then, to me, sounds like the contrib modules could be the bug.

If it’s just dealing with checkboxes should be able to provide test coverage, we got some existing ones as is

Don’t see the test coverage

Before

After

Resolved what threads I could but restoring status

Actually see in #6 ckrina gave the thumbs up.

Before

After

Does appear to address the failure

Waiting on a maintainer to make sure they're fine with the color change.

Left a comment on the MR.

1) Drupal\Tests\Core\DependencyInjection\Compiler\BackendCompilerPassTest::testProcess
Expectation failed for method name is "hasDefinition" when invoked 1 time
Parameter 0 for invocation Symfony\Component\DependencyInjection\ContainerBuilder::hasDefinition('.fakeService'): bool does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'a_valid_default_backend.fakeService'
+'.fakeService'
/builds/issue/drupal-3518917/core/lib/Drupal/Core/DependencyInjection/Compiler/BackendCompilerPass.php:67
/builds/issue/drupal-3518917/core/tests/Drupal/Tests/Core/DependencyInjection/Compiler/BackendCompilerPassTest.php:101
FAILURES!

Shows the test coverage

Summary appears to match the MR and don't see any open questions.

New maintainer is working on a D10/11 release

A new maintainer was added last week.

This is a co-worker of mine and I have the opt in security coverage if that helps.

Since there hasn't been a reason to re-open since 2014, going to close out. If still a valid task in D11 lets re-open updating the summary please.

Thanks all!

Since we still don't have steps going to close out.

If still a valid bug please re-open providing steps to reproduce

Thanks all

Believe this can be closed as outdated, views as the ability to expose the operators so could do that if you want to run differently.

If I'm wrong please re-open

Thanks!

Since it's been a few years with no follow up, going to close out. If still a needed feature in core please re-open.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

This came up as a daily BSI target

Can someone confirm if this is still an issue in D11?

Also tagging for issue summary update so if moved back to active lets update that as well please

Thanks!

Myself for 🐛 Key is not automatically populated after validation failure on blank title Active

Since there hasn't been a follow up going to close out, if still an issue in the latest version of Drupal please re-open providing steps to reproduce

Seems like a good improvement for qualify of life, and debugging

Maybe a test case should be added to show the problem and why this fix is needed.

Try this again lol, additional changes seem fine. Restoring status

Issue summary is incomplete

Should include the full summary template, with steps to reproduce

Also all fixes should be in MRs and as a bug will need test coverage.

Issue summary is incomplete.

But also need some more investigation, what's being passed here that's null. If caused by custom code then seems the custom code is wrong.

LGTM!

Don't see an MR opened but will need test coverage too.

We can't add a test to verify the existence of a class?

Appears to be random nightwatch failure, re-running is fine

Restoring previous RTBC status.

Seems like a good conversion

Appears to have pipeline failures in the unit tests.

Seems straight forward, we had a brief conversation in slack about any questions haha

LGTM

Going to disagree that we should have test coverage added but will leave in review.

Should make them appear inline vs stacked.

Meant to say you could self RTBC but thanks!

Seems like a good refactor.

Appears to have pipeline issues. And shouldn't this be done as part of 📌 Move drupal_find_theme_templates and drupal_find_theme_functions to Theme Registry service Needs work , think for this to merge need to convert an instance where this would be needed

Seems phpstan is still failing.

Sorry can the title/summary be tweaked? Mentions doing a move but seems just removing stuff?

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Reviewed the additional changes in commit https://git.drupalcode.org/project/drupal/-/merge_requests/11518/diffs?c... and they seem fine.

This probably could of been a novice task for a new user.

Lets do it,

Wasn't 100% sure how to test but I ran the updates locally and ran the ckeditor commands in package.json and seem to function fine.

The D12 branch isn't opened.

Closed 🐛 Move entity preparation from form controller to entity class: "last changed" timestamp not updated and "create new revision" setting not respected when updating entities via Entity API Postponed: needs info with overlap to this.

Will move over credit to the issue in #53

This needs more information please, #10 mentioned needing to know what rule this is breaking

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

This happen in the 3.x branches? Not a hugh fan of just an empty check as it could be masking a larger problem. But really could drop support for 2.x since 9 is EOL

posted in #core-development. @dww was a +1

I'm a +1 because I never know when to use final myself

Going to mark it, guess if it gets approved a follow up to convert current finals can be opened.

RemovePathKeyTest may be a good example

Essentially the test would be

Load a fieldBlock and verify the key DOES NOT exist

Run updates

Load the same block and verify the key DOES exist.

CR reads well to me.

Spoke to @catch and he said the existing CR approach should be fine.

Not sure if this will make 11.2 in time but seems like a good conversion to me, all template_hooks appear to be deprecated.

This came up as daily BSI target

Testing in D11 I can confirm still an issue with error InvalidArgumentException: Invalid translation language (ar) specified. in Drupal\Core\Entity\ContentEntityBase->addTranslation() (line 986 of core/lib/Drupal/Core/Entity/ContentEntityBase.php).

Will need an MR for 11.x, last patch appears to have test coverage but wonder if we can extend an existing one without a full new bootstrap?

Can we use the full issue summary template please.

May need a test to show this bug and make sure it doesn't come back