🇺🇸United States @smustgrave

Account created on 30 June 2015, almost 10 years ago
  • Software Engineer at Mobomo 
#

Merge Requests

More

Recent comments

🇺🇸United States smustgrave
1) Drupal\Tests\views\Functional\Plugin\AccessTest::testContentAccessFilter
Failed asserting that an array does not contain 'node_access'.
/builds/issue/drupal-1822440/core/modules/views/tests/src/Functional/Plugin/AccessTest.php:133
FAILURES!

Shows test coverage
Actual change seems pretty straight forward, no issue and pipeline is green. I did rebase because it was 200+ commits

🇺🇸United States smustgrave

Seems to maybe be a problem with the browser? If still an issue in D11 we can always re-open.

🇺🇸United States smustgrave

The other issue is in review and already been through a few rounds, believe it's close.

🇺🇸United States smustgrave

Since there's been no follow up going to close out, if still valid in D11 please re-open

Thanks

🇺🇸United States smustgrave

Since there's been no follow up for steps going to close out. If still valid please re-open

🇺🇸United States smustgrave
1) Drupal\Tests\block\Kernel\BlockViewBuilderTest::testBlockViewBuilderCacheTitleBlock
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
     0 => 'block_view',
     1 => 'config:block.block.test_block_title',
-    2 => 'custom_cache_tag',

Test coverage does show the problem

IS seems to match the solution

Code wise don't see any issue

LGTM

🇺🇸United States smustgrave

Posted in slack and @chx was kind enough to give a look and apparently this needs some work.

🇺🇸United States smustgrave

So should this one and the taxonomy one be postponed till an agreed upon structure can be decided?

🇺🇸United States smustgrave

Since there's been no follow up going to close out, if still a bug in D11 please re-open.

🇺🇸United States smustgrave

Since there's been no follow up going to close this one out, but can always be re-opened

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

I mean you had to alter tests for this to pass, which could break contrib modules.
Sure a lot of drupal docs, user manuals, and training will have to be written with these changes.

🇺🇸United States smustgrave

Seems pretty straight forward

🇺🇸United States smustgrave

JK this broke tests

🇺🇸United States smustgrave

Haven't tested this particular scenario but can you test the latest version? Number of changes were added.

🇺🇸United States smustgrave

Wasn't able to reproduce but don't mind including this little defense. Will include in latest patch.

🇺🇸United States smustgrave

Since been a few years assuming maybe the question has been answered? If not please re-open.

🇺🇸United States smustgrave

Thanks! Will include in next release.

🇺🇸United States smustgrave

Just tested on the latest version and cannot reproduce. If still seeing it please re-open.

🇺🇸United States smustgrave

As much of some of these would make sense I may be a -1 for such as change as it would be very disruptive

🇺🇸United States smustgrave

There any security concern with putting user information into the dom?

🇺🇸United States smustgrave

Since no followup going to close out, if still a valid task please re-open.

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Since there's been no follow up in 3 months going to close out, if still a valid task though we can always re-open.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

There’s like 3 more issues but will pick back up tomorrow

🇺🇸United States smustgrave

Been a few years without activity so assuming the question has been answered.

🇺🇸United States smustgrave

So been a few years with no activity, so going to close out. If anyone feels different please re-open.

🇺🇸United States smustgrave

Curious if 🐛 Infinite loop issue RTBC solves this for you?

🇺🇸United States smustgrave

smustgrave made their first commit to this issue’s fork.

🇺🇸United States smustgrave

Ok got the pipeline 100% green. Am doing new branch 3.0.x for just 10.3 and 11.

Will still need some manual testing and still have to triage the rest of the queue then can do a release.

🇺🇸United States smustgrave

So is this fixed by the related issue in #9?

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

🇺🇸United States smustgrave

With D7 EOL going to close out, if still an issue in D11 we can re-open

Production build 0.71.5 2024