🇺🇸United States @smustgrave

Account created on 30 June 2015, almost 10 years ago
  • Software Engineer at Mobomo 
#

Merge Requests

More

Recent comments

🇺🇸United States smustgrave

The update hook number probably should be 21001 to match the version it would be landing

And schema validation part is missing. EntityBundleExists maybe?

🇺🇸United States smustgrave

This no longer the message so wonder if still valid?

🇺🇸United States smustgrave

Since there hasn't been a follow up, going to close out for now. If still a valid issue please re-open.

🇺🇸United States smustgrave

Personally I’m a -1 for the description. Yes it does mention those fields are disabled but doesn’t mention why, so is it worth it?

🇺🇸United States smustgrave

These were the only 2 things identified by upgrade status.

🇺🇸United States smustgrave

I’ll leave in review for others but seems odd to have mix and match. Can already see a ticket opened asking why some are italicized and some aren’t

🇺🇸United States smustgrave

Thanks but MRs should be pointed at 11.x

Was also previously tagged for tests which are needed still

🇺🇸United States smustgrave

Can we add an example where it’s not passed to make sure both ways are covered?

🇺🇸United States smustgrave

Haven’t tested yet but something like that.

Functionality isn’t lost now without the wysiwyg?

🇺🇸United States smustgrave

This something we should add test coverage for?

🇺🇸United States smustgrave

Either way think adding test coverage would be good to have

🇺🇸United States smustgrave

Think we need coverage for all the tags being added

🇺🇸United States smustgrave

Seems conflict was around core/modules/system/system.post_update.php update seems fine

🇺🇸United States smustgrave

All the tests having to be updated to pass makes me think we are introducing a breaking change

🇺🇸United States smustgrave

Since there hasn't been a follow up going to close out, but if still a valid bug in D11 please re-open.

🇺🇸United States smustgrave

Per #12 it's been almost 2 years so definitely past 3 months :)

If still a valid task please re-open.

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

🇺🇸United States smustgrave

Not sure the right status but with the new service won't we need a CR?

Even though a task does this kind of change need test coverage?

🇺🇸United States smustgrave

Moving to NW because the MR is now almost 1000 commits back and still think test coverage is needed.

🇺🇸United States smustgrave

Unresolved the 2 threads and see if the core committers are fine with it,

I did search for pageTextContains(\sprintf and didn't find any instances in core

🇺🇸United States smustgrave

So I believe this may be a local issue, this test passes inside gitlab and to my knowledge doesn't even have random failures around it.

🇺🇸United States smustgrave

We actually don't have a token sub-maintainer so bumping to framework.

Can 1 MR be closed or hidden that's not for 11.x
4236 is 200+ commits back so probably will need a rebase at some point.
CR still appears to be needed

🇺🇸United States smustgrave

Appears to be a good conversion, agree with the update to the testTrait since it's just void. Hopefully doesn't lead to any more random failures then we already get :)

🇺🇸United States smustgrave

So I tested it out and pretty basic, creating a new content type and the promoted to front checkbox is unchecked

Hiding old patches
Tweaked the CR just slightly with an image for the visual people out there.

I imagine this may break some contrib tests (hopefully not a lot) but seems like a right step.

🇺🇸United States smustgrave

Tested out and the issue is fixed for newly reverted revisions but for existing revisions they still have em tag. So do we need an upgrade hook to retroactively fix that? Are we okay with a mix of of the 2 on the same screen?

🇺🇸United States smustgrave

Do you want to open a ticket under cspell for this and postpone this one?

🇺🇸United States smustgrave

Opened https://www.drupal.org/project/drupal/issues/3518551 📌 Document about menu ordering Active

🇺🇸United States smustgrave

Fair enough, but for good practice think the issue summary should still be complete

🇺🇸United States smustgrave

Moving to NW for the test coverage

Thanks!

🇺🇸United States smustgrave

This has been tagged for steps and issue summary. So moving to PNMI for that info.

🇺🇸United States smustgrave

Issue summary should be complete

Also MRs should be against 11.x

🇺🇸United States smustgrave

No there are 30 instances in core where it’s just like it is now without the change. So why is this single spot needed

🇺🇸United States smustgrave

Added a simple class like olivero

🇺🇸United States smustgrave

Not sure this is a bug. Classy is old and stable also got moved to contrib, and composer.json has a dependency on it so it'll get downloaded.

🇺🇸United States smustgrave

Per #15 don't think this is going to land

🇺🇸United States smustgrave

Thanks! I actually just got added so think we are good for now, hoping to have a d11 branch up in the next 24-48 hours.

🇺🇸United States smustgrave

smustgrave made their first commit to this issue’s fork.

🇺🇸United States smustgrave

Wonder if this is still needed actually? Classy shouldn't be the starter point for any theme, instead the starterkit_theme should be used.

🇺🇸United States smustgrave

Going to try and do a release soon that unhides the theme

But now fixes
1. Edit the core.extension file to remove there.
2. Edit the classy.info.yml file and remove the hidden: true part.

🇺🇸United States smustgrave

Will include in both 1.0.x and 2.0.x

🇺🇸United States smustgrave

Will include in 1.0.x and 2.0.x

🇺🇸United States smustgrave

With it moving to contrib and 11+ years of inactivity I don't believe this is as needed in contrib space.

🇺🇸United States smustgrave

Seems to already be fixed in contrib :)

🇺🇸United States smustgrave

Ran test-only feature

1) Drupal\Tests\node\Functional\NodeEditFormTest::testNodeFormNullAuthor
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.
/builds/issue/drupal-3161212/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3161212/vendor/behat/mink/src/WebAssert.php:145
/builds/issue/drupal-3161212/core/modules/node/tests/src/Functional/NodeEditFormTest.php:267
FAILURES!
Tests: 4, Assertions: 105, Failures: 1.

99% of the code is tests so the actual fix makes sense.

Very nice.

🇺🇸United States smustgrave

Pipeline appears to have issues but the goal is to now do a deprecation summary + title need to reflect that.

🇺🇸United States smustgrave

Will need test coverage as a next step. Thanks!

🇺🇸United States smustgrave

Just got access will work on a new branch for D11 this week.

Production build 0.71.5 2024