🇺🇸United States @smustgrave

smustgrave → created an issue.

Been over 8 years and tired of seeing it in the queue :)

Since it's been a few years wonder if this is needed.

smustgrave → created an issue.

Doing some issue triage and closing this one out but can always re-open.

Resolved the threads and believe all feedback has been addressed.

Wonder if something similar can be done like in EntityBase for original

Only change I wasn't sure was instantiating $link_attributes = []; vs $link_attributes = new attribute(). But seems to return the same.

Ran the test-only job here https://git.drupalcode.org/issue/drupal-3122526/-/jobs/5648445 which gave

1) Drupal\Tests\system\Unit\Pager\PreprocessPagerTest::testPagerModalAttributes
null does not match expected type "array".
/builds/issue/drupal-3122526/core/modules/system/tests/src/Unit/Pager/PreprocessPagerTest.php:218
--
1 test triggered 1 PHP warning:
1) /builds/issue/drupal-3122526/core/modules/system/tests/src/Unit/Pager/PreprocessPagerTest.php:218
Undefined array key "class"
FAILURES!
Tests: 7, Assertions: 9, Failures: 1, Warnings: 1, PHPUnit Deprecations: 7.

Appears to be 1 thread from 2 years ago but no follow up from the response. Also not sure how to do that outside the preprocess_function. Leaving thread open but don't want to hold the ticket.

Rest appears to be addressed, LGTM.

@grimreaper for the idea.

smustgrave → created an issue.

Appears all feedback on this one has been addressed

Ran the test-only job here https://git.drupalcode.org/issue/drupal-3357616/-/jobs/5648057

1) Drupal\Tests\user\Functional\UserLoginTest::testFailedLoginMessageWithNoPasswordResetAccess
Behat\Mink\Exception\ResponseTextException: The text "Forgot your password?" appears in the text of this page, but it should not.
/builds/issue/drupal-3357616/vendor/behat/mink/src/WebAssert.php:907
/builds/issue/drupal-3357616/vendor/behat/mink/src/WebAssert.php:312
/builds/issue/drupal-3357616/core/modules/user/tests/src/Functional/UserLoginTest.php:377
FAILURES!
Tests: 8, Assertions: 161, Failur

Will provide some stats as this has been going on for a few months and been closing issues as well

Total issues tagged: 830
Closed: 226
Moved to active: 31
Moved to NW: 6
1 issue got worked and committed :)

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Since there's been no follow up in 3 months going to close out, if still a valid task please re-open

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a valid task please re-open

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a valid task please re-open

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a valid task please re-open

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a desired feature please re-open, maybe updating summary

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a desired feature please re-open, maybe updating summary

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a desired feature please re-open, maybe updating summary

Thanks all!

Since there's been no follow up in 3 months going to close out, if still a desired feature please re-open, maybe updating summary

Thanks all!

@gabesullice thank you for the time and effort! Shame you can't continue but know that's the way things go sometimes. Thanks again!

Hello @tgauges first appreciate taking on this task!

Since this seems to be still in discussion moving to NW, discussions can still happen without being in review

Since this was previously tagged for steps and not provided going to close out. If still a bug in D11 please reopen updating summary with steps.

Thanks

Should this one be closed out?

Following up on #2, if no follow up in 3 months this could be closed out.

Should this be closed out?

This came up as a daily BSI

The issue summary appears incomplete and could use some love. Notably missing steps to reproduce.

I see then everything seems to be working as expected.
Tested with the editor role from the standard install.

Think all feedback has been addressed

Example https://www.drupal.org/project/translate_export →

May be something that needs sign off if it’s to be included in core or should be a contrib feature

Yea that would be cool to see!

Will include in 3.0.x alpha release.

Thanks! Also added you as a co-maintainer for all the help recently.

Seems feedback from @xjm has been addressed to disable specific rules vs disable

Believe the API change will need a CR

Seems pretty straight forward, didn't seem to break gitlab :). Not sure if this kind of change needs a CR but addition of --phpunit-configuration seems fine to me.

Seems pretty straight forward. Searched for core/scripts/generate-proxy.sh and all instances updated.

Seems like something probably should have test coverage for.

Also tagging for IS update as the proposed solution isn't super clear

Should we put back into review ?

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Added the update hook so this should be ready

Re-ran test failures and they were all random.

Was previously RTBC restoring status

Since this is an API change probably needs a CR

Tweaked the CR slightly for 11.3 rest seems fine to me!

smustgrave → created an issue.

This came up as a daily BSI target.

IS needs to be updated with the proposed solution.
MR needs to be opened for 11.x and address the open threads from 3588

Thanks!

Since there's been no follow up to #5 going to close out. If still an issue in D11 please re-open adding steps to reproduce.

Can this one be closed?

To my knowledge there is no way in core for exporting translations

Will give this one more bump, if no interest will close in 3 months, thanks all!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Since there's been no follow up in 3+ months going to close out. If someone still wants this feel free to re-open the ticket!

Seems all threads and participants credited.

Thanks for fixing those, seems we are getting test-failures now, re-ran twice

Assume the test-only changes should of failed?

Won't this need an upgrade path

Hiding the test-only branch incase the bot picks it up.

But I see that the failures are now coming from the added test coverage

│ /builds/issue/drupal-3473029/core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php:368

That was the only feedback I had, so believe this one is good to go.

smustgrave → changed the visibility of the branch 3473029-correct-maxlength-test-only to hidden.

Reviewed the threads on 05/08/2025 and all threads appear to be captured and participants credited

Reviewed the threads on 04/10/2025 and all threads appear to be captured and participants credited

What about this in the 3.0.x branch instead

We have a simple select for "new" and "search for existing book" if they select the 2nd then an autocomplete field appears regardless of how many books there are?

Thanks for cleaning up the details!

kernel failed

    
    FF                                                                  2 / 2 (100%)
    
    Time: 00:04.448, Memory: 8.00 MB
    
    Link Formatter (Drupal\Tests\link\Kernel\LinkFormatter)
     ✘ Link formatter with default·formatter
       ┐
       ├ Failed asserting that 'Hello world' [ASCII](length: 101) contains "" [ASCII](length: 49).
       │
       │ /builds/issue/drupal-3530149/core/modules/link/tests/src/Kernel/LinkFormatterTest.php:118
       ┴
     ✘ Link formatter with separate·link·text·and·URL
       ┐
       ├ Failed asserting that 'Hello world\n                                     
       ├ https://www.drupal.org/\n
       ├ ' [ASCII](length: 126) contains "" [ASCII](length: 49).
       │
       │ /builds/issue/drupal-3530149/core/modules/link/tests/src/Kernel/LinkFormatterTest.php:118

MenuLinkTest failed with

      ┐
       ├ Failed asserting that 'Link test' [ASCII](length: 99) contains "" [ASCII](length: 49).
       │
       │ /builds/issue/drupal-3530149/core/modules/menu_link_content/tests/src/Kernel/MenuLinksTest.php:505

So believe this shows the test coverage is good

Deleted the Unit test from my MR since we saw it fail, lets see if the kernel does now.

smustgrave → changed the visibility of the branch 3530149-revert-changes-2024-004 to hidden.

Opened an MR with 2024-004 revert

Unit test fails with

  Line   core/modules/link/tests/src/Unit/AttributeXssTest.php                
 ------ --------------------------------------------------------------------- 
  16     @covers value \Drupal\link\AttributeXss references an invalid class  
         or function.                                                         
         🪪 phpunit.covers                                                    
  24     Call to static method sanitizeAttributes() on an unknown class       
         Drupal\link\AttributeXss.                                            
         🪪 class.notFound                                                    
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  

kernel tests don't run is it needed to opened a 3rd MR without the unit test?

smustgrave → made their first commit to this issue’s fork.