The update hook number probably should be 21001 to match the version it would be landing
And schema validation part is missing. EntityBundleExists maybe?
This no longer the message so wonder if still valid?
@wim leers for 🐛 SQLite driver does not allow for case insensitive LIKE comparisons on non-ASCII characters Postponed: needs info
Since there hasn't been a follow up, going to close out for now. If still a valid issue please re-open.
Personally I’m a -1 for the description. Yes it does mention those fields are disabled but doesn’t mention why, so is it worth it?
These were the only 2 things identified by upgrade status.
I’ll leave in review for others but seems odd to have mix and match. Can already see a ticket opened asking why some are italicized and some aren’t
Thanks but MRs should be pointed at 11.x
Was also previously tagged for tests which are needed still
Can we add an example where it’s not passed to make sure both ways are covered?
Haven’t tested yet but something like that.
Functionality isn’t lost now without the wysiwyg?
This something we should add test coverage for?
Either way think adding test coverage would be good to have
Will have to wait for D12
Think we need coverage for all the tags being added
Seems conflict was around core/modules/system/system.post_update.php update seems fine
Believe feedback has been addressed on this one.
Left some comments on the MR.
All the tests having to be updated to pass makes me think we are introducing a breaking change
So is this one good to close out?
Since there hasn't been a follow up going to close out, but if still a valid bug in D11 please re-open.
Per #12 it's been almost 2 years so definitely past 3 months :)
If still a valid task please re-open.
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Not sure the right status but with the new service won't we need a CR?
Even though a task does this kind of change need test coverage?
Moving to NW because the MR is now almost 1000 commits back and still think test coverage is needed.
Unresolved the 2 threads and see if the core committers are fine with it,
I did search for pageTextContains(\sprintf and didn't find any instances in core
So I believe this may be a local issue, this test passes inside gitlab and to my knowledge doesn't even have random failures around it.
Seems there is some feedback on the MR.
Going to go on a limb and believe this one is complete.
Thank you!
We actually don't have a token sub-maintainer so bumping to framework.
Can 1 MR be closed or hidden that's not for 11.x
4236 is 200+ commits back so probably will need a rebase at some point.
CR still appears to be needed
Appears to be a good conversion, agree with the update to the testTrait since it's just void. Hopefully doesn't lead to any more random failures then we already get :)
So I tested it out and pretty basic, creating a new content type and the promoted to front checkbox is unchecked
Hiding old patches
Tweaked the CR just slightly with an image for the visual people out there.
I imagine this may break some contrib tests (hopefully not a lot) but seems like a right step.
Tested out and the issue is fixed for newly reverted revisions but for existing revisions they still have em tag. So do we need an upgrade hook to retroactively fix that? Are we okay with a mix of of the 2 on the same screen?
Do you want to open a ticket under cspell for this and postpone this one?
Opened https://www.drupal.org/project/drupal/issues/3518551 📌 Document about menu ordering Active
smustgrave → created an issue.
Fair enough, but for good practice think the issue summary should still be complete
Moving to NW for the test coverage
Thanks!
Seems like this probably needs to be re-opened.
This has been tagged for steps and issue summary. So moving to PNMI for that info.
So question is if still an issue in D11
Thanks, will need test coverage
Issue summary should be complete
Also MRs should be against 11.x
Feedback appears to be addressed.
No there are 30 instances in core where it’s just like it is now without the change. So why is this single spot needed
Thanks!
Just did a classy release.
smustgrave → created an issue.
Added a simple class like olivero
Not sure this is a bug. Classy is old and stable also got moved to contrib, and composer.json has a dependency on it so it'll get downloaded.
Per #15 don't think this is going to land
Thanks! I actually just got added so think we are good for now, hoping to have a d11 branch up in the next 24-48 hours.
smustgrave → made their first commit to this issue’s fork.
smustgrave → created an issue.
Wonder if this is still needed actually? Classy shouldn't be the starter point for any theme, instead the starterkit_theme should be used.
Per #2 wonder if still an issue?
Curious after many years if still an issue?
Going to try and do a release soon that unhides the theme
But now fixes
1. Edit the core.extension file to remove there.
2. Edit the classy.info.yml file and remove the hidden: true part.
Done!
Will include with 2.0.x
Will include in both 1.0.x and 2.0.x
Will include in 1.0.x and 2.0.x
With it moving to contrib and 11+ years of inactivity I don't believe this is as needed in contrib space.
Seems to already be fixed in contrib :)
Ran test-only feature
1) Drupal\Tests\node\Functional\NodeEditFormTest::testNodeFormNullAuthor
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.
/builds/issue/drupal-3161212/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3161212/vendor/behat/mink/src/WebAssert.php:145
/builds/issue/drupal-3161212/core/modules/node/tests/src/Functional/NodeEditFormTest.php:267
FAILURES!
Tests: 4, Assertions: 105, Failures: 1.
99% of the code is tests so the actual fix makes sense.
Very nice.
Pipeline appears to have issues but the goal is to now do a deprecation summary + title need to reflect that.
Will need test coverage as a next step. Thanks!
Just got access will work on a new branch for D11 this week.