🇺🇸United States @smustgrave

Think there may have been a rebase issue?

Looking good!

That does seem more correct. Imagine once it’s more stable that documentation page will get some love

So is this postponed in the related issues?

Can the issue summary be updated to include the issue this was added? May have been done on purpose. 4 years makes me wonder if it was a regression

Before making the change is there a spot we could update to show why it’s needed

Think we will have to trigger some deprecation to warn people

Then think this needs to go back to NW for backwards compatibility can’t just break things for people immediately

Think the issue summary needs some love. The motivation section mentions performance? But anything to support that?

Was also mentioned as a remaining task

The 8.1 I think is out of date haha

Uploading a screenshot to show.

@xjm closed issues get credit now so if they’re checked here they’ll get something.

If we move over then we should uncheck here too else we are giving double

Would say keep using the patch but most likely I’ll have to start another branch and redo the grid plugin again. It’s really just a fork with tweaks but those tweaks seem to have issues

Then update hook can set to TRUE. Whichever one keeps existing behavior so people’s sites don’t randomly break

Gotcha. So that key needs to be set in the upgrade hook. Probably needs to be a configUpdateImporter like views does it so it can be in batches.

Probably has to be set to FALSE to maintain existing behavior

Is this key going to appear in config yml file on config export

Thanks for reporting

MRs need to point to 11.x as the development branch.

Will need a test case showing this problem too

If this is a new key that will appear in config during an export then the upgrade path would be to add that key to all entity reference selection plugins.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Since there's been no follow up, going to close out. if still an issue in D11 please re-open addressing #34

Since there's been no follow up going to close out, if still an issue in D11 please reopen.

Since there has not been a follow up to #11 going to close out, but if still an issue in D11 please reopen

Thanks all!

This came up as daily BSI target

Issue summary could use some love but #129 may be worth exploring?

Seems like a good conversion.

Distribution aren't really a thing anymore, are they?

They may be out of date with recipes but believe they are definitely still around

Thanks for working on this!

Test failures seem related to this change.

Seems like good updates, any reason to be a draft? Don't want to premature mark

@rakhi soni this was closed as duplicate why are you saying this isn't? can you explain please.

just following up in a fresh install if you are seeing the issue?

Pipeline runs against 10.x and seems to pass there as well.

Pipeline all green!

Able to replicate this without the groups module?

1) Drupal\KernelTests\Core\DependencyInjection\AutowireTest::testAutowireInvalidDependency
Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: Cannot autowire service "Drupal\KernelTests\Core\DependencyInjection\InvalidServiceInterface": argument "$service" of method "Drupal\KernelTests\Core\DependencyInjection\InvalidOptionalDependencyController::_construct()", you should configure its value explicitly.
/builds/issue/drupal-3464426/core/lib/Drupal/Core/DependencyInjection/AutowireTrait.php:37
/builds/issue/drupal-3464426/core/tests/Drupal/KernelTests/Core/DependencyInjection/AutowireTest.php:191
ERRORS!
Tests: 4, Assertions: 7, Errors: 1.

Seems like good test coverage

Leaving tag for stats

But as a feature request with no activity or interest can’t imagine this will be added.

May just be better as a contrib

Unit tests appear to keep failing :(

CR will need some work as believe we missed 11.2

Left some comments on the MR.

If the test changes were needed to make them pass then wouldn't this change potentially break contrib tests.

Seems like a good update to cover both instances.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Curious if this is still an issue? I'm able to delete vocabularies without issue

Since there hasn't been a follow up in over a year going to say maybe this wasn't a needed task. Going to close but if still valid please re-open.

@belba can you add the exact steps you took to the issue summary please.

may be worth opening a ticket in the webform queue?

Our team is planning on making the jump too. Just need to figure what maps to what now. Maybe someone wants to write a blog about switching :)

Thanks @mstrelan for digging into that! Agree with your findings.

Based on the summary seems like a good test coverage being added.

PMNMI may be the right status but can the issue summary be updated with why this isn't needed?

Issue summary isn’t super clear what’s being suggested. To better help the Usability team it should be clear so they can quickly pick up

Seems like the question has been answered. Thanks!

Since there's been no follow up about "why" this is needed or specifically where I'm going to close out.

Just following up on steps to reproduce, if no follow up will close in 3 months.

To my knowledge the dialog header was actually updated to H1 (sorry can't find the ticket but rkoller believe worked on it as an acccessibility issue).

Came up as a daily BSI target

This still appears to be the case, example

* "delete-multiple-confirm" = "Drupal\Core\Entity\Form\DeleteMultipleForm"

But is it still a problem?

Will say if this still happening lets put back into NW, but no follow up in 3 months could close out.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

We already have an MR with those changes in them. Also from the comments that's not what's holding this up.

MR needs to be updated for 4.0.x and hopefully those pipeline errors go away

Thanks next step would be a test case.

If this isn’t reproducible in core may be a bug in the contrib module you’re using

So wonder if this should be closed as works as designed.

Restoring status.

Not 100% how else to test so am relying on tests, which are green. Locally nothing seems broken so going to go on a limb

I can agree with that. May even be a neat gitlab project to see if we can opt into different versions of ckeditor5. Not a core problem but idea came to mind reading this.

not 100% how to test but talked a little in the related issue 📌 Clean up unserialize() in the config system Active , relying on the tests for this one which are green. Since migration is marked to be removed in D12 and issues are being postponed might be good to get this in now. So going to mark it.

So seems all beta blockers for package manager on the roadmap are done, so assuming this is good?

What if someone extending the media library doesn't have these new keys what are the odds it'll be an immediate breaking.

Also not sure '_weight' is standard key format? But moving to NW as there appear to be open questions from #4

To discuss the feedback on #50, also was tagged for a follow up but don't see the issue for that.

Left comments.

Can 1 MR be closed or hidden. Or summary updated what the difference of the 2 are if one option needs to be picked over the other

Thanks.

Seems like something that probably should have test coverage.

Still looks like need feedback on the open threads.

Thanks for reporting

Changes will need to be in an MR against 11.x

Also will need a test case showing the bug.

MRs should be pointed at 11.x and will need test coverage.

Also issue summary template appears to be missing.