- Issue created by @KlemenDEV
- ๐ซ๐ทFrance o'briat Nantes
o'briat โ made their first commit to this issueโs fork.
- ๐ซ๐ทFrance o'briat Nantes
Don't know if it's revelant, but file_validate_image_resolution was removed without replacement, see https://www.drupal.org/node/3363745 โ & https://www.drupal.org/project/drupal/issues/3221793 ๐ Move file upload validation from file.module to constraint validators Fixed
- ๐ธ๐ฎSlovenia KlemenDEV
Don't think it is relavant, as ClamAV only uses/used hook_file_validate where the file size passed is incorrect if the file is resized
- ๐ซ๐ทFrance o'briat Nantes
I push the same patch to the new constraint part:
Works for me.
kerneltest is ok. - ๐ซ๐ทFrance o'briat Nantes
There's another usage of
$image->save()
in "navigation" experimental module core/modules/navigation/src/Form/SettingsForm.php:286.But the resize is done after the validation.
- Merge request !12928Update file size at image size validation (plus test). โ (Open) created by smustgrave
- ๐บ๐ธUnited States smustgrave
opened the MR but putting into NW because the summary is incomplete, please keep the full template and fill in relevant sections
- ๐ธ๐ฎSlovenia KlemenDEV
Updated issue to use full template and filled out to best of my knowledge
- ๐ซ๐ทFrance o'briat Nantes
Update description and put back the issue to needs review.
The "PHPUnit Build" pipeline task failed, but it doesn't seem to be related to this issue. - ๐ธ๐ฎSlovenia KlemenDEV
I confirm the merge request fixes the issue with ClamAV not working with resized images.
The MR also applied cleanly to 10.5.x
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Tests are failing and comments in #9 need to be addressed. See https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... โ for details on what makes an issue RTBC.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Re-ran the tests and they are back to green.
- ๐ธ๐ฎSlovenia KlemenDEV
I do believe as per rules you linked it was RTBC, also as per o'briat judgement of why tests were failing, but I will not leave to someone else to RTBC this issue/MR :)
- ๐ซ๐ทFrance o'briat Nantes
@kim.pepper
To me #9 was with #12.Since the tests are now OK, I put back the issue as "Needs review".
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I think this is ready to go.