🇸🇮Slovenia @KlemenDEV

Account created on 7 October 2016, about 8 years ago
#

Recent comments

🇸🇮Slovenia KlemenDEV

Closed. Issue with custom module.

🇸🇮Slovenia KlemenDEV

Are there any outstanding changes needed on the module itself to run on Drupal 11?

🇸🇮Slovenia KlemenDEV

This could work. But still keep the local files option available, because there are use cases/users (most of our websites, for example), where local files are used.

🇸🇮Slovenia KlemenDEV

We will do tests in the upcoming weeks, need to wait for some other modules to get a bit more ready and update internal modules

🇸🇮Slovenia KlemenDEV

Now that the critical CVE was fixed (the other one I don't believe is valid), is this ready for a release? It would be nice to see D11 ready release of Bootstrap 3 :)

If any other help is needed, I can try to help further

🇸🇮Slovenia KlemenDEV

Is a stable release supporting D11 planned?

🇸🇮Slovenia KlemenDEV

Are there any plans for D10/11 compatible release for 4.x branch of Social Auth?

🇸🇮Slovenia KlemenDEV

Are there any plans for D10/11 compatible release for 4.x branch of Social Auth?

🇸🇮Slovenia KlemenDEV

I see, thanks for the info @joseph.olstad

🇸🇮Slovenia KlemenDEV

I don't understand the ins and outs of Bootstrap, so excuse me if this is a dumb question, but what will happen with jQuery UI dependencies this module depends on? I have checked and it seems jQuery UI only works with jQuery versions up to 3.7

🇸🇮Slovenia KlemenDEV

I think the IE support removal is very good change too

🇸🇮Slovenia KlemenDEV

Big thanks @joseph.olstad for the efforts done here! Amazing work, looking forward to the movement of this, as it would be an amazing thing not having to go to Bootstrap 5 as some of my websites would require tons of work to achieve that

🇸🇮Slovenia KlemenDEV

Here is a full list of changes in jQuery 4: https://blog.jquery.com/2024/02/06/jquery-4-0-0-beta/

Maybe it is doable, maybe even this module could provide own fork of JS files of bootstrap

Also see https://www.drupal.org/project/bootstrap/issues/3428283 📌 Automated Drupal 11 compatibility fixes for bootstrap Needs review

🇸🇮Slovenia KlemenDEV

Here is a full list of changes in jQuery 4: https://blog.jquery.com/2024/02/06/jquery-4-0-0-beta/

Maybe it is doable, maybe even this module could provide own fork of JS files of bootstrap

🇸🇮Slovenia KlemenDEV

This bug was not fixed. After updating the Redis module to 1.8, we still get

PHP message: PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 20480 bytes) in contrib/redis/src/Controller/ReportController.php on line 129; PHP message: PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 20480 bytes)

every time the report page is open. Why is so much memory needed?

🇸🇮Slovenia KlemenDEV

We don’t either and have same issue

🇸🇮Slovenia KlemenDEV

I agree it is a bit harsh to the users having to either use the alpha version or observe error on their status screen that they are using unsupported module when using Drupal 10.3.x

🇸🇮Slovenia KlemenDEV

Looks good, makes me wonder why there is this version restriction here in the first place. Are you sure we can just remove the restriction?

🇸🇮Slovenia KlemenDEV

Opened new issue: https://www.drupal.org/project/mail_login/issues/3462188 🐛 Updating to 3.1 is not possible on Drupal 10.3.x Active

🇸🇮Slovenia KlemenDEV

Is this why mail login 3.1 does not work with Drupal 10.3.x and forces downgrade to 10.2.x when installing latest update?

🇸🇮Slovenia KlemenDEV

Sorry, I got confused and wrote the wrong module, I probably enabled multiple modules and thought it was navigation requesting that one.

Couldn't it (layout builder) be a soft dependency instead and if people don't want to place blocks using the new navigation, this feature is simply not shown in navigation entries?

🇸🇮Slovenia KlemenDEV

No occurrence of drupal_js_cache_files in the codebase, it seems this is stale stuff. The website we spotted this on used to run on all versions starting D7, so maybe it is an artifact from these times.

🇸🇮Slovenia KlemenDEV

I hope #3384600 lands soon as this prevents 10.3 from being "usable" due to the amount of logging that happens with this bug

🇸🇮Slovenia KlemenDEV

We have observed that on some of our websites

SELECT name, LENGTH(value) FROM key_value WHERE collection = 'state' ORDER BY LENGTH(value) DESC LIMIT 100;

yields mength numbers in orders of 200k, which is not ok according to https://www.drupal.org/node/3177901 .

The vast majority of the length comes from drupal_js_cache_files.

https://www.drupal.org/node/3177901 recommends optimizing if

Sites with more than 100 entries and/or a total value size/length of 100,000 should review their specific entries using the following query and either optimize their usage or disable state caching as a temporary measure:

but how can I optimize something that originates from the core?

🇸🇮Slovenia KlemenDEV

Code wise looks good, but not sure if this will also fix the

Warning: file_exists(): Unable to find the wrapper

that sometimes happens on line 140

🇸🇮Slovenia KlemenDEV

Patch #5 from https://www.drupal.org/project/drupal/issues/3384600 🐛 Don't hide permissions local tasks on bundles when no permissions are defined Needs work fixes the problem described in https://www.drupal.org/project/drupal/issues/3306434 🐛 Fix access checks for bundle permissions to avoid triggering a config validation error Fixed that started happening when updating from 10.2 to 10.3

🇸🇮Slovenia KlemenDEV

Patch #5 fixes the problem described in https://www.drupal.org/project/drupal/issues/3306434 🐛 Fix access checks for bundle permissions to avoid triggering a config validation error Fixed that started happening when updating from 10.2 to 10.3

🇸🇮Slovenia KlemenDEV

Happening since updating to 10.3 from 10.2. Site is super slow due to all of logging for all comment types and display modes of nodes that contain those comment types for every node visit

🇸🇮Slovenia KlemenDEV

As this issue is still stalling, does anyone have a patch for 10.3 at hand, otherwise I can try to prepare one later?

🇸🇮Slovenia KlemenDEV

Is this needs work, or needs review?

The last patch seems to fix the ajax part of the problem I had

🇸🇮Slovenia KlemenDEV

What would that translate to in the UI selection? Thanks for help!

🇸🇮Slovenia KlemenDEV

What is the default caching strategy on a fresh install for the default search view? (to know what to revert to)

🇸🇮Slovenia KlemenDEV

I have scanned the whole codebase with an automated script for any whitespace or new lines before <?php, but found none, however, I still experience AJAX problems such as modals not working. Is there something else I should also scan for?

🇸🇮Slovenia KlemenDEV

It seems multiple modules as well as the core itself were affected by some change in 10.2 that caused this. This issue prevents many websites from updating to 10.2, while 10.1 EOL is getting closer and closer (17. 6. 2024)

🇸🇮Slovenia KlemenDEV

I would be happy to help further if I understood the details of this, but this issue is probably preventing many websites from updating to 10.2

🇸🇮Slovenia KlemenDEV

You have linked to this same page where there is no #35 comment

🇸🇮Slovenia KlemenDEV

My issue is the JS error, but not style.

My issue is both in JS error (due to missing style) and missing style

🇸🇮Slovenia KlemenDEV

I think this issue should be reduced to the original case of responsive images not working in rewritten fields and a new ticket should be open for other HTML tags needed.

🇸🇮Slovenia KlemenDEV

I think the issue is deeper as this patch only fixes the consequence, but not the reason why styles are not properly passed to AJAX dialogs/popups

🇸🇮Slovenia KlemenDEV

Additional findings show that https://www.drupal.org/project/drupal/issues/3414753 🐛 Drupal ajax error after D10 update from version 10.0.11 to 10.2.1 Needs review does not fix this issue

🇸🇮Slovenia KlemenDEV

Ok so in my tests, https://www.drupal.org/project/ajax_comments/issues/3412943 🐛 Delete comment modal dialog broken with Drupal 10.2.x Active is partially (see my comment at https://www.drupal.org/project/drupal/issues/3409505#comment-15461560 🐛 Uncaught TypeError: Cannot read properties of null (reading 'style') (toolbar.js) Needs work ) fixed by https://www.drupal.org/project/drupal/issues/3409505 🐛 Uncaught TypeError: Cannot read properties of null (reading 'style') (toolbar.js) Needs work , but not fixed at all by #16 from this issue.

🇸🇮Slovenia KlemenDEV

I have reported some findings at https://www.drupal.org/project/drupal/issues/3409505#comment-15461560 🐛 Uncaught TypeError: Cannot read properties of null (reading 'style') (toolbar.js) Needs work

🇸🇮Slovenia KlemenDEV

I can confirm patch #2 fixes https://www.drupal.org/project/ajax_comments/issues/3412943 🐛 Delete comment modal dialog broken with Drupal 10.2.x Active , however, the look (CSS styling) of the popup dialog is still broken

🇸🇮Slovenia KlemenDEV

I will try to test if this is the case for this issue too when I get some time: https://www.drupal.org/project/ajax_comments/issues/3412943 🐛 Delete comment modal dialog broken with Drupal 10.2.x Active

It is also custom link dialog + bootstrap theme + css + js

🇸🇮Slovenia KlemenDEV

MR got some confirmations at https://www.drupal.org/project/clamav/issues/3058018 🐛 Use of Max Resolution on Image Field causes ClamAV Timeout in Deamon mode Needs review too, so I believe the MR fixes the problem.

Will this be merged in 11.x only or will 10.1/10.2 get a backport of this?

🇸🇮Slovenia KlemenDEV

I can now confirm RTBC based on 2-week running experiment on one of the sites, LGTM

🇸🇮Slovenia KlemenDEV

I am currently lost what to take for the next step in debugging this, but would be happy to help if anyone has any suggestions for the next steps to take

🇸🇮Slovenia KlemenDEV

Could this be duplicate of https://www.drupal.org/project/ajax_comments/issues/2896916 🐛 Ajax not working when using non-default view mode. Needs work ?

🇸🇮Slovenia KlemenDEV

This is happening again, now when I updated from Drupal 10.1.x to 10.2.x

🇸🇮Slovenia KlemenDEV

#3410303: FilterHtml data loss when iframe and/or textarea is allowed indeed fixes this issue

🇸🇮Slovenia KlemenDEV

Could any maintainer merge this into a release? This issue could be preventing people from updating to 10.2.x unless they opt to use a patch

🇸🇮Slovenia KlemenDEV

Ok I have used a wrong term. I mean data loss on render, not in the database. Sorry for the confusion.

I will spin up local instance of our system and try it out and report back

🇸🇮Slovenia KlemenDEV

Could be, I am also using iframe as the HTML tag allowed, alongside some div tags with custom classes

🇸🇮Slovenia KlemenDEV

I can confirm the MR fixes the bug for our websites and does not seem to introduce any additional regressions.

🇸🇮Slovenia KlemenDEV

In further tests, it seems this only happens if one defines HTML tags that already exist or variations of them with custom attributes or attribute values allowed. If a tag added here is a tag that is not added by any other plugin, it seems to work fine.

Production build 0.71.5 2024