- 🇩🇪Germany Anybody Porta Westfalica
Could we please have MR for this and perhaps someone could contact an active maintainer to have this fixed finally? Looks like a lot of people run into this trouble? :)
Thanks!
- Issue was unassigned.
- 🇳🇱Netherlands idebr
Approach looks good, but this issue will need some test coverage before commit.
- First commit to issue fork.
- last update
11 months ago 2 pass - @parisek opened merge request.
- last update
11 months ago 2 pass - @parisek opened merge request.
- Status changed to Needs review
9 months ago 10:29am 14 October 2023 Thank you parisek, your MR works as expected.
Now It works for a different view mode for me.
I am not sure if it is related. But Edit button now does not work. I am using modal window and using different view mode to display. Everything works fine after i applied that MR, however edit button does not work - whole screen become greyed out. Once I click ESC and open dialog window again + edit button - it works fine.
But every time refresh of page needs to be done.#71 - it does not work also for the normal view, so it is not related to this issue. Hence I created a new one here.
3394119 🐛 Edit button in Dialog window Active
- 🇩🇪Germany Anybody Porta Westfalica
@parisek, @coaston still no test coverage, sadly. It's needed to get this issue fixed finally.
Anybody, do you think it is possible to disable ajax for operation actions like edit/delete (or simply add target "_blank" to this links ?)
This would solve the issue for dialog.- last update
6 months ago 2 pass - 🇺🇸United States pvalappil
Updating #60 to convert display option to empty array if it is null
- 🇫🇷France PhilY 🇪🇺🇫🇷 Paris, France
Patch #75 works for me using Drupal 10.1.7 + CKEditor 5 on a full display mode.
- 🇬🇧United Kingdom globexplorer
The problem with the above patches is they assume every entity is fieldable, but if not it throws WSOD!
- last update
3 months ago 2 pass - 🇺🇸United States SocialNicheGuru
@globexplorer, please remove changes to ajax_comments.info.yml and could you provide an interdiff?
- Status changed to Needs work
3 months ago 3:10pm 17 March 2024 - Status changed to Needs review
3 months ago 1:54pm 18 March 2024 - 🇩🇪Germany Anybody Porta Westfalica
Could we perhaps switch to a MR which is easier to review and "interdiffed automatically"?
- Status changed to Needs work
3 months ago 2:12pm 18 March 2024 - 🇩🇪Germany Anybody Porta Westfalica
Still this has no tests to ensure it doesn't break again in the future.