🇺🇸United States @SocialNicheGuru

I take it this is in os alpha23?

This is not working because it is too late in the process. autoload-test is fine, but the other is causing problems as commerce is not autoloaded.

socialnicheguru → created an issue.

Last two were incomplete and had errors

When installing a site and even some modules i get this: Passing null to parameter #1 ($string) of type string is deprecated filter.module

The variable is not set yet on install:

$public_base_url = Settings::get("file_public_base_url");
$public_base_url_length = mb_strlen($public_base_url);

Drupal 10.4.8
php8.3

socialnicheguru → created an issue.

No need for this in 3.x since it is already defined:
https://git.drupalcode.org/project/commerce_license/-/blob/3.0.x/src/Plu...

socialnicheguru → created an issue.

socialnicheguru → created an issue.

This is still an issue for me.
I think this might be an explanation:

Even when disabled, the module's entity class files are being autoloaded during cache rebuilds. The Campaign entity class is being discovered and its baseFieldDefinitions() method is being called, which tries to create a field of type commerce_plugin_item:commerce_recruiting_bonus_resolver, but the plugin type doesn't exist because the module (and its services) are disabled.
This is a common issue with Drupal modules that define entity types with custom field types - the entity discovery happens before the module's services are available.

1. Database Update Hook (commerce_recruiting.install)
phpfunction commerce_recruiting_update_8003() {
  $recruitment_bonus_resolver = BaseFieldDefinition::create('commerce_plugin_item:commerce_recruiting_bonus_resolver')
    // ... field definition
}
2. Entity Definition (Campaign.php)
php$fields['recruitment_bonus_resolver'] = BaseFieldDefinition::create('commerce_plugin_item:commerce_recruiting_bonus_resolver')
3. Install Configuration
yamlmodules/contrib/commerce_recruiting/config/install/commerce_plugin_item.commerce_recruiting_bonus_resolver.yml
The problem: Even with the module disabled, Drupal is trying to run entity field discovery during cache rebuild, which loads the Campaign entity class, which tries to create the field definition that references the non-existent plugin type.

socialnicheguru → created an issue.

Can this report display be done with views?

Thank you for this. I was wondering if I was just a little crazy and not being able to find it. (still a little crazy but at least with a reason now )

i was on psr version less than 3.
What is in code works for psr >= 0

Making this closed (works as designed)

Was the patch committed? I do not see a reference to it or the issue number in the commit queue. Did I miss it?

Not sure what the status is. The PR is closed but was it already merged?

should this be closed since the PR that it points to is closed?

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

Has this code been added via MR commit or patch? Is there a link?

Is there code to review?

The MR does not apply to Drupal 10.4.x

MR450 is blank

socialnicheguru → created an issue. See original summary → .

Once this patch is applied, other errors show up in the module.

ArgumentCountError: Too few arguments to function Drupal\Component\Plugin\Attribute\Plugin::__construct(), 0 passed in drupal-10.4.x/html/modules/contrib/geolocation/modules/geolocation_search_api/src/Plugin/views/argument/SearchApiLocationRadius.php on line 14 and at least 1 expected in Drupal\Component\Plugin\Attribute\Plugin->__construct() (line 25 of drupal-10.4.x/html/core/lib/Drupal/Component/Plugin/Attribute/Plugin.php

Updated class names to match module name

socialnicheguru → created an issue.

socialnicheguru → created an issue.

Added patch. remove .gitlib and composer.json changes. seemed not germain to this issue.

composer require "drupal/eca": "2.1.x-dev@dev"

In PackageDiscoveryTrait.php line 383:

Could not find a matching version of package 2.1.x-dev@dev. Check the package spelling, your version constraint
and that the package is available in a stability which matches your minimum-stability (dev).

this is strange.

It must just be my system.

Changes made to the latest dev

socialnicheguru → created an issue.

socialnicheguru → created an issue.

The MR no longer applies to dev version of scheduler:

drupal/scheduler
https://git.drupalcode.org/project/scheduler/-/merge_requests/230.diff (Support for ECA - https://www.drupal.org/project/scheduler/issues/3363972 💬 Support for ECA Active )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/scheduler/-/merge_requests/230.diff

The recommended patch no longer applies to latest version:

 - Applying patches for drupal/jsonapi_schema
    https://www.drupal.org/files/issues/2019-10-31/3091633-3.patch ([commerce_api]: Support for cross bundle resource types 
            
              
              
              ✨
              Support for cross bundle resource types
                Needs work
              
             - https://www.drupal.org/project/commerce_api/issues/3116465)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-10-31/3091633-3.patch

This MR/patch cannot be installed on 2.x version because of this recent commit, 🐛 Moderated Content view does not show the correct data for roles other than the group creator Active .

Patch no longer applies

OK. so adding autowire in would force the use oc commerce 3. I was on commerce 2.x that is why I had to add the patch that I did.

i am using 2.x-dev so yes commerce 2

That was the wrong patch for the wrong module.

Here is the correct one

socialnicheguru → created an issue.

@klemendev, can you open up another issue and reference this one. The point you raised seems very important and it shouldn't be lost since these changes have been committed.

Is there a way that I can see the api changes between 2 and 3 and the diff? I want to see what specific commerce changes there are in 3 that I might be able to backport with your permission.

No longer applies:
drupal/entity_field_condition (1.4.0 => 1.5.0)

The other patch is more comprehensive

Or per the security issue linked above, update search_api_solr to 4.3.10.

So with this MR is ai 1.1.x needed? Wasn't this the cause of that other branch?

AHHH... I see. The MR worked.

socialnicheguru → created an issue.

This happened to me as i was fixing my site. This patch saved the day.

socialnicheguru → created an issue.

Since many of us simply cannot move to Drupal 11 yet, is it possible to have Auctions support commerce 3.x and Drupal 10.4+?

socialnicheguru → created an issue.

socialnicheguru → created an issue.

With selecting "Inline SMS" these additional errors occur that cause ckeditor5 not to be installed:

Error message
'display' is not a supported key.
'display_text' is not a supported key.
'default_icon' is not a supported key.
'custom_icon_path' is not a supported key.

I still need to use smsframework 2.3. I understand that this submodule is going away and that is why you do not want to fix it.

But for those of us still on 2.3 let's see if we can fix it

socialnicheguru → created an issue.

socialnicheguru → created an issue.

This is still useful for Drupal 10

please checkout 📌 Automated Drupal 10 compatibility fixes Needs review

This patch conflicts with a commit to Commerce 3.x ✨ Display payment method in the CheckoutPane Payment informations even if only single payment gateway available Needs review .

Does anything have to happen to make sure that this new submodule is compatible with ECA, 💬 Support for ECA Active ?

This does not apply to commerce_vado 3.0.2. Is it needed for that version? it is on the module page.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

socialnicheguru → created an issue.

this has been closed as fixed: 🐛 Uncaught TypeError: $(...).once is not a function with Drupal 10 Fixed

and are they needed anymore? I have upgraded to group 2.x for example.

Could this be used instead: https://www.drupal.org/project/views_argument_token → ?

MR and patch no longer apply to latest dev version

I see that this does not pertain to all providers: https://www.drupal.org/project/ai_provider_ollama/issues/3512333#comment... 🐛 Update to use ai 1.1.x-dev Active

This does not apply to commerce 3.0.x-dev

it does not apply

it applies for me