🇺🇸United States @SocialNicheGuru

Account created on 2 February 2007, over 18 years ago
#

Recent comments

🇺🇸United States SocialNicheGuru

OK. so adding autowire in would force the use oc commerce 3. I was on commerce 2.x that is why I had to add the patch that I did.

🇺🇸United States SocialNicheGuru

i am using 2.x-dev so yes commerce 2

🇺🇸United States SocialNicheGuru

That was the wrong patch for the wrong module.

Here is the correct one

🇺🇸United States SocialNicheGuru

@klemendev, can you open up another issue and reference this one. The point you raised seems very important and it shouldn't be lost since these changes have been committed.

🇺🇸United States SocialNicheGuru

Is there a way that I can see the api changes between 2 and 3 and the diff? I want to see what specific commerce changes there are in 3 that I might be able to backport with your permission.

🇺🇸United States SocialNicheGuru

No longer applies:
drupal/entity_field_condition (1.4.0 => 1.5.0)

🇺🇸United States SocialNicheGuru

The other patch is more comprehensive

🇺🇸United States SocialNicheGuru

Or per the security issue linked above, update search_api_solr to 4.3.10.

🇺🇸United States SocialNicheGuru

So with this MR is ai 1.1.x needed? Wasn't this the cause of that other branch?

🇺🇸United States SocialNicheGuru

AHHH... I see. The MR worked.

🇺🇸United States SocialNicheGuru

Since many of us simply cannot move to Drupal 11 yet, is it possible to have Auctions support commerce 3.x and Drupal 10.4+?

🇺🇸United States SocialNicheGuru

With selecting "Inline SMS" these additional errors occur that cause ckeditor5 not to be installed:

Error message
'display' is not a supported key.
'display_text' is not a supported key.
'default_icon' is not a supported key.
'custom_icon_path' is not a supported key.

🇺🇸United States SocialNicheGuru

I still need to use smsframework 2.3. I understand that this submodule is going away and that is why you do not want to fix it.

But for those of us still on 2.3 let's see if we can fix it

🇺🇸United States SocialNicheGuru

Does anything have to happen to make sure that this new submodule is compatible with ECA, 💬 Support for ECA Active ?

🇺🇸United States SocialNicheGuru

This does not apply to commerce_vado 3.0.2. Is it needed for that version? it is on the module page.

🇺🇸United States SocialNicheGuru

and are they needed anymore? I have upgraded to group 2.x for example.

🇺🇸United States SocialNicheGuru

MR and patch no longer apply to latest dev version

🇺🇸United States SocialNicheGuru

I see that this does not pertain to all providers: https://www.drupal.org/project/ai_provider_ollama/issues/3512333#comment... 🐛 Update to use ai 1.1.x-dev Active

🇺🇸United States SocialNicheGuru

If I use http://drupal.org/project/eca will this module give added triggers and conditions?

🇺🇸United States SocialNicheGuru

I updated the charictarization.

Just wonderinf if the version of d3/d3 will be updated to 7.8+ ?

🇺🇸United States SocialNicheGuru

Could this be added as a submodule, flipbook_sound?

🇺🇸United States SocialNicheGuru

Does that take an update hook in addition to removing them in config?

🇺🇸United States SocialNicheGuru

Maybe we can use this as a moment, upgrade to Drupal 10+/11 to consolidate all of the "affiliate" type modules under one umbrella.

http://drupal.org/project/uber_affilaite
http://drupal.org/project/affiliate_ng
http://drupal.org/project/affiliate
http://drupal.org/project/affiliates

I like the idea of being able to connect and apply userpoints and commerece_userpoints; keep track of referrals using, https://www.drupal.org/project/indieweb; give actual dollars using commerce_affiliate; give points or rewards for sharing and sign ups.

Most of this can be done in services or hooks that might connect to individual modules to do the heavy lifting.

We could use views to show reporting

🇺🇸United States SocialNicheGuru

no that is not the change that i wanted.

🇺🇸United States SocialNicheGuru

While this does not effect 2.0 releases yet because the line is not in composer, it does effect the 2.0.x-dev release.

🇺🇸United States SocialNicheGuru

Then it probably is just a restraint issue in composer.json and .info.yml to allow ai:ai 1.0.x-dev || 1.1.x-dev

🇺🇸United States SocialNicheGuru

#6 is a bad patch. it adds .orig files

🇺🇸United States SocialNicheGuru

I just took a quick peak at the MR and saw:

 diff --git a/composer.json b/composer.json
index f5f380a65bff59d87a62ee7ffb9928d1b317dd23..9ab54755ad21f72d612afe5a8dadcf28fb13277f 100644
--- a/composer.json
+++ b/composer.json
@@ -10,7 +10,8 @@
         "drupal/devel_generate": ">=4",
         "drupal/workbench_moderation": "*",
         "drupal/workbench_moderation_actions": "*",
-        "drupal/commerce": "^2 || ^3"
+        "drupal/commerce": "^2 || ^3",
+        "drupal/eca": ">=2"
     },
 

Now I see that ECA is being added to require-dev not require.

🇺🇸United States SocialNicheGuru

Could this be a submodule that depends on eca? Making the main scheduler module depend on eca seems more than is needed for a simple installation.

🇺🇸United States SocialNicheGuru

if I apply 🐛 getResults is not returning the correct results Needs review like it says, this MR does not apply to 2.0.x.

🇺🇸United States SocialNicheGuru

Is there a difference between $74 and #75?

🇺🇸United States SocialNicheGuru

As per, https://github.com/steverhoades/oauth2-openid-connect-server/blob/v3.0.1..., there might be cases like mine where ^8.4 was being installed but I needed 9.2 and above.

I had to explicitly call ^9.2 to ensure that got enabled

🇺🇸United States SocialNicheGuru

So i added "league/oauth2-server": "^9.2" to my composer file and it did work.

So was taking it out a regression?

I did have to do some work to accommodate which I am including if it will help others:
I also had to add this to my composer.json: "lcobucci/jwt":"5.5 as 4.0" to accommodate the change as a few modules (commerce_authnet and indieweb use lcobucci/jwt":^4.0"

Production build 0.71.5 2024