Live feed

โšก๏ธ Live updates new comments are added automatically.
๐Ÿ‡ณ๐Ÿ‡ดNorway thorandre

A similar mechanism will be made into the 4.x release of DG. The above is very specific for WP and after some discovery we saw that it cannot be used. Closing this. Will create a new 4.x issue with relevant child issues.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom Jons

Hi @dolszewski
Yes disabling this stops the stripping - but should there be a config to allow span to have an attribute?
With a custom tag this is possible. Would it make sense to use a custom tag?

๐Ÿ‡ณ๐Ÿ‡ดNorway thorandre

We're postponing this from the 3.x release. Not yet decided if it should go into 4.x.
Setting to Closed(Won't fix) - let's reopen or create a new one when we decide to move forward with this.

๐Ÿ‡ฉ๐Ÿ‡ชGermany Marcus_Johansson

Setting back to "Needs Review", since I saw weird behaviour and read about similar behaviour in the Slack channe for contributors.

@Amandeep123 - can you describe how you tested this ticket?

๐Ÿ‡ฎ๐Ÿ‡ณIndia ankitv18

ankitv18 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡นItaly Bladedu Italy

This is something we definitely need, but in the MR there's too much going on.

Would you care re-rolling the MR on top of 1.x and only for the batch part?

The refactoring proposed is also interesting, but I'd move it in a separate issue, if you wouldn't mind.

Thank you!

๐Ÿ‡ฎ๐Ÿ‡ณIndia Rajeshreeputra Pune

Rajeshreeputra โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฉ๐Ÿ‡ชGermany Marcus_Johansson

Thanks @Gurkawal, how did you actually test it?

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom alexpott ๐Ÿ‡ช๐Ÿ‡บ๐ŸŒ

Needs backporting to 10.3.x

Hy @Marcus_Johansson

I have reviewed it

Thank you for providing the solution

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishalkhode

Reviewed MR and changes looks good to me.

๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

Since you've confirmed the fix and I'm about to tag a new release, went ahead and merged the MR. We can expand the tests in a followup issue, in the meantime, closing this one.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Diwakar07

Hi @Rajeshreeputra, Taran2L
I have updated the list of ignored words and removed the some words(the ones that were used in README and for providing examples of configuring the module) that does make any change to the working of the module.
I think rest of the words are required to be ignored.
Please review.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom Jon Pollard

It is this extension - CMS User

https://github.com/Skvare/com.skvare.cmsuser

with that extension disabled I am still getting the error.

Hello,

I've seen the same error, but caused by the button pattern preprocess (visible on pages : /patterns or /patterns/button ou /patterns/button_group) :

TypeError: strtolower(): Argument #1 ($string) must be of type string, Drupal\Core\Render\Markup given in strtolower() (line 440 of themes/contrib/ui_suite_dsfr/ui_suite_dsfr.theme).

ui_suite_dsfr_preprocess_pattern_button(Array, 'pattern_button', Array)
...

It seems the same kind of condition causes the same error.

The strange thing is :

  • if we comment those lines in ui_suite_dsfr but implement the same preprocess in our child theme, there is no error, everything works as expected
  • I see the link pattern preprocess has the same kind of condition but it doesn't trigger any error...

I confirm that this preprocess is not obsolete, as it handles the "external" setting automatically based on the URL, so the best would be to find the cause of the error and fix it, if possible, instead of removing.

๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

jsacksick โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฐ๐Ÿ‡ฌKyrgyzstan sahaj

Actually, I noticed the issue on a 'Service' type. But what was strange, is that the Schema.org additional type wasn't enabled.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Rajeshreeputra Pune

@Taran2L, I agree with your point. Although the spelling does not correspond to an actual word, considering that we are using it for a variable name and also username(on D.O), we should be good to proceed.

I am open to suggestions on this.

๐Ÿ‡ต๐Ÿ‡ญPhilippines cleavinjosh

Hi,

I applied the patch #40 and verified that the issues reported by phpcs are fixed.

 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 84340  100 84340    0     0   168k      0 --:--:-- --:--:-- --:--:--  168k
Checking patch entity_browser.api.php...
Checking patch entity_browser.module...
Checking patch entity_browser.views.inc...
Checking patch modules/entity_form/entity_browser_entity_form.module...
Checking patch modules/entity_form/src/Plugin/EntityBrowser/Widget/EntityForm.php...
Checking patch src/Ajax/SelectEntitiesCommand.php...
Checking patch src/Ajax/ValueUpdatedCommand.php...
Checking patch src/Controllers/EntityBrowserController.php...
Checking patch src/Controllers/EntityBrowserFormController.php...
Checking patch src/Controllers/EntityBrowserListBuilder.php...
Checking patch src/DisplayBase.php...
Checking patch src/DisplayInterface.php...
Checking patch src/Element/EntityBrowserElement.php...
Checking patch src/Entity/EntityBrowser.php...
Checking patch src/EntityBrowserInterface.php...
Checking patch src/Events/AlterEntityBrowserDisplayData.php...
Checking patch src/Events/EntitySelectionEvent.php...
Checking patch src/Events/EventBase.php...
Checking patch src/Events/Events.php...
Checking patch src/Events/RegisterJSCallbacks.php...
Checking patch src/Form/EntityBrowserEditForm.php...
Checking patch src/Form/EntityBrowserForm.php...
Checking patch src/Plugin/EntityBrowser/Display/Modal.php...
Checking patch src/Plugin/EntityBrowser/Display/Standalone.php...
Checking patch src/Plugin/EntityBrowser/FieldWidgetDisplay/ImageThumbnail.php...
Checking patch src/Plugin/EntityBrowser/FieldWidgetDisplay/RenderedEntity.php...
Checking patch src/Plugin/EntityBrowser/SelectionDisplay/MultiStepDisplay.php...
Checking patch src/Plugin/EntityBrowser/SelectionDisplay/View.php...
Checking patch src/Plugin/EntityBrowser/Widget/Upload.php...
Checking patch src/Plugin/EntityBrowser/Widget/View.php...
Checking patch src/Plugin/EntityBrowser/WidgetSelector/DropDown.php...
Checking patch src/Plugin/EntityBrowser/WidgetSelector/Single.php...
Checking patch src/Plugin/EntityBrowser/WidgetSelector/Tabs.php...
Checking patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php...
Checking patch src/Plugin/Field/FieldWidget/FileBrowserWidget.php...
Checking patch src/Plugin/views/display/EntityBrowser.php...
Checking patch src/Plugin/views/field/SelectForm.php...
Checking patch src/Plugin/views/filter/ContextualBundle.php...
Checking patch src/RouteSubscriber.php...
Checking patch src/SelectionDisplayBase.php...
Checking patch src/SelectionDisplayInterface.php...
Checking patch src/WidgetBase.php...
Checking patch src/WidgetInterface.php...
Checking patch src/WidgetSelectorBase.php...
Checking patch tests/modules/entity_browser_test/entity_browser_test.routing.yml...
Checking patch tests/modules/entity_browser_test/src/Form/FormElementTest.php...
Checking patch tests/modules/entity_browser_test/src/Plugin/EntityBrowser/Widget/DummyWidget.php...
Checking patch tests/src/Functional/EntityBrowserUITest.php...
Checking patch tests/src/Functional/FormElementTest.php...
Checking patch tests/src/FunctionalJavascript/CardinalityTest.php...
Checking patch tests/src/FunctionalJavascript/ConfigurationTest.php...
Checking patch tests/src/FunctionalJavascript/EntityBrowserTest.php...
Checking patch tests/src/FunctionalJavascript/EntityBrowserViewsWidgetTest.php...
Checking patch tests/src/FunctionalJavascript/EntityBrowserWebDriverTestBase.php...
Checking patch tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php...
Checking patch tests/src/FunctionalJavascript/FieldWidgetConfigTest.php...
Checking patch tests/src/FunctionalJavascript/InlineEntityFormTest.php...
Checking patch tests/src/FunctionalJavascript/ParagraphsTest.php...
Checking patch tests/src/FunctionalJavascript/PluginsTest.php...
Checking patch tests/src/Kernel/Plugin/FieldWidgetDisplayTest.php...
Applied patch entity_browser.api.php cleanly.
Applied patch entity_browser.module cleanly.
Applied patch entity_browser.views.inc cleanly.
Applied patch modules/entity_form/entity_browser_entity_form.module cleanly.
Applied patch modules/entity_form/src/Plugin/EntityBrowser/Widget/EntityForm.php cleanly.
Applied patch src/Ajax/SelectEntitiesCommand.php cleanly.
Applied patch src/Ajax/ValueUpdatedCommand.php cleanly.
Applied patch src/Controllers/EntityBrowserController.php cleanly.
Applied patch src/Controllers/EntityBrowserFormController.php cleanly.
Applied patch src/Controllers/EntityBrowserListBuilder.php cleanly.
Applied patch src/DisplayBase.php cleanly.
Applied patch src/DisplayInterface.php cleanly.
Applied patch src/Element/EntityBrowserElement.php cleanly.
Applied patch src/Entity/EntityBrowser.php cleanly.
Applied patch src/EntityBrowserInterface.php cleanly.
Applied patch src/Events/AlterEntityBrowserDisplayData.php cleanly.
Applied patch src/Events/EntitySelectionEvent.php cleanly.
Applied patch src/Events/EventBase.php cleanly.
Applied patch src/Events/Events.php cleanly.
Applied patch src/Events/RegisterJSCallbacks.php cleanly.
Applied patch src/Form/EntityBrowserEditForm.php cleanly.
Applied patch src/Form/EntityBrowserForm.php cleanly.
Applied patch src/Plugin/EntityBrowser/Display/Modal.php cleanly.
Applied patch src/Plugin/EntityBrowser/Display/Standalone.php cleanly.
Applied patch src/Plugin/EntityBrowser/FieldWidgetDisplay/ImageThumbnail.php cleanly.
Applied patch src/Plugin/EntityBrowser/FieldWidgetDisplay/RenderedEntity.php cleanly.
Applied patch src/Plugin/EntityBrowser/SelectionDisplay/MultiStepDisplay.php cleanly.
Applied patch src/Plugin/EntityBrowser/SelectionDisplay/View.php cleanly.
Applied patch src/Plugin/EntityBrowser/Widget/Upload.php cleanly.
Applied patch src/Plugin/EntityBrowser/Widget/View.php cleanly.
Applied patch src/Plugin/EntityBrowser/WidgetSelector/DropDown.php cleanly.
Applied patch src/Plugin/EntityBrowser/WidgetSelector/Single.php cleanly.
Applied patch src/Plugin/EntityBrowser/WidgetSelector/Tabs.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/FileBrowserWidget.php cleanly.
Applied patch src/Plugin/views/display/EntityBrowser.php cleanly.
Applied patch src/Plugin/views/field/SelectForm.php cleanly.
Applied patch src/Plugin/views/filter/ContextualBundle.php cleanly.
Applied patch src/RouteSubscriber.php cleanly.
Applied patch src/SelectionDisplayBase.php cleanly.
Applied patch src/SelectionDisplayInterface.php cleanly.
Applied patch src/WidgetBase.php cleanly.
Applied patch src/WidgetInterface.php cleanly.
Applied patch src/WidgetSelectorBase.php cleanly.
Applied patch tests/modules/entity_browser_test/entity_browser_test.routing.yml cleanly.
Applied patch tests/modules/entity_browser_test/src/Form/FormElementTest.php cleanly.
Applied patch tests/modules/entity_browser_test/src/Plugin/EntityBrowser/Widget/DummyWidget.php cleanly.
Applied patch tests/src/Functional/EntityBrowserUITest.php cleanly.
Applied patch tests/src/Functional/FormElementTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/CardinalityTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/ConfigurationTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/EntityBrowserTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/EntityBrowserViewsWidgetTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/EntityBrowserWebDriverTestBase.php cleanly.
Applied patch tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/FieldWidgetConfigTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/InlineEntityFormTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/ParagraphsTest.php cleanly.
Applied patch tests/src/FunctionalJavascript/PluginsTest.php cleanly.
Applied patch tests/src/Kernel/Plugin/FieldWidgetDisplayTest.php cleanly.
โžœ  entity_browser git:(85a79c7) โœ— cd ..
โžœ  contrib git:(main) โœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_browser
โžœ  contrib git:(main) โœ—

Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฉ๐Ÿ‡ชGermany Marcus_Johansson

Tested via https://www.drupal.org/project/ai_interpolator_openai/issues/3449252 โœจ Add simple text fields Fixed

๐Ÿ‡ท๐Ÿ‡ธSerbia pivica

@silvi.addweb, @Amandeep123, and to all similar actions people in the future, please do not just create MR without adding any additional value to this issue or related code.

Read carefully https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... โ†’

Don't: Open a merge request without adding any code. Delay opening the request until you have created the code you want merged.

I will not give you issue credit just for creating MR from patch or doing anything else that does not add any value to this issue or any other issue in ddo projects I maintaine.

If you want to contribute great, but then do some actual contribution. If you are not sure how there is plenty of issues you can do actual work, just ask for help/guidance.

๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

Let's start with this, we're IMO just missing an alteration of the name (something like "
(Copy)"), but I'd say this is good enough for now.
Merging, thanks!

๐Ÿ‡ซ๐Ÿ‡ทFrance pdureau Paris

+1

I am impress how efficient Mateu was to add SDC in Core in less than a year. He targeted Drupal 10.1 and successfully hit it.
Thanks to Mateu's great work and its communication & promotion skills, SDC is gaining traction in the community and will transform how we work with Drupal.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ซ๐Ÿ‡ทFrance Grimreaper France ๐Ÿ‡ซ๐Ÿ‡ท

Hi,

+1 on this too.

Working since 5 years with Pierre on UI Suite and following him on his other projects like https://dilla.io/, I can't count the architecture discussions we have on Drupal rendering system, UI Suite and new technological ideas.

๐Ÿ‡ฎ๐Ÿ‡ณIndia aman1248

Hy @Marcus_Johansson
I have reviewed it , It has a straight forward fix.

Please & Thank You.

** Marking this ticket as RTBC!!

๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

Based on the second backtrace, this seems to originate from Commerce shipping and I believe this was already reported. Are you running the latest Commerce shipping version?

๐Ÿ‡ฎ๐Ÿ‡นItaly aronne

Hi there,
sorry for the long wait. I'm gonna fix it ASAP.

๐Ÿ‡ง๐Ÿ‡ชBelgium Mav_fly

@Ravi kant Thanks for the video!

I understand the principle of fit to content or 2 columns.
But the problem I have is if you choose for example 2, 3, โ€ฆ columns the data of your view is arranged horizontal

Data A Data B
Data C Data D

And when using responsive grid you can also choose 2,3,โ€ฆ columns, but you have the option alignment horizontal or vertical

Alignment horizontal :

Data A Data B
Data C Data D

Alignment vertical :

Data A Data C
Data B Data D

And that was my question if it is possible to align your data vertical in bootstrap grid ?

You see my problem ?

๐Ÿ‡ฉ๐Ÿ‡ชGermany Marcus_Johansson

Hey @alexandersluiter, I actually needed this in another project now, so there is a reusable helper function for this in the core module now.

Related ticket: https://www.drupal.org/project/ai_interpolator/issues/3446771 โœจ Add helper class to base fields to add imagestyle preprocessing Active

If you pull this DEV version of this and the core module AI Interpolator it should be possible to test.

๐Ÿ‡ช๐Ÿ‡ธSpain plopesc Valladolid

Tests added for this new scenario.

๐Ÿ‡ฉ๐Ÿ‡ชGermany mbuechner Frankfurt

I can confirm what @31danflanagan8 says. But the current 8.x-1.x-dev fixes the problem!

composer require 'drupal/views_ajax_history:1.x-dev@dev'

If someone created a release for version 1.8, I'd be happy ;-)

๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

Can you reproduce this consistently? Are you able to reproduce this on a vanilla install?

Production build 0.69.0 2024