Live feed

โšก๏ธ Live updates new comments are added automatically.
๐Ÿ‡ง๐Ÿ‡ชBelgium Wim Leers Ghent ๐Ÿ‡ง๐Ÿ‡ช๐Ÿ‡ช๐Ÿ‡บ
๐Ÿ‡ณ๐Ÿ‡ฑNetherlands bbrala Netherlands

bbrala โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom longwave UK

Well the code just does this:

              ['id' => $id, 'content' => $content] = $this->parseClass($class, $fileinfo);

              if ($id) {
                $definitions[$id] = $content;
                // Explicitly serialize this to create a new object instance.
                $this->fileCache->set($fileinfo->getPathName(), ['id' => $id, 'content' => serialize($content)]);
              }
              else {
                // Store a NULL object, so the file is not parsed again.
                $this->fileCache->set($fileinfo->getPathName(), [NULL]);
              }

So really it's just replacing that $id check with a catch? Or, we also allow parseClass to return just NULL directly instead of an array of NULLs?

๐Ÿ‡บ๐Ÿ‡ธUnited States DamienMcKenna NH, USA

DamienMcKenna โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States mark_fullmer Tucson

The fix for this was committed to both the 8.x-1.x branch and 2.x branches. See https://git.drupalcode.org/project/responsive_tables_filter/-/commit/eaf...

A release for 2.x is available that includes this change. 8.x-1.x does not yet have a release that includes this fix.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom scott_euser

Some progress adding a test, need to wait for ajax request, but out of time for today. Hopefully at least it gets someone going further on this (or hopefully I can come back to it soon enough)

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev22.addweb

Changes are merged now, thanks for the help.

๐Ÿ‡ฎ๐Ÿ‡ณIndia ankitv18

ankitv18 โ†’ changed the visibility of the branch project-update-bot-only to hidden.

๐Ÿ‡ณ๐Ÿ‡ฌNigeria chike Nigeria

chike โ†’ created an issue.

๐Ÿ‡ฆ๐Ÿ‡นAustria maxilein

Thank you the buttons appear. And it seems to work, but for some reason there is a limit.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom SirClickALot Somerset

SirClickalot โ†’ created an issue.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bhaveshdas

I applied MR!2 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/smileys_field-3460978/

FILE: /var/www/html/drupal-contri-d10/modules/custom/smileys_field-3460978/assets/css/smileys_field.css
-------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------
 28 | ERROR | [x] Selectors must be on a single line
 29 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
 29 | ERROR | [x] Selectors must be on a single line
 30 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
 30 | ERROR | [x] Selectors must be on a single line
 31 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/smileys_field-3460978/assets/js/smileys_field.js
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 8 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/smileys_field-3460978/modules/smileys_field_emoji/assets/js/picker.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 20 LINES
--------------------------------------------------------------------------------------------------------------------------
 382 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 383 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 384 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 385 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 386 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 387 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 388 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 389 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 390 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 391 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 392 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 393 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 393 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 526 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 527 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 528 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 529 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 530 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 531 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 532 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 533 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
 533 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/smileys_field-3460978/modules/smileys_field_emoji/assets/js/smileys_field_emoji.js
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 793ms; Memory: 38MB
๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joachim

In some cases, the invalid plugin is expected -- such as the case handled by ๐Ÿ› Changing plugins from annotations to attributes in contrib leads to error if plugin extends from a missing dependency Needs review . I thought using exceptions as messages was a bad pattern?

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev22.addweb

Changes are merged, thanks for the help.

๐Ÿ‡ซ๐Ÿ‡ทFrance prudloff Lille

prudloff โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡จ๐Ÿ‡ญSwitzerland Berdir Switzerland

Reopening this, we're running into this error as part of running updates, specifically block_content_post_update_revision_type().

Since post updates can't depend on others and if this configuration change is required for the code to not fail, I think there should either be a guard-rail in place or the update should be a regular update function and not a post update.

Will look into providing a patch when I get to it,

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom longwave UK

Failed as expected; postponing on that issue, although we could merge the two.

๐Ÿ‡ง๐Ÿ‡ทBrazil RonanRBR Fortaleza-CE

Just adding the patch file for the brantch MR 3107993-3x-template-not-found https://git.drupalcode.org/project/components/-/merge_requests/32

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ฆUkraine abramm Lutsk

Hi @koosvdkolk,

You're right, the warning message is outdated; it references the very old hooks logic before we had plugins.
Feel free to submit the MR with a fix/README update.

๐Ÿ‡บ๐Ÿ‡ธUnited States nicxvan

I think as long as there is a way to generate it locally just like https://www.drupal.org/project/drupal/issues/3403649#comment-15331668 ๐Ÿ“Œ Rework database update tests so we don't have to ship database dumps in git Active suggests it should be fine.

I also think this is much lower stakes and easier to tinker with than full DB dump generation.

We can also just postpone this and ๐Ÿ“Œ Decompress files for update_test_new_module Active

๐Ÿ‡บ๐Ÿ‡ธUnited States nathan573

This is a patch I came up with that allows multiple exact match querystrings to be defined. There is a checkbox that enables this new behavior instead of the original behavior.

๐Ÿ‡บ๐Ÿ‡ธUnited States neclimdul Houston, TX

I keep forgetting Drupal even provides commands. They aren't quite at the point the can replace any drush workflows for me though I guess.

Maybe we should start moving this in front of people more. The Drupal console isn't active these days so since it won't conflict could we start pushing core/scripts/drupal into vendor/bin/

Then maybe we could start looking at using a discovery mechanism of some sort for auto discovering commands instead of hard coding them.

Then we could encourage people could start tinkering with this, testing real world use cases, without hacking on core as directly?

๐Ÿ‡ณ๐Ÿ‡ฑNetherlands bbrala Netherlands

bbrala โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Nayana Ramakrishnan

I have verified the MR MR-545 and tested it on Drupal version 10.4.x and Project browser version 2.0.x. Spacing before the Filter Categories text is adjusted. I have added the before and after screenshots for reference. Need RTBC+1

๐Ÿ‡ฎ๐Ÿ‡ณIndia riddhi.addweb

I tried the MR-11 patch, but the icons are not displayed, they are missing. Attaching Screenshots for the same. Please review it.

๐Ÿ‡บ๐Ÿ‡ฆUkraine id.aleks

Hello @Graber,

Thank you for reporting this issue. It is better to limit the addition of these forms to the pages where they are used, instead of removing them completely. Otherwise, it will break the login functionality of Opigno. I have created MR and attaching the patch. Please test and review.

๐Ÿ‡ณ๐Ÿ‡ฑNetherlands bbrala Netherlands

bbrala โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ณ๐Ÿ‡ฑNetherlands bbrala Netherlands

All green! :D

Did drop d9 support because of issue with traioling commas. But meh.

๐Ÿ‡ฎ๐Ÿ‡ณIndia DishaKatariya

Hi, I have verified this issue with the marvelous them.

Testing steps:
1. Install theme.
2. Set as default theme from appearance.
3. Check subscribe newsletters section in footer

Testing Results:
The Icon is appearing from e-mail field in from Footer subscribe newsletters section.

Attaching before and after screenshot for the reference.

Hence Can be move to RTBC.
RTBC+1

Thanks!

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom SirClickALot Somerset

@a.dmitriiev, No, I think we're good now and can go ahead and close this one.

Thank you for your help.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฎ๐Ÿ‡ณIndia shivam_tiwari

I have verified merge request !8640 and it working fine. Attaching screenshots before and after the implementation.

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom longwave UK

I think this makes sense and I can't see a simpler or better way to do it.

However let's open a followup to discuss that return value of parseClass() because I agree the structure with NULLs is strange, perhaps it should throw an exception it probably should throw an catchable exception in the failure case instead? The reason we do it is:

              ['id' => $id, 'content' => $content] = $this->parseClass($class, $fileinfo);

so the return value is always expected in that structure. I think this is all internal enough that we can change it without BC implications, but the followup can help us decide that.

๐Ÿ‡ฉ๐Ÿ‡ชGermany a.dmitriiev

Do you need any other information or help in this issue?

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ฉ๐Ÿ‡ชGermany a.dmitriiev

Frontend editing in version 1.x should not work anymore on pages with admin context

๐Ÿ‡บ๐Ÿ‡ฆUkraine id.aleks

id.aleks โ†’ made their first commit to this issueโ€™s fork.

  • 14cc34fd committed on 1.0.x
    Issue #3460779: Add ability to update all Schema.org mappings field...

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡ญ๐Ÿ‡บHungary Balu Ertl Budapest ๐Ÿ‡ช๐Ÿ‡บ

Balu Ertl โ†’ changed the visibility of the branch 3416512-error-after-updating to hidden.

Production build 0.69.0 2024