There is some info in here that is potentially helpful: https://www.drupal.org/project/drupal/issues/2353419 📌 Improve the way how views renders their contextual links Postponed: needs info
Added test coverage. Rebased. Not sure why tests failed.
smustgrave → created an issue.
mlncn → created an issue.
chrisla → created an issue.
-
smustgrave →
committed c0b3cc4c on 4.0.x authored by
kumareshbaksi →
Issue #3390465: Fixed the cache metadata of individual blocks are not...
It looks like the .contextual element that contains the button and links gets removed on the ajax reload.
I think this is because it's inside the element that is getting replaced.
In the browser inspector, I moved the element outside of the .view element, and then ajax reloads don't remove them!
A potential workaround is to just move them after the initial load, but that feels a little dirty.
Are there any other examples of a component being refreshed with ajax that should have contextual links?
We actively use this functionality. So for us, yes.
smustgrave → closed merge request !15
Does patch in #5 resolve this issue too?
Wonder if this is still an issue? Not seeing it in latest version.
-
smustgrave →
committed fd5c0ec3 on 4.0.x authored by
loze →
Resolve #3407343 "Theme loading markup"
D7 EOL is this still needed?
Can you least provide steps that are triggering this? Actually working for me
smustgrave → closed merge request !11
smustgrave → closed merge request !21
Went with the catch at least it's a net improvement.
-
smustgrave →
committed a7729b13 on 4.0.x
Issue #3322771 by smustgrave: QuickTabs Drupal\Component\Plugin\...
Code in 3223947-disable-on-admin now checks if the current theme is set as the site's admin theme and skips adding the libraries if it is. There is no configuration required as it goes off the site's configured admin theme to determine behavior.
Still requires testing to make sure it works.
-
smustgrave →
committed f4b1f963 on 4.0.x authored by
haritha c →
Resolve #3519116 "Tab memory feature"
rhovland → opened merge request !13
smustgrave → closed merge request !28
Triaging the queue with so long of inactivity is this still a desired feature?
smustgrave → made their first commit to this issue’s fork.
If you want, this module doesn't block any themes though you may have to handle your own styling.
We have pipelines for this now.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
rhovland → opened merge request !12
Probably needs a rebase
Add credit based on discussions
kristen pol → credited yautja_cetanu → .
kristen pol → credited valthebald → .
kristen pol → credited marcus_johansson → .
rhovland → created an issue.
I went through the doc and updated and added comments and talked separately with Marcus and Val and we are on the same page… there is only one open item I think in the comments
Probably needs a test too
This is a good find - performance tests stopped reporting to the dashboard in 11.2 - was fine with 11.1, and couldn't see a reason why. Moving to needs work while we figure out where we can set this without breaking regular test runs.
Seems like a scenario would be easy to add test coverage for
See attached Drupal 11 compatibility patch.
santiagon → created an issue.
philip_stier → opened merge request !117
I'm still getting that malformed url "/course/5/0/[object%20Object]" and the error
This is really confusing to me - can you confirm whether you've got custom JavaScript or similar running on that page? I'm wondering if something is appending things to the URL incorrectly or similar. I can't think of a way this could ever be generated purely from PHP - at least not by accident.
Can confirm this is still an issue on the 2.x branch. However, we're now using Claro as the admin theme the reset is based off of so this won't be an issue for claro users, only those using other admin themes.
The css files are attached in the linked function now so the logic to enable or not needs to go there:
https://git.drupalcode.org/project/media_library_theme_reset/-/blob/2.x/...
dydave → opened merge request !4
Se adjunta evidencia correspondiente a la publicación
Se adjunta evidencia correspondiente
I think you may be correct in that cache busting will happen automatically if a version is omitted.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
Learn something new every day!
Se adjunta evidencia correspondiente
Patch isn't applying on 4.0.24. I think it's because 4.x and 4.0.x are out of sync. Will try to get a working on next week.
Se adjunta evidencia correspondiente
More elegant patch that should also work when the routes exist?
Se adjunta la evidencia correspondiente a la publicación
The merge request applies to 2.2.x branch (2025.04.15), not to the 2.2.6 release (2024.08.09) which is several commits behind.
Tested again in Drupal 11. Still is broken. Works in Drupal 10.
New install of Drupal 10:
New install of Drupal 11:
While code wise this module is technically compatible with Drupal 11 in practice a lot of critical css is not applying for an unknown reason.
If this old approach (in 1.x branch) to theming the media library in the front-end theme is still important to someone for use in Drupal 11 I welcome a working merge request to make it compatible.
The 1.x branch is not a priority for me so if this is important to you please contribute!
Automatically closed - issue fixed for 2 weeks with no activity.
#293 applies and works for Drupal 10.5
swirt → opened merge request !1
saidatom → closed merge request !22
saidatom → closed merge request !20
LMS H5P activities work as expected after properly configuring the lms_xapi to point to the internal lrs_xapi. Thank you for your responsiveness on this and the related issues.
saidatom → closed merge request !11
Automatically closed - issue fixed for 2 weeks with no activity.
The Internal LRS works properly without the double slashes. I thought I'd tried that but guess I'd missed something. With this working, I have no need for an external LRS. I apologies for the confusion.
Amending attribution.
To work with the nature of the Linkit configuration described above, I propose that a new setting be added to the text filter for setting "Media entity URL substitution", with three choices:
- Use metadata from when the link was created
- Direct URL to file
- Standalone media URL (e.g., /media/{id})
This will allow sites to update their text formats to normalize how media links are substituted. By choosing either option 2 or 3, they effectively instruct the processor to ignore the metadata value in the link and do one of the two available URL methods.
I just did a spot check and verified that views.view.test_view_block.yml has no sort, so this is still a valid issue.
mark_fullmer → opened merge request !110
Still think contrib makes more sense though. If it were added to core that puts ownership and responsibility of a feature that has already been removed.
I think twig tweak makes the most sense as a landing place but even its own module