Live feed

Will this affect unit tests?
If I understand correctly the legacy files would not be loaded before this change, but after this change all unit tests will load all legacy includes.

Not sure if this is a problem or acceptable, but it likely is a change.

You understand correctly. There were two tests that still relied on those functions and redefined them themselves, those have been changed in the diff. For the other tests if they ignore the functions then nothing happens. I guess the only risk is that people start using them in more places? However, there's nothing stopping someone from doing that in a place that's covered by a test that's not a unit test, so I'd argue that's acceptable.

I'll write up a change record and update the deprecation links later this week :) I'm not sure how I would go about writing a deprecation test. Any pointers to an example would be welcome.

I'm here today

ccoughlan → created an issue.

Can this be back ported to 4.x? - GraphQL Compose is on the AlterableComposableSchema and I'd prefer to jump into line without dropping support for 4.x immediately.

📌 Merge AlterableComposableSchema into ComposableSchema Active Means changes required.

Thanks again for reporting and your code change suggestions. I added dependency injection and a CI pipeline.

I'll release the fix in version 1.8.

Ah, I think the issue is that my personal site doesn't have a pre-existing media bundle of type image. I only recently enabled Media (and that was only to make a Remote Video bundle).

So I guess installation of this module needs to create that bundle if it doesn't exist?

Took some force-pushes (one day I'll get FunctionalTests working locally again) but the MR is now green across the board :raised_hands:

carsoncho → opened merge request !7

I did not get this error when installing on top of Umami.

I'm assuming the issue here is some collision between the fields that this module is creating and my pre-existing fields.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

carsoncho → created an issue.

I'm also getting WSOD errors as I navigate around the site after the attempted installation.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "imagecache_external.admin_settings" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 211 of /code/web/core/lib/Drupal/Core/Routing/RouteProvider.php).

bnjmnm → opened merge request !926

MR has it working, still need to add tests.

stevector → created an issue.

anaconda777 → created an issue.

Merge request created based on the patch in #27.

liam morland → opened merge request !11907

liam morland → made their first commit to this issue’s fork.

Looks like it needs a rebase.

Done!!

All done!

Pleased to say this is finally fixed and released!

darren.fisher → closed merge request !4

Can confirm that the corresponding change fixes this problem in 3.x, so it probably works in 8.x-1.x too. But the usual route is to fix in the current branch first and then backport.

Automatically closed - issue fixed for 2 weeks with no activity.

Thank you.

Fixed that issue by changing the following in the "OpenIdProvider.php" file:

    $userInfos = [
      'name' => $steamNickname,
      'pass' => '',
      'status' => 1,
      'field_steam64id' => $steamCommunityId,
      'field_steam_username' => $steamNickname,
    ];

All works well now

nestor_fabian → opened merge request !15

Thanks for your offering to help murilohp! I can (once our module is finished) open an MR for sure, but that way of working will be a hassle in the long run, so let's hope robin.ingelbrecht replies.

volkswagenchick → credited weekbeforenext → .

volkswagenchick → created an issue. See original summary → .

Thanks, April!

volkswagenchick → credited weekbeforenext → .

volkswagenchick → created an issue.

Thanks!

volkswagenchick → credited weekbeforenext → .

volkswagenchick → created an issue. See original summary → .

The snippet of code provided in #75 is from the StateTokenStorage which itself is provided to reduce the code that developers need to implement in their plugins.

If the StateTokenStorage file is empty of code then something is wrong with your code base. If you mean that nothing has been stored in the State system see my next paragraph.

The interface requires that you implement public function storeAccessToken(AccessTokenInterface $accessToken) but while you are developing you don't have to store anything. You could simply print info from the token object to a message in your implementation of this method and not use the trait.

Thanks!

volkswagenchick → credited weekbeforenext → .

volkswagenchick → created an issue.

Thanks, April!

volkswagenchick → credited weekbeforenext → .

Thank you, I'll review that linked issue when I have more time.

I didn’t want the non-stable color to be too much of a warning. While we do hope production sites can run as many stable releases as possible, we also want maintainers to have some visibility for testing pre-releases.

This is less about the non-stable being more of a warning than the stable one being more easily seen as recommended. Blue doesn't read as stable to me.

The second and related issue is the grey is harder to see, but really the grey and blue look very similar to me. When they are side by side I can see the difference, but on modules that only have one or the other it's very hard for me to tell if the module is stable or not.

volkswagenchick → created an issue.

Thanks, April!

volkswagenchick → credited weekbeforenext → .

volkswagenchick → created an issue.

It was determined that the requirement in this issue is obsolete and is currently outside the scope of the module's functionality.

Problem with SDC on component with multiple inputs, solved by using [] on name in the component.

We tried to create a lat/lon component with geofield, not working because of applicative
logic into the field type.

Checkbox in form API directly: OK
Checkboxes in form API directly: OK

Usage of names to handle multiple inputs.

Problem of unchecked checkbox currently handled in Checkbox.php form element, workaround in field widget in UIP 2.

TODO:
- field storage and field setting mapping into the component
- test checkboxes as field widget
- test with multiple values fields in field widget
- handle data type constraints?

ok, after some time I found where this person made a change in the "steam_login.services.yml" file to use no cache:

steam_login.openid:
  path: '/steam-auth'
  defaults:
    _controller: '\Drupal\steam_login\Controller\OpenIdAuth'
  requirements:
    _permission: 'access content'
  options:
    no_cache: true

https://www.drupal.org/project/steam_login/issues/3103744 →

It now returns to my site and works however, it uses their steam ID as their username.. (steam-xxxx)

zaporylie → opened merge request !12

Can confirm this worked great for me.

It already has an alter for anyone to make custom adjustments, so i'm not sure making it configurable in the UI is necessary.

See ✨ Track the number of times a queue item is claimed and pass as an optional param to queue workers Active which includes this change and addition improvments, though maybe not the suggested comment.

I'd like to be able to close this as duplicate if that gets commited.

Why would I want to wait for Drupal 12 or later when we can solve the problem now? I'm proposing this because I need this kind of feature to solve problems with queue processing sooner than later. I'd rather see it in core now to benefit everyone.

I understand it would be possible to follow the path outlined in the docs to add a new argument that would be an actual part of the interface in 12. I think this is what you are suggesting? https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... →

I'dd defer to the commiters if they think that's the right choice.

Well, it has a MR now, but looks like not even code style is passing.

danrod → created an issue.

jdleonard → created an issue.

I added the .gitlab-ci.yml file and I see a bunch of ESLINT / PHPCS / PHPSTAN issues to fix, in addition to the missing tests: https://git.drupalcode.org/project/radiostoslider/-/pipelines/478660

I'll create another issue to fix these, for now I'll mark this as "Fixed".

Cool, thanks @star-szr!

Thank you but following your #48 the last thing you say is

"If JSON is returned it is parsed and turned into an AccessToken object. Otherwise errors are thrown."

But since there is no error nor success message and I cannot retrieve it, it must not be getting either parsed or stored.

Is there a way to call and print to the screen what is stored???

It appears StateTokenStorage is empty

baikho → opened merge request !11906