Live feed

Sure, Thanks

Looks good, I'll update the project page soon.

I'll add https://www.drupal.org/project/search_api_elasticsearch_synonym → to list of modules that extend Elasticsearch Connector. Currently it relies on events provided by 8.x-7.x, so I should work on 📌 Deprecate events and hooks in 8.x-7.x Active and 📌 Add index to AlterSettingsEvent for backward compatibility Active so the upgrade would be easier for modules extending Elasticsearch Connector.

I fixed my off-by-one, and helped confirm that there shouldn't be any issues with func_get_arg() by adding a couple tests of the possible parameters that could be passed if the module was being extended based on an older module version.

This module now support Ckeditor 5 in the 2.x version, it's now depend on CKEditor 5 Template →

Automatically closed - issue fixed for 2 weeks with no activity.

Duplicate 🐛 Use of "static" in callables is deprecated Fixed

Automatically closed - issue fixed for 2 weeks with no activity.

Works for me too, thanks

Thanks for the feedback. Merged.

Thanks all! I committed this even there are plans to deprecate "elasticsearch_connector_views" submodule for 8.0.x.

No, I don’t think these are covered by our FunctionalJavascript tests. I just tried it out manually and it works fine.
Thanks for finding the docs! However, the “correct code” examples they give do not work for me, and also aren’t consistent with the error message that says matches() should be used instead. So, they don’t seem very helpful.

Anyways, I think we can just merge this, should be fine.

I created an issue for marking deprecated/experimental themes: 📌 Mark deprecated and experimental themes on admin appearance page Active

Automatically closed - issue fixed for 2 weeks with no activity.

simohell → created an issue.

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

VladimirAus → made their first commit to this issue’s fork.

Changes was not merged/commited into 11.x branch.

I confirmed with xdebug that the environment variables are passed into the child process, and the HtmlOutputLogger appears to work, except that HtmlOutputLogger::testRunnerFinished() appears to not be called inside the isolated process, and so the verbose message is not printed. Will continue debugging...

Navigation overall supports more menu that are active in the overall project than just Administration as our first focus. Many other menu's do often have 4-6 layers too.
Yes, as Navigation should be able to handle any menu that has greater depth!

Redirecting the depth of what is in 'all the modules' that add into this one menu and their organizing is the extending goal. This would then need followup against every other (core component) that is providing the link/links.

catch → closed merge request !7911

Committed/pushed to 11.x, see if this helps.

Automatically closed - issue fixed for 2 weeks with no activity.

As I understand that Gin does have a tool 'navigation' already. Should this not be against Gin, Gin toolbar as it is now true that 'navigation' is a core namespace, and it is contrib will have to alter around this now?

Automatically closed - issue fixed for 2 weeks with no activity.

Looks good, did not spot any mistakes reviewing the code. Also the green tests are reassuring :)

gapple → created an issue.

In my use case where I get the Notice is a problem drush deploy vs. drush updb/cim/cr.

And I also got than a exception when I opened a page which use the missing route.

The hook_module_implements_alter from views_local_tasks module was not called/empty in drush deploy which results in broken routes.

So I vote for assert-only patch or closed (works as designed). :D

Unfortunately, though, this broke the HTML output logger. Looks like the environment variables are no longer visibile in PHPUnit isolated subprocess and therefore the logger does not init. If I remove the BrowserTestBase constructor the failing test passes, but that means that we are not running in isolation. I'm afraid this path is taking us too much into PHPUnit internals, and that makes me shiver. I think the point here is that ALL tests could potentially run in isolation, but in run-test.sh we're omitting process isolation only for Unit ones for a matter of performance, the Unit test run job will last 15 minutes instead of 1. But in local dev, I see no reason not to run everything in isolation. Don't IDEs have a process isolation setting themselves when it comes to run tests https://www.jetbrains.com/help/phpstorm/run-debug-configuration-phpunit....? (not a user, sory)

From #20 the task "Either a Claro maintainer or (preferably) a frontend framework manager needs to validate the approach." I think falls under the definition of "review" so I'll tag this back to "needs review".

tobiasb → opened merge request !7912

catch → opened merge request !7911

Gitlab wasn't happy, tried again in 🐛 Update composer metapackages Active

Thanks @mondrake - I see the error I made last night now, I forgot to escape the () in the deprecation.

tagged 1.0.7 for drupal-radix-cli to get around this issue, please do npm update drupal-radix-cli to get the latest version.

catch → created an issue.

catch → created an issue.

Committed and pushed 0894355a79 to 11.x and ae9b755736 to 11.0.x and e1643718f3 to 10.4.x and 19eee98494 to 10.3.x. Thanks!

Added deprecation ignore

I think I just consider each page distinct, but it sounds like you are considering them states of a single page.

I haven’t used the ordered list formatter very much

Anecdotally, I've had the need for this several times over the years. So much so that I decided to revive this issue and share my work. I use ordered lists on paged search results, where yes each page in the search results is part of a larger context. This fix is also really helpful when using "Views Load More" or "Views Infinite Scroll" module, where new results are loaded into the current page via ajax without a round trip to the server.

Keep in mind, I'm implementing designs from UX teams with limited knowledge of Drupal, and this pattern of incrementing the index of give search results across pages just makes sense intuitively. It is also worth noting that this issue was closed 16 years ago by Earl, the original author of Views, which could also explain why not more people are subscribed to this issue. The fact that there were 10 comments on the issue after it was originally closed is a decent indicator that there is a need, however small, for this fix.

I rely on the method in #11 (the Twig template override) as the go-to solution on many projects because it is more semantic and properly announced and easily navigable by screen readers, as opposed to having to go with the "views result counter" approach in #15 inside each row and using the "Unformatted" Views display format, which then requires more theming effort to restore basic formatting styles that you get for free with an <ol> and <li>.

PHPCs was fixed.
Created separate PHP Stan and PHP Unit fixes: ✨ Gitlab CI: PHP Stan and PHP Unit fixes Active

VladimirAus → created an issue.

The settings are default Simple settings, with CDN domain filled in. I also tried the scheme relative setting, but it makes no difference.

mondrake → closed merge request !6823