Live feed

⚡️ Live updates new comments are added automatically.
🇬🇧United Kingdom joachim

> You already mentioned limit - "block placing". Are there any other limits?

I had a read back of this issue, and there's page caching too. I've added docs about that. Hopefully that can be figured out in a follow-up, in which case we'll just remove the docs :)

Automatically closed - issue fixed for 2 weeks with no activity.

🇧🇪Belgium bart lambert

I am also hoping for a tagged release if you’ve got some free time. Appreciate it!

🇬🇧United Kingdom catch

If we do 1 then a module could never implement on behalf of a submodule if the submodule uses a prefix. Since paragraph will always match before paragraph_layout etc.

Are there any known examples of this? I can't think of a use case for it.

🇳🇱Netherlands johnv

Sorting multiple issues with "Pager option 'Items per page' with value 0" alphabetically.

🇬🇧United Kingdom joachim

> I was wonder about theme used, but you already mentioned that there is no theme.
> I don't clearly understand what does it mean?

I've reworded on the docs about that a bit. Does that help?

🇺🇸United States swirt Florida

This is complete. It will now find any image tags within field types

  • text
  • text_long
  • text_with_summary

It will not find embedded media entities in the text. Those will surface directly in the media entity.

🇳🇱Netherlands johnv

The following issues are duplicates, having competing solution proposals:

I cannot judge which solution proposal is best. I guess the second one.

Issue summary is now updated with better screenshots and steps to reproduce, so removing tags.

🇳🇱Netherlands johnv

The following issues are duplicates, having competing solution proposals:
🐛 Views incorrect display with filters, table and full pager Active adds 'margin-block-end'
🐛 Olivero pager template creates additional grid columns Needs work removes 'layout--content-medium'
🐛 Using 'Paged output, full pager' changes view table display Active (without patch, but contains nice screenprints in #3 and #5)
I cannot judge which solution proposal is best. I guess the second one.

I guess the 'Needs subsystem maintainer review' allows the patch to be reset to 'Needs review'.

🇬🇧United Kingdom oily Greater London

RE: #63 I am starting on that.

Outside scope stricly speaking but comment in existing Unit test in Drupal\Tests\link\Unit\LinkFormatterTest states

Tests when LinkItem::getUrl returns a functional URL.

That should be 'functioning' I think. I am creating a (new) similar test with a similar comment. Will change 'functional' to 'functioning'. Could hoover up that slight typo in the existing test.. I mean i think the coder meant 'that works properly' not 'contains the bare necessities but no more'. It is a subtle difference. 'functional' seems correct, but 'functioning' is really what is needed IMO.

🇨🇭Switzerland berdir Switzerland

Strange, I have seen CronRunTest fail a few times recently, but this seems to make it more likely. I can't reproduce locally. Looking at https://issue.pages.drupalcode.org/-/drupal-3501727/-/jobs/4142293/artif..., it says cron was run one second ago.

it's some race condition between the login, which triggers cron and deleting it, as cron is likely still running when we delete state, and then immediately sets it again.

\Drupal\Tests\system\Functional\System\CronRunTest::testAutomatedCron above already uses setWaitForTerminate, I think testCronUI() should do the same.

We'll have to fix this either here or a separate issue and postpone it on it.

🇳🇱Netherlands johnv

The following issues are duplicates, having competing solution proposals:
🐛 Views incorrect display with filters, table and full pager Active adds 'margin-block-end'
🐛 Olivero pager template creates additional grid columns Needs work removes 'layout--content-medium'
🐛 Using 'Paged output, full pager' changes view table display Active (without patch, but contains nice screenprints in #3 and #5)
I cannot judge which solution proposal is best. I guess the first one.

Settings this a duplicate, since the others have a patch.

🇳🇱Netherlands johnv

Not sure if this is an 'ajax system' issue, or an 'Oliver theme' problem.

🇳🇱Netherlands johnv

This is a duplicate of 🐛 Views incorrect display with filters, table and full pager Active and is a problem in Olivero theme. It can be reproduced without layout_builder, too.

🇨🇦Canada danrod Ottawa

The original issue raised by @pawelgorski87 makes sense, there's some URLs / entity links that should be under the admin theme, among others:

/calendar
/calendar/add
/calendar/%/edit
/calendar/all/import
/calendar/event/nid/edit
/calendar/event/nid/delete

There's also some links can be under the user theme:

/calendar/event/nid

Provided that the user has permissions for that.

I'll look on this today.

🇬🇧United Kingdom oily Greater London

Work is needed. Test coverage is required. I have edited the issue summary removing unnecessary text. But further update is required. Added tags for these things.

🇬🇧United Kingdom oily Greater London

In the issue summary it states

- with S3...

What does that mean? With (in the case of) the S3 contributed module? Or with the S3 stream wrapper?

Then

..we want to first serve an image locally..

Who is 'we'? The reporter's company? Drupal.org?

How does 'we' 'want to first serve an image locally'? By using or creating a contributed module? Or a custom module?

I dont know the answers to these questions. If someone would like to update the issue summary or I will if I can get answers to these questions.

🇳🇱Netherlands johnv

"It should also instruct the user to create a new display to get more options here. "

I was going through the "More link" issues, and I could not reproduce, on my simple view with only 1 page display.
Then, somewhere I was encouraged to add a Block display to the View. Now the "more link" appears on both the Block display and the Page display, but the "Link display" option is only showing on the Block display. I am confused.

Now I also understand why people state (on issue ...) that the unconfigurable 'More link' is useless on Page displays, since it point to the display itself.
(Alphabeticaly ordening the 'More link' íssues.)

  • 7f20ba5a committed on 3488261-migrate-to-advanced
    Issue #3488261: Replacing Marker with AdvanceMarker
    
🇧🇷Brazil renatog Campinas

Merged into dev branch

Thank you so much, everyone

🇧🇷Brazil renatog Campinas

Thanks for your feedback @zigazou

translation of "Add another class" and "Remove last added class" could be included as well

This one has been fixed at 🐛 Some button labels are not translatable Active

🇬🇧United Kingdom oily Greater London

Do we need a CR for this?

🇧🇬Bulgaria valthebald Sofia

valthebald made their first commit to this issue’s fork.

🇳🇬Nigeria chike Nigeria

Here is a patch that works with the latest version.

This patch will add the following features to the module:

1) Make possible to show image fields on products, taxonomy terms and users. Without this patch you can't show image fields of products, users and taxonomy terms, you can only show image fields of nodes.

2) Make possible to add the site breadcrumb inside the block. With a checkbox you can choose to add the breadcrumb or not.

3) Make possible to choose overlay colors. You can choose two colors for the overlay color gradient, choose the gradient direction and choose overlay opacity, all in the UI.

4) Make possible to choose to show or hide the image title of the image field or the alternative text for the "Default background image" if image field is not used.

As I said earlier, AI helped me write these features so perhaps I (sorry, 'we') could have missed one or two Drupal coding standards.

🇺🇸United States tr Cascadia

This is something that is fundamental in Drupal core - you can't delete the type if you have any entities of the type in the database. That goes for all entity types and has nothing specifically to do with the votingapi.

🇨🇦Canada psaleks

I copied file z_style.css from dev version. And it fixes this bug. Thank you.

🇧🇪Belgium borisson_ Mechelen, 🇧🇪

I think this looks good now, there seems to be a failure in CronRunTest, is this a known random fail?

🇳🇱Netherlands johnv

The issue 🐛 Implement constraints for Pager config Active contains a directive to use constraints, rather than if-then constructions.

if (is_null($value)) {$value = '';} can be shorter with $value ??= 0; . Setting 0 since we expect integers.

🇷🇺Russia zniki.ru

Thanks for MR.
Do you think we can add interface for these new methods?

🇳🇱Netherlands johnv

The issue 🐛 Implement constraints for Pager config Active contains a directive to use constraints, rather then if-then constructions.

  • mably committed 313c094a on 8.x-1.x
    Issue #3498259 by mably: Update to PHPOffice/PhpSpreadsheet 2.3.7
    
  • mably committed 52cfa0e8 on 2.0.x
    Issue #3498259 by mably: Update to PHPOffice/PhpSpreadsheet 2.3.7
    
🇨🇦Canada joseph.olstad

@rajab natshah , I 100% agree with your comment in #48

Enough with the dipsy doodling, for those ACTUALLY using Drupal 11, only ckeditor 5 makes sense. Forget ck4 in Drupal 11, it's a non-starter.

🇦🇹Austria roromedia Linz

Closing, as further development in AI submodule.

  • mably committed 39072ce0 on 2.1.x
    Issue #3498259 by mably: Update to PHPOffice/PhpSpreadsheet 2.3.7
    
🇦🇹Austria roromedia Linz

Closing, as fixed in AI submodule, no further development in this project.

🇳🇱Netherlands johnv

I guess this addition 'in URL' gives more context.

Automatically closed - issue fixed for 2 weeks with no activity.

🇷🇺Russia zniki.ru

MR looks good. But should we add test coverage new method at Drupal\Tests\link\Unit\LinkFormatterTest?

🇪🇸Spain vidorado Pamplona (Navarra)

You're right @nikolay_shapovalov! We forgot to update the screenshot after the UX review and changes :)

I've updated the screenshot and taken a quick look to yor MR comments, which look very useful to me. I will address everything as soon as possible.

Thank you very much!

🇺🇸United States phenaproxima Massachusetts

This change is fine, but I think we might want to close it, and not commit it (although we should definitely transfer credit) in favor of 📌 Project Browser makes a pointless API request for categories Active , which will obviate this entirely.

🇨🇦Canada danrod Ottawa

danrod changed the visibility of the branch 3432121-move-all-entity to active.

🇨🇦Canada danrod Ottawa

danrod changed the visibility of the branch 3432121-move-all-entity to hidden.

🇩🇰Denmark ressa Copenhagen

I do appreciate getting the tires of the MR kicked, don't get me wrong!

I just think that in the majority of new installations, you do not want node/100 paths indexed. And if that's true, we should make the preferred behaviour the default, non?

🇷🇺Russia zniki.ru

Thanks for MR, this feature looks really nice, but as I understand expected change in the UI already change at #77.
Please update IS.
I left my feedback at MR, please check.

Automatically closed - issue fixed for 2 weeks with no activity.

Actually that's not completely true because of the /issues auto path.

Production build 0.71.5 2024