lemming → opened merge request !5
Merging this as this patch does work.
I would recommend updating to version 2.x, however, as there are other bug fixes and relevant depreciation fixes on that branch.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
larowlan → created an issue.
othdvlpr → created an issue.
I think support for things like Bootstrap should be in separate projects. There is already webform_bootstrap5 → .
as above
drush pm:install update
drush pm:uninstall composer_deploy
*AND*
composer remove composer_deploy
drush cr
composer show | grep -iE "deploy|update"
(empty)
drush pm:list | grep -iE "deploy|update"
Core Update Manager (update) Enabled 11.1.0
now, NO WSOD error at /admin/*; poking around the site, can't atm get it to replicate.
if not a fluke, `drush pm:install` does not seem sufficient?
also, now, checking status report @ https://example.com/admin/reports/status#warning ,
1 warning
Drupal core update status
No update data available
No update information available. Run cron or check manually.
Cron maintenance tasks
Last run 3 seconds ago
(more information)
re-exec'ing cron doesn't cure.
i can't find it in my scribbled notes atm, but iirc, composer_deploy was supposed to solve for the missing update info in a composer-installed Drupal instance
Discussed this issue with one of the plugin subsystem maintainers over Slack. He is not completely against having supplemental attributes, but he thinks it might be addressed more easily by allowing arbitrary properties to be set on Plugin attributes: $this->additional[$key] = $value
. (Splitting the EntityType attributes into separate attributes is still valid and would not be tied to this.)
I know Drupal core does have a version of this with one plugin type: \Drupal\Core\Layout\Attribute\Layout, which looks like this:
/**
* Any additional properties and values.
*
* @var array
*
* @see \Drupal\Core\Layout\LayoutDefinition::$additional
*/
public readonly array $additional;
/**
* Constructs a Layout attribute.
*
* @param string $id
* The plugin ID.
<snip ...>
* @param class-string|null $deriver
* (optional) The deriver class.
* @param mixed $additional
* (optional) Additional properties passed in that can be used by a deriver.
*/
public function __construct(
public readonly string $id,
<snip ...>
public readonly ?string $deriver = NULL,
...$additional,
) {
// Layout definitions support arbitrary properties being passed in, which
// are stored in the 'additional' property in LayoutDefinition. The variadic
// 'additional' parameter here saves arbitrary parameters passed into the
// 'additional' property in this attribute class. The 'additional' property
// gets passed to the LayoutDefinition constructor in ::get().
// @see \Drupal\Core\Layout\LayoutDefinition::$additional
// @see \Drupal\Core\Layout\LayoutDefinition::get()
$this->additional = $additional;
}
We could possibly add $additional
to Drupal\Component\Plugin\Attribute\Plugin
, and merge the contents of $this->additional
to AttributeBase::get() in Plugin::get(). This would involved updating all the plugin type attribute constructors as well.
I take it back, since these are used as array keys you need to use the scalar value.
The array structure is a bit weird though, maybe it would make sense to have a value object class instead of associative arrays. Maybe enum doesn't make sense after all. Let's see what others think?
tr → opened merge request !85
cpierce42 → created an issue.
Automatically closed - issue fixed for 2 weeks with no activity.
I tried the patch provided in #4.
But it doesn't work properly for me.
I get the following response from the chatbot:
I am sorry, but I could not find any relevant information in the archives. Please try to ask the question in a different way or try to ask a different question.
Works fine for me in admin.
Bootstrap 3.34 is compatible with Drupal 11 and there's no plans to stop at 11.
Drupal 11 is currently planned to be supported until December 2027
I might be wrong, but I think Wim is off work this whole week for the holidays, so I reviewed this in his stead, and it looks great to me, so I merged it. @wim leers: I hope I didn't miss anything important that you would have caught.
-
effulgentsia →
committed f166295f on 0.x authored by
longwave →
Issue #3494114 by larowlan, longwave, wim leers: Implement auto-save of...
I'm creating new bootstrap 3 sites including one I just created this week.
Automatically closed - issue fixed for 2 weeks with no activity.
I am closing this as a duplicate of 🐛 fatal error on `update` module enable on composer-managed D11.1.0 instance Active , which has more and better information.
For what it's worth that site doesn't have any particularly rare modules. I am trying to remember whether (and where) update data is cached...
I concur with @berdir.
IS still needs updating.
Honestly I'm not super familiar with what you mean, if you can point to an example I'm happy to modify this approach.
Is it still the case when the module code is not present? Update manager looks at all present extensions.
I didn't look too thoroughly, but ideally we can pass around the enum itself rather than the string backed values. Is that possible or are there too many bits to untangle?
@longwave gave a +1 for 10.3/11.0 backport so did that too
-
larowlan →
committed 69b56719 on 11.0.x
Issue #3478628 by oily, alexpott, catch, sheshsharma, osopolar, dunx,...
-
larowlan →
committed 4feb744c on 10.3.x
Issue #3478628 by oily, alexpott, catch, sheshsharma, osopolar, dunx,...
Hey, thanks for taking a look. The str_replace method you are using looks like it would work, but it is a little strange, since email configuration generally has good support for tokens. Do you think we should not add the token module → as a dependency?
Automatically closed - issue fixed for 2 weeks with no activity.
it was already happening prior to `composer_deploy` installation; i'd installed that while attempting to deal with this.
that said, specifically,
drush pm:uninstall composer_deploy
drush pm:install composer_deploy
and, immediately, at nav to `https://dev.pgnetwork.net/admin/config`
The website encountered an unexpected error. Try again later.
TypeError: Cannot access offset of type Drupal\Core\StringTranslation\TranslatableMarkup in isset or empty in Drupal\update\ProjectCoreCompatibility->getPossibleCoreUpdateVersions() (line 83 of core/modules/update/src/ProjectCoreCompatibility.php).
...
Added MR that renders Hierarchy plugin config form.
edwardsay → opened merge request !267
This is first draft if you want to test out the patch. There's a few hardcoded styles just to get something visually appealing that I'll refactor but functionally... I think it's working really well. In the field settings, you'll see the new "Hierarchical select widget" as an option. Just use the default reference method for now as I haven't looked at the views option. There will be a couple extra settings at the bottom of the form:
- Force deepest level
- Show level labels
I think the descriptions are self explanatory. Try it out and let me know how it works for you. It should support multi-lingual and work fine in paragraphs as well.
edwardsay → created an issue.
At a glance it may be composer_deploy, because it modifies update information. I would try uninstalling it first.
apmsooner → opened merge request !82
Thanks @abhi_khandelwal ...
but at the moment the media_library_importer module is under good supervision and maintenance.
You personal Drupal profile doesn't show much credits and any drupal project already under your maintenance.
Could you please better elaborate why you would like to become direct maintainer of this module?
Usual collaborative patterns in Drupal community allow everyone to just open new issues, as feature requests, bug reports, etc.
Thus, please feel free to post any of those if you want some specific new feature being implemented,
and eventually also add your patches or MRs where you could prove your commitment and your Drupal & PHP best config standards ...
Also backported to 10.4.x and 10.5.x after discussing with @alexpott
Will wait for an RM opinion as to whether this should also go to 11.0 and 10.3 that are security only now.
Hey @emptyvoid could you better report when you experience this bug?
Because I cannot reproduce, on my Drupal 11.1.0 instance and Media Library Importer 2.1.0, where all looks working fine ...
I also don't see any declaration of FileExists on line 21 of MediaLibraryImporterService.php,
that would be here:
https://git.drupalcode.org/project/media_library_importer/-/blob/2.x/src...
The MediaLibraryImporterService is indeed exactly calling the Drupal\Core\File\FileExists here:
https://git.drupalcode.org/project/media_library_importer/-/blob/2.x/src...
-
larowlan →
committed eab209db on 10.5.x
Issue #3478628 by oily, alexpott, catch, sheshsharma, osopolar, dunx,...
-
larowlan →
committed c2cd94a7 on 10.4.x
Issue #3478628 by oily, alexpott, catch, sheshsharma, osopolar, dunx,...
Automatically closed - issue fixed for 2 weeks with no activity.
I updated the change record with the new proposal, including an example how you can use an OOP hook to store and access the original entity (or just the ID) and reuse it in the insert hook after the new duplicate entity was saved.
yes, there are.
no, i've not been able to bisect.
fwiw, in this specific instance here:
Core Announcements (announcements_feed) Enabled 11.1.0
Core BigPipe (big_pipe) Enabled 11.1.0
Core Block (block) Enabled 11.1.0
Core Block Content (block_content) Enabled 11.1.0
Core Breakpoint (breakpoint) Enabled 11.1.0
Core CKEditor 5 (ckeditor5) Enabled 11.1.0
Core Comment (comment) Enabled 11.1.0
Core Configuration Manager (config) Enabled 11.1.0
Core Contact (contact) Enabled 11.1.0
Core Contextual Links (contextual) Enabled 11.1.0
Field types Datetime (datetime) Enabled 11.1.0
Core Database Logging (dblog) Enabled 11.1.0
Core Internal Dynamic Page Cache (dynamic_page_cache) Enabled 11.1.0
Core Text Editor (editor) Enabled 11.1.0
Core Field (field) Enabled 11.1.0
Core Field UI (field_ui) Enabled 11.1.0
Field types File (file) Enabled 11.1.0
Core Filter (filter) Enabled 11.1.0
Core Help (help) Enabled 11.1.0
Core History (history) Enabled 11.1.0
Field types Image (image) Enabled 11.1.0
Field types Link (link) Enabled 11.1.0
Core Custom Menu Links (menu_link_content) Enabled 11.1.0
Core Menu UI (menu_ui) Enabled 11.1.0
Core MySQL (mysql) Enabled 11.1.0
Core Node (node) Enabled 11.1.0
Field types Options (options) Enabled 11.1.0
Core Internal Page Cache (page_cache) Enabled 11.1.0
Core Path (path) Enabled 11.1.0
Core Path alias (path_alias) Enabled 11.1.0
Core Search (search) Enabled 11.1.0
Core Shortcut (shortcut) Enabled 11.1.0
Core System (system) Enabled 11.1.0
Core Taxonomy (taxonomy) Enabled 11.1.0
Field types Text (text) Enabled 11.1.0
Core Toolbar (toolbar) Enabled 11.1.0
Core Update Manager (update) Disabled 11.1.0
Core User (user) Enabled 11.1.0
Core Views (views) Enabled 11.1.0
Core Views UI (views_ui) Enabled 11.1.0
Administration Admin Toolbar (admin_toolbar) Enabled 3.5.1
Administration Admin Toolbar Search (admin_toolbar_search) Enabled 3.5.1
Administration Admin Toolbar Extra Tools (admin_toolbar_tools) Enabled 3.5.1
Other Composer Deploy (composer_deploy) Enabled 8.x-1.10
Development Devel (devel) Enabled 5.3.1
Encryption Encrypt (encrypt) Enabled 8.x-3.2
Spam control Honeypot (honeypot) Enabled 2.2.0
Security Key (key) Enabled 8.x-1.19
Mail Mail System (mailsystem) Enabled 8.x-4.5
Other Pathauto (pathauto) Enabled 8.x-1.13
Other Redirect (redirect) Enabled 8.x-1.10
Performance Redis (redis) Enabled 8.x-1.8+3-dev
Security Security Review (security_review) Enabled 3.1.1
Mail SMTP Authentication Support (smtp) Enabled 8.x-1.4
Security Sodium (sodium) Enabled 3.0.0
Security Two-factor Authentication (TFA) (tfa) Enabled 8.x-1.9
Other Token (token) Enabled 8.x-1.15
Webform Webform Devel (webform_devel) Enabled 6.3.0-alpha3+7-dev
Webform Webform UI (webform_ui) Enabled 6.3.0-alpha3+7-dev
Webform Webform (webform) Enabled 6.3.0-alpha3+7-dev
Core Claro (claro) Enabled 11.1.0
Core Olivero (olivero) Enabled 11.1.0
with _that_ simply enabling `udpate` causes the error.
the only logs i've seen, i've shared.
Thanks so much abarrio for rebasing. Any ideas what we can do to fix the "Access to an undefined property" stuff flagged above? That seems like the biggest flagged snag currently.
Automatically closed - issue fixed for 2 weeks with no activity.
I've created 📌 Refactor Label Help to use hook_field_widget_WIDGET_TYPE_form_alter Active
jwilson3 → created an issue.
This has been stuck for years. Adding methods to entities is complicated and this even added methods to EntityStorageInterface, which is definitely a problem, as that isn't covered by the 1:1 rule. It might have a chance without the createDuplicate() refactoring into the storage classes, but even just the method is tricky to land, it took an immense amount of work to land 📌 Define 'original' as property on the entity object Needs work (which to be fair has a bigger scope).
I simplified it to something that actually has a chance to get committed and is equivalent to what replicate.module provides (not the field-level events, but that's trivial to replicate as shown by the paragraphs MR) and i believe also entity_clone and others didn't really offer more.
i already replied to those concerns in #81. OOP Hooks make it fairly easy to store state in your service and reuse it in another hook, for example keyed by the UUID of the duplicated entity. You can even add something directly on the entity yourself too, while we might deprecate __get()/__set(), we will provide an alternative with #2896474: Provide an API to temporarily associate data with an entity → .
IMHO this covers 80% of the use case and allows to handle to handle the 20% of cases that need the original on save with a tiny bit of extra logic. And if this is something that product entities commonly face due to their data model with variations, then it can extend createDuplicate() and provide that extra method on its own interface too.
Ahh sorry, should have checked. Turns out I'm on a fairly old version (16.6) so I think we won't worry about this. Time to upgrade the OS!
Ty for the patch it corrects the issue. So nice! Ty.
Are there contributed or custom modules present in the Drupal installation that produces this bug?
Automatically closed - issue fixed for 2 weeks with no activity.
MR Merged with '8.x-1.x'
I made a MR with the latests patch and fixed some phpcs errors. The patch is working well for me. Thanks @gcalex5!
After spending several hours on project maintenance over the past weekend, I have a growing suspicion that the entire module architecture should be refactored to utilize hook_field_widget_WIDGET_TYPE_form_alter
for different field widget types (i.e. field formatters), which ultimately are the things that have intimate knowledge of each Field API widget's internal array structure and render oddities.
This should probably be opened as a separate issue, and (likely) would need to be worked on as a precursor to the approach here. And then (wishfully thinking) we may even get Paragraphs support "for free" once the refactor is done.
Since this could end up being a large refactor that may take significant time (>6 months) and a version bump, feel free to keep iterating on the approach here, if you feel so inclined.
-
apmsooner →
committed 4df76bec on 3.0.x
Issue #3495494 by apmsooner, giuse69: Language not passed when using...
Thank you for fixing this. The fix is exactly as it should be. 🐛 Redirect after login not correct when using base_path Fixed should never have been committed as-is, especially since the main maintainer of this module (me) is probably the one making the most noise about these errors, and possibly the only one spamming people's logs.
(
By the way, I'm not even sure that the warning is accurate anymore, since
📌
Exception in EarlyRenderingControllerWrapperSubscriber is a DX nightmare, remove it
Needs work
has been unceremoniously committed, after waiting in limbo for 8 years. I'll have to read up on the current situation / re-test which exact circumstances would still make Core trigger such a "leaked cacheability metadata" exception.
)
roderik → closed merge request !22
-
roderik →
committed 2b8cd36f on 8.x-3.x authored by
nsciacca →
Issue #3486925 by nsciacca, .nickiv: Cacheability Metadata Leakage Error...
roderik → made their first commit to this issue’s fork.
This looks fantastic, but an E2E test is now failing. Possibly due to a recent commit to 0.x?
Upon testing, it turns out the approach here doesn't work with all core field types inside Paragraphs.
I see the following errors on screen when creating a Node type with paragraphs reference field:
Warning: Undefined array key 0 in label_help_field_widget_complete_form_alter() (line 68 of /var/www/html/label_help.module).
Warning: Undefined array key "value" in label_help_field_widget_complete_form_alter() (line 68 of /var/www/html/label_help.module).
Warning: Undefined array key "#title" in label_help_field_widget_complete_form_alter() (line 68 of /var/www/html/label_help.module).
While several field types do work and show the Label Help text, I see the following field types do not work inside Paragraphs (but do work on a normal Node).
- Boolean
- Link (URL only)
- Link (URL & Title)
- List (float)
- List (integer)
- List (text)
- Reference > Node w/ Autocomplete formatter.
- Reference > Other w/ Select List formatter.
- Reference > Term w/ Autocomplete (Tags style) formatter.
- Reference > User w/ Checkbox/radio buttons formatter.
- Text (formatted)
- Text (formatted, long)
- Text (formatted, long, with summary)
In "1.x-dev" support for translations have been introduced. You can define translations as mentioned in the Issue description like so,
# Demo: String with a placeholder.
dashboard.welcome_message.short:
default: "Hello @name!"
translations:
de: "Hallo @name"
fr: "Bonjour @name"
it: "Ciao #name"
For plural,
# Demo: Plural strings.
string_demo.search.result.items_count:
default: "@count item found"
default_plural: "@count items found"
placeholders:
- key: "@count"
type: int
translations:
en:
0: "@count item found"
1: "@count items found"
de:
0: "@count Artikel gefunden"
1: "@count Artikel gefunden"
fr:
0: "@count article trouvé"
1: "@count articles trouvés"
Since the MR focus on "export" part, that has not been included in the current commit. Please try out and let me know if it works
The issue still exists in drupal 10.
$element['upload']['#attached']['drupalSettings']['file']['elements']['#' . $id] = $extension_list;
Here we actually have selectors for div and input tags.
Updated to PHPStan 2.0.4, removed ignore of missingType.generics
and regenerated baseline
@haemishm I created an MR with a change that fixes the issue for me. Are you able to test the change to verify that it corrects the issue for you too?
anruether → created an issue.
I was having this issue as well, but thanks to the advice above, clearing the default "field_breadcrumb_title" value out of the "Alternative title field name for breadcrumb" input made the "Use menu title when available" functionality work properly.
This seems like a big issue, since it is totally not obvious that the bread crumb field name has anything to do with the menu titles, and it is filled in by default on module install.
dcam → opened merge request !10
skyriter → created an issue.
torfj → opened merge request !12
I've rebased the MR on the latest 2.0.x. and added a submodule to test the Paragraphs integration.
ddev drush en lh_paragraphs_test
Automatically closed - issue fixed for 2 weeks with no activity.