Live feed

โšก๏ธ Live updates new comments are added automatically.
๐Ÿ‡บ๐Ÿ‡ธUnited States GuyPaddock

Looks like the original issue is no longer reproducible even without a patch.

The Needs Review Queue Bot โ†’ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide โ†’ to find step-by-step guides for working with issues.

๐Ÿ‡ธ๐Ÿ‡ฌSingapore loziju

MR past the tests, but it's because there's no test on ldap_last_authserv yet. The feature not working yet for creating new user.

Remaining things to do:
- Fix the logic for both provisioning new user and authenticating existing user
- Write test for ldap_last_authserv

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Using the dev version fixed the error for me.

๐Ÿ‡บ๐Ÿ‡ธUnited States yas California ๐Ÿ‡บ๐Ÿ‡ธ
๐Ÿ‡บ๐Ÿ‡ธUnited States todea

In Drupal 7 we used the Quickbar module for this type of role based navigation and shortcuts. Quickbar allowed the admin to control which toolbar a role would get by using the built-in weights and drag/drop. (screenshot attached)

Being able to control the assignment of shortcuts this way would be helpful.

๐Ÿ‡บ๐Ÿ‡ธUnited States yas California ๐Ÿ‡บ๐Ÿ‡ธ

@baldwinlouie

Thank you for the update. It looks good. I'll merge the patch to 6.x and 7.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ธUnited States joshuami Portland, OR

@jacobupal, I think you might be on to something, but the approach in patch #70 in CKEditor 5 support for Content Templates โœจ CKEditor 5 support for Content Templates Needs review creates a command called "ckeditorTemplates" in /js/ckeditor5_plugins/ckeditor_templates/src/ckeditorTemplatesCommand.js that is called in /js/ckeditor5_plugins/ckeditor_templates/src/ckeditorTemplatesEditing.js. That command is inserting a section around every template when embedded:

+          <section class="ckeditor-template-wrapper">
+            <div class="ckeditor-template-content">
+              ${htmlCode}
+            </div>
+          </section>

That section getting converted into a widgetEditable with the widgetTypeAround handles. I didn't test that patch in particular, but that's what I'm seeing in the code. It kinda looks like they were following the tutorial at https://ckeditor.com/docs/ckeditor5/latest/tutorials/widgets/implementin....

That said, it would be awesome if we could target any element + attribute combination to make it an editable block widget when in focus. A horizontal rule gets upcast into a widget, why can't we do that with other element + attribute combinations. It might fix some issues like the ability to edit a <cite> within a <blockquote>.

๐Ÿ‡ซ๐Ÿ‡ทFrance MacSim

MacSim โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฆ๐Ÿ‡บAustralia realityloop

Can confirm #3 is working for us at least.

๐Ÿ‡บ๐Ÿ‡ธUnited States baldwinlouie

@yas, please review again.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

I think this looks good! And good timing

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ธUnited States maskedjellybean Portland, OR

I realized I can get around the issue by editing my local config split then choosing Advanced > Do not patch dependents. I understand this undoes some of the benefits of 2.x, but it is a way to avoid this issue for now. Since my local dev scripts will yell at me (and other devs) if drush config:status returns something other than "No differences between DB and sync directory.", I need to do this.

๐Ÿ‡ฆ๐Ÿ‡บAustralia acbramley

Pushed changes to an MR with an upgrade path to retain BC for existing sites.

๐Ÿ‡ฆ๐Ÿ‡บAustralia geoffreyr

Just pushed an update to the merge request adding an update hook to add the `id` column if it's not already there. This will help users with existing installations.

Sorry about the implementation, it's hacky, but I couldn't find a better way. The issue https://www.drupal.org/project/drupal/issues/3264915 ๐Ÿ’ฌ Can't update database: Syntax error or access violation: 1075 Incorrect table definition Closed: duplicate describes a similar problem.
We might need to check other database types (SQLite, Postgres) to see if this method is valid or not.

๐Ÿ‡บ๐Ÿ‡ธUnited States greggles Denver, Colorado, USA

Thanks for your help vmarchuck and for that QA and update for Drupal 10, Nathaniel!

Nudging this to RTBC. We've been using the various versions of it since 2019. Would be great to get a maintainer's feedback.

๐Ÿ‡จ๐Ÿ‡ฑChile Andrรฉs Chandรญa

Choukran, thousand times!!!

I couldn't take the black border out when hovering but I got a nice effect adding a transparent fill

.sm-icon:hover svg {
fill: rgba(255,255,255,0.5) !important;
background-color: purple !important;
border-radius: 50%;
}
๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Thanks for the updates. I looked at MR 70 and noted a couple formatting fixes and had a question.

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Add another fixed issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Thanks everyone. I reviewed the code and tested MR 72 and it works as expected. This has been merged and will be in the next release.

That said, there still might be missing tests. Don't we want to test things like the following? If so, we can have a followup issue with more tests.

1. We set min numbers to 3 and we set password to 3 numbers that are the same.

2. We set min numbers to 3 and we set password to 3 numbers that are the different.

3. We set min numbers to 3 and we set password to 2 numbers that are the same (or different).

4. We set min numbers to 3 and we set password to 4 numbers that are the same (or different).

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ธUnited States benjifisher Boston area

benjifisher โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States dww
  1. Changes in the MR are small, clear, and do what the title and summary say they should. No complaints, not even nits. And I'm usually good for at least something pedantic to point out during a review. ๐Ÿ˜‚
  2. CI pipeline is all green.
  3. The fact that we might have random garbage collection during tests is definitely a source of instabilityts.
  4. This random query behavior has been causing trouble in the performance tests and other spots.

Therefore, RTBC.

Thanks!
-Derek

p.s. Out of scope, but I'll say it anyway. Expanding the full context for the MR changes, I notice this (untouched by the MR):

      // @todo Decide in https://www.drupal.org/project/drupal/issues/3395099 when/how to trigger deprecation errors or even failures for contrib modules.

But ๐Ÿ“Œ Follow-up for #3361534: config validation errors in contrib modules should not cause deprecation notices, unless they opt in Active is Closed (fixed). Do we need a followup to remove that @todo?

๐Ÿ‡ซ๐Ÿ‡ทFrance andypost

Thank you! Still needs work to fix CS and

only need some test coverage for the new RouteProvider::getRouteAliases() method now.

๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10

Thanks @johnwebdev @catch - I updated the text on the CR to make it clear that 10.3.0 is the point at which the status page will start to report on the deprecation

๐Ÿ‡บ๐Ÿ‡ธUnited States benjifisher Boston area

The list of attendees looks right to me.

๐Ÿ‡บ๐Ÿ‡ธUnited States benjifisher Boston area

benjifisher โ†’ created an issue.

๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10
๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

@johnwebdev the commit was made to 11.x, but we branched off the 10.3.x branch from 11.x just after it was made, so it's now deprecated in both the 10.3.x and 11.x branches.

What this means is:

1. 10.3.0+ sites will get a warning that core forum module is deprecated, and will be encouraged to install the contrib forum module.

2. We still need to actually remove forum module from the 11.x branch/11.0.0, that will happen in ๐Ÿ“Œ [PP-1] Remove Forum module Postponed .

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom mcdruid ๐Ÿ‡ฌ๐Ÿ‡ง๐Ÿ‡ช๐Ÿ‡บ
๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10
๐Ÿ‡จ๐Ÿ‡ฑChile Andrรฉs Chandรญa

A little issue with menus, background is overlapping, how do I solve it, I've been looking around and the solution seems to be z-index, but some places discourage the use of it, I'm adding a video โ†’ for you to see what's going on...

Thanks

๐Ÿ‡บ๐Ÿ‡ธUnited States cobblestone.consulting

This was addressed in beta4

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Adding another fixed issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States becw

I needed the work in this ticket, but the patch against 1.3.x no longer applies, and I didn't see a recent update in the issue fork on GitLab, so I did a bit of refactoring and have a working approach.

I've added a PHPUnit kernel test, but there's some things where I'm not exactly sure what the existing behavior is, so I need to validate that before finishing those tests. Anyway, here's my WIP.

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Fixed and will be included in next release.

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

This isn't picked up in phpcs so leaving this on its own.

Automatically closed - issue fixed for 2 weeks with no activity.

๐Ÿ‡บ๐Ÿ‡ธUnited States Kristen Pol Santa Cruz, CA, USA

Copying issue credits for people who worked on duplicate issue:

๐Ÿ“Œ Fix the issues reported by phpcs Needs work

Production build https://api.contrib.social 0.61.6-2-g546bc20