brooke_heaton → created an issue.
I am having a similar issue with permissions not being removed for Entity Print on bunbles of a taxonomy, so this is also happening with non-node entities.
Seems the issue may be a new setting missing. I went in to each menu and resaved the form and the issue goes away.
Just chiming in to say that I'm getting this error as well on the current Dev version and Core Version 10.2.0. I haven't dug in to investigate yet but will try to identify the problem. But just noting that unfortunately the latest changes on Dev do not seem to resolve this issue.
Woops. Thanks for moving this @megachriz. I'm stuck in D7.
brooke_heaton → created an issue. See original summary → .
brooke_heaton → created an issue.
Awesome. I'll try to get some of the patches merged in after some review. Thanks!
Revised patch. No need to track parent in the eat table, just on addTerm. This patch should applay against 3.0.1.
Adding updates to schema in 3.0.1 patch.
brooke_heaton → created an issue.
So, it won't be possible to create a clean patch off a Gitlab Merge Request since the current 3.x branch is behind the 3.0.1 release on Packagist. I had to manually roll a patch via diff in order to apply clean against the 3.0.1 release, which is currently the only Drupal 11 comptabiel release. This is not idea and unfortunately it is no longer possible to easily perform MRs against this module so active maintainership is needed.
So, strangely it seems that the current 3.x branch is BEHIND the 3.0.1 tag, so it's not really possibly to apply the patch to the current release. I think it'd need to be applied to the 3.x Dev branch but I'm not certain. While the MR above is mergeable, the patch will not apply with Composer. Just a heads up.
brooke_heaton → created an issue.
brooke_heaton → changed the visibility of the branch add_parent_term to hidden.
brooke_heaton → created an issue.
@windm - The next step would be to test the patch by applying it via Composer. The patch can be found at teh most recent Pull Request: https://git.drupalcode.org/project/barcodes/-/merge_requests/9.patch
But, with this change we'd also want a maintainer to take a look at the patch and functionality. It likely needs a Test as well.
This is also happening on 3.0.0-rc3.
Call to a member function id() on null in ginvite_group_content_delete() (line 209 of modules/contrib/ginvite/ginvite.module). call_user_func_array(Object, Array) (Line: 416)
Happy to open a new ticket if needed.
Gotcha. My bad! Looking at the wrong branch.
Looks like the current branch has this updated fully integrated now but for some reason this isn't marked as fixed.
https://git.drupalcode.org/project/bootstrap_paragraphs/-/blob/5.0.x/boo...
See bootstrap_paragraphs_update_8204() and bootstrap_paragraphs_update_8205()
I see this issue has recently been resolved in the most recent versions.
brooke_heaton → created an issue.
I've added a Merge Request to the fork that adds a new 'Allow users to re-use existing @label multiple times' checkbox, which, when checked, will skip the duplicate entity id validation and permit multiple re-use of existing entities.
brooke_heaton → made their first commit to this issue’s fork.
This is for a link field. Link fields can be configured to include internal or external links. If an internal link is stored, the $value of the field is not a fully rendered URL, it is a Drupal path (e.g. entity:node/3821). When the field is rendered as a barcode, problematically the scanned barcode will render to entity:node/3821. This PR and patch fixes this issue. I would encourage you to review it.
brooke_heaton → created an issue.
Attached patch will convert internal links to full urls. See Merge Request.
brooke_heaton → created an issue.
Does anyone know why the following help text is hard-coded to the link field and seeminly can't be removed?
Start typing the title of a piece of content to select it. You can also enter an internal path such as %add-node or an external URL such as %url. Enter %front to link to the front page. Enter %nolink to display link text only. Enter %button to display keyboard-accessible link text only.', ['%front' => '', '%add-node' => '/node/add', '%url' => 'http://example.com', '%nolink' => '', '%button' => '']);
Is there a way to easily remove this text?
We can add a Views Field Handler extending EntityLink to handle this and to render the link as a QR code. I have an initial proof of concept for Nodes that is not customizable but is working.
brooke_heaton → made their first commit to this issue’s fork.
Pushed up an MR to fix the typo. Simple fix.
brooke_heaton → created an issue.
I actually like the idea of providing examples that might include node, block, user (as these are all core Content Entities), could really help here and provide some important context.
Ok understood. I agree especially from a backend Dev Drupal/API perspective that Drupal considers the User object a Content Entity - but that's not necessarily my primary concern here. My primary concern is ensure that the UI is clear to the end user. It wasn't clear to me and I've been using Drupal since 2007 and I acknowledge that Drupal has historically been Dev-centric and is struggling with adoption and hemoraging usership to other CMS solutions. That is my primary concern here. Does the end user understand that a User is a 'Content Entity' and should we be using that terminology for the particular end user who is interacting with this module. I'm not sure the answer is 'yes' but I understand the developer perspective here.
Closing this as 'User profile' is listed. 'User profile' is probably confusing and confounded with 'Profile' entities and I think the overall bifurcation of 'Config' vs 'Content' could probably be better documented, especially to those new to Drupa.
brooke_heaton → created an issue.
It's also probably worth adding that 'Content Entities' are outlined in current Drupal documentation → and Users are very much NOT considered a Content Entity in current documentation. I'd strongly suggest a change in wording that is consistent with Drupal documentation and standards.
In any case, I spent a lot of time overlooking 'Content Entity' when wanting to work with a User. I just don't like the term 'Content' here. Sorry.
brooke_heaton → created an issue.
This all looks good to me @greggles. Appreciate the second look and fix on those indentations. Might have been me editing on Gitlab via the interface there. This is good to go from my end unless you think it needs more testing.
brooke_heaton → created an issue.
brooke_heaton → made their first commit to this issue’s fork.
Ok, I pushed up a new approach that should vastly improve the speed and efficiency of this. I'm doing a leftJoin between login_history and the user table for any NULL values in the user table then I am able to fetch the array keys into one array and run a delete query with the set of deleted user IDs.
/**
* Deletes records of deleted user from login_history.
*/
function login_history_update_8004() {
$connection = Database::getConnection();
$query = $connection->select('login_history', 'lh');
$query->condition('lh.uid', 0, '<>')->addField('lh', 'uid');
$query->leftJoin('users', 'u', 'lh.uid = u.uid');
$query->isNull('u.uid');
$results = $query->distinct()->execute()->fetchAllAssoc('uid');
$results = array_keys($results);
$count = count($results);
if ($results) {
$message = "Removing $count deleted user id from login_history table.";
\Drupal::logger('login_history')->notice($message);
$query = $connection->delete('login_history')
->condition('uid', $results, 'IN')
->execute();
}
$message = "Removal complete.";
\Drupal::logger('login_history')->notice($message);
}
Feedback welcome on the PR.
A lot of developers miss the required fields method on a select query and it's not clearly outlined here that fields are REQUIRED by a dynamic select query or the query will fail.
Sure, I can revise this to make this a left join instead. Let me see if I can rig that up. Might take a bit.
Added update hook to remove data on deleted users form login_history.
This ticket could likely also use an update hook to purge the data on any previusly deleted user accounts.
Oh interesting. Thanks for pointing that out. I'll look into it. Thanks Aaron!
Here is a full stack trace of my error, if this can help elucidate the problem. Sorry for any confusion:
Backtrace
#0 /code/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php(80): Drupal\Core\Entity\Query\Sql\Query->prepare()
#1 /code/web/modules/contrib/salesforce/modules/salesforce_mapping/src/Plugin/Validation/Constraint/UniqueFieldsConstraintValidator.php(37): Drupal\Core\Entity\Query\Sql\Query->execute()
#2 /code/web/core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php(202): Drupal\salesforce_mapping\Plugin\Validation\Constraint\UniqueFieldsConstraintValidator->validate(Object(Drupal\salesforce_mapping\Entity\MappedObject), Object(Drupal\salesforce_mapping\Plugin\Validation\Constraint\MappingSfidConstraint))
#3 /code/web/core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php(154): Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateConstraints(Object(Drupal\salesforce_mapping\Entity\MappedObject), '000000000000212...', Array)
#4 /code/web/core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php(106): Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode(Object(Drupal\Core\Entity\Plugin\DataType\EntityAdapter), Array, true)
#5 /code/web/core/lib/Drupal/Core/TypedData/Validation/RecursiveValidator.php(93): Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validate(Object(Drupal\Core\Entity\Plugin\DataType\EntityAdapter), NULL, NULL)
#6 /code/web/core/lib/Drupal/Core/TypedData/TypedData.php(132): Drupal\Core\TypedData\Validation\RecursiveValidator->validate(Object(Drupal\Core\Entity\Plugin\DataType\EntityAdapter))
#7 /code/web/core/lib/Drupal/Core/Entity/ContentEntityBase.php(518): Drupal\Core\TypedData\TypedData->validate()
#8 /code/web/core/lib/Drupal/Core/Entity/ContentEntityForm.php(188): Drupal\Core\Entity\ContentEntityBase->validate()
#9 [internal function]: Drupal\Core\Entity\ContentEntityForm->validateForm(Array, Object(Drupal\Core\Form\FormState))
#10 /code/web/core/lib/Drupal/Core/Form/FormValidator.php(82): call_user_func_array(Array, Array)
#11 /code/web/core/lib/Drupal/Core/Form/FormValidator.php(275): Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object(Drupal\Core\Form\FormState))
#12 /code/web/core/lib/Drupal/Core/Form/FormValidator.php(118): Drupal\Core\Form\FormValidator->doValidateForm(Array, Object(Drupal\Core\Form\FormState), 'salesforce_mapp...')
#13 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(593): Drupal\Core\Form\FormValidator->validateForm('salesforce_mapp...', Array, Object(Drupal\Core\Form\FormState))
#14 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('salesforce_mapp...', Array, Object(Drupal\Core\Form\FormState))
#15 /code/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\salesforce_mapping_ui\Form\MappedObjectForm), Object(Drupal\Core\Form\FormState))
#16 /code/web/core/modules/layout_builder/src/Controller/LayoutBuilderHtmlEntityFormController.php(39): Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#17 [internal function]: Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#18 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#19 /code/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#21 /code/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#22 /code/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#23 /code/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#24 /code/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /code/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /code/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /code/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /code/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /code/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /code/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /code/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /code/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}brooke_heaton → created an issue.
Sure. Works for me.
Nope. That's not the problem.
See, by setting $create_only to FALSE, you are STILL running a function that should not be ran and results in additional errors.
Warning: Trying to access array offset on value of type null in Drupal\autotagger_search_in_text\Plugin\Autotagger\SearchInTextFields->tagNode() (line 209 of modules/contrib/autotagger/modules/autotagger_search_in_text/src/Plugin/Autotagger/SearchInTextFields.php).
Warning: Trying to access array offset on value of type null in Drupal\autotagger_search_in_text\Plugin\Autotagger\SearchInTextFields->tagNode() (line 210 of modules/contrib/autotagger/modules/autotagger_search_in_text/src/Plugin/Autotagger/SearchInTextFields.php).
We want to wrap this in a conditional and NOT run this if there are no settings on a bundle.
if ($node->isNew() || !$create_only) {
// If the node is first being created, or the node is set to not only tag
// on new, then go ahead and tag it.
$this->tagNode($node);
}
If there are no settings on a bundle, why are we tagging the node? The node has no settings and the node is new.
Your ternary is nice and all, but the goal here should be to prevent tagging of nodes that do not have any settings. For that you need a conditional statement to prevent running $this->tagNode if $settings['autotagger_tag_on_create_only'] returns FALSE. BTW Drupal coding standards should have PHP Constants like FALSE in ALL CAPS. →
So I don't think a ternary is possible here. We actually want the entire code below to be conditional and we don't want to run ->tagNode whatsoever if there are no settings. I don't see a way to apply a ternary here, sorry.
if (isset($settings)) {
$create_only = $settings['autotagger_tag_on_create_only'];
if ($node->isNew() || !$create_only) {
// If the node is first being created, or the node is set to not only tag
// on new, then go ahead and tag it.
$this->tagNode($node);
}
Can we use MRs going forward?
Will do!
Merge request submitted to 1.0.x branch.
brooke_heaton → created an issue.
brooke_heaton → created an issue.
I removed the module entirely due to this issue. Was not worth the pain nor time.
For the benefit of others, here's how I was able to get custom attributes/mapping working with drupalauth4ssp.
First, you will need to patch the drupalauth/simplesamlphp-module-drupalauth module required by drupalauth4ssp using this PR. As of Feb 27, 2024 the PR has not yet been integrated. What that PR does is it creates an Event in the drupalauth SSP module to allow for a Drupal EventSubscriber.
Next you will need to create your custom EventSubscriber to subscribe to the SimpleSAML\Module\drupalauth\Event\SetAttributesEvent created with the patch from the PR above.
Below is an example of how I am mapping to First and Last names in Drupal which are created via the 'name' module, which is not accounted for with the out-of-the-box attribute mapping of drupaluth.
declare(strict_types=1);
namespace Drupal\custom_sso\EventSubscriber;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use SimpleSAML\Module\drupalauth\Event\SetAttributesEvent;
/**
* @todo Add description for this subscriber.
*/
final class CustomSsoSubscriber implements EventSubscriberInterface
{
/**
* {@inheritdoc}
*/
public static function getSubscribedEvents(): array
{
$message = "getSubcribedEvents fired";
return [
SetAttributesEvent::EVENT_NAME => ['setAttributes'],
];
}
/**
* React to attributes
*
* @param \SimpleSAML\Module\drupalauth\Event\SetAttributesEvent $event
* Drupalauth setAttributes event.
*/
public function setAttributes(SetAttributesEvent $event)
{
$user = $event->getUser();
if (!$user->get('field_name')->isEmpty()) {
$first = isset($user->get('field_name')->given) ? $user->get('field_name')->given : NULL;
$last = isset($user->get('field_name')->family) ? $user->get('field_name')->family : NULL;
$attributes = $event->getAttributes();
$attributes['givenName'] = [$first];
$attributes['sn'] = [$last];
$event->setAttributes($attributes);
}
}
}
brooke_heaton → created an issue.
FWIW since the future of this module is undetermined, I have implemented drupalauth4ssp and so far it is working pretty well, however it is lacking some of the features of saml_idp, namely the implementation of a alter hook to manipulate the SimpleSAML 'attributes' in an assertion. But it does seem to have a mechanism to define attributes. I am still investigating. Thanks for your owrk on this @halth.
brooke_heaton → made their first commit to this issue’s fork.
Try:
composer require 'drupal/drupalauth4ssp:^2.0@RC'
I should note that the new requiresments of the module.enable config makes the current README and Drupal\saml_idp\Install::postInstall obsolete. The config-dist should probably include an example config.php file as well.
brooke_heaton → created an issue.
Hey folks, been around for a while and trying to follow the transition from patches to MRs but as I'm on Drupal 10.2 I have absolutely no idea which patch or MR I should be using for this. Can anyone advise?
This patch needs a reroll.
Patch #14 is applying clean for me and working. Thanks @paulrad!
Looks like I had an old patch getting applied.
brooke_heaton → created an issue.
It's odd that this fix is not in the latest version marked as compatibel with Drupal 10. The latest version is most definitely not compatible without this.
Just here to report that I am seeing the same errors as noted in $6. I see the following error on my search View:
can not use FieldCache on unindexed field: boost_documenttype Status reportmessage can not use FieldCache on unindexed field: boost_documentdescription The request sent by the client was syntactically incorrect.
I am using the following modules on Drupal 9.5.11:
Search API (search_api) 8.x-1.30
Search API Pantheon (search_api_pantheon) 8.1.4
Search API Solr Autocomplete (search_api_solr_autocomplete) 4.2.9
Search API Solr Legacy (search_api_solr_legacy) 4.2.9
Search API Solr (search_api_solr) 4.2.9
The latest patch isn't resolving the fundamental performance problems for me. The views plugin still appears to try to load WAY WAY too many entities. In my case I'm using nodes referenced on a Paragraph that uses a Relationship. What DOES work for me is to comment out the getValueOptions() function entirely when developing locally. I think the plugin has some fundamental problems that aren't addressed here. Definitely needs a lot more work.
Patch at 💬 D9 compatibility issues Needs work is prerequisite for this patch and does not apply clean, so this patch cannot be applied.