Exception when membership is deleted after user

Created on 11 October 2024, 7 months ago

Problem/Motivation

My test cleanup script stumbled on this. An exception is thrown when a membership is deleted after its user.

Steps to reproduce

- Delete a membership after its user.

Exception in Drupal\Tests\c4c\ExistingSite\DGOContractTest::tearDownAfterClass
Call to a member function id() on null

web/modules/contrib/ginvite/ginvite.module:209
web/modules/contrib/hux/src/HuxModuleHandler.php:114
web/modules/contrib/hux/src/HuxModuleHandler.php:100
web/core/lib/Drupal/Core/Extension/ModuleHandler.php:395
web/modules/contrib/hux/src/HuxModuleHandler.php:103
web/modules/contrib/hux/src/HuxModuleHandler.php:121
web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:215
web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php:900
web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:462
web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:753
web/modules/contrib/group/group.module:465
web/modules/contrib/hux/src/HuxModuleHandler.php:114
web/modules/contrib/hux/src/HuxModuleHandler.php:100
web/core/lib/Drupal/Core/Extension/ModuleHandler.php:395
web/modules/contrib/hux/src/HuxModuleHandler.php:103
web/modules/contrib/hux/src/HuxModuleHandler.php:121
web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:217
web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php:900
web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:462
web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:753
web/core/lib/Drupal/Core/Entity/EntityBase.php:362
web/modules/custom/c4c/tests/src/ExistingSite/ContentCleanup/EntityWatcher/EntityWatcher.php:48
web/modules/custom/c4c/tests/src/ExistingSite/BaseClass/C4cExistingSiteBase.php:56
vendor/bin/phpunit:122


Proposed resolution

s/$group_relationship->getEntity()->id()/$group_relationship->getEntityId()/
and avaid the anyway not necessary entity load.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

4.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany geek-merlin Freiburg, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024