Contrib.social

Not removing permissions when you remove content type

Open on Drupal.org →
Created on 15 February 2024, over 1 year ago

Problem/Motivation

I am upgrading from Drupal 9.5.4 to Drupal 10. The Upgrade Status module tells me what has to be fixed before I upgrade, and it flags bad permissions that will cause a runtime error in Drupal 10. It took a while to figure, but was eventually reproducible.

Steps to reproduce

Create a custom content type. Give it some Entity Print permissions. Delete the content type. The permissions will not be deleted from the config database, and will throw an error in the Update Permissions database.

Workaround is to remove all of the permissions (checkboxes) in the Entity Print permissions table before you delete the content type. But you should not have to. When you delete a content type, it tells you the configurations it will modify or delete, but Permission or Access is not among those listed. There is probably just some further specification that needs to be made of "when you delete a content type, remove these permissions."

Proposed resolution

Specify the Access Config's that you modify when installing and mark them to be removed when a content type is deleted.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.13

Component

Code

Created by

🇺🇸United States scottop

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @scottop
  • Comment 4 months ago →
    🇺🇸United States brooke_heaton

    I am having a similar issue with permissions not being removed for Entity Print on bunbles of a taxonomy, so this is also happening with non-node entities.

  • Status changed to Needs work about 13 hours ago
  • Comment about 13 hours ago →
    🇦🇺Australia jannakha Brisbane!

    I can reproduce the issue on the dev branch:

    Deleted 'article' content type
    Exported config still contains permissions:

    permissions:
  - 'access content'
  - 'entity print access bundle article'
  - 'use text format restricted_html'
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024