🇦🇺Australia @jannakha

Hi team! any plans for a stable release?

this is CKEditor5's issue https://github.com/ckeditor/ckeditor5/issues/15908
as per #9 - don't use "shared class names" until CKEditor will fix the issue

as per #15 this patch doesn't fix the issue.
if you have:

a.btn|Button
a.btn.btn-small|Button small
a.btn.btn-alert|Button alert

Apply button small and green.
Save.
Re-open editor.
Only Button is selected.
and then it starts behaving weirdly (see screenshot → ) by splitting link

tested on D11, patch from MR4 applies, tailwind classes applied to a link as expected after the patch.

try installing 7.0.11 of Linkit - https://www.drupal.org/project/linkit/releases/7.0.11 →
and MR37 from for Editor Advanced Link - https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active

I tested it on D11.2 - all attributes are kept and saved, no split links appear, you can add additional classes via editor_advanced_link and they are saved together with ckeditor_link_styles

Styles is a different plugin, not related to CKEditor Link Styles. Styles requires at least one style, but it's not required for Link Styles.
Link styles has its own tab where you can put link styles.
On D11 I was able to add styles to Link Styles and to Styles and it saved all config.

Can you provide any logs which display any errors? maybe record a video of the glitch? Thank you!

Unfortunately, this is how CKEditor5 45+ handles attributes.
As you said, it's not the end of the world and we are getting CKEditor5 for free!

Any feature/bug fixes contributions are welcome!

try installing 7.0.11 of Linkit - https://www.drupal.org/project/linkit/releases/7.0.11 →
and MR37 from for Editor Advanced Link - https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active

I tested it on D11.2 - all attributes are kept and saved, you can add additional classes via editor_advanced_link and they are saved together with ckeditor_link_styles

looks like this index.php is being abused (from my access log from some soviet hackers):

/index.php/node/

the MR doesn't implement the title/description of the issue.
MR only creates stubs out of references without any configuration or recursion limits.

see issue https://www.drupal.org/project/single_content_sync/issues/3511539 🐛 Recursion takes too much memory compared to earlier versions (1.4.6 or earlier) Active which may resolve your recursion issue

+1 to MR 154
import/export works on a node that references 46 other nodes
total length of the export file is 16716 lines!

thanks for MR!
please release!

can you please create a merge request?
Merge requests speed up development, reviews and releases!

thanks for keeping the lights on this module!
when are you planning to release 3.8?
it's a bit misleading to keep issues as 'fixed' without a release :(

MR created

jannakha → made their first commit to this issue’s fork.

it should be fixed in MR37 here - https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active

please review, test and confirm

thanks for reporting and fixing the issue.

RTBC!

It's not best practice for one module to be aware of the other module's implementation.
If editor_link changes their attribute names - it will be broken again.

Should all editor advanced fields belong in editor_advanced_link module and editor_file only be responsible for file attributes?
This will simplify the maintenance and remove any conflicts with editor_advanced_link! (same way linkit module is implemented)

Sweet!!!
Thanks Mark for reviewing MRs!

@seb_r is it possible to port patch #46 to branch of MR37 in https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active ?
for 2.3.x

nope
doesn't work
disregard previous comment
reverting version to 2.2.x

ok, so, after another day of testing both editor advanced link and linkit (and digging into CKEditor's code)
link is getting split (https://youtu.be/b4Ir59uv7Ds) at the time when contextual balloon is visible (CKEditor is handling it here: _showFakeVisualSelection())

once cursor moves off - link is no longer split, but if you click on balloon while the link is split - it leads to random behaviour.

From CKEditor's code: they move cursor to the end of selection so the editor will not try to create a new link after cursor
see https://git.drupalcode.org/project/linkit/-/merge_requests/149/diffs#c91...
that's coming from how they handle link re-rendering (here's end result: https://youtu.be/hYwEEnF_gUk)

extra testing required: when decorators (target attribute) are enabled - displayedText and custom attributes are not part of args in the event handler (it leads to unnecessary re-calculation of ranges etc), maybe a good idea will be to check when decorators are involved - do not process custom attributes?

I've updated editor advanced link as well, I've tested them separately and together.

What do you think?

jannakha → created an issue.

MR doesn't apply to 7.0.10 - is that because it's off latest unreleased dev?

jannakha → created an issue.

jannakha → created an issue.

Thanks for testing @inregards2pluto

MR 37 contains code from #32 patch with a fix.

Do you have Linkit enabled when you tested?
Is it possible to record a video of how link splitting appears?

MR !149 fixes the issue
- tested on D11
- not tested with any other CKEditor5 plugins/modules

jannakha → created an issue.

can someone test MR 37 from
https://www.drupal.org/project/editor_advanced_link/issues/3534699#comme... 📌 Refactor custom JS for CKEditor5 v45+ Active

I have tested it with images - it looks like it's working - maybe it will work for someone else? if not - put it back into needs work.

please review MR 37 in https://www.drupal.org/project/editor_advanced_link/issues/3534699#comme... 📌 Refactor custom JS for CKEditor5 v45+ Active

Please review MR 37, it also resolves these issues:
#3519379: Fix keyboard accessibility of advanced attribute fields
#3349389: Fix image/media link attributes being lost

I've tested MR 37 on D11 with multiple links in same CKEditor5 window, opening/closing/editing/editing image as a link - try to break it!
let me know if there are any errors.

(haven't tested it with linkit yet)

jannakha → changed the visibility of the branch 2.3.x to hidden.

jannakha → changed the visibility of the branch 3534699-minimal to hidden.

@mark_fullmer why not create a MR out of #32?

I have tested MR#43 and #32 on D11.2.

Unfortunately, all issues are still there:
- link is splitting
- values in advanced tab (and display text) appear/disappear randomly
- multiple links mix advanced values (even without clicking update)
- tab order of the text fields is not correct and advanced tab is reachable by keyboard

here's testing: https://youtu.be/d80reijHsD0 and https://youtu.be/maspn44C1nU

Perhaps, editor_advanced_link does need a proper refactoring for CKEditor v45+ not just a patching

fixed by https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active

please use a proper development process (do not commit directly to dev branch, create a fork and then a merge request): https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →

patch from #3 commit attached and applies to Drupal 10.5 and fixes the issue

all green!

thank you for your contribution!
MR looks good

as per #18

as per #11

fixed in #3549897

Since Bootstrap 4 is no longer in active development by TWBS team and keeping Bootstrap 4 in line with latest SASS compilers will take a significant effort (more and more deprecations will be added to sass v1.34+)

The solution is to use old version of Sass compiler:
https://github.com/twbs/bootstrap/issues/34051#issuecomment-845838276

please use:

npx sass@1.32  scss/style.scss css/style.css
npx sass@1.32  scss/ck5style.scss css/ckstyle.css

enabled big pipe
enabled js aggregation
Drupal 11
Bootstrap4 v3

no issues, no errors, Local tasks drop down shows and operates as expected

also added code these fixes:
🐛 Schema is missing for few parameters Active feat: Schema is missing for few parameters
🐛 Use minified js bundle in libraries.yml Active feat: Use minified js bundle in libraries.yml

updated requirement to jquery 4
updated/run tests with new jquery - all tests pass (see screenshot → )

please review/release

jannakha → created an issue.

all green, thank you for your contributions!
please release!

phpcs is still red

MR 104 is working and fixed the issue
thank you for your contributions!

please release :-)

hurray for new version of Boostrap!

to be ported to v4 before release

- version 3 is no longer supported - should this be ported to v4?
- a lot of changes in the merge request are not related to the issue description, it makes it extremely difficult to test and review
- If there are issue with formatting or phpcs or documentation - please create a separate issue for that
- https://en.wikipedia.org/wiki/Comparison_of_American_and_British_English

@thefancywizard can you create MR with patch #18? you can get push access to existing fork and MR37 will include your changes
It will really help with reviewing/testing process

thank you!

jannakha → created an issue.

Drupal 11 - ready!

thanks for adding/fixing CI
good to be merged

all good,
ready to be merged

works,
ready to be merged

css lint returns error

hello Drupal 11
good to merge!

What I'm not sure with this solution is how would I enable floating labels on webform? or on edit entity form?
do I need to override each textbox/selectbox in hooks to insert into attribute 'floating_label' => 1 ?

How do you do it?

Thanks for your contributions
Ready to be merged

Yes, but you should load all of css from all 3 themes - it’s like loading bootstrap 3 times!

If templates are overridden in subtheme, they’ll be used in subsubtheme unless overridden in subsubsub theme.

Are you still having issue with this?

If yes - what exactly is an issue? Which files are not loading? can you provide more details on the sub-themes and configuration? (Screenshots or zip files)?

floating labels will be attached to custom created fields
or via hook alter

maybe it should be a setting configuration

fixed in https://www.drupal.org/project/bootstrap5/issues/3396810 🐛 Wrong URL for Style Guide URL Bootstrap5 Setting page Fixed

review on v4

needs to be ported to v4

port/test on v4

port to v4

still issue in v4

still an issue in v4

you shouldn't be loading sub-theme if there's a sub-sub-theme
all sub-theme styles should be incorporated into sub-sub-theme - so you have just one style

still an issue v4 (Bootstrap 5.3.7)

jannakha → made their first commit to this issue’s fork.

thanks for fixing this and reporting it to drupal/core

tested and works as required

thank you for your contribution.
tested and ready to be merged in.

thank you for your contribution.
tested and works as expected.

tested - works well!
thank you for your contribution.

jannakha → made their first commit to this issue’s fork.

fixed in #3458182

jannakha → made their first commit to this issue’s fork.

MR is not related to the issue and it's v3
moving implementation to #3542885 (created it before finding this old issue)

jannakha → created an issue.

it's an existing issue with sass-lint: https://github.com/sasstools/sass-lint/issues/1161

is not a set value. pagination_heading_level is configured on the view itself by drupal/core.
This change came in with drupal/core (10.2.7 => 10.3.0) config.

If this has to be removed - please submit an issue to the core as it's a core functionality.

- How do you reproduce this issue? I can't reproduce on my local.
- Re: Patch #2: How does removing commented out lines resolve the issue?