🇦🇺Australia @jannakha

@mark_fullmer have a look at MR 127 - bare min changes

minimal refactoring for CKEditor 45+ to make sure all linkit attributes persist.
tested on D11.2 with ckeditor5_plugin_pack link attributes and editor_advanced_link with patch from https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active

jannakha → changed the visibility of the branch 3535479-refactor-linkit to hidden.

thank you for your contribution.

can you please create a fork and merge request
this will speed up review, testing and release process.

@nicholass
when you're updating dependencies, especially when Drupal is updated, run command to check for any major versions of contrib modules:
composer outdated -M -D

composer update usually just updates minor version by default (eg 6.1 to 6.2) if dependency has carrot (^) "drupal/linkit": "^6.0", but not to 7.0

in twig template try:
{{ dump(ds_content) }}
you'll see structure of your DS render array, your copy field should be there:

0 array:7 [▼
  "field_rcks_header_logo_with_text" => array:18 [▶]
  "group_rcks_details" => array:21 [▶]
  "field_rcks_disclaimer_text" => array:18 [▶]
  "group_rcks_table_of_content" => array:19 [▼
    "field_rcks_special_comments" => array:2 [▶]
    "display_field_copy:node-rcks_spec_systems_toc" => array:16 [▶]
    "display_field_copy:node-rcks_data_sheets_toc" => array:16 [▶]
    "field_rcks_add_maintenance_guide" => array:18 [▶]
    "#attached" => array:1 [▶]

In my case copy fields are under a field group:
{{ ds_content['group_rcks_table_of_content']['display_field_copy:node-rcks_spec_systems_toc'] }}

I take it back - patch is complete and was ported to an MR. Thank you @diegopino for your contribution!

MR is good for review.

The patch is incomplete:

- example of config for field copy:

id: spec_id_copy
label: 'Spec ID copy'
ui_limit: 'some_content_type|*'
type: display_field_copy
type_label: 'Copy field'
entities:
  node: node
properties:
  field_id: node.some_content_type.field_specification_id

- use example from DS on how to define schema for a field ./ds/config/schema/ds.field.schema.yml

patch #10 ported to MR
very rough implementation

#10 patch doesn't apply to v2

jannakha → made their first commit to this issue’s fork.

Drupal 7 reached EOL.

tested - all good.
pipeline is green.

thanks for your contribution.

good to go!

is that still an issue?
please provide more details:
- Drupal version
- php version
- can you provide screenshots?
- steps to reproduce?

Copied field are displayed in "Disabled" fields on all custom Display View modes.

Can you please check that the copied fields belong to a correct content type?

here's config of a field:
https://www.drupal.org/files/issues/2025-07-29/config-copy-field.png →

Code needs to be reviewed by someone who has not committed to MR.

This issue has to be tested as well.

jannakha → created an issue.

Drupal 7 has reached its official end of life

Drupal 7 has reached its official end of life.

jannakha → created an issue.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 7 has reached its end of life.

Drupal 8 is out of support.
Please upgrade to Drupal 10+ and use latest version of the module.

Drupal 8 is out of support.
Please upgrade to Drupal 10+ and use latest version of the module.

jannakha → changed the visibility of the branch 3249367-entity-browser-modal to hidden.

Tested on D10.5:

- Without patch entity browser window is opened by pressing Enter on any text field
- MR2 installed, tested, fixes the issue

Please release?

jannakha → made their first commit to this issue’s fork.

@pookmish thank you for raising your hand!
+1 for new co-maintainers for this module!

@vladimiraus - we need this module D11 ready too!

try these patches: https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active
and linkit: https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active

CKEditor5 v45+ had a big refactoring of links (in v44) so things have changed a lot.

@jcandan I'll see if have some time next week to check how to handle link attrs on media (it's something to do with their upgrade in v44 and https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-lin...)

example of batch processing: https://git.drupalcode.org/project/views_data_export

thank you @liuyuanchao !
please create merge request - it will trigger pipeline and we'll see the status of the fixes.

jannakha → created an issue.

can you please set default branch to 3.0.x?

@jeroen dost - try patch from https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active for 2.3

- add tests
- fix tests
- make setting "Print all views results" applicable per "Print view" link (not a global setting), so editors have a choice of printing a page or full view - (it can be a query string argument on a print link, eg ?print_all=1)

Also it's possible to achieve this with printing a copy of a view which doesn't have pagination

tested on D11.2 - as per fix - Access denied is displayed

jannakha → made their first commit to this issue’s fork.

jannakha → made their first commit to this issue’s fork.

jannakha → made their first commit to this issue’s fork.

for comment #9 - it's not this modules' issue
see linkit: https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active

CKEditor5 v45+ removes all attributes by default, unless Drupal's module's tries to persist them.
unfortunately CKEditor5 team doesn't want to implement any of the link attributes like title, id, class, etc - so we are stuck with our own implementation.

I would actually change status of this issue to "closed (won't fix)" - but we'll keep the discussion for now.

For example, if you uninstall editor_advanced_link and use CKEditor's own module which adds open in new tab ( https://www.drupal.org/project/ckeditor5_plugin_pack → ) you'll have the same issue.

all other modules have to fix persistence of their own attributes.

can work with batch support?

jannakha → created an issue.

jannakha → made their first commit to this issue’s fork.

+1

use css to hide any HTML containers
entity print allows to include extra css, so @media doesn't have to be set to print

PrinceXML is a proprietary and paid library.
You can ask their developers to create a plugin for entity_print.
Here's an example how to create a plugin for your own pdf engine:
https://www.drupal.org/project/entity_print/issues/3063998 🐛 mPDF Plugin Needs review

Has this been resolved in v2?
please reopen add more details if it's still an issue

most free PDF libraries have limited support for CSS (and most don't support CSS3, example flex support)

please provide more details:
- Drupal version
- how do you attach css to printing?
- are styles attached in debug mode?
- attach screenshots of produced PDFs

jannakha → made their first commit to this issue’s fork.

@hitfactory thank you for your notes

can you please resolve merge conflicts?

please resolve merge conflicts

🤩 merged to dev

Stay tuned for release

Thank you for your contribution!

Typo in the fix

Currently it’s
9.4^ || 10^ || 11^

There will be more D11 compatibility issues coming

There’s no visibility of how many Drupal 9-10.3 installations still out there

Will be good to move on to proper versioning

Should all advanced fields belong in editor_advanced_link module and editor_file only be responsible for file attributes?
This will simplify the maintenance and remove any conflicts with editor_advanced_link!

CKEditor 4 is EOL

is that still an issue?

CKEditor 4 EOL

@yara mezher
thank you for your contribution.
Can you please create a merge request to speedup reviewing and testing process?
here's how: https://www.drupal.org/community/contributor-guide/task/create-a-merge-r... →

jannakha → changed the visibility of the branch 8.x-2.x to hidden.

latest release (2.17) needs CI fixed.

jannakha → changed the visibility of the branch 3466043-fix-phpcs-and to hidden.

merged

jannakha → made their first commit to this issue’s fork.