🇦🇺Australia @jannakha

jannakha → created an issue.

Drupal 11 - ready!

thanks for adding/fixing CI
good to be merged

all good,
ready to be merged

works,
ready to be merged

css lint returns error

hello Drupal 11
good to merge!

What I'm not sure with this solution is how would I enable floating labels on webform? or on edit entity form?
do I need to override each textbox/selectbox in hooks to insert into attribute 'floating_label' => 1 ?

How do you do it?

Thanks for your contributions
Ready to be merged

Yes, but you should load all of css from all 3 themes - it’s like loading bootstrap 3 times!

If templates are overridden in subtheme, they’ll be used in subsubtheme unless overridden in subsubsub theme.

Are you still having issue with this?

If yes - what exactly is an issue? Which files are not loading? can you provide more details on the sub-themes and configuration? (Screenshots or zip files)?

floating labels will be attached to custom created fields
or via hook alter

maybe it should be a setting configuration

fixed in https://www.drupal.org/project/bootstrap5/issues/3396810 🐛 Wrong URL for Style Guide URL Bootstrap5 Setting page Fixed

review on v4

needs to be ported to v4

port/test on v4

port to v4

still issue in v4

still an issue in v4

you shouldn't be loading sub-theme if there's a sub-sub-theme
all sub-theme styles should be incorporated into sub-sub-theme - so you have just one style

still an issue v4 (Bootstrap 5.3.7)

jannakha → made their first commit to this issue’s fork.

thanks for fixing this and reporting it to drupal/core

tested and works as required

thank you for your contribution.
tested and ready to be merged in.

thank you for your contribution.
tested and works as expected.

tested - works well!
thank you for your contribution.

jannakha → made their first commit to this issue’s fork.

fixed in #3458182

jannakha → made their first commit to this issue’s fork.

MR is not related to the issue and it's v3
moving implementation to #3542885 (created it before finding this old issue)

jannakha → created an issue.

it's an existing issue with sass-lint: https://github.com/sasstools/sass-lint/issues/1161

is not a set value. pagination_heading_level is configured on the view itself by drupal/core.
This change came in with drupal/core (10.2.7 => 10.3.0) config.

If this has to be removed - please submit an issue to the core as it's a core functionality.

- How do you reproduce this issue? I can't reproduce on my local.
- Re: Patch #2: How does removing commented out lines resolve the issue?

Each module can produce their own alerts

can you please provide more details:
- which modules generated alerts? which one is from core?
- provide twig templates or debug information from both alerts?

Bootstrap dev team is working on fixes: https://github.com/twbs/bootstrap/pull/41512
fix for now: lock sass compiler at 1.77.6
https://github.com/twbs/bootstrap/issues/40849#issuecomment-2359038505

Bootstrap dev team is working on fixes: https://github.com/twbs/bootstrap/pull/41512
fix for now: as described in #4:
https://github.com/twbs/bootstrap/issues/40849#issuecomment-2359038505

sorry, but this theme only implements default Bootstrap5 behaviour to reduce any technical debt and keep it minimal for developers to customise.

If Bootstrap dev team decides to implement it - we'll bring it it.
maybe submit another issue - https://github.com/twbs/bootstrap/issues/39447

@ravi kant if you'd like you can create a new module (bootstrap5 addons or something) where you can add requested features?

aria-required is not added by Bootstrap5 theme, it's added either by core or by other modules:
Core: > web/core/lib/Drupal/Core/Render/Element/RenderElementBase.php (Drupal 10.5):
line: 145: $element['#attributes']['aria-required'] = 'true';

please raise the issue with core or other modules.

Comment #3 is correct.
Always have a dependency on bootstrap5/bootstrap5-js-latest if using any bootstrap js features

Comment #4 is not correct. There's no requirement for jQuery with Bootstrap 5.

MR#84 for review - if boostrap specific js is inserted wiht asset injector, asset injector js is executed first and it will result in error. MR adds weight on bootsrap js to make sure it's loaded earlier.

please review.

jannakha → made their first commit to this issue’s fork.

tested, all good - ready to merge

+1 ready to be merged

updated to B5.3

jannakha → made their first commit to this issue’s fork.

jannakha → created an issue.

fixed all docs

added related issues

jannakha → created an issue. See original summary → .

jannakha → made their first commit to this issue’s fork.

jannakha → created an issue.

which version of https://www.drupal.org/project/editor_advanced_link → are you using?
it requires a proper CKEditor 45 refactor for D10.5+

use 7.0.7 and MR122 from https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active (hidden branch)

use 7.0.7 and MR122 from https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active (hidden branch)

Unfortunately yes.

Unless MR122 works on D10.4
I haven’t tested.

@mark_fullmer - Linkit plugin needs to be refactored for CKEditor 45+ anyway - 7.0.8 is just a temp solution:
here's a reported issue 📌 Refactor custom JS for CKEditor5 v45+ Active

I can confirm I can reproduce it (see screenshot → ).

@mrshowerman yeah, that's an issue of not going proper version for CKEditor 45+.

Reason for it: CKEditor 44 refactored links api (Drupal is using 45+) which is not compatible with current versions of editor_advanced_link, linkit and other modules as they are now.

linkit 7.0.8 is a bare min refactor to keep attributes of the link, it's not a proper refactor for CKEditor 45+

Fix (not really a fix, but an example of proper refactoring for CKEditor 45+):
- install linkit 7.0.7 and patch https://git.drupalcode.org/project/linkit/-/merge_requests/122.diff (hidden fork on https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active ) - that works (see screenshot → ).

Please re-open (or open a new bug) https://www.drupal.org/project/linkit/issues/3535479 📌 Refactor Linkit plugin for CKEditor5 v45+ Active and indicate to the maintainer that proper CKEditor 45+ refactoring is required.

@mark_fullmer have a look at MR 127 - bare min changes

minimal refactoring for CKEditor 45+ to make sure all linkit attributes persist.
tested on D11.2 with ckeditor5_plugin_pack link attributes and editor_advanced_link with patch from https://www.drupal.org/project/editor_advanced_link/issues/3534699 📌 Refactor custom JS for CKEditor5 v45+ Active

jannakha → changed the visibility of the branch 3535479-refactor-linkit to hidden.

thank you for your contribution.

can you please create a fork and merge request
this will speed up review, testing and release process.

@nicholass
when you're updating dependencies, especially when Drupal is updated, run command to check for any major versions of contrib modules:
composer outdated -M -D

composer update usually just updates minor version by default (eg 6.1 to 6.2) if dependency has carrot (^) "drupal/linkit": "^6.0", but not to 7.0

in twig template try:
{{ dump(ds_content) }}
you'll see structure of your DS render array, your copy field should be there:

0 array:7 [▼
  "field_rcks_header_logo_with_text" => array:18 [▶]
  "group_rcks_details" => array:21 [▶]
  "field_rcks_disclaimer_text" => array:18 [▶]
  "group_rcks_table_of_content" => array:19 [▼
    "field_rcks_special_comments" => array:2 [▶]
    "display_field_copy:node-rcks_spec_systems_toc" => array:16 [▶]
    "display_field_copy:node-rcks_data_sheets_toc" => array:16 [▶]
    "field_rcks_add_maintenance_guide" => array:18 [▶]
    "#attached" => array:1 [▶]

In my case copy fields are under a field group:
{{ ds_content['group_rcks_table_of_content']['display_field_copy:node-rcks_spec_systems_toc'] }}

I take it back - patch is complete and was ported to an MR. Thank you @diegopino for your contribution!

MR is good for review.

The patch is incomplete:

- example of config for field copy:

id: spec_id_copy
label: 'Spec ID copy'
ui_limit: 'some_content_type|*'
type: display_field_copy
type_label: 'Copy field'
entities:
  node: node
properties:
  field_id: node.some_content_type.field_specification_id

- use example from DS on how to define schema for a field ./ds/config/schema/ds.field.schema.yml

patch #10 ported to MR
very rough implementation

#10 patch doesn't apply to v2

jannakha → made their first commit to this issue’s fork.

Drupal 7 reached EOL.

tested - all good.
pipeline is green.

thanks for your contribution.

good to go!

is that still an issue?
please provide more details:
- Drupal version
- php version
- can you provide screenshots?
- steps to reproduce?

Copied field are displayed in "Disabled" fields on all custom Display View modes.

Can you please check that the copied fields belong to a correct content type?

here's config of a field:
https://www.drupal.org/files/issues/2025-07-29/config-copy-field.png →

Code needs to be reviewed by someone who has not committed to MR.

This issue has to be tested as well.

jannakha → created an issue.

Drupal 7 has reached its official end of life