🇦🇺Australia @jannakha

@Edde20

what's in the #8 patch?
does the issue require re-testing?
please set status of the issue to "needs review" and add some description to what's in the patch.

updated custom JS event to return data:

$('html').on('addToCartLink.updated', (event, data) => {
  // Cart has been updated, following data is available:
  // data.cart_total_count
  // data.product_title
  // data.quantity_added
  console.log(data);
});

By default commerce_cart template will be updated:

...
<span class="cart-block--summary__count">{{ count_text }}</span>
...

If template has been overwritten and classes don't exit - it will not cause an error.

@agoradesign yeah, need to think about it
I used default Commerce template's classes.

I'll try to see if I can pass all parameters (name of product, total count, etc) to the custom event - so all alterations can be done in own JS to keep config super slim.

patch #13 doesn't apply to D10

the feature makes sense in specific cases:
I've got a generic view with a contextual filter (but it's not a part of user exposed filters) - reset will help users to get back to generic view

is there a module for it?

patch applied, but required * is not visible on tabs (see screenshot):

patch for issue #2969051 works

#124 applied and fixes the issue!
Merci @MacSim !

any other testers?

Check out MR!4
- just add 'use-ajax' class to the link and 'Add to cart' becomes AJAX link (see readme.md in MR)

Optional:
add an event handler in your JS:

$('html').on('addToCartLink.updated', (event) => {
// process updated cart event, eg show a message "Item has been added to your cart!"
});

jannakha → made their first commit to this issue’s fork.

tested, ready for release

tested, ready for release

tested, ready for release

fixed with 4.0.2
https://www.drupal.org/project/bootstrap5/releases/4.0.2 →

resolved by: https://www.drupal.org/project/bootstrap5/issues/3449528 📌 Remove jquery dependency Fixed

patch applies, but doesn't work on D10

field_group_inline_entity_form_entity_form_alter() is not even being hit

testing inline form rendered by commerce

this issue affects some themes, eg Claro or Olivero

MR!55 fixes the issue - tested on D 10.2.7 on Claro and Olivero.

before

after

Why do tests fail?

ready for release
CI issues to be fixed separately

ready for release

yeah! no more jquery!
thanks for the fix and additional testing!
release please!

apaderno → credited jannakha → .

tests pass
CI pass
good job!

well spotted
thanks for the fix

#296693: Restrict access to empty top level administration pages - doesn't solve workflow menu issue

When I click on Workflow - I get access denied (on Drupal 10.2.6):

Patch #14 works and should be included in D10+

+1

please release

patch in #7 works,
please release new version

@deepak5423 thanks for your contribution!

Drupal css lint makes no sense, but ok.

tested

tested

hurray for CI

tests are failing, possibly because of renamed functions:

https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/19/...
Line 44: auto_entitylabel_form_auto_entitylabel_settings_form_alter
Line 60: auto_entitylabel_auto_entitylabel_label_alter

all good

+1 to make this page a view

it's quite hard to filter/sort orders because it's not a view

looks good!

jannakha → created an issue.

please provide screenshots of the issue if issue still persist without jquery UI library/module

outstanding failed CI items are created as separate tasks

new issues are created to fix CI errors

great to have CI!

Looks good!

while you're fixing text - can you please update description (see gitlab MR comments):

`This module allows users with appropriate permissions to add and configure "Scroll up" button. Button allows users to scroll up to the top of the page.`

ready for release!

this MR is good to go.

- set default value for scroll_title in case it's empty
- title should not be hardcoded: `title="scroll_title"`
- you can use Template literals, `title=${scroll_title}`
- use semantic HTML, eg ... (not

d11 ready!

ready for release

ready for release

Reviewed and updated summary and introduction

That's great!
Ready for release!

Look good, thanks for the patch

here's screenshot after patch:

jannakha → created an issue.

all green!

PHPStan is OK

nicely done!

D11 ready!

then why not create new issue for the code that you've just discarded?

all this looks just silly game for some gold stars. good luck.

PHPCS reports this: DI is required on this line:
https://git.drupalcode.org/issue/session_limit-3361326/-/blob/3361326-fi...

I might be a bit confused, but I though the point of git/MR workflow is to review code and comment on other contributors' commits and collaborate, rather than creating new branches/MRs and taking all credit.
But I guess it's not a Drupal way to collaborate.

Re: MR4 updates to text/descriptions were valid, the title of the issue could've been updated to indicate the change since it improvement in the textual descriptions, rather than creating bunch of other tasks to update each line of text line/description of code.

@apaderno - please do not add unrelated to issue fixes into the branch - it makes it really hard to review as it's out of scope of the issue.

@vladimirAus thanks for fixing the repo

+1

this issue might be related to how Commerce builds forms by using inline forms:
- see code in Drupal\commerce_order\Plugin\Commerce\InlineForm CustomerProfile.php "public function buildInlineForm(array $inline_form, FormStateInterface $form_state) ..."
- possibly related issue: https://www.drupal.org/project/commerce/issues/3068063 →

I can't make field_group, conditional_fields and field_states_ui work with Commerce's inline forms either - it's just how inline form renders forms.

I think I can reproduce this behaviour:
- enable drupal/field_group module
- add field group elements (html element, details, etc)

- these elements are not being rendered in the checkout flow (see screenshot)

- these elements are being rendered within order edit for in Commerce (/admin/commerce/orders/1420638/edit) see screenshot

this issue might be related to how Commerce builds forms by using inline forms:
- see code in Drupal\commerce_order\Plugin\Commerce\InlineForm CustomerProfile.php "public function buildInlineForm(array $inline_form, FormStateInterface $form_state) ..."
- possibly related issue: https://www.drupal.org/project/commerce/issues/3068063 →

I also tried to install "Conditional fields" module and show/hide some fields on checkout based on user input (some sort of survey) - but because the form is rendered as inline form - conditional fields are not working (they do work on normal edit form page).

@anybody: any thoughts on how to resolve it?

Merge conflict is because of issue #3445605 →

MR!1 is ready to merge after #3445605 is resolved

ready for D11!
thanks bot!

fixes looks good!
thanks bot!

patch applies, tested: works as expected.
thanks for your contribution!

this patch is invalid and cannot be applied:
patch contains:

--- a/session_limit/config/install/session_limit.settings.yml
+++ b/session_limit/config/install/session_limit.settings.yml

it should be:

--- a/config/install/session_limit.settings.yml
+++ b/config/install/session_limit.settings.yml

Firstly, if you're still creating patches - please follow patch naming convention:
[issue-number]-[comment-number]-[issue-description].patch
it helps to identify which patch belongs to which issue, and the if it's a latest patch on the issue

Secondly, use git workflow. There's an issue with default branch → but it's easily resolved on your issue branch.

Thirdly, patch doesn't apply.

Moving to Needs work.

thanks for the update.
tested and it works.

please release a new version!

jannakha → created an issue.

jannakha → created an issue.

jannakha → changed the visibility of the branch 3445501-script-insert-d10 to hidden.

jannakha → changed the visibility of the branch 3445501-location-of-js to hidden.

implement hook_page_attachments_alter()

$attachments['#attached']['html_head'][] = [
  [
    '#tag' => 'script',
    '#attributes' => [
      'src' => 'https://cdn-cookieyes.com/client_data/XYZ123/script.js',
      'type' => 'text/javascript',
      'id'=>'cookieyes',
    ],
  ],
  'cookieyes',
];

jannakha → created an issue.

since #3445222 - good to merge

thank you smart Bot!

jannakha → created an issue.

@ravi kant thanks for the patch - to speed up review:
since you've already created a patch and setup the environment - can you please provide screenshots of before/after patch application from the browsers: safari/firefox/chrome/edge

some string values are not translated strings?

$value = '<div class ="messages messages--error">Avoid numbers only.</div>';

why not use merge requests? it's easier to review and comment per line

+1

fubarhouse → credited jannakha → .

gargsuchi → credited jannakha → .

MR 246 for review

jannakha → created an issue.

D7 version is no longer under active development
D10+ version has this feature

D7 version is no longer updated
D10+ version has this feature

thanks for patch!

thanks for your work!

hello D10!
good work!

VladimirAus → credited jannakha → .

+1 for #5 comment!
thanks for the tip!

+1

according to comment #20 - needs work

@simohell
what's your configuration of CKEditor or which version of CKEditor 5 you have installed? :
- how is "Press Option 0" help text added? is that a special config? or special module?

the reason I'm asking is that I didn't have that text in my default installation/configuration of CKEditor 5 on Drupal 10 (as you can see in the issue description screenshot - the voiceover text doesn't include keyboard shortcut text).

Maybe temporary solution can be just replacing "Editor editing area: main" with the field label? Looks like "Editor editing area: main" is a constant for simple editor.

*temporary until https://github.com/ckeditor/ckeditor5/issues/15208 is resolved (if you can +1 this issue maybe CKSource will fix it sooner?)

MR !7170

how to test:
on standard installation:
- create new content -> add new article
- CKEditor 5 field should have a "Body ..." text in aria-label and

jannakha → changed the visibility of the branch 3426798-ckeditor5-text-area to hidden.