mPDF Plugin

From what I can understand, the review of the patch(es) is done and ready but it would be better if we can clarify which code from which patch or MR should be the one to further check. Can we all agree to go on with #18 🐛 mPDF Plugin Needs review ?

@vensires Yes, #18 is the one to go with.

Redwan Jamous → changed the visibility of the branch 3063998-mpdf-plugin to hidden.

Thank you Redwan for the clarification and for your work!
So, based on the comment of @neelam.chaudhary we can set this as RTBC.

Sorry, I take it back! It seems we now have two "Paper Orientation" fields on the configuration form.
One is the "default_paper_orientation" coming from the parent::buildConfigurationForm(), whereas the other one is coming from the patch.

Fixed the issue with the two orientation fields in the new MR.
Also attaching diff from MR as patch.

Thanks @vensires!

While your patch removes the extra field, it doesn't actually apply the selected orientation because we're passing it to Mpdf under the key "default_page_orientation", while Mpdf expects it to be "orientation".

Updated the MR to fix this.
Adding a patch to use with composer...

I think we need one more review on this.

Thanks for your feedback @redwan-jamous. You are right!
I am setting this as RTBC.