Patch in #5 works great. I'm setting this as RTBC!
Extra things done:
- Updated the MR to match its changes
- Changed the info.yml file since according to
the documentation →
the core/once is not available before 9.2.0; this means the new version won't support Drupal 8.8.
Also attaching patch from latest MR diff.
vensires → made their first commit to this issue’s fork.
I opened the two MRs in order to better understand the changes proposed in each one.
It seems that MR!13 is actually in WIP state.
MR!12 on the other hand seems to be the one we should go on with.
(@chrisachrist Don't hesitate to correct me if I'm wrong though)
I still have to validate that MR!12 is really working..
When we first stepped on this issue, we couldn't find out why this is needed since the functionality exists in core. I edit the summary to clarify things for other people too...
Corrected the description of the OpenModalDialogCommand class.
I personally think that this last comment is not related to the issue tackled here unfortunately.
Your issue seems to be that the there are still paragraph entities having as parent ID your host entity which - from a query perspective - is correct. Maybe your solutions lies on the functionality of paragraphs to remove orphaned paragraphs.
I have created a new MR with the changes from
#3431221-3: allow form elements to override Chosen library options →
but for 4.0.x-dev version.
No further changes exist in my code.
PS: It seems that the tests are failing but I am not sure if they break due to this code or if they were already broken from the past; in the later case we should handle them in a different issue.
vensires → created an issue.
@thanos-ntelis what's the status of this MR? I still see some TODO comments in the code.
vensires → changed the visibility of the branch 3444143-change-webservice-urls to active.
vensires → changed the visibility of the branch 3444143-change-webservice-urls to hidden.
vensires → created an issue.
Is this still valid or is this outdated?
Keeping it as RTBC but, are we sure a composer.lock file should exist?
lauriii → credited vensires → .
From what I checked it seems the changes should break anything in older versions.
vensires → made their first commit to this issue’s fork.
Thanks you for your time on this. Setting as RTBC then, based on your feedback.
I updated the MR13 to better understand the changes from the patch. Needs further testing and review if we are going to use it instead of the patch; just to be sure I did the rebase correctly.
As for the patch provided in
#15
🐛
Take the selected filters into account, support multiselect filters and make 'delete all' text translatable
Needs review
only the {{ options.reset_link.title|t }} troubles me. Can't we avoid it using configuration translation?
So we can hide the other MRs and only keep the MR162 as relevant and working though it's currently marked as draft?
I totally agree that we shouldn't go on with any changes in the code. Just document. And your MR succeeds in this.
So, I set it as RTBC ;)
It's a really small but working change, so if no one else has any objection, I set it as RTBC.
I personally think that if we moved this functionality away, it will be like we deprecate it since it's been here for years and developers expect it to exist by default with the Field Group module.
Unless you do want to deprecate it; that's another discussion...
Link to the slack discussions of that day: https://drupal-el.slack.com/archives/C01GLEXA7DK/p1712747499422099.
vensires → created an issue.
Works fine for me! Setting as RTBC!
Seems fine and working. Setting as RTBC.
Added as default layout plugin "layout_twocol" which is also the one used in tests in core Layout Builder module
I have created all the different issues described as children-issues of this meta.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
Nice catch! Just changed. Will change the other issues too. Thanks for the remark!
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
vensires → created an issue.
Added information that even though maintainers may have decided against Mpdf support, there is currently an issue to add it back which is stable enough for anyone who needs it: https://www.drupal.org/project/entity_print/issues/3063998 🐛 mPDF Plugin Needs review .