Account created on 19 May 2010, almost 14 years ago
#

Merge Requests

More

Recent comments

🇬🇷Greece vensires

I updated the MR13 to better understand the changes from the patch. Needs further testing and review if we are going to use it instead of the patch; just to be sure I did the rebase correctly.

As for the patch provided in #15 🐛 Take the selected filters into account, support multiselect filters and make 'delete all' text translatable Needs review only the {{ options.reset_link.title|t }} troubles me. Can't we avoid it using configuration translation?

🇬🇷Greece vensires

So we can hide the other MRs and only keep the MR162 as relevant and working though it's currently marked as draft?

🇬🇷Greece vensires

I totally agree that we shouldn't go on with any changes in the code. Just document. And your MR succeeds in this.
So, I set it as RTBC ;)

🇬🇷Greece vensires

It's a really small but working change, so if no one else has any objection, I set it as RTBC.

🇬🇷Greece vensires

I personally think that if we moved this functionality away, it will be like we deprecate it since it's been here for years and developers expect it to exist by default with the Field Group module.

Unless you do want to deprecate it; that's another discussion...

🇬🇷Greece vensires

Added as default layout plugin "layout_twocol" which is also the one used in tests in core Layout Builder module

🇬🇷Greece vensires

I have created all the different issues described as children-issues of this meta.

🇬🇷Greece vensires

Nice catch! Just changed. Will change the other issues too. Thanks for the remark!

🇬🇷Greece vensires

Added information that even though maintainers may have decided against Mpdf support, there is currently an issue to add it back which is stable enough for anyone who needs it: https://www.drupal.org/project/entity_print/issues/3063998 🐛 mPDF Plugin Needs review .

🇬🇷Greece vensires

Fixed the issue with the two orientation fields in the new MR.
Also attaching diff from MR as patch.

🇬🇷Greece vensires

Sorry, I take it back! It seems we now have two "Paper Orientation" fields on the configuration form.
One is the "default_paper_orientation" coming from the parent::buildConfigurationForm(), whereas the other one is coming from the patch.

🇬🇷Greece vensires

Thank you Redwan for the clarification and for your work!
So, based on the comment of @neelam.chaudhary we can set this as RTBC.

🇬🇷Greece vensires

From what I can understand, the review of the patch(es) is done and ready but it would be better if we can clarify which code from which patch or MR should be the one to further check. Can we all agree to go on with #18 🐛 mPDF Plugin Needs review ?

🇬🇷Greece vensires

Hello @ckrina,
if everything goes well we will meet you in DrupalCon Barcelona :)

Yes, on April 10th we have the GreeceSpringSprint2024 event. If you have anything you want for us to tackle, gladly! I also worked on this module in the Contribution Day in DrupalCon Lille, so I know the hard work you are doing! Don't hesitate to contact me for anything you might need!

🇬🇷Greece vensires

Thanks for the information!
I will update the description of the module too!

Production build https://api.contrib.social 0.62.1