🇬🇷Greece @vensires

Hm... Back to Needs work then...

Thank you for your work on this. Merged!

@axioteo I checked your code and seems to be correct. We already only support Drupal versions greater than 10.2 though, so we don't actually need the compatibility layer. I have done the required change in MR. Uploading patch too.

Please validate it's working as expected and I will gladly generate a new release immediately afterwards.

vensires → made their first commit to this issue’s fork.

vensires → created an issue.

For a website of ours, I use this fulltext facet filter to search for keywords. The client asked that whether user searches for "foo bar" or "bar foo" the returned result should be the same. I tried playing around tampering the query using proper Search API Events but instead fell back on changing the original patch from this issue's MR (attached) so that the 'LIKE' operator uses multiple conditions instead using AND.

I'm sharing this here too in case we would like a different approach for this or propose a different operator... Maybe...

if ($operator === 'LIKE') {
  $or_condition_group = $this->query->createConditionGroup('AND');
  $tokens = preg_split('/\s+/', trim($this->fulltext->getSearch()), -1, PREG_SPLIT_NO_EMPTY);
  foreach ($tokens as $token) {
    $or_condition_group->addCondition($this->facet->getFieldIdentifier(), $token);
   }
   $this->query->addConditionGroup($or_condition_group);
}

vensires → created an issue.

poker10 → credited vensires → .

poker10 → credited vensires → .

vensires → created an issue.

vensires → created an issue.

vensires → created an issue.

vensires → created an issue. See original summary → .

vensires → created an issue. See original summary → .

Thank you @danrod! I see you haven't added the following line of code in the MR though. Is it intentional?

\Drupal::service('page_cache_kill_switch')->trigger();

Since you provided the patch, I set it as Needs Review for someone else to approve this and set it as RTBC.
Can you also update the MR with the changes?

Based on the previous two comments, I would take the chance to set it as RTBC but... Has anyone else experienced the I had to click on "Save configuration" twice for some reason issue described previously by @danrod?

The tricky part here is that the dl isn't a button in the editor; so no one actually knows it's there, unless you use the plaintext editor. I also checked other documentation pages like Access Policy API → and it seems you are correct. I vote +1 for this change.

PS: Might you want to ask this on slack in a broader community? Though I think it's a decent choice to change this as you proposed.

vensires → created an issue.

I closed the MR so that anyone willing to tackle this issue may start the process from the very beginning.
To be honest though, I did try to find the comment described in the issue summary but couldn't find it at all in the code. Maybe something is off here or was it just me?

vensires → made their first commit to this issue’s fork.

No, I didn't test it to be honest. It seemed like a small change. Did you review my solution yourself?

The original patch had set the return value in the catch{} block and it's actually working. My suggestion in the MR is to instead have it at the end of the function. It seems more clear to me.

@drupaldope thank you for the clarification! I set it as Needs Review then!

The my menu--navbar.html.twig file phrase in #3 confused me; I'm changing this to a support request.
Feel free to revert my change in case I was mistaken.

MR should fix the issue.

vensires → created an issue.

@wotnak, if you don't have any further issues with the MR, you might also consider mentioning either the vite plugin or just this issue in the module's project page description. I see you already have a link to the README.md file; it might just be a bit more fancy - maybe adding another "note-tip" CSS class. Whatever you decide though.

I have fixed the issue in the MR.
I also took the initiative to change the string used so that it says (minimal) and not (minimal-) if the version is missing. I think it's never actually translated so I won't introduce any further issues with this change.

I suspect it was to be set as "Reviewed & tested by the community" but the user misclicked. I set it as Needs Review for now and anyone is free to check the patch and either review it or create a MR based on it with any possible corrections.

@drupaldope, it's not clear to me whether the issue is resolved with your patch or whether the whole issue was a false report.
Could you please clarify?

So, @giannisMak do we need a new MR for this to fit what @saurav-drupal-dev described in #13?

the css should come inside toolbar file because we cannot access dropdown without the admin toolbar

@axioteo, feel free to update README.md with the correct details on how to fix this issue, either using your plugin either without it (if possible).

After this is resolved, we might open another issue to suggest the change of the description of the module if required by @wotnak.

@smustgrave, I think that the points already addressed by @theodorosploumis in #6 is the answer you are looking for:

1) Consistency, as mentioned on the issue title.
2) Performance. Mini pager is less heavy than the full pager.
3) Usability. Media are usually attached to Nodes. So navigating to the first or last item is not something really important.

Feel free to express your objection on the previous points though.

I leave this as Needs Work because I'm not 100% sure the patch and the MR are in accordance.

Added Greek Community digital presence info.

Since this issue is related directly to the navigation module of the Drupal core and not the menu links in general, I think it's well set as postponed, yes.

I add 📌 Plugin config: Delete entity along with GroupContent Needs review as a related issue due to the following comments in code:

1. GroupRelationship::preSave()(L.259-264)
   

   // We want to make sure that the entity we just added to the group behaves
   // as a grouped entity. This means we may need to update access records,
   // flush some caches containing the entity or perform other operations we
   // cannot possibly know about. Lucky for us, all of that behavior usually
   // happens when saving an entity so let's re-save the added entity.
   $this->getEntity()->save();
   

2. GroupRelationship::postDelete()(L.295-301)
   

   // For the same reasons we re-save entities that are added to a group,
   // we need to re-save entities that were removed from one. See
   // ::postSave(). We only save the entity if it still exists to avoid
   // trying to save an entity that just got deleted and triggered the
   // deletion of its relationship entities.
   // @todo Revisit when https://www.drupal.org/node/2754399 lands.
   $entity->save();
   

Created new MR based on 11.x. Uploading a patch for this too.

For tests, don't count on me unfortunately.

I have updated the issue summary.

It seems my previous code didn't work. I have changed the query to a formula in order to be able to check whether the comment_count has a non-zero value and act accordingly.

I have created a MR and also attach the diff as a patch for anyone needing this.

It actually seems like the "comment_last_timestamp" view field is a copy of the comment_count field with a different PHP attribute name.

So far, we have hook_requirements() - which can be bypassed if you use -y in drush, and composer's which may or may not be used for custom modules. My question remains: let's say we have a conflict in *.info.yml; is it there for informational reasons or should it 100% prohibit the coexistence of the module without any bypass?

@mschudders I fixed the MR.

The main question here is what's the action expected when a conflict is found. Depending on what we want the action to be, just by using hook_requirements() we might be ok.

We also faced the same error after updating the module to the latest version. In our case the issue was related to a "entity_type.manager" key because it has a dot (".") though we couldn't anywhere find this entry in the YML files. Decided to roll back to 1.9 for now.

In case it helps, the message returned is coming from ConfigBase::validateKeys.

Thank you for the test @danrod. I can't personally understand why the double submission or the clear cache is required; I really think it's RTBC but let's keep it under "Needs Review" for a while more.

I don't doubt you but is does seem strange to me... It's just a simple maxlength attribute change. I also checked the schema.yml just in case and there isn't anything related in there either. Something is escaping us...
Setting this to "Needs work" until we find this and fix this.

@danrod, based on the change of the MR or the patch in #13, I can't guess why a reinstallation of the module would be required. A cache clear wouldn't suffice?

I know what you're talking about. To clarify things though, the maintainer @davereid replied on #3437974-27: Drupal 10.3 ImageStyleDownloadController::deliver signature change → the following:

Aside from that, whatever the rest of the community decides.

Also uploading the latest diff from the MR as patch.

Thank you @berdir for the update. I wasn't aware of the deprecation change. In my latest commit I transferred the hook implementations to the main module file as a first step short-term fix.

Next thing to do is to follow the guidelines and add the [#LegacyHook] attribute. If anyone else tries to address it, this article by dev.to might be helpful.

I fixed the PHPCS issues. There are still some PHPSTAN issues but I'm not sure they are related to this issue's code.
I also upload the latest patch based on the MR.