- Issue created by @connbi
- Status changed to Needs review
9 months ago 9:37am 28 March 2024 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
9 months ago Waiting for branch to pass - Assigned to azacharop
- Issue was unassigned.
- Status changed to RTBC
9 months ago 1:42pm 10 April 2024 The last submitted patch, 3: 3436637.patch, failed testing. View results →
- 🇬🇷Greece giannis makantasis
While patch seems to fix the issue
The CSS that is getting ovewritten comes from claro's css
/core/themes/claro/css/state/toolbar.menu.css :".toolbar .toolbar-tray .menu-item--active-trail > .toolbar-box a,
.toolbar .toolbar-tray a.is-active {
color: #000;
background-color: #f5f5f5;
font-weight: bold;
}"The patch suggested css for the /modules/contrib/admin_toolbar/css/admin.toolbar.css :
.toolbar .toolbar-tray .menu-item--active-trail > .toolbar-box a,
.toolbar .toolbar-tray a.is-active {
color: #000;
background-color: unset;
font-weight: bold;
}while the only needed rule would be the unset of background color, I am not sure if it should be added on Claro's css or in Admin Toolbar's css.
@giannis makantasis the css should come inside toolbar file because we cannot access dropdown without the admin toolbar. but i am unable to reproduce the issue.
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
- 🇬🇷Greece giannis makantasis
@saurav-drupal-dev In order to reproduce the issue let me give you en example.
If you go Configuration-> Development page, and then you hover on Configuration , the Menu item "Development" will now be bold and underlined but its arrow will be hidden even though Development has more "Children Links".
This happens because in
this file (Claro) public_html/core/themes/claro/css/state/toolbar.menu.css ,there is this css rule:
.toolbar .toolbar-tray .menu-item--active-trail > .toolbar-box a,
.toolbar .toolbar-tray a.is-active {
color: #000;
background-color: #f5f5f5;
font-weight: bold;
}So the background of the a.is-active is covering the background of li.menu-item--expanded (that has that blue arrow)