Thanks a lot Joseph (@joseph.olstad) for getting this in and creating and new release!
Cheers!
Considered the 3 following possible solutions:
1 - Casting an array on the first argument:
return array_intersect_key((array) $this->paymentMethodTypes, array_flip($this->configuration['payment_method_types']));
2 - Using the null coalescing operator to pass an empty array as the first argument:
return array_intersect_key($this->paymentMethodTypes ?? [], array_flip($this->configuration['payment_method_types']));
3 - Initializing the property to an empty array, which was the chosen solution, see MR!405.
Thanks in advance for your feedback and reviews!
dydave β created an issue.
Thanks a lot for the feedback!
Glad to see some interest in this issue!
#17: All branches and MRs were hidden except MR!9, which seems to have been tested and received some comments at #15.
#14: Indeed Andriy (@andriy khomych), this initial MR is pretty basic and needs more work to support more complex configuration types, such as mappings and nested settings.
I was debugging the initial MR while working with the Linkchecker module, which only has flat configuration settings, without any nested settings or more complex configuration types.... and it worked fine (see #13).
Supporting nested config types would most likely require more work:
Could you maybe recommend a "simple" contrib module with nested config types that could maybe used for the initial development?
Otherwise, for tests, we should be able to create a test module with various types of configuration items (including nested), with a view to the test the module and write the Functional test cases to check the page view displays the data as we would expect (Checking the different lines, values, etc...).
Any help, advice, comments, feedback or contributions would be greatly appreciated.
Thanks in advance!
dydave β changed the visibility of the branch 3178099-how-can-i to hidden.
dydave β changed the visibility of the branch 2.0.x to hidden.
Super nice reply as usual Conrad (@cmlara)!
Thanks a lot for your help cleaning up the IS and for providing additional links so we could potentially port/copy some of the fixes that were applied to the 3.x branch.
Whenever I get some time or most likely, as we're nearing a site upgrade, I'd certainly be very happy to contribute to a merge request in this ticket.
Thanks again for all the great work and fantastic maintenance on the module!
Cheers!
dydave β created an issue.
Would be great if compatibility with Drupal 11 could be added!
Thanks in advance!
dydave β created an issue.
Could somebody please take a look at the merge request MR!6 above at #5?
Thanks in advance!
dydave β changed the visibility of the branch project-update-bot-only to hidden.
dydave β made their first commit to this issueβs fork.
Could this get merged please?
The changes from MR!10 above at #6 look "legit" π
Would be great if someone with write access could take a look at this soon!
Thanks!
dydave β changed the visibility of the branch 3430612-automated-drupal-11 to hidden.
Thanks a lot Pamela (@pameeela) for the very prompt and complete reply, it's greatly appreciated!
Sounds good!
No problem, that's something that could probably be done on a project basis.
Thanks!
Closing in favor of π Can't Browse Projects Active
Adding screenshot of Event Form display configuration with Field Groups using Horizontal Tabs:
/admin/structure/types/manage/event/form-display
dydave β created an issue.
Getting this as well after a fresh install from a git pull (Dries install notes).
Thanks everyone!
Great contrib organization and very productive discussions.
Looking forward to the next sprints.
Cheers!
nicoloye β credited dydave β .
As per #62:
We're going with MR!10896 from #54 for now, so the other MR was hidden.
Still remaining to do if anyone has time to work on this issue: Write tests.
Create an automated test case allowing to reproduce the issue.
This would allow to better describe and summarize the IS, in particular with steps to reproduce or a piece of code that currently results in the Exception.
Elim (@elimw) perhaps if you find some time, it would be great if you could look into this and see if you could put together a small piece of code that could reproduce the exception (could be executed in devel_php, for example).
We could use it in an automated Test class added to the MR and then also document it in the IS.
Any help, advice or feedback would be greatly appreciated.
Thanks in advance!
dydave β changed the visibility of the branch 2920527-postgres-driver-issue to hidden.
Cool!! Sounds good!
I'm going to take a look around, ask a few colleagues as well and report back when I have more tangible elements.
Cheers!
Thanks Andrey!
So this ticket is a Won't fix?
Or to be moved with external lib in contrib?
Any recommendations on what to do with this ticket? How to move it forward?
Thanks Andrey (@andypost)!
Found the corresponding CR: core/jquery.form library deprecated β as of 9.4.0
Found the internal.jquery.form
library:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/core.librarie...
Is the jQuery.form uploadProgress
getting removed from Core in D11?
Any suggestions on the changes that would be needed ?
Thanks in advance!
Initial attempt at reformatting issue summary with standard template.
Issue summary needs help filling a few sections in particular:
- Remaining tasks
- User interface changes
- API changes
dydave β changed the visibility of the branch 9.5.x to hidden.
dydave β changed the visibility of the branch 2833968-upload-progress-using to hidden.
Thanks @roderik!
I was working on the following issue
π
Add module configuration schema file
Active
and while debugging the config_object I was trying the type 'route' for :
https://git.drupalcode.org/project/login_switch/-/merge_requests/4/diffs...
So in other words, for example:
register_route:
type: route
label: 'Enter a route to replace user/register route'
If you try using the type route
for example, the error should appear immediately and the page /admin/reports/config-inspector
crash.
Hope this will help reproducing the issue.
Let us know if there is anything else we could do to help.
Thanks in advance!
@mradcliffe: Both merge requests have been rebased.
Issue summary still needs to be updated.
Thanks!
Added initial module schema file in merge request MR!4 above at #2.
The config type path
used for the routes fields, is inspired from Drupal core system.schema.yml for the 403 and 404 pages path fields, defined on the basic site settings form, see:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...
without any specific validation constraints or rules.
See the result with config_inspector:
Details:
Any reviews and feedback would be greatly appreciated.
Thanks in advance!
dydave β created an issue.
Just encountered the same error while testing on 10.4.1 with standard profile on a fresh install.
I then disabled a custom module I was debugging and the page displayed fine again.
Perhaps the exception could be gracefully handled instead of crashing with the error mentioned in the IS ?
Otherwise this issue doesn't seem to be preventing from using the module properly and doesn't seem to come from the module itself, thus lowering the priority to normal.
Thanks in advance!
Thanks a lot Elim (@elimw)! Great job!
We've just given a round of tests with the merge request you created MR!10896 and it fixed the issue as well for us π₯³
We've updated the patch in our project to use the one from #54.
@vistree:
Yes indeed, the patch created by Elim can be tested here:
https://git.drupalcode.org/project/drupal/-/merge_requests/10896.diff
It should fix the issue in your project as well.
It's a different (better) way of writing the same thing as the previous patch.
Thanks again for the work Elim and in advance for your feedback @vistree!
PHPCS and previous major issues addressed in π Fix automated tests Active .
Once again, thanks a lot for your help on this issue @ressa!
Bumping to Major as this is breaking tests for a lot of merge requests in pending tickets.
Tests are passing with warnings:
https://git.drupalcode.org/issue/admin_toolbar-3494654/-/pipelines/392909
Thanks in advance for your reviews and feedback!
dydave β made their first commit to this issueβs fork.
Thanks everyone and sorry for the delay on this!
Thanks a lot @osopolar:
It seems that the fix got committed with the related issue π [AdminToolbarSettingsForm] Fix Fatal Error: Call to undefined method Drupal\Core\Menu\MenuLinkManager::invalidateAll() Fixed , see also https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/94/diffs
Indeed, it seems the fix for the AdminToolbarToolsSettingsForm
got committed without an associated Functional test.
The merge request has been updated to add a new test file for the AdminToolbarToolsSettingsForm
.
The test doesn't do much at this stage, but at least it ensures the form could be saved with its default values
==> It would therefore prevent crashes on the settings form pages, such as the ones reported in this ticket and fixed in the other MR.
Fixed PHPCS errors in admin_toolbar_tools/src/Controller/ToolbarController.php
to allow the MR to pass, but should probably be addressed in other tickets (?!).
Watchout: The tests for previous major had to be disabled for MR!96 to pass.
The errors reported in the build seemed to be related with other issues or files that are not modified in the MR, see:
https://git.drupalcode.org/issue/admin_toolbar-3466743/-/jobs/3984130#L52
Therefore, this change should probably be reverted once the tests issues are fixed, probably in other tickets.
It would be great to see this MR getting merged and more Functional tests being added!
Any feedback, comments or reviews would be greatly appreciated!
Thanks in advance!
Sorry for the delay on the follow-up:
Created a new MR for branch 11.x above at #78 based on the latest patch at #74.
It seems to work nicely with D11.x-dev, see the screenshot below:
Back to Needs review.
Thanks in advance for your reviews and feedback!
dydave β changed the visibility of the branch 3452852-autowire-trait-plugins-rebase to hidden.
dydave β made their first commit to this issueβs fork.
Thanks a lot @vistree for the feedback! Glad it's working for you π₯³
Hopefully we'll get more reviews, feedback and perhaps a better version of the patch (see #51/refactoring), but for now, hopefully, this version will allow all of us to keep moving forward on our projects!
Cheers!
Thanks Elim (@elimw), re #48:
Rather than having to explicitly check if we should wrap a query in a savepoint before calling "Connection::addSavepoint()", wouldn't it be better to do the check inside of "Connection::addSavepoint()" instead?
Sounds good! I'm not super familiar with the overall code of the pgsql
module, but if you do a quick search around and see where the functions are used and if there would be any unexpected impacts, it would be great!
Could you perhaps create a new merge request with a different patch?
We would be able to give the patch a round of tests and see if it could be equivalent to the current MR!10859.
Thanks in advance!
Nice one @vistree!
I am still on Drupal 10.4 by the way!! Therefor patch https://git.drupalcode.org/project/drupal/-/merge_requests/10859.diff will not apply.
Just did the test with D10.4.1 and the patch applies very well.
Additionally, looking at your stack trace, see:
#3 /data/html/docroot/core/modules/pgsql/src/Driver/Database/pgsql/Upsert.php(35): Drupal\pgsql\Driver\Database\pgsql\Schema->queryTableInformation()
Same as pointed above at #45.
Therefore: The patch should apply and fix the issue for your project! \o/
Could you please do a quick round of test and report back?
Thanks in advance!
Thanks for the prompt feedback @vistree:
is your MR expected to also solve the error on
Drupal\Core\Database\TransactionNameNonUniqueException
mentioned in #36 and #43?
Really not sure about that, since we haven't come across this particular error.
Could you please try providing a backtrace, similar to the one above at #45.
Otherwise, perhaps more straight forward: Give the patch at:
https://git.drupalcode.org/project/drupal/-/merge_requests/10859.diff
a quick test and see if it fixes the issue in you project?
Thanks Matthew (@mradcliffe) for the help reviewing and cleaning up the MR.
Cheers!
Thanks a lot Jake (@jakegibs617) for the contributed patch above at #37, the great documentation of the issue and getting the ball rolling with this patch.
I've tried to mention your work as much as possible in the MR to associate the credit.
Quick follow-up:
Created initial merge request above at #44:
1 - Rolled in patch from #37
2 - Added additional fix based on stack trace:
Drupal\Core\Entity\EntityStorageException: A transaction named mimic_implicit_commit is already in use. Active stack: 677ffe0d432d66.20858170\drupal_transaction > 677ffe0d4c76f6.93298422\mimic_implicit_commit in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\pgsql\Driver\Database\pgsql\Connection->startTransaction('mimic_implicit_commit') (Line: 429)
Drupal\pgsql\Driver\Database\pgsql\Connection->addSavepoint() (Line: 149)
Drupal\pgsql\Driver\Database\pgsql\Schema->queryTableInformation('cache_flexible_permissions') (Line: 35)
Drupal\pgsql\Driver\Database\pgsql\Upsert->execute() (Line: 312)
Drupal\Core\Cache\DatabaseBackend->doSetMultiple(Array) (Line: 227)
Drupal\Core\Cache\DatabaseBackend->setMultiple(Array) (Line: 211)
Drupal\Core\Cache\DatabaseBackend->set('flexible_permissions:outsider:[user.roles]=authenticated', Object, -1, Array) (Line: 136)
Drupal\Core\Cache\VariationCache->set(Array, Object, Object, Object) (Line: 172)
Drupal\flexible_permissions\ChainPermissionCalculator->calculatePermissions(Object, 'outsider') (Line: 39)
Drupal\group\Access\GroupPermissionCalculator->calculateFullPermissions(Object) (Line: 40)
Drupal\group\QueryAccess\GroupQueryAlter->doAlter('view') (Line: 143)
Drupal\group\QueryAccess\QueryAlterBase->alter(Object, Object) (Line: 333)
group_query_entity_query_alter(Object, NULL, NULL) (Line: 552)
Drupal\Core\Extension\ModuleHandler->alter('query', Object) (Line: 494)
Drupal\Core\Database\Query\Select->preExecute() (Line: 519)
Drupal\Core\Database\Query\Select->execute() (Line: 157)
Drupal\pgsql\Driver\Database\pgsql\Select->execute() (Line: 272)
Drupal\Core\Entity\Query\Sql\Query->result() (Line: 85)
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 391)
Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection->validateReferenceableEntities(Array) (Line: 133)
Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator->validate(Object, Object) (Line: 202)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateConstraints(Object, '0000000000000e150000000000000000', Array) (Line: 154)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode(Object) (Line: 164)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode(Object, Array, 1) (Line: 106)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validate(Object, NULL, NULL) (Line: 93)
Drupal\Core\TypedData\Validation\RecursiveValidator->validate(Object) (Line: 132)
Drupal\Core\TypedData\TypedData->validate() (Line: 518)
Drupal\Core\Entity\ContentEntityBase->validate() (Line: 25)
Drupal\group\Entity\GroupMembership->preSave(Object) (Line: 528)
Drupal\Core\Entity\EntityStorageBase->doPreSave(Object) (Line: 753)
Drupal\Core\Entity\ContentEntityStorageBase->doPreSave(Object) (Line: 483)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 806)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 147)
Drupal\group\Entity\Group->addRelationship(Object, 'group_membership', Array) (Line: 183)
Drupal\group\Entity\Group->addMember(Object) (Line: 214)
Drupal\CUSTOM->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('free_trial_checkout_form', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Mostly :
Drupal\pgsql\Driver\Database\pgsql\Schema->queryTableInformation('cache_flexible_permissions') (Line: 35)
Tested and fixed issue in our project (similar versions mentioned above at #41) \o/
==> It probably still needs work, testing, but for now it fixes the issue in our project and allows us to move forward.
Any reviews and feedback would be greatly appreciated.
Thanks in advance!
dydave β made their first commit to this issueβs fork.
Thanks a lot Matthew (@drupalmatts)!
Super nice!
Also if you'd like to take a quick look, I've taken an initial stab at getting the module integrated with Gitlab CI in
π
Automated testing: Configure GitLab CI
Active
but haven't had the time to create a complete merge request.
Current changes :
https://git.drupalcode.org/issue/login_switch-3497745/-/compare/8.x-2.x....
But I'm still getting failing pipelines :
https://git.drupalcode.org/issue/login_switch-3497745/-/pipelines
A bit more work needed on fixing the tests: Currently it's blocked on the fact there are no assertions in the tests π
https://git.drupalcode.org/issue/login_switch-3497745/-/jobs/3917671#L77
(and missing schema file)
I'll try to help whenever I get some time.
Feel free to let us know if there is anything we could do to help.
Thanks in advance!
dydave β created an issue.
Dropped support for versions below 10.2, in which was introduced: Symfony autoconfiguration is available for event subscribers β .
dydave β made their first commit to this issueβs fork.
Thanks Lucas! (@heddn)
Chatted w/ @nickdickinsonwilde today in Slack. See https://drupal.slack.com/archives/C1BMUQ9U6/p1733936073358429. This will likely get marked won't fixed in the next few days. Feel free to remove the module from your install and use Drupal core's aggregation directly.
Are you saying the module is getting deprecated and could be removed as of D11?
Did the module's features get integrated into D11 Core?
Is there any recommended documentation on how to switch over module's configuration to Core's?
Any help would be greatly appreciated!
Thanks in advance!
The changes suggested in this ticket's merge request are the same as for:
π
Compatibility with Better Exposed Filters 7
RTBC
but less complete, thus closing in its favor.
Let's combine our efforts on
π
Compatibility with Better Exposed Filters 7
RTBC
.
Thanks in advance!
Thanks @torfj for the feedback!
Maybe you could try using the 2.0.x-dev version:
https://www.drupal.org/project/collapse_text/releases/2.0.x-dev β
until a stable release is created?
Hope that helps!
Thanks a lot @artyom hovasapyan for creating this issue and providing some basic details.
Could this be related to
π
Get the translated field value
Active
, where a patch was contributed?
Could you maybe try testing the patch and see if it could fix the problem?
Otherwise, unfortunately, I was unable to reproduce the issue with the steps described in the issue summary.
Does the problem happen when using the formatter with Views?
I 'm not really sure I understand completely the steps you suggested to reproduce the issue, could you perhaps provide additional details?
(maybe export some config to add to the ticket)
I tried using the Image Link Formatter with a translated content type (node) with a full view (default) standard display and it seemed to work as expected.
Could you please provide more information on how the problem could be reproduced?
Any questions, comments or feedback would be greatly appreciated.
Thanks in advance!
Thanks a lot Andrew (@mortona2k) for your contribution and help keeping the module maintained.
Please note this issue only affects Core versions above 10.3 with the introduction of:
Stricter validation for config schema types is available β
.
See similar issues :
- π Validate config Active
- π Webform's default editor violates config schema validation Active
- π Incorrect "missing schema" error for widget settings, if widget has the same id as formatter / field type Active
- π Module is missing a config schema for validation Needs work
Merge request MR!7 was merged above at #9, with the basic functional tests passing for all supported versions.
At this point, since all the work to be carried in this ticket should have been completed, marking it as Fixed for now.
Feel free to let us know if you have any questions or concerns on any of the changes in this ticket or the project in general, we would surely be glad to help.
Thanks in advance !
dydave β made their first commit to this issueβs fork.
Added a basic Functional test class CollapseTextFormatSettingsFormTest
which opens the Filtered HTML text format settings form and enables the Collapse Text filter by submitting the form.
This test was mostly added for π Fix missing schema Active to ensure the problem introduced in versions above 10.3, could be fixed by the changes suggested in the ticket.
For the tests to pass until the related issue is fixed, the Gitlab CI file of the module had to be modified to force testing by default for versions lower than 10.3, so currently 10.2.x-dev
.
Thanks in advance for your feedback!
dydave β created an issue.
The LICENSE.TXT file was removed from the code base at #5.
It should be automatically added to the next releases by Drupal.org packaging scripts.
This issue can ben considered Fixed.
dydave β created an issue.
dydave β made their first commit to this issueβs fork.
Thanks Justin (@keiserjb) for your help on this.
I've tested the issue fork and encountered probably the same error as you:
PHP Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class Drupal\view_mode_page\PathProcessor\DynamicPathProcessor does not have a method "setContainer" in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:276
Full error with stacktrace:
$ drush cr
PHP Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class Drupal\view_mode_page\PathProcessor\DynamicPathProcessor does not have a method "setContainer" in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:276
Stack trace:
#0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(276): call_user_func_array()
#1 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#2 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#3 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#4 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#5 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#6 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#7 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#8 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#9 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#10 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(445): Drupal\Component\DependencyInjection\Container->createService()
#11 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#12 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#13 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#14 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#15 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#16 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#17 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#18 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#19 /var/www/html/web/core/lib/Drupal.php(197): Drupal\Component\DependencyInjection\Container->get()
#20 /var/www/html/web/core/includes/common.inc(423): Drupal::service()
#21 /var/www/html/web/core/includes/utility.inc(41): drupal_flush_all_caches()
#22 /var/www/html/vendor/drush/drush/src/Commands/core/CacheRebuildCommands.php(60): drupal_rebuild()
#23 [internal function]: Drush\Commands\core\CacheRebuildCommands->rebuild()
#24 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#25 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#26 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#27 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process()
#28 /var/www/html/vendor/symfony/console/Command/Command.php(279): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#29 /var/www/html/vendor/symfony/console/Application.php(1047): Symfony\Component\Console\Command\Command->run()
#30 /var/www/html/vendor/symfony/console/Application.php(316): Symfony\Component\Console\Application->doRunCommand()
#31 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()
#32 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#33 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#34 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#35 /var/www/html/vendor/bin/drush.php(119): include('...')
#36 {main}
thrown in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 276
Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class Drupal\view_mode_page\PathProcessor\DynamicPathProcessor does not have a method "setContainer" in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:276
Stack trace:
#0 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(276): call_user_func_array()
#1 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#2 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#3 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#4 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#5 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#6 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#7 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#8 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#9 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#10 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(445): Drupal\Component\DependencyInjection\Container->createService()
#11 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#12 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#13 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#14 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(237): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#15 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#16 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(430): Drupal\Component\DependencyInjection\Container->get()
#17 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(273): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters()
#18 /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#19 /var/www/html/web/core/lib/Drupal.php(197): Drupal\Component\DependencyInjection\Container->get()
#20 /var/www/html/web/core/includes/common.inc(423): Drupal::service()
#21 /var/www/html/web/core/includes/utility.inc(41): drupal_flush_all_caches()
#22 /var/www/html/vendor/drush/drush/src/Commands/core/CacheRebuildCommands.php(60): drupal_rebuild()
#23 [internal function]: Drush\Commands\core\CacheRebuildCommands->rebuild()
#24 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#25 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#26 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#27 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process()
#28 /var/www/html/vendor/symfony/console/Command/Command.php(279): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#29 /var/www/html/vendor/symfony/console/Application.php(1047): Symfony\Component\Console\Command\Command->run()
#30 /var/www/html/vendor/symfony/console/Application.php(316): Symfony\Component\Console\Application->doRunCommand()
#31 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()
#32 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#33 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#34 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#35 /var/www/html/vendor/bin/drush.php(119): include('...')
#36 {main}
thrown in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 276
[warning] Drush command terminated abnormally.
After applying the changes suggested at #6 and re-installing the issue fork, the error disappeared, see commit:
https://git.drupalcode.org/project/view_mode_page/-/merge_requests/8/dif...
Moving this back to Needs review.
Thanks in advance!
dydave β made their first commit to this issueβs fork.
dydave β made their first commit to this issueβs fork.
Thanks Paul! (@paulmckibben)
You're a super nice maintainer! Always positive, helpful, crediting everyone and super reactive!
It's a great pleasure to be able to work with you! π
I've seen your feedback on the ESLint ticket ... it's a hard one and will take a bit of time, but I'm definitely going to get back to you on this when I have some time.
Thanks again for all the great help maintaining the module and super helpful feedback!
Cheers!
dydave β changed the visibility of the branch 10.1.x to hidden.
dydave β changed the visibility of the branch 11.x to hidden.
dydave β made their first commit to this issueβs fork.
Thanks a lot Paul (@paulmckibben) for getting module's logo added: It looks great on the project page!
I realize the issue is now closed and this message is just a bit too late ... but I'm hoping you might perhaps receive and see the email notification:
Could you please edit the project page ( https://www.drupal.org/project/colorbox β ) and hide or remove the Colorbox logo, since it is now displayed next to the module's page title?
As suggested in the Project Browser integration guidelines at:
https://www.drupal.org/docs/contributed-modules/project-browser/module-m... β
5. If you previously added a logo as the first image on the Drupal.org project page, please remove it.
That's really minor, but we forgot to mention it earlier.
Thanks in advance!
Hi Leslie (@leslieg),
Thanks a lot for raising this issue.
I'm not sure I understand exactly what the problem is here, see the screenshot below taken from the default branch of the GIT repo of the project:
https://git.drupalcode.org/project/block_class/-/blob/8.x-1.x/logo.png
The file logo.png
shows dimensions of 512x512
and a size of 4.55 KiB
.
Could you please let us know if there is anything wrong with the file ?
Did we miss anything ?
Feel free to let us know if you have any questions, comments or concerns on this ticket or any aspects of the project in general, we would surely be glad to help.
Thanks in advance !
Hi Jakob (@japerry),
This ticket should also be ready to go.
I've just added basic checks (as suggested above at #20 for the added disable_sticky
setting to the recently added AdminToolbarSettingsFormTest
.
Merge request MR!76 has also been rebased with the latest changes to 3.x and still seems to be passing all tests.
Please let us know if you would see anything else that would still need to be addressed in order to get this feature added to the module, we would surely be glad to help.
Thanks in advance!
dydave β made their first commit to this issueβs fork.
Hi Joseph (@joseph.olstad),
Could you please help us take a look at this MR when you have some time ?
I've paid particular attention not to modify anything that could break Backward Compatibility (BC), such as translated strings or class names.
At this point, MR!29 seems to be passing all jobs except ESLint and PHPStan which are probably more complicated and would most likely require specific issues to fix :
MR!29 Pipeline: https://git.drupalcode.org/issue/shs-3433198/-/pipelines/264680
Moving issue to Needs review and bumping to Major as an attempt to attract maintainers attention.
Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or this ticket in general, we would surely be glad to help.
Thanks in advance!
Quick follow-up on this issue:
A few additional commits were added to the current merge request MR!43 with a few comments, see above at #2.
But mostly, at this point:
Last build on MR: https://git.drupalcode.org/issue/colorbox-3468719/-/pipelines/257030
- The ESLINT job now seems to be passing β
ESLINT job: https://git.drupalcode.org/issue/colorbox-3468719/-/jobs/2473085
- The PHPUnit Tests are passing as well π’ \o/
PHPUnit job: https://git.drupalcode.org/issue/colorbox-3468719/-/jobs/2473087
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!43 and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on this initial merge request or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews.
DYdave β created an issue.
Thanks a lot Liam (@Liam Morland) for raising this issue and sorry for the delay on this task.
Quick follow-up on this ticket:
Ported the last automated tests for the Supported D7 version of the module from Drupal QA to Gitlab CI by merging MR!53 into the 7.x-2.x branch above at #4 and pipeline came back green π’
https://git.drupalcode.org/project/block_class/-/pipelines/254454
After removing the last test for 7.x-2.x-dev on Drupal QA at:
https://www.drupal.org/node/246513/qa β
the page redirected to a 403 page with the following messages:
403 - Access denied
DrupalCI testing is deprecated. You cannot add new tests or edit existing ones.
Removed testing schedule.Unfortunately, you donβt have permission to enter this area of the site.
Additionally, the Automated testing
tab on module's project page has now disappeared, see:
At this point, Drupal QA should have been properly and completely decommissioned for this module and all its supported development branches configured to be tested on Gitlab CI at:
https://git.drupalcode.org/project/block_class/-/pipelines
At this stage, since all the tasks listed in the issue summary should have been completed, marking issue as Fixed for now.
Feel free to let us know if you have any questions or concerns on any of the latest changes, this ticket, or module's testing configuration in general, we would surely be glad to help.
Thanks in advance for your reviews and feedback!
Thanks a lot Stephan (@szeidler) for the very helpful feedback!
Unrelated with this ticket, but just by curiosity:
To deploy/build a project, do you usually like using the drush deploy
command or rather each one of the commands separately?
drush updb
drush cr
drush cim
drush cr
along with hook_install
I've seen projects use a lot hook_deploy
, along with drush deploy
, but personally, I'm not a big fan...
Would be glad to hear if you have any thoughts on that.
Thanks in advance!
Thanks everyone for the prompt follow-up and positive feedback on this updated logo file.
Created at #14 an initial merge request on default branch 2.1.x, which should allow integrating Colorbox logo with PB and project page on DO.
Thanks in advance for the feedback and reviews!
Thanks @stephen ollman for raising this issue.
The version numbers are a bit misleading, but 3.0.x is based on 8.x-1.x.
If you are using 2.0.x then you shouldn' be updating to 3.0.x.
8.x-1.x ==> 3.0.x, is basically the original version of the module, based on the port from D7, where a single field CSS classes
is added to blocks' configuration form:
https://git.drupalcode.org/project/block_class/-/blob/3.0.x/config/schem...
2.0.x is a new version of the module, with quite a lot of new features, such as support for CSS attributes, bulk operations on classes, etc...
https://git.drupalcode.org/project/block_class/-/blob/2.0.x/config/schem...
Note that currently 2.0.x has quite a few issues and is still a work in progress:
If you look at the issue queue you should see quite a few issues related with autocompletion and various other PHP related issues.
3.0.x has a much smaller scope of features and has existed for much longer, therefore it is probably much more stable.
We plan on updating both branches documentation and more generally the project page to provide more information on supported branches.
Not sure if I was able to answer your questions, but feel free to let us know if you have more or if you would need more information on any of these branches or the project in general, we would surely be glad to help.
Thanks in advance!
Managed getting the image from #4 down to 9.95KB by reducing the colors to 64, with pngquant, without losing "too" much quality, see:
The smoothness of the gradient is a bit degraded, but if the logo is displayed in a small size (which I assume it is supposed to) perhaps that wouldn't be too visible?
See for example:
If more compression is required, then reducing the colors further to 32 or 16 would get the size further down to 8KB or 7KB, but the gradient would look more degraded.
Otherwise, the changes suggested at #8 might help getting better results, but my design skills are too limited to implement them.
Setting issue back to Needs review as the compressed image in this comment should answer the request above at #5 to get the image size below 10KB.
Hope that helps.
Thanks in advance for your feedback and reviews!
Thanks @szeidler for your feedback on this.
8.x-1.x ==> 3.0.x, is basically the original version of the module, based on the port from D7, where a single field CSS classes
is added to blocks' configuration form:
https://git.drupalcode.org/project/block_class/-/blob/3.0.x/config/schem...
2.0.x is a new version of the module, with quite a lot of new features, such as support for CSS attributes, bulk operations on classes, etc...
https://git.drupalcode.org/project/block_class/-/blob/2.0.x/config/schem...
Note that currently 2.0.x has quite a few issues and is still a work in progress: if you look at the issue queue you should see quite a few issues related with autocompletion and various other PHP related issues.
3.0.x has a much smaller scope of features and has existed for much longer, therefore it is probably much more stable.
We plan on updating both branches documentation and more generally the project page to provide more information on supported branches.
Not sure if I was able to answer your questions, but feel free to let us know if you have more or if you would need more information on any of these branches or the project in general, we would surely be glad to help.
Thanks in advance!
Thanks a lot Paul (@paulmckibben)! π
Super happy to see this issue finally making it into the the module π
Thanks also very much for merging other merge requests and getting all the jobs (except ESLint) passing green π’
https://git.drupalcode.org/project/colorbox/-/pipelines/251999
Cheers!
DYdave β made their first commit to this issueβs fork.
Quick follow-up on this issue:
Tried cloning legacy development branch 8.x-1.x to new 1.0.x locally, then pushed:
git checkout 8.x-1.x
git pull
git checkout -b 1.0.x
git push origin 1.0.x
It seemed to work and the branch was visible in the GitLab repo.
However, when I tried creating a new development release under Add new release with 1.0.x selected, the following error message was displayed:
Semantically-versioned releases for this project must start with 2.0.x, or higher, to not conflict with existing 8.x-1.x releases. See documentation on Drupal release versions β .
Therefore, the second option had to be selected, with the next major increment: 3.0.x.
- Created the new development release 3.0.x-dev β from branch 3.0.x.
- Dropped support for D8.
- Minor changes to the README.md file.
- Created the new stable release 3.0.0 β .
Last build on 3.0.x seemed to still pass π’
https://git.drupalcode.org/project/block_class/-/pipelines/249439
Releases on the project page were updated to reflect the fact:
Support for 8.x-1.x-dev β is now dropped in favor of 3.0.x-dev β .
Release
8.x-1.4 β
was marked Unsupported in favor of Recommended
3.0.0 β
.
At this point, all the work expected in this ticket should have been completed, thus marking it as Fixed for now.
Feel free to let us know if you have any questions or concerns on any of the latest changes, this ticket or the project in general, we would surely be glad to help.
Thanks in advance for your feedback, reviews and comments!
Hi everyone,
The new stable release 2.0.12 β of the Block Class module compatible with D11 was created from the 2.0.x development branch.
All the tests seem to be passing π’
https://git.drupalcode.org/project/block_class/-/pipelines/249508
Since other supported development branches now have D11 compatible stable releases, there shouldn't be any more bot updates or noise in module's issue tracker on this subject for the time being, therefore, I allowed myself to mark this issue as Fixed for now.
Feel free to let us know if you have any questions or concerns on any of the latest changes, this ticket, or the project in general, we would be very happy to help.
Thanks in advance for your feedback, reviews and comments.
Project browser integration:
Created 3 merge requests for all the current development branches:
- MR!51: 8.x-1.x being currently the default branch in the repository (doc point 4), it is the branch from which the logo will be loaded and used on the project page on Drupal.org at:
https://www.drupal.org/project/block_class β
- MR!50 for new version 2.0.x development branch.
- MR!49 for legacy D7 compatible version 3.0.x.
Note there is currently a request to change the default branch to 2.0.x:
π
Set default branch to 2.0.x
Needs work
But it is difficult to say when the change could be processed, so the easiest was to push the logo to all dev branches.
To produce the logo file (points 1, 2, 3): Added logo.png
file based on
documentation guidelines β
:
- No design (point 1) since the logo of the project was already the first image displayed on its page on Drupal.org.
Reused the same file: block-class_0.jpeg β . - Converted to PNG file format,
- Size 512x512: it was already correct in the source file.
- Compressed under 10KB with pngquant.
Lastly, as per point 5 of the doc:
If you previously added a logo as the first image on the Drupal.org project page, please remove it.
The logo image was removed from module's page and uploaded in this comment for reference, as the source of the logo.png file committed in the merge requests:
- Project page's first image logo and source: https://www.drupal.org/files/issues/2024-08-09/block-class_0.jpeg β
- Committed project logo: https://www.drupal.org/files/issues/2024-08-09/logo.png β
Block Class project page on Drupal.org is now showing the logo properly, see next to the page title, in the top left corner of the screenshot below:
More work is still needed to improve the integration with the Project Browser, but mostly editing of the project page content, categories, screenshots and documentation.
Otherwise, at this point all the work expected in this ticket should have been completed, thus marking it as Fixed for now.
Thanks in advance for your feedback, questions or comments.
DYdave β created an issue.