undefined - Contrib.social

🇫🇷France DYdave

Thanks @solideogloria!

The stable release for the 2.0.x branch has just been marked recommended ✅

Let us know if you spot anything else.

Thanks again for your help testing and reporting!
Cheers!

📌 | Block Class | Automated Drupal 10 compatibility fixes for Block Class

📌 | Block Class | Deprecated system_get_module_admin_tasks in drupal:10.2.0 and is removed from drupal:11.0.0

🇫🇷France DYdave

This issue is for the 2.0.x branch which currently supports D10.

Marking it as Fixed for now.

Thanks everyone for the help testing and reporting on this issue.

🐛 | Block Class | Fix fatal 'TypeError: ModulePermissionsLinkHelper::getModulePermissionsLink(): Argument #2 ($name) must be of type string, array given'

🇫🇷France DYdave

Hi Manish (@manish-31),

Thanks a lot for the merge request and code contributions.

According to the change record: system_get_module_admin_tasks() is deprecated → as of D10.2.0 where the new service system.module_admin_links_helper was introduced and currently used in your merge request:
https://git.drupalcode.org/project/block_class/-/merge_requests/37/diffs...

If we were to merge these changes we would be breaking backward compatibility (BC) and this feature would not work with D10.1, D10.0 or D9, which means we would have to drop support for 10.1 and only support 10.2 and above.

In order to get MR!37 merged, we're going to have to create the new minor release branch 2.1.x which will drop support for D10.1.

For the time being, the error mentioned in the issue summary has been fixed in related ticket 🐛 Fix fatal 'TypeError: ModulePermissionsLinkHelper::getModulePermissionsLink(): Argument #2 ($name) must be of type string, array given' Fixed with changes committed to the 2.0.x branch.

We should be able to come back to this ticket soon... once we've got other non breaking changes added to the current 2.0.x branch.

Feel free to let us know if you have any questions or concerns on this comment or the ticket in general, we would surely be glad to help.
Thanks!

🐛 | Block Class | Fix fatal 'TypeError: ModulePermissionsLinkHelper::getModulePermissionsLink(): Argument #2 ($name) must be of type string, array given'

🇫🇷France DYdave

Quick follow-up on this issue:

A few additional commits were added to the current merge request MR!41 with a few comments, see above at #4.

Mostly:

Fixed fatal TypeError with compatibility support for 10.2 and above without breaking backward compatibility
Broadened Gitlab CI tests coverage.
Fixed compatibility tests for D9.
Added initial Functional tests class for the admin Help page.

The tests all seemed to pass for the MR so the changes have been merged in branch 2.0.x, which seems to still be passing 🟢
https://git.drupalcode.org/project/block_class/-/pipelines/191822
(for the different Drupal versions tested)

Marking issue as Fixed for now.
Thanks!

🐛 | Block Class | Fix fatal 'TypeError: ModulePermissionsLinkHelper::getModulePermissionsLink(): Argument #2 ($name) must be of type string, array given'

🇫🇷France DYdave

Hi Rajdip (@rajdip_755)!

Thanks for your prompt follow-up on this!

Watchout: This is much trickier than it seems ⚠️

We're trying to support multiple versions of Drupal Core for the module in the 2.0.x branch, in particular D9 and D10.

The current code works for D9, D10.0, D10.1 and breaks as of D10.2.

We're currently trying to figure out what's the best option moving forward... probably creating a new branch which would most likely drop support for D10.1 (so only supports D10.2 and above).

We've mostly got the fix for D10.2 already in merge request MR!37, see related issue 🐛 Deprecated system_get_module_admin_tasks in drupal:10.2.0 and is removed from drupal:11.0.0 Needs review .

Mostly this ticket is to fix the module for D9, D10.0 and D10.1.
Once we've got that fixed, we should be able to get back to 🐛 Deprecated system_get_module_admin_tasks in drupal:10.2.0 and is removed from drupal:11.0.0 Needs review , create a new minor development branch and get MR37 merged in.

I'm currently working on this issue, fixing phpunit tests and broadening test coverage.

Feel free to let us know if you have any questions or concerns on any aspects of this issue or the project in general, we would surely be glad to help.
Thanks in advance!

📌 | Field Group | Automated Drupal 11 compatibility fixes for field_group - Fixed PHPUnit on GitlabCI

🇫🇷France DYdave

DYdave → created an issue.

📌 | Dashboards with Layout Builder | Automated testing on GitlabCI: Fix build pipelines errors

Comment 19 days ago →

🇫🇷France DYdave

Super nice of you Erik (@Erik Seifert)! Thanks a lot!

I've just checked and the ticket appears correctly on the company page!
My colleagues will be pleased 🙂

Thanks again Erik for your reactivity and great help fixing this issue, it's super appreciated!
Cheers!

✨ | Honeypot | Allow for more flexible form configuration

Comment 20 days ago →

🇫🇷France DYdave

Thanks a lot Eric (@ericgsmith) for your comment at #30!

It provided the basic guidelines for the implementation of this feature:

I've created a new merge request MR!28 with the approach suggested with a new configuration form setting additional_form_ids which could be used in the service.

Additionally, a few tests were added to check the additional custom form ids would be properly protected by honeypot, see:
https://git.drupalcode.org/project/honeypot/-/merge_requests/28/diffs#di...

The added test cases seem to pass.
The only errors currently reported are not related with this merge request, they have already been addressed in different issues, see:

📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review
🐛 PHPUnit errors: non-existent service plugin.manager.field.field_type_category Needs review

Therefore, at this point, this new feature "should" be ready to be tested, thus switching ticket back to Needs review as an attempt to get more reviews, testing and feedback on MR!28.

Thanks in advance!

Comment 21 days ago →

🇫🇷France DYdave

Thanks a lot @nils.destoop for your prompt follow-up on this and for the extra clean-up!
Cheers!

📌 | Block Class | Drop support for Drupal 8

🇫🇷France DYdave

Thanks a lot Paulo (@paulocs) for creating this issue and contributing a merge request, it's particularly appreciated!

With the link you provided to the Change record: _system_rebuild_module_data() and co. are replaced by services to give you all available modules and themes →
along with the details you provided, completely makes sense.

See for example, current module's code:
https://git.drupalcode.org/project/block_class/-/blob/2.0.x/src/Controll...
The module would certainly crash with older versions < 8.7.

This has been the case for a while in tagged releases : I went back to 2.0.0 and it had the same code... So it is safe to assume this change isn't going to have much impacts on sites, since they would have had to stop upgrading a while ago (to avoid crashing their site).

The changes have been merged!

The module is no longer supported or maintained for Drupal 8:
If you would like to keep upgrading to the latest version of the module, you will have to upgrade to drupal 9.

Thanks again for your help!

📌 | Block Class | Drop support for Drupal 8

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Block Class | Set default branch to 2.0.x

🇫🇷France DYdave

Hi Todd (@Todd Nienkerk),

Could you please help us change the default branch of the module to the current 2.0.x in the Gitlab repository?

It is starting to become particularly painful and costly having to rebase merge requests on Gitlab manually.

Most of the merge requests received now in the Gitlab repo are targeting the 2.0.x branch.
But since it isn't currently the default branch configured, Gitlab is unable to properly automatically rebase the merge requests through the interface and requires additional manual work.

Although I have the chance to be one of the maintainers of the block_class module, I don't seem to have the required level of permissions to access the Maintainers tab and Settings in the project's Gitlab repo at:
https://git.drupalcode.org/project/block_class/-/settings/repository
(I'm getting a 404)
Otherwise I would have done it myself already 😅

See the very clear DO documentation: Maintainership: Setting a default branch →
for the detailed steps to access the repo's settings form and change the default branch, which should only take 5 minutes.

I think this change/operation might require the user marked as the author of the module and that's why we are contacting you directly Todd (@Todd Nienkerk), but if anyone else among module maintainers would have that kind of access, some help would definitely be greatly appreciated.

Lastly, if there is any particular reason the current default branch 8.x-1.x shouldn't be updated, please let us know and maybe we will try finding other options or solutions, but in the current state it doesn't really seem viable in terms of the amount of extra work it creates for all of us, whether creating MRs, rebasing, etc...

Bumping ticket to Major as an attempt to attract maintainers attention: Too much extra work maintaining merge requests.

Feel free to let us know if you have any questions or concerns on this comment, or the ticket in general, we would certainly be happy to help.
Thanks in advance!

💬 | Block Class | Initial class save causes array_merge error

🇫🇷France DYdave

Thanks everyone for creating this ticket and your code contributions, it's greatly appreciated!

I've taken a quick look at this issue and tried repeating the steps described in the IS and at #5 but unfortunately I was unable to reproduce the problem and prompt the PHP error message:
✅ No crash: Everything worked fine/as expected

Tested with:

drupal/core: 10.2.5
drupal/block_class: 'dev-2.0.x:e03fb6a61296eb8ae595bfc8298e33e633a57610'

Step 1: Install module block_class from scratch (no prior config):

> drush en block_class
 [success] Successfully enabled: block_class

> drush cget block_class.settings

_core:
  default_config_hash: XEpuHrBp3DELKxVx0tmwE6CS7NSIKXu4F6QhT_vwqd0
block_classes_stored: {  }
default_case: standard
enable_attributes: true
enable_auto_complete: true
enable_id_replacement: true
enable_special_chars: false
field_type: multiple_textfields
filter_html_clean_css_identifier: ''
items_per_page: 50
qty_attributes_per_block: 10
qty_classes_per_block: 10
maxlength_attributes: 255
maxlength_block_class_field: 255
maxlength_id: 255
weight_attributes: 0
weight_class: 0
weight_id: 0

As you can see block_classes_stored: { } is an array, so it seems it "should" have an empty array [] as its default value and not null.

Additionally, is seems auto-complete is enabled by default as well: enable_auto_complete: true.

See current: block_class.settings.yml
https://git.drupalcode.org/project/block_class/-/blob/e03fb6a61296eb8ae5...

Step 2: Browse to "Main page content" (system_main_block) edit form:
/admin/structure/block/manage/olivero_content

Step 3: Add a class in autocomplete field "CSS class", for example: 'testingBC1', then save.

I'm not sure if I'm missing anything here, but with a fresh 'drupal/block_class:2.0.x-dev@dev' module install I was not able to reproduce the error.

Could someone please take another look at this issue and let us know if the problem is still affecting the latest 2.0.x DEV code base?

For reference, it seems the default value of the block_classes_stored config was updated in ✨ Storing block_classes_stored as a string value leads to poor developer experience Fixed .

Lastly, I'd like to point out the steps outlined above should actually be the same ones executed in module's Functional tests for the Create ("add") block form: /admin/structure/block/add/system_main_block/olivero.
which all seem to be passing at the moment: 🟢

2.0.x build at e03fb6a: https://git.drupalcode.org/project/block_class/-/pipelines/186710
PHPUnit job, passed: https://git.drupalcode.org/project/block_class/-/jobs/1734345

Code in test class:
https://git.drupalcode.org/project/block_class/-/blob/e03fb6a61296eb8ae5...

We would greatly appreciate if anyone could help confirming the problem in this ticket has been resolved in current DEV, or if it is still active, in which case, more contextual information would be very helpful.

Thanks in advance for your tests, reporting, comments and feedback.

✨ | Block Class | Integration with Drupal core's new Layout Builder

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

🐛 | Block Class | \Drupal calls should be avoided in classes, use dependency injection instead

🇫🇷France DYdave

📌 | Token | Drupal best practices and coding standards

🇫🇷France DYdave

📌 | Block Class | Remove deprecated drupal_get_path

🇫🇷France DYdave

This was fixed in 📌 Fix the issues reported by phpcs Fixed and committed to the 2.0.x branch.

Thanks everyone for the great work on this issue.

📌 | Block Class | Fix the issues reported by phpcs

🇫🇷France DYdave

📌 | Block Class | Fix the issues reported by phpcs

🇫🇷France DYdave

The changes have been merged!

Build pipeline passed: https://git.drupalcode.org/project/block_class/-/pipelines/186710
PHPCS job passed: https://git.drupalcode.org/project/block_class/-/jobs/1734340

Thanks everyone for the great help and work!

🐛 | Block Class | \Drupal calls should be avoided in classes, use dependency injection instead

📌 | Block Class | Deprecated system_get_module_admin_tasks in drupal:10.2.0 and is removed from drupal:11.0.0

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Block Class | Fix the issues reported by phpcs

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Block Class | GitlabCI: Fix CSPELL validation errors

🇫🇷France DYdave

At this point:
Last build on MR!40: https://git.drupalcode.org/project/block_class/-/pipelines/186665

The CSPELL job now seems to be passing ✅
CSPELL job: https://git.drupalcode.org/project/block_class/-/jobs/1734033
The PHPUnit Tests are passing as well 🟢 \o/
PHPUnit job: https://git.drupalcode.org/project/block_class/-/jobs/1734034

The changes have been merged!

Thanks!

📌 | Block Class | GitlabCI: Fix CSPELL validation errors

🇫🇷France DYdave

DYdave → created an issue.

📌 | Block Class | Add Gitlab CI

🇫🇷France DYdave

Thanks a lot for creating this issue and contributing a merge request, it's greatly appreciated!

The changes have been merged!

The module is now integrated with Gitlab CI, see latest build on the 2.0.x branch:
https://git.drupalcode.org/project/block_class/-/pipelines/186653

Thanks everyone!

📌 | Block Class | Update the BlockClassTest class to work on 2.x branch

🇫🇷France DYdave

Thanks a lot @paulocs for the great help and work on this issue!

In the end, it was preferred to go with olivero instead of stable9 (suggested in MR!33#3df28a9e in 📌 Add Gitlab CI Needs review ) or stark (suggested in this ticket's MR!19) since they don't add classes on markup.

In this test, ideally, we'd like to confirm the classes added by other components don't get overridden/replaced.
So in other words: test that classes that were supposed to be added are still there after the block_class classes are added, see:
https://git.drupalcode.org/project/block_class/-/merge_requests/39/diffs...
In particular: class="TestClass_content block block-system block-system-main-block".

Changes merged!

Thanks again!

📌 | Block Class | Update the BlockClassTest class to work on 2.x branch

🐛 | Block Class | Update config 'maxlength_attributes' default value to integer to fix broken tests

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

🐛 | Block Class | Update config 'maxlength_attributes' default value to integer to fix broken tests

🇫🇷France DYdave

Thanks everyone!

In the end we preferred sticking with an integer value and just change its default from false to 255, like other maxlength config fields.
It appears to simplify slightly the code while keeping the same logic and results.

Added update hook to set the value to 255 if it is currently empty.

The changes have been merged!

Thanks!

🐛 | Block Class | Update config 'maxlength_attributes' default value to integer to fix broken tests

🇫🇷France DYdave

DYdave → changed the visibility of the branch 3413783-make-maxlengthattributes-nullable to hidden.

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Block Class | Add Gitlab CI

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

🐛 | Block Class | Missing config schema

🇫🇷France DYdave

Changes merged!

These changes were also included in larger merge request MR!19 from issue 📌 Update the BlockClassTest class to work on 2.x branch Needs review .

Thanks everyone!

🐛 | Rules | PHPUnit errors: non-existent service plugin.manager.field.field_type_category

🇫🇷France DYdave

Thanks a lot Tim (@TR) for your prompt reply and for finding the corresponding change record.

As suggested, I went ahead and updated the version requirement of the module to "drupal/core": "^10.2".

As a follow-up task, I've added 📌 Support drush ^12 commands Active , looking at the line "drush.services.yml": ">=9" in the composer.json, that could most likely be removed, since drush ^12.4.3 would now be required.

Once again, we would greatly appreciate your reviews, advice and feedback.

Feel free to let us know if you would see anything else or more work needed on the merge request MR!26 or the issue in general, we would be happy to help.
Thanks!

📌 | Rules | Support drush ^12 commands

🇫🇷France DYdave

DYdave → created an issue.

📌 | Drupal core | When using drupalGet(), provide an associative array for $headers

🇫🇷France DYdave

@marcoliver, when you get a moment, could you please change the target branch of the merge request to 11.x, as requested at #8 ?
It seems I'm unable to edit the merge request, even with push access to the issue fork.

Otherwise if we need to create a new MR, let me know I would be glad to do so.
Thanks!

📌 | Admin Toolbar | GitlabCI support: Fix all jobs validation errors and PHPUnit tests

🇫🇷France DYdave

Not sure whether ticket's status should be changed back to Needs review, but the last comments have been answered.

Additional reviews, comments and feedback would be greatly appreciated.
Thanks in advance !

📌 | Honeypot | PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest'

🇫🇷France DYdave

Quick follow-up on this ticket:

A few changes were added to the current merge request MR!27 with a few comments, see above at #2.

But mostly, at this point:
Last build on MR!27: https://git.drupalcode.org/issue/honeypot-3450488/-/pipelines/184573

PHPUnit job: https://git.drupalcode.org/issue/honeypot-3450488/-/jobs/1712394
The 2 issues described above seem to have been fixed and the only remaining issue is the one related with the Rules module fixed in MR:
https://git.drupalcode.org/project/rules/-/merge_requests/26

We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!27 and let us know if there would be any more work needed.

At this point, i's really up to the maintainers:

whether to go ahead with this merge request, although the rules test is failing,
or whether the remaining failing test should be disabled temporarily in the same MR (so they all pass).

In any case, feel free to let us know if you have any questions or concerns on any of the changes in the merge request or this ticket in general, we would surely be happy to help.
Thanks in advance for your feedback and reviews

📌 | Honeypot | PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest'

🇫🇷France DYdave

DYdave → created an issue.

🐛 | Rules | PHPUnit errors: non-existent service plugin.manager.field.field_type_category

🇫🇷France DYdave

Thanks a lot Tim (@TR)!

Based on your instructions I was able to take an initial stab at this issue and the changes are now ready to be reviewed in ticket's merge request MR!26.

In the last build:
https://git.drupalcode.org/issue/rules-3425542/-/pipelines/184562

The issue seems to have disappeared from the PHPUnit job:
https://git.drupalcode.org/issue/rules-3425542/-/jobs/1712331

Taking the failing tests down from 124 to 3 🎉 \o/

I haven't looked at the remaining errors yet, but assume they wouldn't necessarily be "too" difficult to fix.
If you think it would be worth looking into them and try fixing them as well in the same MR, please let us know.

Otherwise, I suppose this merge request should fix at least the issue describe in this ticket.

We would greatly appreciate if you could please try testing, reviewing the changes and give us your feedback.

Feel free to let us know if you have any questions or concerns on any of the changes in this merge request or the ticket in general, we would certainly be happy to help.
Thanks in advance!

🐛 | Rules | PHPUnit errors: non-existent service plugin.manager.field.field_type_category

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

✨ | Honeypot | Allow for more flexible form configuration

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

🇫🇷France DYdave

Sorry about that: I got a bit confused here with the number of merge requests in this ticket and didn't really understand what had been done...

It appears the merge request that I modified above (#59 only fixes part of the issues : the ones related with the doc comments blocks mostly, see :
https://git.drupalcode.org/project/token/-/merge_requests/58/diffs#diff-...

As per #49 could someone please help creating some kind of "binder", with all the merge requests from this ticket merged into a single one, without a phpcs.xml file?
(without excluding any error from validation)

Maybe checking out each branch locally and merging it into a new one ("binder") would allow retaining every commit that was made for every merge request created in this issue.
There will mostly likely be some conflicts to be fixed as well when the various merge requests are combined.

Any help or feedback would be greatly appreciated.

Thanks in advance !

Comment 29 days ago →

🇫🇷France DYdave

Quick follow-up on this issue:

A few additional commits were added to the current merge request MR!58 with a few comments, see above at #58.

But mostly, at this point:
Last build on MR!58: https://git.drupalcode.org/issue/token-2774071/-/pipelines/181772

The PHPCS job now seems to be passing ✅
PHPCS job: https://git.drupalcode.org/issue/token-2774071/-/jobs/1684708
The PHPUnit Tests are passing as well 🟢 \o/
PHPUnit job: https://git.drupalcode.org/issue/token-2774071/-/jobs/1684713

These changes should be harmless enough, without any change in module's code (only doc comments) so they shouldn't take too long to review and would help enforcing validation of coding standards for other pending merge requests.

We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!58 and let us know if there would be any more work needed.

Feel free to let us know if you have any questions or concerns on merge request MR!58 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-fix-comments-debug1 to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-left-violations to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-use-fix-empty-line-fix to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-fix-cs-squiz to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-null-coalesce to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-comments-switch to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-visibility-array-indention to hidden.

🇫🇷France DYdave

DYdave → changed the visibility of the branch 2774071-fix-cs-base-branch to hidden.

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Token | GitlabCI: Fix ESLINT validation errors

🇫🇷France DYdave

Quick follow-up on this issue:

A few additional commits were added to the current merge request MR!59 with a few comments, see above at #2.

But mostly, at this point:
Last build on MR!59: https://git.drupalcode.org/issue/token-3411331/-/pipelines/181703

The ESLINT job now seems to be passing ✅
ESLINT job: https://git.drupalcode.org/issue/token-3411331/-/jobs/1684033
The PHPUnit Tests are passing as well 🟢 \o/
PHPUnit job: https://git.drupalcode.org/issue/token-3411331/-/jobs/1684035

We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!59 and let us know if there would be any more work needed.

Feel free to let us know if you have any questions or concerns on merge request MR!59 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews.

📌 | Token | Token ESLint errors

🇫🇷France DYdave

Closing in favor of more recent and better documented issue 📌 Fix eslint violations Needs work .

Thanks!

📌 | Token | GitlabCI: Fix ESLINT validation errors

🇫🇷France DYdave

DYdave → made their first commit to this issue’s fork.

📌 | Token | GitlabCI: Fix CSPELL validation errors