Admin toolbar menu z-index sucks with devel module

Devel sf-dump class having z-index 99999, so to fix the issue for toolbar menu added z-index to 100000.

Works for me! That said, I wonder if a fix should really go into core, since core's own toolbar gets obscured by the output from the dumper too. admin_toolbar could probably then just make use of core's fix. Up to this module's maintainer really?

Thanks

The changed z-index causes a problem with media and other dialogues, because the toolbar z-index the closing of the dialogues is not clickable any more.

The changed z-index also causes a problem with Ckeditor: When you maximize a formatted text field using Ckeditor, the admin toolbar shifts to the left-vertical position and overlays the editor window:

This change to using an enormous z-index has also broken aspects of Acquia Site Studio which assumes the admin toolbar's z-index to be 502 which it has been for years.

Will it be reverted because otherwise we will need to resolve the issues it causes.

I tried to contact the maintainers on slack but haven't received feedback on the issue so far. I found another issue created related to this.
@jessebaker Just lock the version to 3.3.0 for now in composer until it gets resolved.

I'm reverting this issue due to the problems described at 🐛 New z-index is breaking other functionalities Closed: duplicate

Thanks @adriancid. However I think you also need to remove the duplicate style declaration on line 1 of the same file -

#toolbar-bar {
  z-index: 100000;
}

was in that file twice.

@jessebaker can you check the last changes? I can't see any duplicate code there.

The patch here is causing this error 🐛 Top search results are hidden under the toolbar. Closed: works as designed

Hmm I might be wrong, sorry!

If you look here https://git.drupalcode.org/project/admin_toolbar/-/blob/3.3.2/css/admin.... you can see the following code twice (on lines 1 and again on 9)

#toolbar-bar {
  z-index: 100000;
}

It looked like the commit linked in your comment only removed the second one - but looking at 3.x it looks like both are gone!

https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/css/admin.to...

Hi

To address the issue, the requirement states that the toolbar menu should be positioned above the status message.
However, applying the CSS property z-index: 100000; to the #toolbar-bar class caused some unforeseen problems.

In order to resolve this for admin toolbar module, creating a - patch menu-z-index-sucks-with-devel-module-3335841-17.patch. override the CSS (z-index:0;) of the devel module specifically for the admin toolbar by modifying the "admin.toolbar_search.css" file.

Verified! After applying patch #17 issue seems to be fixed. Thanks!

I will leave open the issue until the other user reporting problems write a comment saying is working for them.

The patch at #2 works for me, I don't know about the other issues mentioned.