@Harish1688

Based on comment #13, make the change according the suggestion and create a new patch (3283391-15.patch) for 11.x (wide-image.css renamed in wide-content.css 11.x) so it's only for 11.x. attached image for reference.
Tested the 3283391-9.patch with 10.1.x and 11.x throwing a error in applied.

Needs Review.

Before patch in 11.x

After patch

Based on the comment #22, added the issue summary.
Also Tested the patch 3370683-11.patch with latest 11.x. But found a issue in that, after applying the patch search icon not showing. attached a image for reference.

Testing with version 11.x

Hi,

I have tried to reproduced the issue on local with 8.x-1.x-dev and 10.x on OS X system. found the issue their 1px difference from top, but no patch applied. So create a patch (2768769-10.patch) for the issue as per comment #8 suggestion. attached a image for reference.

Tested Steps:
1. Drupal 10 set up and Adminimal theme setup with 8.x-1.x-dev.
2. Moved on path admin/modules/uninstall/confirm, found the issue and applied the all patch but working.
3. Create a new patch, resolved the issue.

Before Patch:

After Patch:

Based on the comment #saschaeggi , Tested the comment #9 solution for the issue. points covered in the in comment. attached images for reference.

1. Remove the 'Back to site' link from js/toolbar.js if the escapeAdminPath session variable is empty.
2. 'Back to site' link theming fix.
3. Just 2 commit for issue in MR.

Before MR

After MR

Hi,

AS per comment #4, we couldn’t remove max-with as this plays a vital role in a11y. But as per suggestion it could be changes max-width: 60ch;. Tested the Merge request !314 suggested changes are done.

Tested steps:
1. Drupal 10 setup and enable gin theme 8.x-3.x-dev.
2. Enable media library module and add a media filed in content type (article).
3. Verified the max-width changes.

Hi,

As per ticket status (Needs Work) looks the issue, but found it's resolved by the #9 patch. resolved the Remove links alignment issue.

After patch:

Hi,

Based on the last comment #5 solution. tested the issue Differentiate visually dragging with and without hierarchy. and found that in blocks drag able icon is changed for vertically rearranged order. also tested in views also there are only vertically reorder but found the changes. attached image for reference.

Tested Steps:
1. Drupal 11.x setup and moved on path admin/structure/block and admin/structure/views/view/frontpage to verify the icon.
2. Moved to Merge request !4936 , and verified the changes on block and view page.
3. On block page (vertical) looks fine, but on view (filter criteria) it's still same.

After MR:
Block:

Veiws:

Harish1688 → created an issue.

Hi shweta__sharma,

In the ticket a Merge request !297 already open and all the last changes are done in this MR. So (Patch is not required here) please push your changes in MR for review.

Hi,

Tried to replicate the issue on local with same steps provide the in issue summary, but it's not reproduce on local.
can you provide more details about the issue. attached image for reference.

Testing Steps:
1. Drupal 10 Setup and enable module Adminimal Admin Toolbar.
2. Upgrade the admin_toolbar(module) to version 3.3.2, but not found any issue.

Hi,

Based on comment #2, Review the patch 3378195.patch for the issue White flash in toolbar when loading pages, and found patch worked fine, on reload the page white flash is not showing. Attached the screen record.

Tested Steps:
1. Drupal 10 setup and Adminimal Admin Toolbar enable.
2. Moved on any backend page like (admin/appearance), and refresh the page for issue (found the bug).
3. Applied the patch and verified the issue was solved by patch.

Looks good for RTBC+

Hi,

I have tried to find out issue on add block and layout side block for small font size, but not find issue.
can you explain more details (images, links, what should be font size) and steps for reproduced the issue.

Hi,

Based on the comment #13, need to verified the code feedback. In comment #15 code feedback is done. remove the duplicate code from the _views.scss file. Also tested the misaligned issue in MR, Button and input field are top align and vertical centre, if it's fine then issue is resolved. attached the images for reference.

Removed Duplicate code.

 .form-actions {
    margin-top: 0;
  }

Before MR:-

After MR:-

Hi

Based on comment #11, reviewed the Merge request !300 for the issue Header region sticky on top in mobile., and found that in MR issue is resolved. attached the images for reference.

Tested Steps:
1. Drupal Setup and gin admin theme as backend theme enabled.
2. On the path (admin/modules) found the issue, moved on the MR !300.
3. Verified the changes and it's resolved the issue (on scroll Header top not sticking on top and smoothly go to upward.)

Before MR:

After MR:

Looks good for RTBC+

Hi,

Based on last comment #7, improve the patch and created a new patch (3380126-8.patch) and remove all extra code.
attached the images for references.

For Testing :
1. Drupal Setup and gin admin theme as backend theme enabled.
2. Enable admin toolbar module and makes setting changes as pr mention in issue (view in mobile port).
3. Applied the patch (3380126-8.patch) for solution.

Before Patch:

After Patch

Needs Review +

Hi,

Tested the patch from #10, #11, both are not working mention in comment #11. so created a patch (3073556-13.patch) to resolved the issue

Needs review.

patch after (3073556-13.patch) :-
1. Adminimal

2. Thunder

3. Claro

Hi,

Based on your last comments, I tested the patches mentioned in #10 and #11 to resolve the issue. However, I found that the patch in #10 did not resolve the issue for all possible admin themes, as mentioned in comment #8 (Adminimal / Thunder / Claro).

attached the images for reference.

#11 patch not working.

Needs Work

comment #10 patch after:
1. Adminimal

2. Thunder

3. Claro

Hi,
As per comment #9, Updated the image in comment #8.

Hi,

I tried to replicate the problem described as 'sticky view table overlaps Back to site link (icon)' on my local system but was unable to reproduce it. moved on node page and scrolled the view table up, causing the table header to stick to the top. butback to site icon did not appear below the table header. because, during scrolling, the header remained fixed within the view table, causing the back to site icon to be positioned outside the view table.
For reference, I have attached an image.

can you share more details about this issue.

Testing Steps:
1. Drupal set up 10 and enable gin theme as backend
2. moved on path admin/content, adding some content and scroll the page to upward. No issue found.

No issue found:

Hi,
created a (3385497-2.patch) patch for the issue 'dropdown menu appears behind CKEditor 5's'. z-index added to resolved the issue as per Proposed resolution.

Needs Review.

Testing Steps:
1. Drupal Setup 10.x and Gin theme (8.x-3) enable for backend.
2. Change the Gin menu to horizontal view, install the admin tool bar module and enabled.
3. Moved to node type like (article), click on CK editor view and scroll up, issue will appear.
4. Applied the patch, (keep the patch in Gin folder) and test the solution to resolved this issue.

Before patch:

After patch:

Hi rfmarcelino,

Tried to reproduce the issue ( Last dropdown is moving upwards, and if the list isn't tall enough, the dropdown will be cropped
) on local issue is there, tested the provided patch (gin_dropdown.patch). it's working fine. images attached for reference.

Testing steps:
1. Drupal 10.x setup and install/enable gin theme (8.x-3.x-dev) as backend theme.
2. Moved on the path (admin/structure/types), tested the last dropdown got issue there.
3. Applied the patch (gin_dropdown.patch), verified the changes and issue resolve by patch.

Before Patch

After Patch

Looks good for RTBC+

Hi,

As pr comment #10, Tested the MR !4670 for the issue spacing inconsistency in AJAX progress icon with action button (spacing between button and loader right side). found the issue on local and tested the solution given in MR, it's resolved the issue. images attached for references.

Testing Ste
1. Drupal 11.x setup and go to content page admin/content, Claro set as backend theme
2. Edit node type (Article), click on the delete button, and media button found the issue ( it's 24px, but it should be 12px).
3. Moved the MR and verified the solution, it's working fine.

Media loader spacing

Delete loader spacing Before

Delete loader spacing After patch

Looks good for RTBC+

Hi,

I tried to recreate the issue on local and found misalignment issue in paragraphs. created a patch "3383808-4.patch" for the issue. Images attached for reference.

Needs Review

Testing Steps:
1. Set up Drupal 10.1.x and install and enable paragraphs module.
2. Define some paragraph types and add paragraph in node type (article).
3. Applied the patch (3383808-4.patch ) and reviewed the changes to address the problem solution.

After Patch:-

Hi,
can you please add steps for reproduce the issue in issue summary.

Hi,

Looking the issue schedule transition button size is different for first transition and for second transition, I have added second and third transition but button found the transition button size same as in all states. attached a reference image for this.

can you brief the more details, so i can reproduce it.

Testing Steps:-
1. Drupal Set 10 with claro as the admin theme.
2. For scheduled transitions module follow the same steps mention in the ticket.
3. On node page (node/1/scheduled-transitions), testing the bug.

looking this issue

Hi 2dareis2do,

As pr comment #7, I was trying to resolve the issue (flex grid seems to stretch beyond the size of the screen (safari os x)) showing in image (Screenshot 2023-08-15 at 16.34.35.png), but it's not reproduce on safari (Version 16.5.2). and not found same on other browser's. attached screen for reference.

can you give more details about the issue .

Testing steps:
1. Set up the Drupal (10.1.x-dev) and moved to safari browser.
2. Moved to node and tried to found the issue.

Hi,

Tried to replicate the issue with (Drupal 10.1.10 and 8.x-3.x-dev) on local to verified the issue solution provide in MR !286 mergeable, but not able to replicate.
can you please add with steps to reproduce in issue summary.

Hi,

1. working on the issue so reviewing this issue first, but only first issue is reproducible with given details. for that tested the patch #6, But by that the issue is not resolved, so created the patch (3377007-9.patch).

Can you please provide more details on below points
2. How you made the paragraph drag-able.
3. The given URL(/admin/config/development/features) not working redirects to the page not found.

#6 patch applied screenshot.

(3377007-9.patch) Patch that addressing the first point and solving the issue, attached screenshot.

Hi,

As per comment #5, created a (3381598-7.patch) patch for the select box (#5 patch convert tabs into select box) theming.
attached the screenshot for reference.

Testing Steps:
1. Drupal setup 11.x and create several view modes as per issue summary.
2. Applied a patch (3381598-7.patch), check the select box theme on the path (admin/structure/media/manage/image/display).

Needs Review.

Hi,

Tried to reproduced the issue on local with mention details but it's not reproduce able (horizontal scroll in the media library dialog on Edge browser), attached a image for reference.
can you please mention more details about it.

Testing Step:-
1. Drupal 11 setup and enable media and media library.
2. Add a media field to article node content type,
3. enable the contrast mode, open media pop up in the Edge, chrome browser also, but not found horizontal scroll in the media library dialog.

Hi
Tested the patch status-message-hover.patch in comment #3, for issue message not disappear when I hover the mouse over it. patch is working fine and resolved the issue, we set any time from configuration, on hover pop up it's not disappear after time complete.

Tested Step:
1. set up the Drupal 10.0.x and install/enable the module Status Messages ( https://www.drupal.org/project/status_messages → ).
2. In module configuration 5s timing is set. and move on the node page/ stay on extend page (refresh page).
3. Apply the patch and verified the changes, when we hover on the pop up it's not disappear, patch working fine.

Looking good for RTBC+

Hi,

I have tried to reproduce it on my local with same details as you give. created home menu option and testing on many browser. by not find the issue with Drupal core, it's maybe be functionality issue from your side.

can you please add more details about it, so that we cloud replicate it on local.

created a patch 3380407-2.patch for this close icon visibility issue on forced mode.
attached screenshot for reference .

Needs review.

Harish1688 → created an issue.

Hi,

Tested the patch 3379522-7.patch from comment #7, and found unused styles in Umami branding component are removed successfully from the file without any UI impact on design.

Also tested the this code, it will also modify the background color of the logo image.

a:hover, a:focus {
    color: #cc2a00;
    background-color: #e6eee0;
}

Tested steps:
1. Drupal 11 setup with Umami theme.
2. applied the patch and verified the patch changes.

Looks Good for RTBC+

Hi,

created a 3378784-3.patch patch for the issue "Skip to main content" insufficient contrast. .skip-link class white color is override by .visually-hidden class. added a css for this issue. image attach for references.

Need Review.

After Patch

looking this issue..

Hi,

As pr last comment #18, looking the two point.
1. After applying the #18 patch, tested the UI on High contrast mode but not found any inconsistently. so removing the properties, not put any impact on the UI. attached the reference images.

2. Missing space is resolved in 3303551-19.patch patch.

After patch in select box in high contrast mode.

wrong patch commit by mistake in last patch #2, commit the correct one 3378190-2.patch,
Needs Review

created a patch 3377198-2.patch for the issue.
Need review.

Testing Steps:
1. set Drupal with 11.x and enable claro as backend theme.
2. enable the forced color mode active in browser, and check the issue in toolbar.

After patch:

Note: In pcss file hex color code are used however use the follow the same not used variables.

Harish1688 → created an issue.

Hi,

Reproduced the issue on local and created a patch for issue 'details up chevron not quite vertically aligned in forced color mode'. attached a image for reference.

Test Steps:
1. setup the Drupal 11.x and claro theme as backend theme=.
2. moved on path 'admin/config/system/site-information' and active the forced color in browser, and verified the issue (chevron not align vertically).
3. create 3377198-3.patch , Need Review.

After Patch:

looking for this issue..

Hi

Tested the patch 3359636-3.patch, it's removed the padding from menu item, so the navigation second/third level theming looks better than before. attached a screenshot for reference.

Tested Step:
1. Drupal setup 10.0.x and moved on olivero theme.
2. Add some menu on items links on the path 'structure/menu/manage/main'.
3. Applied the patch, and verified the changes.

After patch

Hi,

As pr last comment #5, create a new patch (3375729-6.patch), in last patch no accent color variables are used, except using a background SVG in case when we switch the primary color from GIN setting, loader color image remain the same color that issue resolved in new patch.
images attached to reference. Needs Review.

Testing steps:
1. setup the Drupal 10.1.x and enable the Gin 8.x-3.
2. applied the patch on path 'drupal/themes/contrib/gin', then moved to '/admin/appearance/settings/gin' switch to any primary color in both mode (light/Dark).
3. moved to node like 'node/add/article' , check the autocomplete like tag field type text loader will be show right side.

After patch:

patch test is passed in #40, so restore the status to Need Review.

Hi,

Tested the MR !284 mergeable, for the task paragraphsEE no longer be necessary, so files related to be paragraphsEE should be removed from all over the Gin theme. After moving the MR all files are removed successfully, no files remain in Gin theme.

Testing steps:
1. Install the Drupal 10.0.x set up and enable the Gin theme 8x-3.x.
2. switch to the MR !284, and verified the changes, no files remaining related to paragraphsEE.

Note: No screenshots because this issue is about code consistency, not visual changes.

Looks good for RTBC+

Reviewing this,
as per ticket requirement ParagraphsEE no longer be necessary, so files should be removed and 1 MR is done for this.

Hi,

Tested the patch 3375406-3.patch for the issue The "Name" field in the Add form mode is required, although it lacks any mandatory sign. after applying the patch issue was resolved, mark (asterisk) are showing on the required field (Name). attached the images for reference.

Testing Steps:
1. Install the Drupal 11.x set up and moved on the path '/admin/structure/display-modes/form'
2. click add form mode button and choose form mode entity type 'content'.
3. In the dialog box issue will be appear.

Before:

After:

Looks good for RTBC+

reviewing this.

Hi,

Tested both patches, 3375806-9.patch and 3375806-11.patch, and they are both working well. However, I found that adding the class js-hide to the input element using the Views UI module is a better approach. This change works perfectly on all other themes when switched. I specifically tested the 3375806-11.patch on two admin themes, Claro and Gin, and it worked perfectly on both of them. attached the images for reference .

Testing steps:
1. Install the Drupal setup 11 and enabled the claro theme.
2. on path 'admin/structure/views/view/demo_testing' , applied the patch and verified the changes.

After patch 11:
Claro theme:

Gin Theme:

Looks good for RTBC+

reviewing this.

Hi

Based on comment #33, I tested all three points using the patch provided in comment #36 and found the following:

1. In the Merge Request !3986 and the patch #36, the 'align-items: center' property was added to the 'region-secondary-menu.pcss.css' file. However, after applying the patch, there were no visible changes in the user interface (UI). so removing this in 3238618-40 patch.

2. The issue summary needed an update, but only the issue title was updated in comment #34, the issue summary was also updated with the comment.

3. The height of the focus outlines between the primary and secondary menus was unequal before, but the issue has been resolved by applying the patch provided in comment #36. screenshot was attached to the comment for reference.

Before:

After:

Hi

Tested the MR 4398 for inconsistency in the use of spacing variables or layout helpers in the PostCSS files issue, like replacing the instances of `calc(2 * var(--sp)); calc(3 * var(--sp)); calc(4 * var(--sp)); ` with var(--sp2), var(--sp3) var(--sp4); and created new helper like : var(--sp3-5)l var(--sp13); are used in the relevant PCSS files are done.

Here are the steps I followed to test the changes:

1. Installed Drupal 10.1.x-dev version and navigated to the 'core/themes/olivero/css' path.
2. Switched to the MR (#4398) and verified the changes in the PCSS files.

Note: I didn't take screenshots because this issue is about code consistency, not visual changes.
Looks good for RTBC+

As per last comment #17 changes in MR, reviewing it

Hi @saschaeggi

as per your comment #5, Tried to theme the toggle button (needs only background css apply, functionality working fine) , but found that background color CSS property not working in forced-colors mode, it could be due to the limitations imposed by forced-colors mode itself. it's is a browser accessibility feature that overrides the specified colors on a web page, replacing them with a limited set of high-contrast colors that are more accessible to users. So in my case it's not possible to implant the default css to theme toggle button and checkbox is a good option instead of toggle button.

could know more : https://developer.mozilla.org/en-US/docs/Web/CSS/@media/forced-colors

Hi,

Tested the MR !276 to address the issue toggle switch not usable in forced color mode. it's works fine, issue points (instead of toggle, provide a solution by using checkbox as mention in #3) are covered in MR:

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. on path 'admin/config/development/performance', enable the ( "Emulate CSS media feature forced-colors" ) in 'active" mode.
3. Switch to MR and verified the changes in update MR.

attached the screen for references.
Before:

After:

Looks Good for RTBC

Hi,

Tested the MR !277 to address the issue tabledrag handle and "dragged" bar not visible in forced color. it's works fine, issue points (handle and dragged bar visibility ) are covered in MR:

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. on path 'admin/structure/menu/manage/main', enable the ( "Emulate CSS media feature forced-colors" ) in 'active" mode.
3. Switch to MR and verified the changes in update MR.

attached the screen for references.
Before:

After:

Looks Good for RTBC

Hi,

Tested the MR !278 to address the issue drop button issues in forced color mode. it's works fine, all issue points (chevron icon visibility, Hover/Focus state ) are covered in MR:

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. on path admin/structure/types/manage/article/fields, enable the force color mode.
3. Switch to MR and verified the changes in update MR.

attached the screen for references.
Beore:

After:

Looks Good for RTBC

Hi,

Tested the MR !273 to address the issue error appears with a basic A11y scan. Now it's works fine after '<dl><dd><dt> to <div>' tags change in MR.

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. switch to MR and verified the changes.

Attached the screen for references.
Beore:

After:

Looks Good for RTBC

Hi,

Tested the MR !272 to address the issue where the focus outline was not appearing on the home link. it's now works perfectly fine in both vertical and horizontal views.

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. switch to MR and verified the changes.

attached the screen for references.

Looks Good for RTBC

Hi @smustgrave ,

I apologies for the previous patch failure in #27. I forget to include the files in the patch and also to add the interdiff.
I will now upload the new patch (3213158-29.patch) along with the interdiff.

Hi,

The recent patches #20 and #22 have failed, so we need to re-roll the patch based on core 10 and 11. The following points should be considered:
1. As mentioned in #5, since Quick Edit will be deprecated, any changes should be made in their respective stylesheets.
2. Both LTR and RTL cases have been tested and are functioning correctly.

Hi,

successfully tested the patch '3355510-4.patch' locally, and it applied successfully, resolving the issue and addressing the following point:

1. When the "Primary menu" is empty on a narrow window, the 'secondary menu' becomes visible upon clicking the menu.

Looks for RTBC

Hi @thalemn,

Tried with same info as you provided to reproduced the issue on local. but not able to reproduce the issue on local, it's working fine.
attached a GIf for reference.

Hi,

As per #11 request attached the image in issue summary.
The UI should remain visually consistent before/after the patch applied, with no need to compare the screens before and after screen.

Hi,
The previous patch #18 failed when tested for Drupal 11. I am uploading the patch (refactor-form-field-multiple-3294000-19.patch) again, for D11. However, I have also tested it for Drupal 10, and it works without any issues.

hi,

As per #15 request attached the image in issue summary.
The UI should remain visually consistent before/after the patch applied, with no need to compare the screens before and after screen.

Hi ,

CSS compile Error #8, resolve in the patch (refactor-image-preview-3305148-9.patch), after compile the file, no modification show in 'image-preview.css'. However it's not in the patch.

Needs Review.

Hi,

Tested the #3 patch (305148-version10.0.x.patch) but it's failed to apply, re-roll the patch. working fine on 10 and 11 version.

1. CSS Logical Properties and nesting are utilized appropriately.
2. The UI showing no difference in compared to the previous version.

Screenshot attached

looks good to RTBC

Hi @smustgrave,

the last patch in #59 ( https://www.drupal.org/pift-ci-job/2704056 → ) is build successfully. so moving to need review.

Hi,
After applying the patch 3294006-33.patch, the following points were observed:

1. CSS Logical Properties and nesting are utilized appropriately. (mostly all classes have variables, so found few changes on css Properties - like margin and text-indent)
2. The UI and focus states remain unchanged, showing no difference in behavior compared to the previous version.

Screenshot attached

looks good to RTBC

Hi,

After applying the patch 3303551-11.patch, the following points were observed:

1. CSS Logical Properties and nesting are utilized appropriately.
2. The UI and hover/focus states remain unchanged, showing no difference in behavior compared to the previous version.

Screenshot attached

looks good to RTBC

As per comment #58, Tested the patch #45 again and create a new patch (align-table-headers-3182665-59.patch) with modified some css property.

Note: If no alignment CSS (views-align-left, views-align-center, views-align-right) is defined, the text alignment of the "th" tag will be left-aligned by default.

Needs Review.

Hi,

Tested the patch 3283018-7.patch, points covered in the patch.

1. The issue with the hover state on the field has been successfully resolved.
2. The issue regarding the alignment of field items in the entities list of the selection is also addressed in point #6.

screenshot attached.

Looks Good for RTBC

working on this ...

Hi @smustgrave,

I have updated the images in (#51, #52) but it's not showing via unknown error but added the Before/after screenshots in the issue summary.

Hi @Hamid.ali,

can you please share the Olivero theme figma link for mobile view, so i can verified the issue and solution.

Hi,
Tried to replicate the issue on local with same Drupal 9.4.8 with admin toolbar 3.2.1. and testing the things steps wise as provided but not facing any issue on hover state when switch to vertical to horizontal toolbar mode. Hover working fine and by access by tabs focus also working fine.

can you please provide more info or (UI) to issue, so would be able to generate.

As per #47 request,
1. updated the issue image in issue summary. (Align table headers issue.png )
2. After patch (3332049-45.patch) applied, issue resolved adding after screenshot (3182665 after patch 45.png).

Random failure, restoring the status.

Hi @clgarciab,
I have tested the Mr !55, calc function added successfully in table.scss file. But can you please share more info/steps to reproduce the issue on local (UI Interface), so i can verify the MR !55 solution is working fine.

created a new patch '3319164-5.patch' as a result of the failure of the previous patch (3319164_2.patch) while compiling the CSS.

1. Updated the Issue summary with proposed solution.
2. #8 patch found the random failure, restoring the status to need review.

strange, I have checked the images on others system, it's visible on some and breaks on some.
so updated the images again.

Images:
3191727 after patch 26.png
3191727 before patch 26.png

The patch '3319164_2.patch' was tested and successfully applied. It added the class '.print-none' with the 'display: none' property in the print.css file.

1. Update the issue summary with proposed solution,
2. I have tested patch #26 and it is working fine. As requested in #28, I am attaching a screenshot for reference.

Before

After

RTBC +1