The 'Name' field in the Add form mode is required, even though it lacks any indication of being mandatory.

Hello @Gauravvvv

there are two options to consider for addressing the issue related to the "Name" and "Machine-readable" fields which are hidden in the Add form mode:

1.Make the "Name" Field Mandatory:
If the "Name" field is intended to be mandatory for creating a new form mode, you should add the necessary validation to enforce this requirement. Additionally, it would be essential to provide a visual indication (mandatory sign or asterisk) in the user interface to inform users that the "Name" field is required. By doing so, users will know they need to provide a value for the "Name" field before they can successfully create a new form mode.

2. Remove Validation for the Machine-Readable Field:
If the "Machine-readable" field is causing confusion or if it's not necessary to be mandatory for the form mode creation, you could consider removing the validation for this field. This would allow users to create new form modes without having to provide a value for the "Machine-readable" field. However, it's essential to assess the implications of removing this validation and ensure that it won't lead to unintended consequences or issues in the system.

The decision between these two options depends on the requirements and design of the project. If the "Machine-readable" field is not a critical aspect of the form mode creation, removing its validation might be a reasonable solution. On the other hand, if the "Name" field is a crucial piece of information and should be mandatory for the creation process, then adding the necessary validation and visual indication would be appropriate.

Hi, I have added patch #3 and added sign (asterisk) also attaching screenshot for the same.

The last submitted patch, 3: 3375406-3.patch, failed testing. View results →

reviewing this.

Hi,

Tested the patch 3375406-3.patch for the issue The "Name" field in the Add form mode is required, although it lacks any mandatory sign. after applying the patch issue was resolved, mark (asterisk) are showing on the required field (Name). attached the images for reference.

Testing Steps:
1. Install the Drupal 11.x set up and moved on the path '/admin/structure/display-modes/form'
2. click add form mode button and choose form mode entity type 'content'.
3. In the dialog box issue will be appear.

Before:

After:

Looks good for RTBC+

Patch no longer applies cleanly to 11.x.

Also wonder if a simple assertion could be added to check for the form-required class.

If we can add that simple assertion to make sure this field has the required class.

@smustgrave we need to add an assertion for the Name field or Machine-readable field.

Marking the fields as required is already been taken care in the Allow user to add display modes from respective field UI's. 📌 Allow user to add display modes from respective field UI's. Needs work issue. I think we can ask for the test coverage on the same issue.

Akhil Babu → made their first commit to this issue’s fork.

@Akhil Babu MR !6237 and patch #8 both are same can you please elaborate why created MR.
After applied patch #8 label is required.

Moving this to NW.

@djsagar, Using a merge request is now the recommended approach in Drupal over a patch. I’m sorry for forgetting to add a comment initially 😬. I’ve included a test as mentioned in #9.
Moving to Needs review

Tested Merge request !6237 on Drupal 11.x and it looks good. Now the name field has a required asterisk icon.

Before MR -

After MR -

Issue summary Updated

Moving into the RTBC +

Not entirely convinced the test adds any value here, but let's add it anyway now that it was written.

Backported as a bug fix to 10.2.x.

Committed and pushed f50c6a352d to 11.x and 46549a06b6 to 10.2.x. Thanks!

longwave → closed merge request !6237

Automatically closed - issue fixed for 2 weeks with no activity.