🇮🇳India @utkarsh_33

Re#9 ya i just noticed that the positioning was a bit off.I have fixed that positioning.Marking it NR again.

I can confirm that the issue is solved with this Fix.

Re #6 I can see the SS that you attached still have the issue that's reported here.The width of the installed image and the drop button are still different,You can see the SS in #3 how it looks after the fix.

Adding #3511104: The dropbutton has extra width when opening in the modal as could haves as this is a UX improvement with which users might interact frequently.

Merging the latest changes.

Ready for reviews.

utkarsh_33 → made their first commit to this issue’s fork.

The tests are now passing.

utkarsh_33 → created an issue.

Also as i mentioned earlier in #8 regarding the use of toggles instead of plain checkboxes, I am attaching the SS of how it looks after using toggle.
SS:-

What do others think about this change?

I the SS can we make the Sort by label stacked over the dropdown just like the Filter by category to make it more uniform?

I have pushed some changes that fixes tests.Most of the remaining tests can also be fixed in same manner, but i wonder if we really want to make changes in tests like this.I'll ask @phenaproxima about whether we want to do this.In the mean time if @omkar-pd has a better solution, then it's perfect.

All the tests that are failing are due to the extra wait that we need due to this change.I think this is not a good way.We might need something more robust here.Will try to find a better solution.
Also @omkar-pd if you think you have any better approach inline with what you added it would be great if either you can suggest or push the fix related to what's mentioned in #6.

utkarsh_33 → made their first commit to this issue’s fork.

The changes looks good to me and the filters are also working correctly.Marking it RTBC'd.

@saschaeggi do you have any better way to handle the remaining stuff?

I have removed most of the #project-browser usage.The remaining are hard to remove because they are direct child of #project-browser.
Attaching the SS for the same which shows the HTML structure for this.

This is how it looks after fix.Straight forward change.Marking it NR.

utkarsh_33 → created an issue.

I'll take this up.

As #3505700: Move the Project Browser-specific styling from Gin is in so we can start working on this.Marking it active.

I think it makes sense to move the css rules to gin.css.I think i didn’t completely get how points 2 and 3 makes it similar to other dropdown.If you think it makes sense then you can push the changes accordingly.

I have moved the css related to Gin into it's specific file.This is ready for review.

The checkboxes seems a bit misaligned as you can see in the SS:-

I think we can place them in centre.
Also i have an opinion,

can we use toggles instead of checkboxes?

Marking it NW just for a few css adjustment and opinions on the question.

It needs a round of manual testing and also i'm not sure about the css rule for hovering over the div.Already added the questions for the same.

This is how it looks after the fix.

utkarsh_33 → created an issue.

utkarsh_33 → made their first commit to this issue’s fork.

Marking NR.

This is how the dropdown looks:-

Closing this issue as this is not required.We still need the Installed icon according to this comment 📌 Replace install/select button with a Drupal's action button Active .

Marking it NR.

Marking it NR.

I have addressed all the feedbacks in #33, but there is on modification that i have done is where the installed icon is placed in comparisons to the dropbutton(if it exists).
I'll attach the SS for both the cases:-

1) With follow-up

2) Without Follow-up

This is what i personally think looks good instead of placing them as grid(one over the other).If someone is strictly against this design then I'm happy to change to what’s better in terms of design.
Leaving it to @chrisfromredfin and @phenaproxima for making the decision on designs.

utkarsh_33 → created an issue.

utkarsh_33 → made their first commit to this issue’s fork.

Re #24 I tested the issue and i figured out that the issue is not related to the changes that we made in this MR.The issue already exists on 2.0.x.
Steps to test the issue is try to console log the project object in the action button component and see the tasks object once the project is installed(without refreshing ) and then after refreshing.You will see that the url is not correctly passed.

utkarsh_33 → made their first commit to this issue’s fork.

utkarsh_33 → made their first commit to this issue’s fork.

I have fixed the issue related to

But clicking "Installed" just knocks you back to the top of page without explanation; it feels like a bug

And also related to what you mentioned related to

First, if you install some modules (that you don't already have), once the installation completes, the badge is rerendered as a dropdown that looks utterly broken:

I'm unable to reproduce this.It loads correctly on my local.
I suspect this could be cache issue.When you checkout the branch clear the cache before installing the any module, then it might not happen.I'll ask other community members to test this so that we can get a confirmation if the problem really exists.

Marking it NR again as things are working correctly atleast on my end.Let's wait for someone to verify what's happening.

I think we can now remove the tag as the issue summary has the complete description about the issue.

This is currently postponed on Replace install/select button with a Drupal's action button 📌 Replace install/select button with a Drupal's action button Active

utkarsh_33 → created an issue.

Addressed feedbacks🥳.

Addressed all the feedbacks and also added more tests.Marking it NR again.

All the tests are now passing.I think there is still atleast one thing that remains is that we need to disable the dropbutton if there is no follow-up action in some cases.I will take care of that as well.In the mean time I'm marking it NR so that it can undergo a round of review or manual testing.

utkarsh_33 → made their first commit to this issue’s fork.

Addressed the feedbacks.

Merged the latest changes.

I can still reproduce the problem on my local atleast.But i think this can be Postponed on https://www.drupal.org/project/project_browser/issues/3505700, as this will make easier to handle the css issues.
I am still attaching the SS for how it looks on my local.The version of Gin i am using in "3.1.0".

Left a few comments explaining some weird stuff in the nightwatch tests.Also the tests seems to fail on waiting for the search results.For now i tried adding a very big random weight so that it passes but it fails on CI consistently but it frequently passes on my local, which makes it a bit off.

I tried hard to fix the last failing test but it still fails.Somehow the tasks are coming empty in tests but not locally🥲.

Loading the CSS related to Gin conditionally as requested.Also the CI is Green so marking it NR again.

So here is the latest update on the current status of the issue:-

1. When the module is not installed then we want the normal select button as it was existing before.For that we switched to the Select/Install version of the button as you can see in the SS.
   
2. When the module is installed then we want the button to display the follow-up actions for that(for now it's just a help page's url) which might be expanded in future.The SS of how that looks is attached.
   

Remaining tasks are:-

1. Obviously get the tests fixed.
2. Get an initial review of the approach, for that i would love to get a feedback from @phenaproxima or @chrisfromredfin about the approach.I would highly encourage if you can take a pull of the MR and have a look how things are working.
3. How should we take care of the Installed status on the cards.For now i have removed the Project status indicator and replaced it with the button(which should be disabled if the module is already installed according to me).If anyone can provide a feedback on that then it would be easier for me to navigate.
4. Lastly there was an issue in tests mainly testDropButtonActions test.The problem is that even after installing the module the follow-up actions are not getting into the list of dropdown somehow.The tests failing won't give much idea as they are a rough estimate of how things should work once everything is working as expected.Currently the selector might be the issue which i can change if i get to know why the list if follow-up actions is not getting appended.

I know thats a lot of update in a single comment but i how this clarifies what is the current state of the MR and what all is required to be done/needs help with😅.

I have changed the selector coming from upstream with the selector in our scope.Marking it NR again.

This is ready for a review now.

This is how the action button looks like🥳.

Finally the tests are passing🥳🥳🥳.

Move the Project browser specific styling from gin theme to project browser's scope. 📌 Move the Project browser specific styling from gin theme to project browser's scope. Active this issue moves the styling from gin to the Project browser's scope.I think once this is in then fixing all the css related issue specific to gin would be easier.
Attaching the issue for reference.

Also adding Status icon and maintenance icon are of different size in Gin theme. 🐛 Status icon and maintenance icon are of different size in Gin theme. Active for reference as this was brought up from the comment.
I think this will also make things more simpler for The Svelte code should not have custom logic for the Gin theme 🐛 The Svelte code should not have custom logic for the Gin theme Active if i am not wrong.

Once we verify that the changes are we can ask the Gin theme maintainers to remove the styles from gin theme.I'll mark it NR and will request @chrisfromredfin or @phenaproxima to take further decisions.

utkarsh_33 → created an issue.

I completely agree with #13.I overlooked that.I have added what you suggested.

Not sure if the fix is robust enough but it definitely solves the problem.Marking it NR for opinions.

utkarsh_33 → created an issue.

Only showing the dancing dots when max_selections is 1.

utkarsh_33 → made their first commit to this issue’s fork.

If we want to follow the approach that you suggested then i have made the changes accordingly.marking it NR again.

Working on it

utkarsh_33 → made their first commit to this issue’s fork.

I am facing issues in solving the test fails.I checked the URLs formed in both 2.0.x and this branch are same.

Manually tested this and the code changes looks good to me.The three dots don't appear in both cases.

Can you also update the SS when max_selections > 1?

Removed the fragile selector as i completely agree with @phenaproxima.It's up for another round of review and some manual testing.

@lavanyatalwar the changes related to installed text looks good to me.I still think either we need to decrease the height of wrench icon or increase the pixels for both installed text and security icon.
This could also be done in a separate issue.I'll let @chrisfromredfin decide what will be a better approach.
Also it would be helpful to get Chris's feedback by pinging in Drupal slack's PB channel.

Ya please go ahead.

utkarsh_33 → made their first commit to this issue’s fork.

@phenaproxima i merged the changes that you intended to into my existing MR.It's in a working state.I would request you to review the changes and maybe close the MR that you opened.
Thanks!

I think this is now ready and changes are inline with the discussion that i had with @phenaproxima.Marking it NR .

I will discuss this with @phenaproxima and update the status of the issue soon.