- Issue created by @utkarsh_33
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
(Based on the title, I thought this was a bug in XB itself. 😇)
- First commit to issue fork.
- Merge request !1248#3529328: Selected component value not getting passed to AI agent in request for editing component → (Merged) created by Unnamed author
- 🇳🇱Netherlands balintbrews Amsterdam, NL
The current MR ensures that the most up-to-date selected component ID is always sent to the controller. However, editing a code component subsequently after creating it still doesn't work, and I'm not sure if that's only because that request never had the right component ID before, and therefore the scenario couldn't be fully tested and implemented. Either way, can I get a review on the current solution and see if anything else is needed here?
- 🇮🇳India utkarsh_33
So the current MR fixes the issue mentioned in the IS and the code looks good to me so this can be RTBC'd.
As far as the issue mentioned by @balintbrews in #9 🐛 [PP-1] Chat history not getting preserved for Deepchat on re-rendering Active is something that i can see in the network tab once the component is created but not when i try to edit the component using the code editor or using the AI bot.
It might be because of following code:-const component = message.component_structure; await createCodeComponent(component).unwrap(); navigate(`/code-editor/component/${component.machineName}`);
Upon quickly debugging i found that
component.status
isfalse
, but didn't investigate much in detail as this can be fixed as a separate issue.
@balintbrews if you think that it's not a hard blocker for this issue then i can open another issue for the point you mentioned in #9 and we can keep this issue moving forward. -
balintbrews →
committed d4e377b2 on 0.x
Issue #3529328 by balintbrews, utkarsh_33: Selected component value not...
-
balintbrews →
committed d4e377b2 on 0.x
- 🇳🇱Netherlands balintbrews Amsterdam, NL
We looked into this together with @utkarsh_33. #10 is all expected, so that's not something to be concerned about. Utkarsh is not able to reproduce what I'm seeing, while I consistently can. Granted, we're using different AI providers, which shouldn't be a problem, but maybe that's where things go differently. Either way, I'm opening a new issue to describe things in detail.
We agreed that this issue is good to land.