Jaipur, India
Account created on 22 December 2011, over 12 years ago
  • Staff Software Engineer in the Drupal Acceleration Team at Acquiaย  โ€ฆ
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I think #27 is a valid point, as related issue is still in progress.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

As system.mail no longer exists in SchemaCheckTrait ignored property paths, is this issue still relevant?

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

This issue can be closed as duplicate of โœจ Add validation constraints to image.settings Fixed which is already fixed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I think this is not an issue anymore and can be closed as outdated. Moving it to NR, so as to get more eyes on it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I think as per #14, a deprecation message needs to be added for path in system.schema.yml before removing it completely.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

CR should not be in published state, it will be published once issue is fixed

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

May be it's because field_active_installs_total has null value everywhere. Just a guess ๐Ÿค”.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Is it related to sort somehow? As when I hit https://drupalorg.prod.cluster.drupalsystems.org/jsonapi/index/project_modules?filter[status]=1&filter[project_type]=full&filter[type]=project_module&page[limit]=12&page[offset]=0&include=field_supporting_organizations,field_supporting_organizations.field_supporting_organization,field_module_categories,field_maintenance_status,field_development_status,uid,field_project_images&sort=title it is working but not when https://drupalorg.prod.cluster.drupalsystems.org/jsonapi/index/project_modules?filter[status]=1&filter[project_type]=full&filter[type]=project_module&page[limit]=12&page[offset]=0&include=field_supporting_organizations,field_supporting_organizations.field_supporting_organization,field_module_categories,field_maintenance_status,field_development_status,uid,field_project_images&sort=-active_installs_total

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Re #22, I updated the code to set values to NULL.
Reverting changes related to message(message: '') will fail ContactFormValidationTest.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Deprecation should point to CR and not issue link.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Feedback addressed

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Feedback addressed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Functional tests are failing in _install_get_version_info($version) for $version=11.0-dev in current MR and passing in 11.x ๐Ÿคฏ. I think it needs unblocking from @alexpott ๐Ÿ™

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Feedback addressed

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Re #25, Does it mean removing system_entity_view_mode_presave() from system.module and doing $view_mode->set('description', NULL)->save(); in system_post_update_convert_empty_string_entity_view_modes_to_null of system.post_update.php. Also where should we use @trigger_error in this case or it can be avoided?

When I did as above it gives Schema errors for core.entity_view_mode.node.teaser with the following errors: 0 [description] This value should not be blank.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Feedback addressed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Updating description to 'description' => NULL is giving depreciation error. Other feedback addressed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Feedback addressed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

This issue is ready for re-review. I have added the return FALSE. Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I attempted to remove the @legacy from the tests, which I added in previous commit, but it seems something was done incorrectly in the MR, resulting in deprecation errors. I would appreciate any assistance.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Moved to NW for fixing deprecation errors in better way

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I tried to add deprecation message in previous commit, not sure if this is the correct way or not. But due to this change tests started failing. https://git.drupalcode.org/issue/drupal-3445976/-/jobs/1632410#L2068

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

๐Ÿ˜ฌ Forgot to change status while cloning

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Marked NR for initial review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

I am not sure, what should be written on config save:

    $config_name = $event->getConfig()->getName();
    if ($config_name === 'core.menu.static_menu_link_overrides') {
      // What needs to be done here?
    }
๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Changes look good to me. Moving to RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

sdc_tags.settings in above list does not seems to be part of core.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

MR needs to be marked ready for review. Overall looks good to me.
Added one feedback to address.

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

narendraR โ†’ made their first commit to this issueโ€™s fork.

Production build 0.69.0 2024