narendrar → created an issue.
The created component has an outdated structure, which was changed in 📌 Consider renaming javascript component ID to 'id' rather than machineName Active . This could be the cause of the error.
"source_code_css": "",
"compiled_js": "",
"compiled_css": "",
Pulling the latest changes from the 0.x branch, rebuilding the front-end with npm install && npm run build and clearing the cache might help resolve the issue.
Please let me know if the problem persists.
Forgot to run npm commands , now it is working as shown in Demo, Thanks.
We need to decide whether considering only the SDC component for now is acceptable.
Also, I have a question: What is the purpose of using 'default_information_tools' here instead of using the tool directly?
I think we can limit scope of this issue to only create page using existing components.
Eg. "Create a page for our university website featuring a heading, a hero section, featured content, and news sections." should create the page with existing components.
Creating/editing of components using AI already exists and we should use those tools wherever required.
I tried testing the current MR, but the changes are not reflected on my local. Could I be missing something? Please see below.
narendrar → created an issue.
@marcus_johansson, I agree that adding getStructuredOutput() directly to ExecutableFunctionCallInterface may not be ideal since many tools don’t have structured data to return. Creating a new interface that extends ExecutableFunctionCallInterface and updating plugin manager is a better option.
narendrar → created an issue.
narendrar → created an issue.
Tool tests are already covered as part of
🐛
External AI Chatbot Functionality
Active
. We still need to decide what additional test coverage is needed for this issue.
We probably need to write tests that override the actual response of modules/xb_ai/src/Controller/XbBuilder.php and test it on the front-end.
Basic Kernel tests are added to test tools functionality, similar to what is done in ai_agents module https://git.drupalcode.org/project/ai_agents/-/tree/1.2.x/tests/src/Kernel/Plugin/AiFunctionCall?ref_type=heads. In
📌
[PP-1] Add test coverage for Experience builder AI submodule.
Active
we can extend tests to test front-end/api part. I will update
📌
[PP-1] Add test coverage for Experience builder AI submodule.
Active
also to discuss and decide what all needs to be covered in test.
narendrar → created an issue.
Done as part of 🐛 External AI Chatbot Functionality Active
narendrar → created an issue.
narendrar → created an issue.
This will be fixed in 🐛 External AI Chatbot Functionality Active itself as suggested in #3
narendrar → created an issue.
narendrar → made their first commit to this issue’s fork.
narendrar → created an issue.
This works for me. Tested it by creating custom tokens and context for those tokens is available in sub-agents.
marcus_johansson → credited narendrar → .
I tested this MR and it works as expected.
marcus_johansson → credited narendrar → .
narendrar → created an issue.
I couldn't reproduce this issue in tests, although it was reproducible locally. This fix resolved the issue, and I updated the existing test to cover the scenario of selecting the second instance first.
narendrar → made their first commit to this issue’s fork.
Test need to be updated to validate the existence of text.
All reference of ProjectBrowserUiTestTrait::pressWithWait() are removed and tests are passing 👍. Moving it to RTBC.
narendrar → made their first commit to this issue’s fork.
narendrar → created an issue.
Feedback addressed, moving it to RTBC, Thanks.
All changes look good, tests are passing, moving it to RTBC.
tim.plunkett → credited narendrar → .
narendrar → made their first commit to this issue’s fork.
narendrar → made their first commit to this issue’s fork.
Earlier all projects were re-rendered on installing project. Adding related issue 🐛 [Svelte] Remove the $updated key Active
I think this is not required if we use Clear filters and then test. However it may require if we want to show pagination with Recommended filters in tests.
narendrar → made their first commit to this issue’s fork.
The background and text color of Filter by category items is different from other filters eg Security advisory coverage.
Also suggested some css change.
Changes seems straightforward and tests are passing. Moving it to RTBC.
This is blocked on 📌 Add a test of multiple project browsers on a page Active
I think we can click 'Clear filters' as done in ProjectBrowserUiTest::testPaging() to test this.
narendrar → created an issue.
narendrar → made their first commit to this issue’s fork.
Re #23, Tested manually and it is working on my end. One problem which I see is that Uninstall should take you to current page and not /admin/modules/uninstall after a module is installed and you try to uninstall it without refreshing the page.
Overall, this looks good to me. Just a few suggestions.
Thanks for the review, @phenaproxima! I’ve addressed the feedback and made some refinements.
Tested manually and observed that the page scrolls on initial load (when navigating to /admin/modules/browse/drupalorg_jsonapi, the page automatically scrolls to the list). This behaviour seems incorrect to me.
narendrar → created an issue.
Looks good, some change suggested.
narendrar → made their first commit to this issue’s fork.
This issue is ready for review.
narendrar → made their first commit to this issue’s fork.
Tests added
Basic functionality is ready. This MR needs tests and a way to filter development status.
narendrar → created an issue.
narendrar → created an issue.
I will implement in MR as suggested in #7
Should a new plugin listing locally available Core, Contrib, and Custom modules be implemented?
- This plugin will exclude test modules and sub-modules.
- It will support all filters from the drupalorg_jsonapi plugin.
- Sorting options: A-Z, Z-A.
- Category filtering will include options from both drupal_core and drupalorg_jsonapi plugins.
Changes looks good to me.
Re #9, This intermittent announce issue seems to exist on 2.0.x also and can be skipped for now.
The single instance which I found (not in svelte code) is
/**
* Tests that adding projects to queue is plugin specific.
*/
public function testPluginSpecificQueue(): void {
I think, this can also be addressed in this issue.
Tested manually and it seems that On selecting multiple categories, it does not announce the Count of selected categories when voiceover is on.
narendrar → made their first commit to this issue’s fork.
Tests fixed and CR added. This issue can be reviewed again. Thanks