🇮🇳India @narendraR

Changes done as suggested in #14

I couldn't reproduce this issue in tests, although it was reproducible locally. This fix resolved the issue, and I updated the existing test to cover the scenario of selecting the second instance first.

narendrar → made their first commit to this issue’s fork.

Test need to be updated to validate the existence of text.

All reference of ProjectBrowserUiTestTrait::pressWithWait() are removed and tests are passing 👍. Moving it to RTBC.

narendrar → made their first commit to this issue’s fork.

narendrar → created an issue.

Feedback addressed, moving it to RTBC, Thanks.

All changes look good, tests are passing, moving it to RTBC.

tim.plunkett → credited narendrar → .

narendrar → made their first commit to this issue’s fork.

narendrar → made their first commit to this issue’s fork.

Earlier all projects were re-rendered on installing project. Adding related issue 🐛 [Svelte] Remove the $updated key Active

I think this is not required if we use Clear filters and then test. However it may require if we want to show pagination with Recommended filters in tests.

narendrar → made their first commit to this issue’s fork.

The background and text color of Filter by category items is different from other filters eg Security advisory coverage.
Also suggested some css change.

Changes seems straightforward and tests are passing. Moving it to RTBC.

This is blocked on 📌 Add a test of multiple project browsers on a page Active

I think we can click 'Clear filters' as done in ProjectBrowserUiTest::testPaging() to test this.

narendrar → created an issue.

narendrar → made their first commit to this issue’s fork.

Re #23, Tested manually and it is working on my end. One problem which I see is that Uninstall should take you to current page and not /admin/modules/uninstall after a module is installed and you try to uninstall it without refreshing the page.

Overall, this looks good to me. Just a few suggestions.

Thanks for the review, @phenaproxima! I’ve addressed the feedback and made some refinements.

Tested manually and observed that the page scrolls on initial load (when navigating to /admin/modules/browse/drupalorg_jsonapi, the page automatically scrolls to the list). This behaviour seems incorrect to me.

narendrar → created an issue.

Looks good, some change suggested.

narendrar → made their first commit to this issue’s fork.

This issue is ready for review.

narendrar → made their first commit to this issue’s fork.

Tests added

Basic functionality is ready. This MR needs tests and a way to filter development status.

narendrar → created an issue.

narendrar → created an issue.

I will implement in MR as suggested in #7

Should a new plugin listing locally available Core, Contrib, and Custom modules be implemented?

• This plugin will exclude test modules and sub-modules.
• It will support all filters from the drupalorg_jsonapi plugin.
• Sorting options: A-Z, Z-A.
• Category filtering will include options from both drupal_core and drupalorg_jsonapi plugins.

Changes looks good to me.

Re #9, This intermittent announce issue seems to exist on 2.0.x also and can be skipped for now.

The single instance which I found (not in svelte code) is

  /**
   * Tests that adding projects to queue is plugin specific.
   */
  public function testPluginSpecificQueue(): void {

I think, this can also be addressed in this issue.

Tested manually and it seems that On selecting multiple categories, it does not announce the Count of selected categories when voiceover is on.

narendrar → made their first commit to this issue’s fork.

Tests fixed and CR added. This issue can be reviewed again. Thanks

narendrar → created an issue.

Based on #9, moving it to needs work.

This issue is NR for further feedback. Thanks

Test fixed

narendrar → made their first commit to this issue’s fork.

narendrar → created an issue.

Should this issue be Closed(outdated) now as after ✨ Make all enabled sources exposed as local tasks Active queue is not maintained across plugins?

Updated method comments and changes done as suggested.
I think this is ready for review again.

narendrar → made their first commit to this issue’s fork.

Test added, Changes looks good to me. Moving it to RTBC.

@rkoller In ✨ Make all enabled sources exposed as local tasks Active , Svelte tabs have been replaced. Do you think this issue should now be closed?

tim.plunkett → credited narendrar → .

narendrar → created an issue.

Re #6, The problem with moving the install readiness checks to \Drupal\project_browser\Controller\InstallerController::begin() is:

• The user will not know beforehand if there are errors or warnings on the page.
• sveltejs/src/Project/ActionButton.svelte uses this value to work/display the button based on errors or warnings.

narendrar → made their first commit to this issue’s fork.

phenaproxima → credited narendrar → .

With latest commit https://git.drupalcode.org/issue/drupal_cms-3495711/-/commit/4fbe9a9586e..., now there is only one issue in this integration. I am not able to import default content added in content/xb_page and getting same error as in #3

Steps to make current MR work:

• Rename recipes/drupal_cms_xb/content to recipes/drupal_cms_xb/content_old
• Run ddev rebuild && ddev launch in terminal and follow steps of installation
• Run ddev drush php:eval "(\Drupal\experience_builder\Entity\Page::create(['type' => 'xb_page', 'title' => 'Test']))->save();" in terminal
• Visit https://drupal-cms-dev.ddev.site/xb/xb_page/1/editor.

In current MR, I am not able to import content added in recipes/drupal_cms_xb/content/xb_page/20354d7a-e4fe-47af-8ff6-187bca92f3f7.yml. I am getting error ResponseText: Drupal\Core\DefaultContent\InvalidEntityException: /var/www/html/vendor/composer/../..//recipes/drupal_cms_xb/content/xb_page/20354d7a-e4fe-47af-8ff6-187bca92f3f7.yml: components.0=The array must contain a "tree" key.||components.0=The array must contain a "props" key. in Drupal\Core\DefaultContent\Importer->importContent() (line 113 of /var/www/html/web/core/lib/Drupal/Core/DefaultContent/Importer.php).

Currently, I am doing the steps below to make this MR somewhat work.

• Rename recipes/drupal_cms_xb/content to recipes/drupal_cms_xb/content_old
• Run ddev rebuild && ddev launch in terminal and follow steps of installation
• Run ddev drush php:eval "(\Drupal\experience_builder\Entity\Page::create(['type' => 'xb_page', 'title' => 'Test']))->save();" in terminal
• cd web/modules/contrib/experience_builder/ui
• npm install && npm run drupaldev
• Visit https://drupal-cms-dev.ddev.site/xb/xb_page/1/editor. This also gives console warning Warning: Each child in a list should have a unique "key" prop.

Test failures seems not related to this issue. Other feedback addressed. It is ready for review again.

narendrar → created an issue.

The functionality is complete, but tests are failing due to changes in functionality. I will update the tests if the changes in the MR align with the requirements specified in the issue.

narendrar → made their first commit to this issue’s fork.

Should we close the existing modal before showing the View Commands modal on click?
Here are the two scenarios to consider:

• If the user clicks View Commands directly on the browse page, show the View Commands modal.
• If the user clicks View Commands from within a modal, close the existing modal, show the View Commands modal, and on closing this modal, reopen the previous modal from which the user initiated the action.

Tried updating the IS as per #41. Does it make sense to show these icons on source plugins other than contributed projects, such as recipes or core modules?

Changes look good to me. Just a small nit to address. Tested manually, and the filters are working as they did on 2.0.x.

Tested manually, and the change in page size in one tab is properly reflected in another tab. Moving it to RTBC.

Closing this issue as Closed(cannot reproduce),

The changes look good to me. We can improve them later if needed, but I think this is good to go for now.

This MR needs re-roll.