You can remove the profile from /admin/modules/uninstallpage.
@alexpott, I tried to create a new constraint as suggested in #23. But I don't understand how to bypass existingNotNullConstraint for UUID. https://git.drupalcode.org/project/drupal/-/merge_requests/7723/diffs?commit_id=4fcb5099b2b23f22643948c901321db04b89b0db#4d658554b6066a85600dfbe03dc34c3003f8a3e1_0_32
narendraR → created an issue.
Changes looks good to me.
narendraR → made their first commit to this issue’s fork.
As system.mail no longer exists in SchemaCheckTrait ignored property paths, is this issue still relevant?
This issue can be closed as duplicate of ✨ Add validation constraints to image.settings Fixed which is already fixed.
I think this is not an issue anymore and can be closed as outdated. Moving it to NR, so as to get more eyes on it.
I think as per #14, a deprecation message needs to be added for path in system.schema.yml before removing it completely.
CR should not be in published state, it will be published once issue is fixed
May be it's because field_active_installs_total has null value everywhere. Just a guess 🤔.
Is it related to sort somehow? As when I hit https://drupalorg.prod.cluster.drupalsystems.org/jsonapi/index/project_modules?filter[status]=1&filter[project_type]=full&filter[type]=project_module&page[limit]=12&page[offset]=0&include=field_supporting_organizations,field_supporting_organizations.field_supporting_organization,field_module_categories,field_maintenance_status,field_development_status,uid,field_project_images&sort=title it is working but not when https://drupalorg.prod.cluster.drupalsystems.org/jsonapi/index/project_modules?filter[status]=1&filter[project_type]=full&filter[type]=project_module&page[limit]=12&page[offset]=0&include=field_supporting_organizations,field_supporting_organizations.field_supporting_organization,field_module_categories,field_maintenance_status,field_development_status,uid,field_project_images&sort=-active_installs_total
Re #22, I updated the code to set values to NULL.
Reverting changes related to message(message: '') will fail ContactFormValidationTest.
PP on 📌 Allow parsing and writing PHP constants and enums in YAML files Needs work
Deprecation should point to CR and not issue link.
Re #2, I think so mean to say PP on 📌 Allow parsing and writing PHP constants and enums in YAML files Needs work
Feedback addressed
narendraR → created an issue.
narendraR → created an issue.
Feedback addressed.
narendraR → made their first commit to this issue’s fork.
narendraR → made their first commit to this issue’s fork.
narendraR → created an issue.
Functional tests are failing in _install_get_version_info($version) for $version=11.0-dev in current MR and passing in 11.x 🤯. I think it needs unblocking from @alexpott 🙏
Feedback addressed
Re #25, Does it mean removing system_entity_view_mode_presave() from system.module and doing $view_mode->set('description', NULL)->save(); in system_post_update_convert_empty_string_entity_view_modes_to_null of system.post_update.php. Also where should we use @trigger_error in this case or it can be avoided?
When I did as above it gives Schema errors for core.entity_view_mode.node.teaser with the following errors: 0 [description] This value should not be blank.
Feedback addressed.
Updating description to 'description' => NULL is giving depreciation error. Other feedback addressed.
Feedback addressed.
This issue is ready for re-review. I have added the return FALSE. Thanks
I attempted to remove the @legacy from the tests, which I added in previous commit, but it seems something was done incorrectly in the MR, resulting in deprecation errors. I would appreciate any assistance.
Moved to NW for fixing deprecation errors in better way
narendraR → created an issue.
narendraR → created an issue.
I tried to add deprecation message in previous commit, not sure if this is the correct way or not. But due to this change tests started failing. https://git.drupalcode.org/issue/drupal-3445976/-/jobs/1632410#L2068
thejimbirch → credited narendraR → .
narendraR → created an issue.
😬 Forgot to change status while cloning
narendraR → created an issue.
narendraR → created an issue.
narendraR → created an issue.
Marked NR for initial review.
I am not sure, what should be written on config save:
$config_name = $event->getConfig()->getName();
if ($config_name === 'core.menu.static_menu_link_overrides') {
// What needs to be done here?
}narendraR → created an issue.
Changes look good to me. Moving to RTBC
narendraR → created an issue.
sdc_tags.settings in above list does not seems to be part of core.