🇮🇳India @narendraR

narendraR → created an issue.

😬 Forgot to change status while cloning

narendraR → created an issue.

narendraR → created an issue.

narendraR → created an issue.

Marked NR for initial review.

I am not sure, what should be written on config save:

    $config_name = $event->getConfig()->getName();
    if ($config_name === 'core.menu.static_menu_link_overrides') {
      // What needs to be done here?
    }

Follow-up 🐛 [PP-1] Remove `system.theme` entry from \Drupal\Core\Config\Schema\SchemaCheckTrait::$ignoredPropertyPaths Active .

narendraR → created an issue.

Changes look good to me. Moving to RTBC

narendraR → created an issue.

sdc_tags.settings in above list does not seems to be part of core.

MR needs to be marked ready for review. Overall looks good to me.
Added one feedback to address.

narendraR → made their first commit to this issue’s fork.

narendraR → created an issue.

Not sure what next should be done in this issue, hence marking it for another review.

narendraR → created an issue.

Tests passing, changes looks good to me. Moving to RTBC.

I tried to add a test in previous commit, which should fail, but it is not failing. 🤷‍♂️

narendraR → made their first commit to this issue’s fork.

narendraR → created an issue.

narendraR → created an issue.

narendraR → created an issue.

alexpott → credited narendraR → .

narendraR → made their first commit to this issue’s fork.

Sorry, but I don't get #17. As per #13, Only lowercase alphanumeric characters and underscores are allowed, and only lowercase letters and underscore are allowed as the first character.

narendraR → created an issue.

Adding _ in the end of field prefix failed core/modules/field_ui/tests/src/Functional/ManageFieldsFunctionalTest::testFieldPrefix. Either that test needs to be adjusted as per new validation rule or _ in the end of field prefix is not necessary. For now, I am removing the _ from field prefix end.

narendraR → created an issue.

narendraR → changed the visibility of the branch 3437325-add-validation-constraints to hidden.

narendraR → created an issue.

I think that is already handled in core/modules/field/src/Entity/FieldStorageConfig::__construct

if (!preg_match('/^[_a-z]+[_a-z0-9]*$/', $values['field_name'])) {
throw new FieldException("Attempt to create a field storage {$values['field_name']} with invalid characters. Only lowercase alphanumeric characters and underscores are allowed, and only lowercase letters and underscore are allowed as the first character");
}

Looks good to me, moving to RTBC.

narendraR → created an issue.

narendraR → made their first commit to this issue’s fork.

smustgrave → credited narendraR → .

Thanks for the follow-up. One test scenario which is missing here is "Imported node with owned by user that does not exist".
Rest LGTM.

A follow-up documentation issue might be required to help understand how content can be created/imported using recipe system.

narendraR → created an issue.

A follow-up documentation issue is needed to include this change. Rest looks good to me.

Done #61.2

Thanks @phenaproxima, Changes looks good to me.

I think follow up needs to be created to update the recipe documentation to include this feature.

narendraR → made their first commit to this issue’s fork.

Re #7, Test started failing after reverting the changes.