This makes a lot of sense, some real fun nuance in there with
- private ?array $values = NULL;
+ private array $values = [];
:D
Great work, thanks!
lol not me testing this MR, staring at Browse trying to figure out where Recipes are, then seeing it right next to it at the top level. that's the point!
UI looks good, and I reviewed the code and the tests. Great work!
This could use a new title, since it's not specifically about Drupal CMS.
We're tracking it, however, using a new tag.
✨ Make the "add to cart" threshold configurable Active allows DCMS to sidestep this issue.
phenaproxima → credited tim.plunkett → .
Says it needs a rebase, but otherwise good to go!
pameeela → credited tim.plunkett → .
pameeela → credited tim.plunkett → .
There was a mistake made on our end which removed the zip file, hence the 404. The link should work again.
tim.plunkett → created an issue.
Based on my conversation with @phenaproxima, part of why it's affixed with .command was to make it clickable in MacOS. Except that regardless of what directory it is in, it runs in my home directory (~) and then fails.
I also discussed with @pameeela and she pushed back on using .command instead of the more common .sh
If this were the only CLI thing and we could actually make everything doable from a GUI, then I'd be all for it. But we still need the CLI to get DDEV running anyway.
So let's change this to launch-drupal-cms.sh and commit it. Unassigning myself so I don't block this while traveling.
Ah you fancy! I take it back
It's set to dev, which I guess is even worse?
I agree with @longwavein #2, this would have been a lot more helpful if #2926914-30: Rewrite \Drupal\layout_builder\Section to represent the entire section, not just the block info → had explained how I ended up with this. I definitely recall wrestling with TypedData and the inherent magic-ness of setValue(), and I think I was just trying to save my sanity by having it blow up if something else was passed in.
The change here is sound, and the tests look good.
From the CR:
If custom or contrib JavaScript is implicitly depending on vertical-tabs.js being loaded very early, this might result in regressions
more like custom, contrib, or core ;)
🐛
Block visibility settings have summary duplicated in the title
Active
Crediting @lauriii who found the bug. NW for tests
tim.plunkett → created an issue.
tim.plunkett → created an issue.
This was broken by this commit, which was committed directly to the repo without a d.o issue.
I discussed this with @anish.a at DrupalCon, and while I suggested that he add test coverage, there are no tests in the module that I could find!
Bumping priority to major and assigning to @mandclu
Cool, thanks @thejimbirch! (and joachim).
Leaving to @phenaproxima to decide if he wants to use this and then to wire it up, but running it in the built zip directory gives this output:
packages:
asm89/stack-cors: v2.2.0
carbonphp/carbon-doctrine-types: 3.2.0
chi-teck/drupal-code-generator: 4.1.0
clue/stream-filter: v1.7.0
commerceguys/addressing: v2.2.3
composer/installers: v2.3.0
composer/semver: 3.4.3
consolidation/annotated-command: 4.10.0
consolidation/config: 3.1.0
consolidation/filter-via-dot-access-data: 2.0.2
consolidation/log: 3.1.0
consolidation/output-formatters: 4.6.0
consolidation/robo: 5.1.0
consolidation/site-alias: 4.1.0
consolidation/site-process: 5.4.0
davedevelopment/stiphle: 0.9.4
dflydev/dot-access-data: v3.0.3
doctrine/annotations: 2.0.2
doctrine/collections: 2.2.2
doctrine/deprecations: 1.1.3
doctrine/inflector: 2.0.10
doctrine/lexer: 2.1.1
dragonmantank/cron-expression: v3.4.0
drupal/add_content_by_bundle: 1.2.2
drupal/address: 2.0.2
drupal/addtocal_augment: 1.2.3
drupal/ai: 1.0.0-beta4
drupal/ai_agents: 1.0.0-alpha1
drupal/ai_image_alt_text: 1.0.0-alpha1
drupal/ai_provider_anthropic: 1.0.0-beta2
drupal/ai_provider_openai: 1.0.0-beta1
drupal/ai_simple_provider_installer: 1.0.0-alpha3
drupal/antibot: 2.0.4
drupal/automatic_updates: 3.1.6
drupal/autosave_form: 1.7.0
drupal/better_exposed_filters: 7.0.2
drupal/bpmn_io: 2.0.2
drupal/captcha: 2.0.7
drupal/checklistapi: 2.1.6
drupal/coffee: 2.0.0
drupal/core: 11.1.0-rc1
drupal/core-composer-scaffold: 11.1.0-rc1
drupal/core-project-message: 11.1.0-rc1
drupal/core-recommended: 11.1.0-rc1
drupal/crop: 2.4.0
drupal/ctools: 4.1.0
drupal/dashboard: 2.0.0-beta1
drupal/date_augmenter: 1.1.1
drupal/drupal_cms_accessibility_tools: 1.0.0-rc1
drupal/drupal_cms_admin_ui: 1.0.0-rc1
drupal/drupal_cms_ai: 1.0.0-rc1
drupal/drupal_cms_analytics: 1.0.0-rc1
drupal/drupal_cms_anti_spam: 1.0.0-rc1
drupal/drupal_cms_authentication: 1.0.0-rc1
drupal/drupal_cms_blog: 1.0.0-rc1
drupal/drupal_cms_case_study: 1.0.0-rc1
drupal/drupal_cms_content_type_base: 1.0.0-rc1
drupal/drupal_cms_events: 1.0.0-rc1
drupal/drupal_cms_forms: 1.0.0-rc1
drupal/drupal_cms_image: 1.0.0-rc1
drupal/drupal_cms_news: 1.0.0-rc1
drupal/drupal_cms_olivero: 1.0.0-rc1
drupal/drupal_cms_page: 1.0.0-rc1
drupal/drupal_cms_person: 1.0.0-rc1
drupal/drupal_cms_privacy_basic: 1.0.0-rc1
drupal/drupal_cms_project: 1.0.0-rc1
drupal/drupal_cms_remote_video: 1.0.0-rc1
drupal/drupal_cms_search: 1.0.0-rc1
drupal/drupal_cms_seo_basic: 1.0.0-rc1
drupal/drupal_cms_seo_tools: 1.0.0-rc1
drupal/drupal_cms_starter: 1.0.0-rc1
drupal/easy_breadcrumb: 2.0.9
drupal/easy_email: 3.0.3
drupal/easy_email_express: 1.0.3
drupal/easy_email_standard: 1.0.2
drupal/easy_email_text_format: 1.0.2
drupal/easy_email_theme: 1.0.0
drupal/easy_email_types_core: 1.0.3
drupal/easy_email_types_default: 1.0.1
drupal/eca: 2.1.0-beta1
drupal/eca_modeller_bpmn: 2.0.8
drupal/eca_ui: 2.0.8
drupal/editoria11y: 2.2.0-rc7
drupal/field_group: 3.6.0
drupal/focal_point: 2.1.2
drupal/friendly_captcha_challenge: 0.9.18
drupal/friendlycaptcha: 1.1.3
drupal/geocoder: 4.25.0
drupal/geofield: 1.62.0
drupal/gin: 3.0.0-rc14
drupal/gin_toolbar: 1.0.0-rc6
drupal/google_tag: 2.0.7
drupal/honeypot: 2.2.0
drupal/jquery_ui: 1.7.0
drupal/jquery_ui_resizable: 2.1.0
drupal/key: 1.19.0
drupal/klaro: 3.0.0-rc13
drupal/klaro_js: 3.0.0
drupal/leaflet: 10.2.29
drupal/linkit: 7.0.0-alpha2
drupal/login_emailusername: 3.0.0-rc1
drupal/mailsystem: 4.5.0
drupal/menu_link_attributes: 1.5.0
drupal/metatag: 2.1.0
drupal/pathauto: 1.13.0
drupal/project_browser: 2.0.0-alpha6
drupal/redirect: 1.10.0
drupal/robotstxt: 1.6.0
drupal/sam: 1.3.2
drupal/search_api: 1.37.0
drupal/search_api_autocomplete: 1.9.0
drupal/search_api_exclude: 2.0.3
drupal/selective_better_exposed_filters: 3.0.3
drupal/seo_checklist: 5.2.2
drupal/simple_search_form: 1.6.0
drupal/simple_sitemap: 4.2.2
drupal/sitemap: 2.0.0
drupal/smart_date: 4.2.1
drupal/svg_image: 3.2.0
drupal/symfony_mailer_lite: 2.0.2
drupal/token: 1.15.0
drupal/token_or: 2.3.0
drupal/trash: 3.0.9
drupal/webform: 6.3.0-alpha2
drush/drush: 13.3.3
egulias/email-validator: 4.0.2
enshrined/svg-sanitize: 0.20.0
geocoder-php/common-http: 4.6.0
geocoder-php/nominatim-provider: 5.7.0
grasmash/expander: 3.0.1
grasmash/yaml-cli: 3.2.1
guzzlehttp/guzzle: 7.9.2
guzzlehttp/promises: 2.0.4
guzzlehttp/psr7: 2.7.0
html2text/html2text: 4.3.2
illuminate/collections: v11.34.2
illuminate/conditionable: v11.34.2
illuminate/contracts: v11.34.2
illuminate/macroable: v11.34.2
illuminate/support: v11.34.2
itamair/geophp: '1.6'
joachim-n/composer-manifest: 1.1.6
laravel/prompts: v0.1.25
league/container: 4.2.4
league/html-to-markdown: 5.1.1
masterminds/html5: 2.9.0
mck89/peast: v1.16.3
mtownsend/xml-to-array: 2.0.0
nesbot/carbon: 3.8.2
nikic/php-parser: v5.3.1
openai-php/client: v0.10.3
pear/archive_tar: 1.5.0
pear/console_getopt: v1.4.3
pear/pear-core-minimal: v1.10.16
pear/pear_exception: v1.0.2
phootwork/collection: v3.2.3
phootwork/lang: v3.2.3
php-http/discovery: 1.20.0
php-http/guzzle7-adapter: 1.1.0
php-http/httplug: 2.4.1
php-http/message: 1.16.2
php-http/multipart-stream-builder: 1.4.2
php-http/promise: 1.3.1
php-tuf/composer-stager: v2.0.0-rc6
phpowermove/docblock: v4.0
psr/cache: 3.0.0
psr/clock: 1.0.0
psr/container: 2.0.2
psr/event-dispatcher: 1.0.0
psr/http-client: 1.0.3
psr/http-factory: 1.1.0
psr/http-message: '2.0'
psr/log: 3.0.2
psr/simple-cache: 3.0.0
psy/psysh: v0.12.6
ralouphie/getallheaders: 3.0.3
revolt/event-loop: v1.0.6
sebastian/diff: 5.1.1
simshaun/recurr: v5.0.2
symfony/clock: v7.2.0
symfony/console: v7.2.0
symfony/css-selector: v7.2.0
symfony/dependency-injection: v7.2.0
symfony/deprecation-contracts: v3.5.1
symfony/error-handler: v7.2.0
symfony/event-dispatcher: v7.2.0
symfony/event-dispatcher-contracts: v3.5.1
symfony/filesystem: v7.2.0
symfony/finder: v7.2.0
symfony/http-foundation: v7.2.0
symfony/http-kernel: v7.2.0
symfony/mailer: v7.2.0
symfony/mime: v7.2.0
symfony/polyfill-ctype: v1.31.0
symfony/polyfill-iconv: v1.31.0
symfony/polyfill-intl-grapheme: v1.31.0
symfony/polyfill-intl-idn: v1.31.0
symfony/polyfill-intl-normalizer: v1.31.0
symfony/polyfill-mbstring: v1.31.0
symfony/polyfill-php81: v1.31.0
symfony/polyfill-php83: v1.31.0
symfony/process: v7.2.0
symfony/psr-http-message-bridge: v7.2.0
symfony/routing: v7.2.0
symfony/serializer: v7.2.0
symfony/service-contracts: v3.5.1
symfony/string: v7.1.8
symfony/translation: v7.2.0
symfony/translation-contracts: v3.5.1
symfony/validator: v7.2.0
symfony/var-dumper: v7.2.0
symfony/var-exporter: v7.1.6
symfony/yaml: v7.2.0
tijsverkoyen/css-to-inline-styles: v2.2.7
twig/twig: v3.15.0
voku/portable-ascii: 2.0.3
webmozart/assert: 1.11.0
willdurand/geocoder: 4.6.0
wpai-inc/anthropic-sdk-php: 0.2.1
yethee/tiktoken: 0.5.1
:facepalm: on the tags
Crosspost. There were too many existing merge commits to sanely rebase this, which was sad. So I'm adding to the pile by merging, again
Attempting a rebase, this is trickier because of all the hook conversions
#13 is potentially caused by / related to 🐛 Google Tag makes CSS aggregates uncacheable Active
Fantastic work!
I read through the other FormElements and I *think* checkbox is the only one we need to special case. At the least, this is a good fix.
Given that ✨ [PP-1] Give recipes a way to group and organize their inputs, when they are presented in a form Postponed exists, I think this is a pretty nice way of handling this. Great work!
tim.plunkett → created an issue.
If a committer could fix the spacing on the @todo before merge, that'd be cool. But this looks great, thanks!
Looks great, thanks for the follow-ups!
No meeting happened that week, due to no agenda. No credit for me please!
This needs steps to reproduce, or it can be closed.
My expectation is that if you never interact with the Sort option, every tab should be sorted by their default sort.
But if you select a specific Sort for one tab, it should persist across tabs when possible.
For example, if you select Z-A on one tab, it should be used across all tabs.
Looking into this
Reviewed, merging.
tim.plunkett → made their first commit to this issue’s fork.
alexpott → credited tim.plunkett → .
Removing tags from the dupe
This has a legit merge conflict after 🐛 Selected categories disappear on switching tabs Active went in, not just on the compiled svelte.
catch → credited tim.plunkett → .
Re-targeted!
gábor hojtsy → credited tim.plunkett → .
xjm → credited tim.plunkett → .
xjm → credited tim.plunkett → .
@baluertl, I see how you mistook @dww's comment as him "losing his temper", but he was stating a fact. Feature branch commit messages can be anything, and that's okay.
The point I am not clear on is why this wouldn't affect contrib.
Contrib projects have the same commit message format as core, and have for as long as I can remember.
I would expect contrib to adopt this change too.
Merged!
tim.plunkett → made their first commit to this issue’s fork.
tim.plunkett → made their first commit to this issue’s fork.
Added https://git.drupalcode.org/project/drupal_cms/-/commit/f2ca0f5566e3739de... after the fact
okay, so more like 144 hours ;)
Adding @mandclu!
tim.plunkett → made their first commit to this issue’s fork.
As a former/inactive maintainer, I'd be happy to add @mandclu as a maintainer.
Based on your response @dakala, sounds like you agree as well.
I will wait 48 hours and then add @mandclu unless @dakala says "go" or "no" sooner :)
Updated to indicated assigned status
Assigning to track lead (co-lead with @_doyle_, picked first one alphabetically)
Assigning to Pam representing the Leadership Team
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Assigning to track lead.
Kristen Pol → credited tim.plunkett → .
Great work, all!
Reviewed
quietone → credited tim.plunkett → .
Great work @phenaproxima!
tim.plunkett → made their first commit to this issue’s fork.
chrisfromredfin → credited tim.plunkett → .
tim.plunkett → made their first commit to this issue’s fork.
Merged !511 🎉
Wim Leers → credited tim.plunkett → .
Wim Leers → credited tim.plunkett → .
@phenaproxima and I discussed this over the past few days, this is ready now.
larowlan → credited tim.plunkett → .
Adding credit
tim.plunkett → created an issue.
Thanks!
tim.plunkett → made their first commit to this issue’s fork.
from @longwave in Slack:
MRs against 11.x are ok and will be preferred once 11.0.0-beta1 is out and 11.1-only changes go into 11.x (yes this is confusing, can't wait until we can use
main)