🇺🇸United States @tim.plunkett

Philadelphia
Account created on 14 February 2008, almost 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States tim.plunkett Philadelphia

Reviewed it, all my feedback has been resolved and so was the remaining items from previous reviews.

🇺🇸United States tim.plunkett Philadelphia

This is a draft CR, the issue it describes was never merged into Drupal Core (as of today, 2026-01-13)

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

tim.plunkett created an issue.

🇺🇸United States tim.plunkett Philadelphia

Merging next

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

From #9:

How will this work once we have multiple Content templates enabled?
Now we only allow to edit the "Default / Full" content template, but that will change in the future.

Did this ever get answered?

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Discussed with Utkarsh, Naren, Ted, and Sergiu today.

For building *landing pages*, we agreed that Figma integration would be the top priority.

But for generating actual content (i.e. nodes), the `.doc` / `.md` and `.csv` approach sounds promising.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged. Please open a follow-up next time @heyyo! Thanks.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett created an issue.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

Thanks @justafish!
Merged

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Marking back to NW for now

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

This is failing on CI with:

    1 test triggered 1 PHP warning:
    
    1) /builds/project/canvas/modules/canvas_ai/src/CanvasAiPageBuilderHelper.php:144
    Undefined array key "props"
🇺🇸United States tim.plunkett Philadelphia

Adding the *original* issue that introduced this.
Reviewed with @justafish at DC Vienna, I'm signing off on this as the AJAX subsystem maintainer.

🇺🇸United States tim.plunkett Philadelphia

Reviewing.

🇺🇸United States tim.plunkett Philadelphia

Merged !83, leaving open for !82

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged!

🇺🇸United States tim.plunkett Philadelphia
🇺🇸United States tim.plunkett Philadelphia

I would like to opt-in this module: http://www.drupal.org/project/conductor
It has 15 open and 58 total issues, and all maintainers agree we are ready to try GitLab issues. We understand we cannot revert this change and there may be some unexpected issues as early adopters.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett created an issue.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

We don't have a d.o issue open yet, but we're tracking #5 more generically.

I merged the basic MR for now, as it can't hurt.
Thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, @justafish might clean up, but this is good enough for now!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Fixing component

🇺🇸United States tim.plunkett Philadelphia

Fixing component

🇺🇸United States tim.plunkett Philadelphia

Fixing component

🇺🇸United States tim.plunkett Philadelphia

Fixing component

🇺🇸United States tim.plunkett Philadelphia

Fixing component

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Agreed that Scenario 2 can be done in a follow-up issue.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

This looks good but there are minor merge conflicts after 📌 Canvas AI: #3533079 Sub Issue: Move layout model to currentValuesRef instead of separate layoutModelRef Needs review
Please set back to RTBC after fixing

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

Merged, thanks!

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

🇺🇸United States tim.plunkett Philadelphia

tim.plunkett made their first commit to this issue’s fork.

Production build 0.71.5 2024