- Issue created by @utkarsh_33
- Merge request !772#3511104; The dropbutton has extra width when opening in the modal. → (Merged) created by utkarsh_33
- 🇮🇳India utkarsh_33
This is how it looks after fix.Straight forward change.Marking it NR.
- 🇮🇳India snehal-chibde
hello @utkarsh_33 can you please mention the steps to reproduce this issue please. I am on 2.0 branch but not able to see help dropdown on the modal
- 🇮🇳India snehal-chibde
hello @utkarsh_33 ,Installed the package manager module as instructed,and checked this on Gin theme v8.3, the issue does not replicate for me. Added screenshot for reference
- 🇮🇳India utkarsh_33
Re #6 I can see the SS that you attached still have the issue that's reported here.The width of the installed image and the drop button are still different,You can see the SS in #3 how it looks after the fix.
- 🇮🇳India snehal-chibde
hello @utkarsh_33, thanks , checked this on Gin theme v8.3, MR gets applied successfully,and now the 'installed' text and the dropdown is of the same width. Added before and after screenshot for reference.
- 🇺🇸United States phenaproxima Massachusetts
This looks pretty good in both light and dark mode under Gin, and it looked pretty good in Claro, but there is one thing that I think should be fixed before commit -- namely, the "Installed" badge and drop button are a little bit off-center. The effect is particularly exacerbated in Gin, for some reason.
It's a minor detail, to be sure, but I think it's in the scope of this issue since we're just trying to ensure that these UI components look good, with proper dimensions and positioning.
- 🇮🇳India utkarsh_33
Re#9 ya i just noticed that the positioning was a bit off.I have fixed that positioning.Marking it NR again.
- 🇺🇸United States phenaproxima Massachusetts
Quickly checked in Gin and Claro - the alignment looks much better! Ship it.
- First commit to issue fork.
-
chrisfromredfin →
committed da9afe45 on 2.0.x authored by
utkarsh_33 →
Issue #3511104: The dropbutton has extra width when opening in the modal
-
chrisfromredfin →
committed da9afe45 on 2.0.x authored by
utkarsh_33 →
- 🇺🇸United States chrisfromredfin Portland, Maine
Manually tested in Claro, Gin (Light & Dark). Works great, even fixes an oddity on 2.0.x with Claro. Thank you!
Automatically closed - issue fixed for 2 weeks with no activity.