The filters are not selected for correct instance in case of multiple PB instances.

We'll need a test for this (a new method of MultipleInstancesTest should suffice), and it's definitely a beta blocker.

I couldn't reproduce this issue in tests, although it was reproducible locally. This fix resolved the issue, and I updated the existing test to cover the scenario of selecting the second instance first.

I can confirm that the issue is solved with this Fix.

Fixed merge conflicts, and suggested an alternate (simpler) approach here that might work.

The bigger problem, though, is that the test passes locally even against 2.0.x...so it's not catching the bug. :( The test needs to fail on 2.0.x without the patch.

Another question: how is it that the existing test didn't catch this bug?

At the bottom of the test method in 2.0.x, we are confirming that adding an additional category to the second instance produces a different list of results than the first instance. Why didn't this fail in 2.0.x?

I did a little bit of investigating and discovered that the reason the tests aren't catching is because...even in 2.0.x, the test behaves correctly!

And yet, if I put a sleep(30) at the top of the test, and then click around manually in Chrome...I am seeing the buggy behavior. In other words, this is a case where the human interaction of clicking on the checkbox causes the bug, but Mink's interaction with the checkbox does not.

That leads me to believe that the problem is something to do with, maybe, the onChange function in MultipleChoiceFilter.svelte. There are some really dodgy DOM traversal/queries happening in showHideFilter to deal with focusing -- those seem very suspicious to me, and it's entirely possible that they're somehow looking at the wrong part of the DOM tree.

I think we need to take a few steps back here and start with a test that unambiguously fails against 2.0.x. We're not going to have any other way to know for sure if we've fixed this bug.

I can also confirm that if I pause the test at the beginning with a sleep(30) and click around, my proposed fix appears to prevent the bug.

Ensuring credit is correct, as @narendra and @utkarsh_33 worked to reproduce this in a test while I was asleep.

Figured out the problem -- clicking the label causes the problem; clicking the checkbox does not. The tests normally click the checkbox.

Confirmed that tests catch the bug; the test-only job fails as expected.

tests are passing, PHPStan issue present in 2.0.x-HEAD

Automatically closed - issue fixed for 2 weeks with no activity.