I am unable to access these demo components. Is there a way to place them on the page?
After MR
The hover issue has been fixed, but clicking the slot throws an error. please see the stack trace and GIF for reference.
Drupal\Core\Render\Component\Exception\ComponentNotFoundException: Unable to find component "experience_builder:druplicon" in the component repository. [The "experience_builder:druplicon" plugin does not exist. Valid plugin IDs for Drupal\Core\Theme\ComponentPluginManager are: experience_builder:deprecated, experience_builder:obsolete, experience_builder:experimental, experience_builder:my-section, experience_builder:shoe_tab_group, experience_builder:two_column, experience_builder:one_column, experience_builder:my-hero, experience_builder:image, experience_builder:shoe_tab, experience_builder:shoe_tab_panel, experience_builder:heading, experience_builder:shoe_badge, experience_builder:shoe_button, experience_builder:shoe_details, experience_builder:video, experience_builder:shoe_icon, olivero:teaser] in Drupal\Core\Theme\ComponentPluginManager->createInstance() (line 118 of /var/www/html/core/lib/Drupal/Core/Theme/ComponentPluginManager.php).
The issue is no longer reproducible.
gauravvvv → made their first commit to this issue’s fork.
Here is after MR screenshot, please review
gauravvvv → created an issue.
gauravvvv → made their first commit to this issue’s fork.
This issue also occurs when selecting 'None' for the column width. Could you specify which component you encountered this issue with? Thanks!
Here is after MR gif
This issue is no longer reproducible.
Before
After
gauravvvv → made their first commit to this issue’s fork.
Here is the MR screen-recording, All tests are passing now. MR is ready for review
Hi @wim leers, Yes I am following the same steps. Here is the screenshots for same.
Drupal standard installation
Image upload in hero field
Database log for the error
I am facing this on a fresh install, also when I am trying to upload an image then I get an error:
TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, null given in str_starts_with() (line 255 of /var/www/html/modules/experience_builder/src/Plugin/Field/FieldWidget/TwoTerribleTextAreasWidget.php).
here is the Stack trace
#0 /var/www/html/modules/experience_builder/src/Plugin/Field/FieldWidget/TwoTerribleTextAreasWidget.php(255): str_starts_with()
#1 /var/www/html/core/lib/Drupal/Core/Field/WidgetBase.php(505): Drupal\experience_builder\Plugin\Field\FieldWidget\TwoTerribleTextAreasWidget->massageFormValues()
#2 /var/www/html/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(244): Drupal\Core\Field\WidgetBase->extractFormValues()
#3 /var/www/html/core/lib/Drupal/Core/Entity/ContentEntityForm.php(334): Drupal\Core\Entity\Entity\EntityFormDisplay->extractFormValues()
#4 /var/www/html/core/lib/Drupal/Core/Entity/EntityForm.php(301): Drupal\Core\Entity\ContentEntityForm->copyFormValuesToEntity()
#5 /var/www/html/core/lib/Drupal/Core/Entity/ContentEntityForm.php(155): Drupal\Core\Entity\EntityForm->buildEntity()
#6 /var/www/html/core/lib/Drupal/Core/Entity/ContentEntityForm.php(186): Drupal\Core\Entity\ContentEntityForm->buildEntity()
#7 [internal function]: Drupal\Core\Entity\ContentEntityForm->validateForm()
#8 /var/www/html/core/lib/Drupal/Core/Form/FormValidator.php(82): call_user_func_array()
#9 /var/www/html/core/lib/Drupal/Core/Form/FormValidator.php(274): Drupal\Core\Form\FormValidator->executeValidateHandlers()
#10 /var/www/html/core/lib/Drupal/Core/Form/FormValidator.php(118): Drupal\Core\Form\FormValidator->doValidateForm()
#11 /var/www/html/core/lib/Drupal/Core/Form/FormBuilder.php(585): Drupal\Core\Form\FormValidator->validateForm()
#12 /var/www/html/core/lib/Drupal/Core/Form/FormBuilder.php(321): Drupal\Core\Form\FormBuilder->processForm()
#13 /var/www/html/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#14 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#15 /var/www/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#16 /var/www/html/core/lib/Drupal/Core/Render/Renderer.php(593): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#17 /var/www/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#18 /var/www/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#19 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(183): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#21 /var/www/html/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#22 /var/www/html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#23 /var/www/html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#24 /var/www/html/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#25 /var/www/html/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#26 /var/www/html/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#27 /var/www/html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#28 /var/www/html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#29 /var/www/html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#30 /var/www/html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#31 /var/www/html/core/lib/Drupal/Core/DrupalKernel.php(709): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#32 /var/www/html/index.php(19): Drupal\Core\DrupalKernel->handle()
#33 {main}
In the Components prop editor, some required fields don’t have values, which is why the error occurs.
gauravvvv → created an issue.
Tests are failing, working on them.
Here is the after MR screen recording:
Hi @Wim Leers, I changed the status to needs review before the test results.
griffynh → credited Gauravvvv → .
Still needs to add test component.
nod_ → credited Gauravvvv → .
Gauravvvv → changed the visibility of the branch 3463307-zoom-interface to active.
Gauravvvv → changed the visibility of the branch 3463307-zoom-interface to hidden.
Addressed feedback on using AppConfiguration
as well smoothen the transition when zooming
Updated attributions
I have added a prop debug, if it is true then it will display the X, Y coordinates and "Debug: scroll to middle" button and on debug false it will only display the zoom range slider.
Debug: false
Debug: True
Based on the image in the issue description, the range slider for zoom should not include additional values like X, and Y points or the "debug to scroll" button. Do I need to hide these in the current tray or create a new one for the range slider? Thank you.
I have taken the latest pull on 0.x
branch and on running the npm run start
I am still facing this issue.
I am proposing to define an icon per individual component as you can see in the screenshot we have different icons for each element.
Example: The button has a different icon, so "the landing page" component.
Gauravvvv → created an issue.
Gauravvvv → changed the visibility of the branch 3458503-Improve-page to hidden.
This is happening on preview only. If we use the command npm run preview
for preview then front-end app crashes when I open the component list.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
MR !7895, fixed the issue. Added after MR screenshot for reference.
I believe this is a duplicate of 🐛 Secondary tabs design is distorted on block view page Active .
This can be fixed by MR #7895
Otherwise the variables in the css like '--vertical-tabs-menu-width' are not defined.
The variable --vertical-tabs-menu-width
is defined in the variable.pcss.css
file, and it is available globally. So there's no need to add the dependency of claro/vertical-tabs