Gauravvvv → made their first commit to this issue’s fork.
With open dialog
Closed dialog
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Addressed #52, please review
Gauravvvv → made their first commit to this issue’s fork.
MR is passing the tests now.
I have updated the physical width of the search box for desktop and mobile device as 80ch and 45ch respectively for desktop and mobile devices.
Gauravvvv → made their first commit to this issue’s fork.
On the MR !494, we have hardcoded href={'#drupalorg_mockapi'} which breaks when we're on the recipes tab. It takes the focus to the id=drupalorg_mockapi" tab, which should be on the current tab.
I have added after merge request screenrecording for reference, please review
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you
Hello @esha_kundu, Thank you for contributing to the issue. I noticed that you have not added any screenshots or provided the steps to test it. Additionally, the "before" and "after" patch images you included are giving a 404 error and are not being displayed. Credits are granted for valuable contributions that help move the issue forward.
Thank you for working on the issue, committed to 9.1.x and 10.0.x
Earlier, `settings.drupalOffCanvasPosition` was undefined on the second dialog open. I have updated it. However, it is still calculating the height of the off-canvas incorrectly, which needs to be fixed. I am leaving this to NW.
This is still happening after the patch #2, as well. please see screenshot for reference
Gauravvvv → changed the visibility of the branch 3291764-the-0-hatch to hidden.
Updated issue summary
Gauravvvv → made their first commit to this issue’s fork.
Here's After merge screenshot:
Gauravvvv → made their first commit to this issue’s fork.
This seems to be an issue with Carousel itself.
when we set the format to the rendered entity it shows the contextual link for the same media. see screenshot
However, when we set the format to "Slick media, " the contextual link is absent.
I have updated the latest screenshot in the issue summary
This issue is no longer reproducible. check screenshot for reference
Gauravvvv → made their first commit to this issue’s fork.
After:
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → changed the visibility of the branch 3450256-off-canvas-tray to hidden.
Gauravvvv → changed the visibility of the branch 2417111-replace-container-inline-with to hidden.
Gauravvvv → made their first commit to this issue’s fork.
@ahsannazir, Could you place the "User account menu" block and then try reproducing it.
Follow up issue created.
Gauravvvv → created an issue.
After patch
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → created an issue.
Gauravvvv → changed the visibility of the branch 3450254-navigation-fix-lb to hidden.
Whitefix has been added, This is ready to go
Gauravvvv → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to active.
Gauravvvv → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to hidden.
@Gauravvvv: what browser are you using?
I am using Chrome 124 on macOS (Sonoma).
Gauravvvv → created an issue.
Gauravvvv → created an issue.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Still needs to work on styling.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Updated issue summary and title
Gauravvvv → made their first commit to this issue’s fork.
Here is after patch screenshot
Gauravvvv → made their first commit to this issue’s fork.
Addressed #7, please review
Gauravvvv → created an issue.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → made their first commit to this issue’s fork.
Gauravvvv → changed the visibility of the branch 3405006-the-footer-shadow to hidden.