- 🇮🇳India dsandhya
I have created this patch for 10.1.x-dev and its working fine. Please verify.
- 🇮🇳India jaydeep_patel Ahmedabad
jaydeep.jdb@gmail.com → made their first commit to this issue’s fork.
- Merge request !8645User's profile image in comments section overlaps in article → (Open) created by jaydeep_patel
- Status changed to Needs review
7 months ago 11:44am 3 July 2024 - 🇮🇳India jaydeep_patel Ahmedabad
User's profile image in comments section overlaps with in Article has been fixed. Please review. Thanks !!!
- Status changed to Needs work
7 months ago 9:23pm 4 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 7:00am 5 July 2024 - 🇮🇳India jaydeep_patel Ahmedabad
comments.pcss.css has been updated and User's profile image in comments overlaps with Layout Builder section issue has been resolved
- 🇮🇳India Kanchan Bhogade
I've tested MR 8645 on Drupal 11.x
The MR is applied cleanly...Test Result:
The User's image in the comments overlaps with the Layout Builder section issue is resolved and visually looks good.
Also, the Non-Layout UI looks good.Attaching Scrrenshots
RTBC+1
- Status changed to RTBC
7 months ago 6:20am 15 July 2024 - 🇳🇿New Zealand quietone
I read the issue summary, which is incomplete, there is no proposed resolution. And as, an issue that affects the UI there should be screenshots available from the issue summary. I am restoring the template and will update as I continue. Thanks you to andregp for summarizing the relevant changes and what comments have been addressed.
I think everything has been addressed here, but worth checking that #72 🐛 User's image in comments overlaps with Layout Builder section RTBC is complete. Also an Olivero maintainer commented in #72 that they are "indifferent" about this being changed.
Leaving at RTBC
- Status changed to Closed: works as designed
6 months ago 12:41pm 26 July 2024 - 🇫🇷France nod_ Lille
I reviewed the issue and all the different solutions change the design of the comment section one way or another. Changing the design of the comment section is not in the scope of this issue.
The issue is that inside the LB UI the icon is outside the LB section. This is by design that the picture is out of the normal flow of the page, it makes sense that it is also out of the flow of the LB interface. If we make it fit inside the LB the preview would not be accurate anymore.
Moving the comment element to the right to avoid this, but it breaks the intended design of the page. If the overlap is problematic it's always possible to disable the content preview with the checkbox on top of LB UI. Because we do not want to change the design of the comment and there is a solution to avoid this I'm closing this as works as designed.
Thanks to everyone who worked on this over the years. I wish we caught this one earlier to avoid spending so much time on this.