nod_ → made their first commit to this issue’s fork.
updating credits
Committed 228328d and pushed to 11.x. Thanks!
Making sure this doesn't get forgotten somewhere
Committed and pushed 8610d622f11 to 11.x and 43c52bdf4a4 to 10.5.x and 750f5decb21 to 11.1.x and d5035b8d3c0 to 10.4.x. Thanks!
griffynh → credited nod_ → .
Committed 49373ed and pushed to 11.x. Thanks!
I think that's worth a release note
Committed 784effb and pushed to 11.x. Thanks!
That makes sense, will be easier than ignoring one file at a time
per thread on slack we're not backporting the top bar work to 10.x, closing this one
per thread on slack we're not backporting the top bar work to 10.x, closing this one
let's worry about 11.x first and we'll handle the backports once it's RTBC/committed
nod_ → changed the visibility of the branch 2741877-nested-modals-10.1 to hidden.
nod_ → changed the visibility of the branch 2741877-nested-modals-10.3 to hidden.
nod_ → changed the visibility of the branch 2741877-nested-modals-10.2 to hidden.
all good, thanks
There is a phpcs failure, needs to be fixed before I can commit
appears random 📌 Remove cache tag checksum assertions from performance tests Active
test failure that seems legit
Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest::testStandardPerformance
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
],
'CacheSetCount' => 45,
'CacheDeleteCount' => 0,
- 'CacheTagChecksumCount' => 38,
- 'CacheTagIsValidCount' => 43,
+ 'CacheTagChecksumCount' => 37,
+ 'CacheTagIsValidCount' => 42,
'CacheTagInvalidationCount' => 0,
'CacheTagLookupQueryCount' => 21,
'CacheTagGroupedLookups' => Array &2 [
core/tests/Drupal/Tests/PerformanceTestTrait.php:679
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57
I didn't know this tag, would have been useful to me a while back, nice :)
Committed 086f524 and pushed to 11.x. Thanks!
Committed f3d4fc3 and pushed to 11.x. Thanks!
small suggestion
nevermind, git is smart enough
sorry another conflict in dictionary.txt, once rebased ping me so I can commit quickly hopefully this will be the last rebase
merge conflict after 📌 Navigation leverage icon core API Needs work
Committed and pushed 667827baf8f to 11.x and b6569266a24 to 11.1.x. Thanks!
I can't commit still got an phpstan error on my end. If it's fixed for you feel free to commit @quietone
small merge conflict. Other than that it looks good to me, great progress and thanks for the extensive testing! Feel free to RTBC, happy to commit this :)
Not sure about the change record. I'm guessing there are folks working on gin here no? we might add a note to the existing icon api change record but I'm not sure what would be in the change record? Also can't commit if we don't have the change record. so in the spirit of not making our life harder, I'll remove the tag.
My bad thanks for checking this!
merge conflict :)
Committed d0e11e1 and pushed to 11.x. Thanks!
Could be good to have for 11.1.x, doesn't cherry pick cleanly so need a new MR
committed sibling issue, merge conflict to resolve now :)
nod_ → made their first commit to this issue’s fork.
merge conflict
Committed and pushed 6f6a78544ee to 11.x and ec3d2e1a81d to 11.1.x. Thanks!
+1 from me
all child issues are fixed, should this one be closed too?