Lille
Account created on 15 September 2009, over 15 years ago
#

Merge Requests

More

Recent comments

🇫🇷France nod_ Lille

Committed 228328d and pushed to 11.x. Thanks!

Making sure this doesn't get forgotten somewhere

🇫🇷France nod_ Lille

Committed and pushed 8610d622f11 to 11.x and 43c52bdf4a4 to 10.5.x and 750f5decb21 to 11.1.x and d5035b8d3c0 to 10.4.x. Thanks!

🇫🇷France nod_ Lille

I think that's worth a release note

Committed 784effb and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

That makes sense, will be easier than ignoring one file at a time

🇫🇷France nod_ Lille

Committed e10e162 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

per thread on slack we're not backporting the top bar work to 10.x, closing this one

🇫🇷France nod_ Lille

per thread on slack we're not backporting the top bar work to 10.x, closing this one

🇫🇷France nod_ Lille

let's worry about 11.x first and we'll handle the backports once it's RTBC/committed

🇫🇷France nod_ Lille

nod_ changed the visibility of the branch 2741877-nested-modals-10.1 to hidden.

🇫🇷France nod_ Lille

nod_ changed the visibility of the branch 2741877-nested-modals-10.3 to hidden.

🇫🇷France nod_ Lille

nod_ changed the visibility of the branch 2741877-nested-modals-10.2 to hidden.

🇫🇷France nod_ Lille

nod_ changed the visibility of the branch 2741877-10-4-x to hidden.

🇫🇷France nod_ Lille

There is a phpcs failure, needs to be fixed before I can commit

🇫🇷France nod_ Lille

Committed 0948fc8 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

test failure that seems legit

Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest::testStandardPerformance
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     ],
     'CacheSetCount' => 45,
     'CacheDeleteCount' => 0,
-    'CacheTagChecksumCount' => 38,
-    'CacheTagIsValidCount' => 43,
+    'CacheTagChecksumCount' => 37,
+    'CacheTagIsValidCount' => 42,
     'CacheTagInvalidationCount' => 0,
     'CacheTagLookupQueryCount' => 21,
     'CacheTagGroupedLookups' => Array &2 [

core/tests/Drupal/Tests/PerformanceTestTrait.php:679
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57
🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

I didn't know this tag, would have been useful to me a while back, nice :)

Committed 086f524 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed cbaf8e4 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Committed 51599c2 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nevermind, git is smart enough

🇫🇷France nod_ Lille

sorry another conflict in dictionary.txt, once rebased ping me so I can commit quickly hopefully this will be the last rebase

🇫🇷France nod_ Lille

Committed e7a6df2 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

I like removing JS files :)

Committed 73ff0d1 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed 9d6d91c and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed 4a3fbdb and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed dd95187 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

I can't commit still got an phpstan error on my end. If it's fixed for you feel free to commit @quietone

🇫🇷France nod_ Lille

Committed 7258763 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

small merge conflict. Other than that it looks good to me, great progress and thanks for the extensive testing! Feel free to RTBC, happy to commit this :)

Not sure about the change record. I'm guessing there are folks working on gin here no? we might add a note to the existing icon api change record but I'm not sure what would be in the change record? Also can't commit if we don't have the change record. so in the spirit of not making our life harder, I'll remove the tag.

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Committed d0e11e1 and pushed to 11.x. Thanks!

Could be good to have for 11.1.x, doesn't cherry pick cleanly so need a new MR

🇫🇷France nod_ Lille

Committed 7735d0e and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Committed 7abcc2f and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

committed sibling issue, merge conflict to resolve now :)

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Can we get the follow up from #4 created?

Committed 37e0a7f and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed e187658 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Committed f666681 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed e97a510 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed 427d745 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

Committed and pushed 6f6a78544ee to 11.x and ec3d2e1a81d to 11.1.x. Thanks!

🇫🇷France nod_ Lille

Committed 6793be9 and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

nod_ made their first commit to this issue’s fork.

🇫🇷France nod_ Lille

Committed b60186b and pushed to 11.x. Thanks!

🇫🇷France nod_ Lille

all child issues are fixed, should this one be closed too?

Production build 0.71.5 2024