Remove @nest from claro stylesheets

smustgrave → credited AkshayAdhav → .

Working on this :)

I'd like some help on this :)

@Hritik Parihar
thank you for work here!

You need to run `yarn && yarn build && yarn lint:css --fix` in `/core` to be sure that css compiled well and avoid lint pipeline failures.

Added a commit for the lint fixes.

Lint failures still happening.

Sorry for the noise, but I was under the assumption that the lint check had passed as indicated by this - https://git.drupalcode.org/issue/drupal-3410681/-/pipelines/68290

Or are there some linting errors that aren't picked up and the compilation check fails because of that (without giving any specific error)?
Thanks in advance.

Failure happends in this pipeline job https://git.drupalcode.org/issue/drupal-3410681/-/jobs/534027

You need to run `yarn build` and check which css should be changed. Also if css changed better to check if this place has no regressions.

Raised MR for fixing above issue.

Searching for remaining @nest in claro theme and all have been addressed.

During manual testing
Checked user edit form to change password
Edited the content view testing views ui
Created an Article content
Verified page title change + shortcut seem fine.
Content view showed table is good.

Compiler caused some weird moves but nothing that I see should break anything.

Couple of minor comments

The comments in the MR need to be looked at and figure out a way forward.

Hello everyone,

I noticed that this issue is currently marked as 'Needs work' due to some unresolved comments regarding CSS ordering and linting errors. I would like to contribute, but I want to confirm the best approach before making any changes.

Could someone clarify what exactly needs to be addressed at this point? Should we focus only on removing @nest, or is there a need to revert the CSS order changes as well?

Any guidance would be greatly appreciated. Thanks!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Hi everyone,

I did the rebase on the MR, and there were several changes.
I'm not sure if it would be better to create a new MR with the updates.
If that would be safer, please let me know, and I'll make the change.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Hey everyone, the issue with the Stylelint in the CSS was caused by the order of the elements, so I fixed it. You can check the change in this link. It was correct before, but I might have mistakenly modified it during the merge.

Additionally, I removed some @nest rules that were added to the light theme. Could someone validate if any further changes are needed?

I’d also like to understand why this issue is happening. I’ve noticed it occurring in several issues I contributed to. If possible, I’d love to learn how this works and help fix it if necessary.

Still 1 nit change on the MR, since it's from a core committer going to put back into NW.

Hi @smustgrave

Removed an unnecessary blank line that was marked as "out of scope."