- Issue created by @smustgrave
- ๐ฎ๐ณIndia AkshayAdhav Pune, India ๐ฎ๐ณ
smustgrave โ credited AkshayAdhav โ .
- Merge request !5948Issue #3410681 by AkshayAdhav: Remove @nest from claro stylesheets โ (Open) created by Hritik Parihar
- ๐ท๐ธSerbia finnsky
@Hritik Parihar
thank you for work here!You need to run `yarn && yarn build && yarn lint:css --fix` in `/core` to be sure that css compiled well and avoid lint pipeline failures.
- Status changed to Needs work
6 months ago 9:31am 25 December 2023 - First commit to issue fork.
- Status changed to Needs review
6 months ago 12:37am 26 December 2023 - Status changed to Needs work
6 months ago 1:20am 26 December 2023 - ๐ฎ๐ณIndia sidharth_soman Bangalore
Sorry for the noise, but I was under the assumption that the lint check had passed as indicated by this - https://git.drupalcode.org/issue/drupal-3410681/-/pipelines/68290
Or are there some linting errors that aren't picked up and the compilation check fails because of that (without giving any specific error)?
Thanks in advance. - ๐ท๐ธSerbia finnsky
Failure happends in this pipeline job https://git.drupalcode.org/issue/drupal-3410681/-/jobs/534027
You need to run `yarn build` and check which css should be changed. Also if css changed better to check if this place has no regressions.
- ๐ฎ๐ณIndia ehsann_95
ahsannazir โ made their first commit to this issueโs fork.
- Status changed to Needs review
6 months ago 7:36am 3 January 2024 - Status changed to RTBC
6 months ago 4:36pm 3 January 2024 - ๐บ๐ธUnited States smustgrave
Searching for remaining @nest in claro theme and all have been addressed.
During manual testing
Checked user edit form to change password
Edited the content view testing views ui
Created an Article content
Verified page title change + shortcut seem fine.
Content view showed table is good.Compiler caused some weird moves but nothing that I see should break anything.
- Status changed to Needs work
5 months ago 7:50am 30 January 2024