Zurich
Account created on 11 June 2012, over 11 years ago
  • Senior Product Designer at GitLabΒ  …
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

This looks awesome @Gabor, nice work πŸ‘

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I'm also unable to reproduce this, so at least steps are needed to reproduce this as by default a max-width of 100% is set.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Thanks @eelkeblok, MR pipeline running

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing this in favor of πŸ› Styling issue with paragraphs Needs work

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Thanks for changing the status, I completely forgot it πŸ˜…πŸ‘

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as it's related to #[3419076]

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

We moved the dependency to be included automatically which seems it doesn't get exposed to the frontend.

We might want to re-add the dependency on all navigation variants.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this is not coming from Gin.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing this again as it required a core patch to be applied. Once merged we can reopen it.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I wasn't able to reproduce this. Try to clear all caches.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

We're not officially supporting using Gin as a frontend theme. To solve this you might need to use the correct breadcrumbs template from Gin.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing this as checking for PHPCS is part of our pipeline (see https://git.drupalcode.org/project/gin/-/pipelines) and if it sees errors it will not allow MRs to be merged. Also it seems you did run it in a fork.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Like the feedback given in πŸ› Improved Accessibility: Unveiling Dropbutton Operations Hidden by Gin Table Scroll Wrapper Closed: duplicate this doesn't seem like the solution as it will lead to other issues.

So moving this back to needs work.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

See the Gin issue queue.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing this as a duplicate. Also removing this will lead to other regressions.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Please report in the ECA module instead.

Cheers

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this is one as it has been fixed in dev and there are a ton of similar closed issues.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I think it was creates in the right project. Closing this one again.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I'm closing this for now as works as designed. It's a known limitation of the new navigation design and we'll work on solutions in the core implementation.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Nope a core issue, there are two issues open at the moment.

Closing again.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

This is a non core standard compliant dropdown (not yet migrated).

So I'd urge you to open an issue in the core issue queue so we can migrate this dropdown.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

@nicxvan yes πŸ‘

Is this the issue? If yes, we can close this one.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Is this a table within tabs? If yes, we can close this as there is a core issue for it

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

A quick search will yield you about 10 tickets about the same issue. This has been fixed in the dev version.

Cheers

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Left a code suggestion/question

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

We currently dont support subtheming per se. See our documentation on different methods to override things.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this is the x duplicate.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Thank you @djsagar LGTM, needs a review now πŸ‘

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

saschaeggi β†’ changed the visibility of the branch 8.x-3.x to hidden.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I can't see any changes in the correct MR https://git.drupalcode.org/project/gin/-/merge_requests/363

So I'll move this back to needs work

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

@majmunbog

Praise: For creating the icon in the same way as the others so it works flawlessly in darkmode πŸ‘

Let's move forward with this πŸ‘

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I've left some code suggestions. Please have a look πŸ‘€

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Add link to composer install section of the guide

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I'm also unable to reproduce this, so I'll go ahead and close this issue.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as cannot reproduce, feel free to reopen and provide steps to reproduce.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Can't reproduce.

Please post screenshots, Drupal Version and check out our dev branch.

Also try to see if another module interferes as well as any JS errors.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I'll move this to the webform module, Cheers ✌️

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

You can either use the MYMODULE_custom_theme() method programmatically or use a module like the Switch Page Theme

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Can you please add a screenshot?

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

SlickUI needs to fix this. When they use the default Drupal core coding standards it will automatically work.

Cheers

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

So this needs a review of someones who has the Order showing up

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

The misalignment seems to be fixed, I've pushed a change so we also address it for legacy paragraphs.

Order showing up is something I can't reproduce in either 10.2 or 10.2.1

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Thanks y'all πŸ‘

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Great, can you create a MR for this? We don't use patches anymore. Thank you in advance!

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

We would need steps to reproduce here otherwise it's impossible to debug.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

@Anybody seems like a good candidate to move to Core as we can change the default for this in Claro. (it's not defined by Gin).

Would you mind either moving this issue or creating a new one in the core issue queue?

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

I've left some code suggestions

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

This is a core bug as core has changed the absolute/fixed position to use of position: sticky which doesn't work properly when a parent has set overflow.

So I have to close this. Feel free to open a core issue if there is not already one open.

Temporarily you can work around this to unset the stickyness of this table (remove sticky option).

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

6px is way to wide and should be reduced to 2px max. Also we should leverage our CSS variables here instead of fixed values.

Moving back to needs work

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Thanks y'all for your participation in addressing this πŸ™Œ

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as ✨ Allow media items to be edited in a modal when using the field widget Postponed is still postponed. Feel free to reopen this once it got merged.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as I can't reproduce these issues on the latest Drupal versions.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Can we use Gin's variables instead of fixed values here? TY!

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as we're lacking the resources to tackle this. Feel free to reopen if you want to work on this.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this should be fixed upstream in Claro.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing this as won't fix as we don't have the resources for this at the moment.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Can this be tested & verified it works as well with Group v3?

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as outdated as no activity was on this issue for a while. Feel free to reopen if this still needs to be worked on.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing because of the lack of activity. Feel free to reopen if this needs work.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this should be fixed directly in Entity Browser

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Please create an issue in the Easychart module.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing because of the lack of activity. Feel free to reopen if we still need to work on this.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing of lack of activity. Feel free to reopen if the problem persists.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as won't fix for now as mentioned we're working on a completely new navigation in Core.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing because there was no activity on this issue for a while. Feel free to reopen if we still should do something here. Cheers!

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

We're currently having no resources to support this, so I'm gonna to close this for now.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as I wasn't able to reproduce this issue

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

saschaeggi β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

@leymannx can you create a MR for this? TY in advance!

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Might be something Paragraphs needs to look into it to fix it directly in the module

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Although it's better looking without background but thanks for clarification!

This might be very subjective but I'd argue otherwise. Also it helps stand out more especially if you use the White/Black combination.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

Closing as this is a duplicate of πŸ› Primary local tasks not rendering on entity routes due to striptags filter Fixed

(which already contains the solution).

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

FYI the active item should have a background color, it wasn't there before as it was a bug.

πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

@JΓΌrgen can you create a Core (Claro) issue that we reset the position for tables placed inside of vertical tabs? Thank you

Production build https://api.contrib.social 0.61.6-2-g546bc20