🇨🇭Switzerland @saschaeggi

potentially composer require 'drupal/gin:^4.0' --with-dependencies would work, too

Are you using the field_group module? If so we might want to move this to the module so they can look into fixing this.

I don't think we have different opinions about stable code – but there is quite some complexity maintaining the main admin theme which has a ton of hidden requirements for different use cases which might not be obvious at the first glance.

We don't want to add an explicit dependency. Also toolbar will soon be replaced by the new navigation module.

Unfortunately I'll have to close this as won't fix.

The search icon seems misaligned and not the remove button

I'm closing this again, as you already created a new issue for the same thing in 🐛 Paragraphs Issue Active

penyaskito → credited saschaeggi → .

That's a bummer. I see more situations where we do certain things where we only want to target Drupal CMS.

It could be just a config which we can easily query e.g. (drupal_cms: true) or anything else. We potentially could also include this setting in Gin if we can't place it somewhere outside it. However other modules might benefit of a setting like this, too in the long run. We can then make sure it gets enabled on the Drupal CMS installation progress (via recipes).

We should NOT add the accent library as this is only suitable for the backend, not for the frontend.

I would disagree here. The accent might be required to show the correct accent color within the dialog. As all our accent colors are gin prefixed this does not interfere with any content in the frontend. Also gin_dialog wraps all it's styles within the scope of .ui-dialog {} (note that we could change that to something like .gin-dialog {} down the line.

So with that there might no iframe needed.

That data attribute, among others, are being added in gin_preprocess_html(). Here is the catch. That preprocess never runs on the page where the XB app is rendered due to XB's unusual controller.

You're correct, also this will lead to more issues like Darkmode not working correctly, so we might want to fix this.

Can we scope this to Drupal CMS only?

Do we know how this is supposed to look like? It seems still pretty much unstyled afterwards? 🤔

that suggested change looks much better in theory. However, the buttons don't have any background color defined with that approach

Maybe a cache clear?

Thank you Cristina 💙

@pameeela can we add an issue credit for lauriii and myself as we have worked on the initial proposal, too

Thanks!

Thanks Jürgen, closing

Please contribute this to localize project over at https://localize.drupal.org/

Please report problems with the new sidebar navigation in the core issue queue

The legacy CSS was removed like it was announced in the release notes. You might need to clear caches.

We have spent a lot of research and time for different solutions and the split option just didn't perform and did not work for most users. Of course there will never be a solution which fits 100% of users. If you want to raise your concerns however, you can provide your feedback in the core issue queue for the new core navigation.

Thanks for confirming. Closing as works as designed as this level is only ment to open and close the flyout menus. You can access the level from within the flyout menu itself (Overview links or the title).

Cheers

Great thanks, I've issued a new release https://www.drupal.org/project/gin/releases/4.0.2 → 🎉🖖

More information are needed here. Which Extra tools? From Admin Toolbar or from Navigation?

Also can you provide a screenshot of which 1st level links you're talking about?

Thanks for confirming Paul 🙇

Let's wait for another review

Thanks both 👏

saschaeggi → created an issue.

bump

I still can't reproduce this, we'd need more steps or a video how to reproduce this

We're not using the sidebar for the media entity, so this must be some custom config or patch.

Additionally Gin 4.0 has removed its legacy code (Settings migration checks & CamelCase class support), see the 3.0 release notes.

Cheers

You might need to change the z-index of your sticky header.

Thanks! I've went ahead and included some more outstanding implementations to expose local actions as well as a temporary solution.

saschaeggi → changed the visibility of the branch 3495024-make-top-bar--gin.html.twig-compatible to hidden.

saschaeggi → changed the visibility of the branch 8.x-3.x to hidden.

saschaeggi → made their first commit to this issue’s fork.

Thanks @flocondetoile 👏

Thank you James

The icon used is quite complex at its optical size. It doesn't seem to go well with other icons. We also want to use svg's instead of pngs.

LGTM, Thanks!

This MR needs a rebase, I also left one tiny code nitpick

Thanks!

This needs a rebase

This needs a rebase and a dist recompile

Thanks for reporting, it's merged 🚂

Decreasing prio. here as it's on the dev branch

Merging

Thank you hudri, added you to the issue credit

Closings as another duplicate, Paragraphs EE or Paragraphs features need to be updated. The issue was fixed in their issue queue.

Thanks

The MR needs a rebase 👀

I wasn't able to reproduce this, so I'll close this one. If that's still a problem for some feel free to reopen.

saschaeggi → changed the visibility of the branch 3437516-improve-chosen-single-size to hidden.

Dist files are missing in the MR, moving back to needs work

The MR needs a rebase and recompiled CSS. Also I left 2 code comments 👀

Thanks!

Is this still a problem?

If yes, we might want to rebase the MR and update it's code to not use background-image as this won't scale with accent colors.

Closing as duplicate of 🐛 The icon color for the 'Remove Media' button should match the button color. Active

Closing as outdated as I wasn't able to reproduce this. We recently pushed some paragraphs related improvements which might have fixed the issue described here, too. If that's not the case please feel free to reopen. Thanks

Closing as I can't reproduce this, it might be outdated.

If you can still reproduce this feel free to reopen please.

I believe this is outdated as of now with recent changes.

Feel free to reopen if that's not the case please!

If this still applies, this MR needs a re-roll

Is this still a problem?

If yes, we might want to rebase the MR and update it's code to not use background-image as this won't scale with accent colors.

Is this outdated or does this still apply?

If yes, I've left some question in the code 👀

This needs a rebase if it still applies

@catch thanks for confirming 👍

Thanks!

MR 550 needs a review

saschaeggi → changed the visibility of the branch 3490111-shortcuts-link-in to hidden.

saschaeggi → changed the visibility of the branch 3490111-shortcuts-link-in to hidden.

bump

I left some code suggestions, moving back to needs work 👀

Fixed via 🐛 Temporarily suppress toolbar & navigation warning Needs review

Thanks Christos!

saschaeggi → changed the visibility of the branch 3489361-status-warning-toolbar to hidden.

saschaeggi → changed the visibility of the branch 3489361-Status-warning-modules-are-both-installed to hidden.

The MR needs testing, we're not reviewing patches

Thanks!

Thanks y'all!

saschaeggi → changed the visibility of the branch 3281984-url-access to hidden.

Thanks Paul for your work on this 👏

Thanks y'all 👏

There are some phpcs errors which need some work

saschaeggi → changed the visibility of the branch 3440148-remove-hardcoding-group to hidden.

Hey Paul

I left some comments in the MR

Cheers!

Closing as duplicate.

Thanks!

Is this a duplicate of 🐛 Js error when saving reference field Active ?

Thanks!

saschaeggi → changed the visibility of the branch 3463177-comment-24-patch-to-mr to hidden.

saschaeggi → changed the visibility of the branch 3463177-sidebar-resize-overlap-15791901 to hidden.

saschaeggi → changed the visibility of the branch 3463177-resizable-sidebar-can to hidden.

saschaeggi → changed the visibility of the branch 8.x-3.x to hidden.

Just to be sure: Were you testing MR !177? Thanks for a short feedback

Waiting for an RTBC here. Thanks!

Can we RTBC this?

Good news I think we can close this now as with RC14 we overhauled this and it doesn't seem to be needed anymore.

If needed, I'll reopen it later again.

Closing as duplicate of 🐛 Js error when saving reference field Active

Closing as outdated, see 🐛 Add in between button is no longer horizontally centered when using Gin Active

We're currently not planning to add this. As the different toolbar/navigation options will differ and the go-to solution will be the new core navigation.

So adding a feature request to the new core navigation might be the way to go instead.

Cheers!