🇨🇭Switzerland @saschaeggi

@teknocat great discovery, let's merge this! 👏

I've pushed another change to include a proof of concept to move other actions to a kebab menu. It uses a container so it would be possible to move things in or out of that menu, but by default we would show all buttons which are not primary functions (submits) to that kebab menu.

@LRoels fixed, thank you!

See https://www.drupal.org/project/gin/issues/3293369 🐛 Table header overflow issue for multiple user role on permissions page. Postponed: needs info

saschaeggi → changed the visibility of the branch 3356717-moving-the-save to hidden.

We fixed this

I think this is a duplicate of https://www.drupal.org/project/gin/issues/3376559 🐛 Home link added when using Toolbar Menu RTBC so I'm closing this in favor of the one we have in Gin.

Can you check if that MR fixes your issue and add a comment on that issue? Thank you!

Closing as duplicate of https://www.drupal.org/project/gin/issues/3395897 📌 Use dependency injection in GinNavigation.php Needs review

@kksandr thanks for reporting the issue, I've pushed a fix.

Great, moving the status of this issue to outdated.

Closing as duplicate of 🐛 Strange "white" space occurring on mobile when using an autocomplete widget for a multi valued field inside field groups Fixed

CSS3 :not() to the rescue! Consider this fixed.

Consider this finally fixed 🎉

Fixed the overflow of the Powered by CKEditor badge and position.

Closing as I can't reproduce this issue.

Awesome work, thanks Jürgen 👏

Closing as this issue has no activity for a long time.

This was fixed in 3.x-dev with recent changes.

@kevinquillen is this still an issue with the latest Gin dev?

I went with a way simpler solution to fix this issue. Thanks y'all for participating here 👏

Closing this issue in favor of 🐛 With New Drupal Navigation update.php broke layout Active

Closing as I can't reproduce this and no steps have been provided to reproduce this.

Closing as haven't heard back. Feel free to reopen this issue if the issue reappears.

@robcarr how can I reproduce your scenario?

As using your overrides will certainly break it for the general implementation.

Is this reported problem already covered with https://www.drupal.org/project/toolbar_menu/issues/3271757 🐛 css class name conflict with gin theme Needs review ?

Or maybe you can override the template for your custom menu?

This has been fixed in dev. Thanks for reporting 👏

That's certainly a bug and shouldn't be the case. I'm moving this to Gin as the fix has to happen there.

Hey Traves, great improvement and thank you for spotting the PHP Warning. Let’s merge this 🚂

@finnsky I didn't saw that the «Create» menu is missing on mobile at first, thanks for pointing that out.

I've pushed a fix 👏

Spacing looks as I would expect it on mobile, so I'm closing this one. But thanks for checking 👍

Hey finnsky 💪

That's a great point. I've pushed a change to remove this override.

Thank you!

Hey finnsky 👋

Is this OK in terms of user experience?

Yes, Gin enhances some features of the core navigation module.

We have to change some of the things to integrate it better with the amount of options the Gin Admin Theme has out of the box (different toolbar options, Darkmode, Accent color, high contrast mode etc.).

Here are some of the things just to keep it documented:

• Our own icons
• Integration with Darkmode, Accent color, high contrast mode etc.
• Moved shortcuts to the top bar for now as we're providing this functionality there on all toolbar options

I'm closing this as works as designed.

Cheers!

Thanks, Jürgen 👍

«Good things take time» sorry for the long wait here, but we finally have it fixed and in a way so it should be future proof 🤝

Thanks everyone in participating here 👏

saschaeggi → changed the visibility of the branch 3355054-edge-case-illegal to active.

saschaeggi → changed the visibility of the branch 3355054-edge-case-illegal to hidden.

Easy way to test this:

1. Add some messages via JS (can be done via the browser console):

const messages = new Drupal.Message();
const messageId = messages.add('test message');
messages.remove(messageId);
messages.add('test message', {type: 'status'});
messages.add('test message', {type: 'warning'});
messages.add('test message', {type: 'error'});

2. Test regular messages, e.g. Save form, clear cache etc.

This will be fixed with 🐛 Table header overflow issue for multiple user role on permissions page. Postponed: needs info

Closing this issue in favor of the other one and moving credits over.

New year, new approach 😅

This new approach should unify the markup of messages and also fix it in a future proof way so it will work with Drupal 11+ 🎉

Needs final testing 👯

saschaeggi → changed the visibility of the branch 3214515-merged-with-existing-library to hidden.

I'm closing this as Gin is an admin theme and not a frontend theme (even though you can use it as one).

I'm pretty sure you'll need to inject the libraries. Best is to reach out in the Varbase issue queue. I know they're also using Gin heavily so they might know an easy solution for your issue.

Otherwise you might want to create a small helper module and inject the libraries yourself, see also https://www.drupal.org/docs/contributed-themes/gin-admin-theme/custom-th... →

Cheers

Closing again, as Core has a fix ready and we have different approaches in Gin's issue queue

How does this align or impact the changes from https://www.drupal.org/project/gin/issues/3293369 🐛 Table header overflow issue for multiple user role on permissions page. Postponed: needs info ?

Closing this as I tested this on various sites without being able to reproduce this. Also a brand new Drupal instance just works as expected. You might need to debug your site ans check for errors.

This happens to me as well on 11.x-dev and the proposed solution seems to fix the problem

lauriii → credited saschaeggi → .

The behavior is as expected here as the tabs are part of that entity. We'll implement something similar in core for Claro.

Note that Gin is always ahead of Claro as we test features out first.

Regarding the message: From a UX POV it should appear right before (above) the action buttons in the content area.

See https://www.drupal.org/project/gin/issues/3293369 🐛 Table header overflow issue for multiple user role on permissions page. Postponed: needs info for a solution

Thank you, let's close this then 👍

The module works as intended. The goal of this module is to create a seamless login experience with either Claro or Gin.

For your usecase you can either create a small module to override/inject your library or you can easily utilize the built in gin-custom.css file which you could place your changes in.

You can find the documentation for this CSS file over at https://www.drupal.org/docs/contributed-themes/gin-admin-theme/custom-th... →

@phenaproxima no inconsistencies introduced here, rather eliminated as all our other navigation (toolbar) options use the same. You'll need our companion module (gin_toolbar) anyway to use Gin's option in your frontend theme.

As there is no major functionality broken caused by Gin I don't see this as a major issue (from Gin's side).

Also usually in production PHP errors are hidden so one more reason why it's not «major». Still something we have to look into to fix the Developer experience for sure.

Also I seem to be able to select the text:

Closing as duplicate of 🐛 Clientside validation breaks checkbox toggle Active

Can you check if the solution there will fix your issue as well?

@phenaproxima I've updated the description to reflect that, sorry forgot to mention that.

Not sure where you use these settings but they don't look like anything when used within Gin.

You have to use the ones within the Gin theme settings (/admin/appearance/settings/gin)

@jurgenhaas I've pushed a fix to 📌 Add support for Navigation Beta 1+ Active , please have another look 👀

@Esha_Kundu looking at this screenshot I'd rather like to see the module fix it's use of flex and wrap items. It's overlapping quite some items which is rather a bad UX. Also this way it will automatically fix the toggle. And that the toggle doesn't render correctly is a result of that.

So I will move this issue back to the module's issue queue to fix the apparent bug:

saschaeggi → created an issue.

Closing as duplicate

This issue was caused by a recent change in core.

We have our own fix on the way with 🐛 Table header overflow issue for multiple user role on permissions page. Postponed: needs info

saschaeggi → created an issue.

@robcarr I can't really reproduce this, can you provide steps how to reproduce this, Browser & which Drupal version you're using. Also does it happen only on a single instance (so potentially another module is interfering?)

I just tested this and the link just works fine.

We'll need more information here.

@JurriaanRoelofs definitely a mix between perfectionism and some things I really want to get in beforehand 😉

But 2024 is the year we'll see the stable release for sure I promise 😅

@alexandru.dumitru would

if (!isset($variables['element']['#weight']) || !is_float($variables['element']['#weight'])) {

work to solve your issue?

PS: please use an MR instead of patches as we don't use patches anymore.

The problem being we need a way to identify checkbox groups, as Drupal doesn't provide an official way to do so.

See #2643012: Add property to identify if checkbox/radio is in group of checkboxes/radios → , maybe we could check for the integer/float type instead if that would solve this issue, otherwise we might have to close this as won't fix 👀

FYI $suggestions[] = 'input__checkbox__toggle'; can't be removed as it will break core functionalities.

So maybe better to move this issue to the clientside_validation.

@Hebl I pushed a fix for Chrome 👀

Tugboat preview is fixed, can be tested at:

1. https://mr404-tvh4mpqiaqdfkkufdvfcc1xmmqdtjaxd.tugboatqa.com/user
2. Login with admin/admin
3. https://mr404-tvh4mpqiaqdfkkufdvfcc1xmmqdtjaxd.tugboatqa.com/admin/peopl...

Pushed another change to switch to use scrollsync to avoid some of the jerkyness when positioning an element with JS within overflow.

Testers wanted 👀

Thanks Jürgen! 👏

@Arantxio I was able to reproduce it in Chrome. I've pushed a fix.

I've setup some artificial roles in the linked Tugboat of the MR and can't reproduce the whitespace, see https://mr404-tvh4mpqiaqdfkkufdvfcc1xmmqdtjaxd.tugboatqa.com/admin/peopl... (admin/admin)

@Arantxio

it creates loads of blank space next to the permissions wrapper div

Can you share a screenshot?

kinda fixes this problem, however now everything gets cramped together which is also not wanted.

For this as well. Thank you.

I've created a new branch with a complete new approach and for me it seems to work locally, but I'd love to gather some more feedback.

Can somebody please test the branch https://git.drupalcode.org/project/gin/-/merge_requests/404?

You can generate a patch to use against the latest dev with https://git.drupalcode.org/project/gin/-/merge_requests/404.diff

Thank you in advance!

Thanks!