- Issue created by @pameeela
- π¨πSwitzerland saschaeggi Zurich
jurgenhaas β credited saschaeggi β .
- πΊπΈUnited States damienmckenna NH, USA
For the test coverage, would it be better to just copy all of Claro's tests and tidy them up, or just recreate them as needed?
- πΊπΈUnited States damienmckenna NH, USA
I created a sub issue for the tests: π Recreate/copy Claro tests to Gin 6.x Active
- π©πͺGermany jurgenhaas Gottmadingen
I've broken the tasks down into child issues. All of them are against the 6.x branch, and they're tagged with
Gin merge into Core
. - π¨π¦Canada mgifford Ottawa, Ontario
An important, outstanding issue with Gin is that accessibility issues have been raised and not addressed. Bringing Gin into Core will be a regression for accessibility, unless these issues are fixed. Many of the issues in https://www.drupal.org/project/gin/issues/3506302 π± [Meta] Improve the accessibility of the Gin theme Active were raised for Drupal CMS, where we were also attempting to meet WCAG requirements.
- πΊπΈUnited States damienmckenna NH, USA
@mgifford: That's amazing work, thanks to everyone involved!
Should we list all of the accessibility tasks under one priority category, or list them individually based upon their individual importance?
- π¨π¦Canada xmacinfo Canada
The more I work with Single Directory Components (SDC), the more Iβm convinced that SDC is mature and that is should be adopted in core themes.
For Gin 6.x, it could be an excellent opportunity to start shipping with a set of accessible, base-level SDC components. This would not only modernize Ginβs architecture but also provide reusable building blocks for consistency and future growth.
A first iteration could include foundational components such as:
- gin-link
- gin-input
- gin-pagination
- gin-radios
- gin-select
- gin-text
- gin-textarea
This is just a starting sample. The list can easily expand to include other essentials like gin-breadcrumb, gin-button, and more as we refine the component library.
To support both development and adoption, we might consider how to best showcase and test these components:
- Would a Stylebook-like repository (or Storybook integration) be valuable to document, preview, and track progress?
- Or would the new components folder structure alone be sufficient for contributors at this stage?
Each SDC component should align with Ginβs project requirements, namely:
- Accessibility-first implementation
- Light and Dark color mode support
- Consistent Gin styling and UX patterns
This leads to the key question:
> Is Gin 6.x the right branch to begin implementing SDC components in a systematic way?
- πΊπΈUnited States damienmckenna NH, USA
@xmacinfo: IMHO the first effort should be to make the necessary fixes to make it core-worthy, refactoring efforts should be held for later.
- π©πͺGermany jurgenhaas Gottmadingen
I've updated the IP with a not for testing. Also wanted to note that the first major step has been completed, the 6.x branch is now available and completely decoupled from Claro. It still renders the same result as before. Now it's time to go into details for cleaning up stuff.
Regarding #17, I do agree with #18 that the scope of merging Gin into core is to make the least possible structural changes, and get ready for improvements afterwards.
- π©πͺGermany jurgenhaas Gottmadingen
Next step has been completed: Code for 19 contrib projects has been removed from Gin 6.x and each of those project got an issue in their queue with a link to the MR to ask them to incorporate that code into their own projects. π Remove special treatment of contrib modules Active