Barcelona
Account created on 7 March 2011, about 13 years ago
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

We just defined an strategy to keep titles for the menus and avoid the problems with cache.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Huge +1. Beyond other qualities, his willingness to coordinate with others make him a great maintainer.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Huge +1 to this. His enthusiasm and smart calls make him key for this role.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

ckrina β†’ changed the visibility of the branch 3424744-on-collapsed-sidebars-off-11.x to hidden.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Replacing the screenshot posted to avoid confusion and discussions about unrelated elements on the page. Please take into account that this is still on the definition phase where we are actively defining (and testing) which features to provide.
Yes, the plan is to provide an plugable system for contribs and custom modules. But we still need to define where goes what and why, and after that provide the necessary documentation to help everybody make the best call. But as today we're not there yet :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Moving to Postponed until we've define how this feature needs to work.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Huge +1 to this. We need to make life easier to FEDs and provide good defaults for the rest.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Thanks for fixing this so quick. Committed ecf4b20 and pushed to 10.3.x. Thanks!

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Committed 981989f and pushed to 10.3.x. Thanks!

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

ckrina β†’ changed the visibility of the branch 11.x to hidden.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Would it be possible to clean-up&minimize the SVG itself too through a tool like https://jakearchibald.github.io/svgomg/? Sorry I didn't see it sooner :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Committed 7b292f0 and pushed to 10.3.x. Thanks!

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

ckrina β†’ changed the visibility of the branch 3438046-2nd-level-active to hidden.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Sorry, small detail! The icon megaphone should be pointing to the other direction, so moving this again to Needs work:

Wrong:

It should actually be:

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Re to #15 and #16:
We're using a variable font: it means that all weights are built in one file, so it really doesn't matter if we use 1 weight or 4. That's the magic behind variable fonts and why we decided using them. A variable font size might be twice a regular font, but you get way more :)
So there is no need for any redesign/design exploration. But thanks @jponch for being open to it!

However, I have no idea how to split a font by language/glyphs

There are several tools out there. @finnsky 's links have a few of them. But the question still is which languages.

About other languages, then it defaults to the system's font. I've tried it with Arabic and Japanese.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Normalizing title.

Closing since I can't reproduce this anymore. Feel free to open it if you still can, with steps to reproduce.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

@SKAUGHT this is a message we have designed. It's place is the vertical navigation because it's where the site-wide messages belong. The Top Bar will only be used for contextual tools/actions that belong to the content/forms on the page.
Now that the Navigation is in core can be addressed.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Closing this one for now since it's been mostly applied. We can open a new one in a few weeks. Thanks everybody for the work here!

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Thanks @katannshaw! Updating the issue summary with the detailed recommended approach to make it easier to understand and address the issue.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Thanks @rkoller for the feedback!
Removing "In regards of the navigation logo announce that logo link is forwarding the user to the front page of the default theme." since it has its own issue in πŸ› navigation Logo does not communicated where the link is taking the user Needs work .
Also, this issue should be split into smaller issues with specific recommendations for each point so they can be addressed easier. Smaller and focused issues are always better and easier. :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Designs have been updated to comply with the accessibility requirements. Updating the issue summary accordingly.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Standardizing issue title.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

If this could happen independently it would be great since the existing icon for missing icons looks like "broken" or that an icon is missing. We can always refactor and integrate the logic in the SVG process that ends up being used.

Also, it would be great if this MR didn't change any SVG file that doesn't really need to change to make it easier to isolate the changes.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

As Ivan mentions in #11 we aren't aren't shipping the italic font yet (since we don't use it, and I think we won't until the new design system is used more broadly on the UI), so that's something we can't remove.

So I agree with him on that the only way to decrease the file size: removing initial Language support to split the glyphs in different subsets. Do we have any guideline for Language prioritization already?

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

As mentioned in the other issue, this project is not used anymore and you should open issues against core. For that, be sure to test the latest version of the Navigation shipped with core. Closing this issue for this project, but if you can still reproduce in core feel free to move this into core's issue queue, on the navigation.module component. Before doing that thought please provide specific steps to reproduce the error you've found.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Thanks for your interest on the Navigation. You can go to the parent item through the title of the Drawer, when the sub-menu opens. We can't have the same item to open&close the sub-menu and to be a link at the same time because it's a usability problem discovered in the first UX tests.

Beyond that, this project is not used anymore because the Navigation has been merged into core. If you want to open any issue against the Navigation it has to be in core's issue queue.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Not sure what this issue is for: to add a logo when the Navigation is collapsed on mobile or to make it work on mobile without JS? If it's the first, the designs have already explored the logo on mobile and discarded it. The reason is that it will need to hold more elements beyond the existing toggle. If it's to get this working without JS, πŸ› The toolbar should be usable without JS Needs work . Let's clarify what this is for and make sure that issues focus on solving 1 problem only. :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Should we be using a variable font (I'm thinking maybe not).

You can see the background behind the decision already taken to use Inter font and in its variable form in 🌱 [PLAN] Discuss using Inter font for the navigation Fixed . On a design and UI perspective, even on a UX perspective to help give deep and differentiate typography styles, a variable font is the tool we need for a modern UI. It's basically one of the most important UI elements we have, since a UI is mostly built by text and surfaces.

That said, happy to find a way to decrease its weight.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

@AaronMcHale of course the ultimate goal should be to improve the IA, but that is out of scope for the Navigation. That should happen independently on 🌱 Restructure the admin interface Information Architecture Active .

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

I just came across this issue and this seems like a big UX change and I need to think a bit about it: the Navigation will handle many more things beyond what we have now (like Top Bar settings), so we need to plan for that before merging pages and hiding them in deeper levels. I'd like to hold big UX changes like this until we all have had time to discuss and agree on them. This needs some time and with DrupalCon planning going on I can't keep up with all issues.

So moving to Needs work not because the code isn't OK, but because we need to discuss the changes :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

ckrina β†’ changed the visibility of the branch 3391723-pp1plan-accessibility-review to hidden.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Really good idea, thanks Ben!

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Moving πŸ› The toolbar should be usable without JS Needs work to the Should have section.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

@bnjmnm
Not a stable blocker at all IMO. Disabling JavaScript does not prevent any content from being reached, nor does it make it inaccessible. It's less convenient without JS enabled, but that tends to be the case when disabling something that exists to make the web more convenient

Removing the Navigation stable blocker tag.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Based on this, changing the direction of this issue and updating the issue summary accordingly.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

@mherchel
In my mind there's a happy medium, which is just letting the top level nav be links. (when no JS)

Mike Gifford (CivicActions)
@bnjmnm is closer to this than I am. As I understand it the challenge is that without JS it is very difficult to make the entire navigation accessible. However, it is possible to make the first level accessible to assistive technology users who have also disabled javascript.
If I am understanding this correctly, than I am in agreement with that.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

By @plopesc in Slack
JFYI the cacheable menu links approach is AJAX based, so it would not work without JS πŸ“Œ Implement a caching strategy for the menu links Active .

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Just to point out that the contrib module is not going to be used anymore. So unless you want to do anything specific here for drupal.org or general contrib purposes, it'd be great to leave all issues closed to not give a false message to people :)

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Updating test environment link with the latest changes now that Navigation is in core.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Cleaning up the Stable blockers.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Since all the tickets from here except one have been closed, I'll close the meta and mark the missing issue as Navigation stable blocker.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Can this be addressed only for what is in core right now and updated with any other changes later?

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Hahah sorry @smustgrave I mean the other way around for the tag. Having one for the navigation will make things easier :D

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Moved SDC and Workspaces as Stable for 10.30, and added Navigation and Navigation Top Bar as new Experimental modules.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Closing this since we've updated the designs and merge Navigation into core as experimental, so this doesn't apply anymore.

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Closing as we've implemented new designs with a drawer to solve this.

Production build 0.69.0 2024