NH, USA
Account created on 25 January 2007, about 17 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

fwiw this appears to describe the issue I'm facing, but the provided patch doesn't fix it: πŸ› Ajax replace inside a modal causes the current field to lose focus. Needs work

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Rerolled, but it doesn't seem to work?

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Some of the underlying logic was changed in πŸ› Dialog focus is returned to dialog instead of first tabbable element on dialog AJAX update Fixed , so at the very least this needs to be rewritten.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Patch #36 (based on #32) resolves the problem of where the form is positioned, but the focus is still moved to the wrong field, the focus is moved to the first field in the parent entity form, rather than the first item of the child paragraph being added.

In my scenario I'm using Layout Builder to control the fields on an inline block. The block has two text fields followed by a paragraphs field. When either click "Edit" to show the fields for the paragraph, or click the "add" button to add another paragraph item, the same thing happens - the focus moves to the first field of the block, not the first field of the paragraph.

Is it possible there are core issues complicating this, something with the AJAX logic?

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Please take a look at the current output and let me know if it's better. Thank you.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This fixes it for me locally.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

I think we might need to try loading the devel module from D7Security via a composer.json file.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

I think we might need to try loading the devel module from D7Security via a composer.json file.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This existing issue exists: πŸ› Sort out and fix language fallback inconsistencies Needs work

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

I'm not sure why og_menu_form_node_form_alter() includes logic to force $form['menu']['enabled']['#default_value'] to be TRUE on new nodes, so this changes it subtly.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

The logic here interferes with core's standard node form logic.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This causes problems when editing a node that has a menu item - the "Provide a menu link" checkbox is unchecked.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

The enclosure tag has some logic to try and parse a file, but it should also output anything else that's assigned.

I wonder if the problem that the field itself is not outputting the correct data?

Just to test it - if you assign the same field to a simple text element, e.g. "description", do you get the expected value in that element?

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This works great, thank you!

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Thanks to fjgarlin for the syntax tip for the "exclude" option.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Related - I created a merge request that fixes the PHP 8 bugs in Devel:

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This works locally.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

The current test failures are due to problems with the Devel module, so I opened a merge request for it:

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

I think 7.x-3.11 should focus on bugs, especially deprecation errors from PHP.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Committed. Thank you.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This looks reasonable.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Something's causing the pipelines to not run.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

It'd be useful to be able to skip the Drupal.NamingConventions.ValidFunctionName.InvalidPrefix test in phpcs.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

This works locally.

Another part of the problem was that the code to trigger hook_scanner_query_alter() was removed at some point! Doh!

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Don't assume the 'summary' is set.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

The problem seems to be that text_scanner_preg_replace() doesn't load the language from the field.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Split the shared functions into a separate file.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Yeah, that was accidental.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Building on the last patch.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

The latest MR makes some changes I don't like:
* Hook arguments are changed.
* Array arguments are defined with a default of NULL, rather than an empty array.
* Some array definitions are changed to short arrays - we want to retain compatibility with PHP 5, so let's not do that.
* Inconsistent whitespace change.
* Some string translations have been removed.
* A code changes was made to scanner_execute() that removes a part of the query.
* Some syntax was changed to be shorter for PHP 7, this isn't something we can do.

While I appreciate the work done, this can't be used as is.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

All you have to do is have the media module 7.x-2.x branch in your codebase and it'll be able to find the class, it's included in the media_internet submodule of Media.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Is that for the channel or per item? There's a per-item enclosure field available from the settings popup, does that work or do you need something different?

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

It's still present in the D7 version. The D8+ version has never had the "edit meta tags" permission, we always took the approach that sites should use the Field Permissions module to control access to that field.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

That was all you had to do, I've taken care of it. Thank you for all of your contributions to the module and the Drupal community, we wish you well!

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Bump on the permissions problem for the prototype.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Not sure this is what's needed, but it's a starting point.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Committed.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Also, now that there's test coverage ( πŸ“Œ Add useful functional test Fixed ) we can finish this off to make sure it works as expected.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Committed.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Some basic test coverage for the shortcode filter.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

Committed.

πŸ‡ΊπŸ‡ΈUnited States DamienMcKenna NH, USA

As described.

Production build https://api.contrib.social 0.62.1