NH, USA
Account created on 25 January 2007, almost 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States DamienMcKenna NH, USA

I can confirm that in 3.0.0-beta3 the modules work together as expected.

🇺🇸United States DamienMcKenna NH, USA

After looking through all of the facet options, it turns out that all you have to do is uncheck the "Hide facet when facet source is not rendered" option.

🇺🇸United States DamienMcKenna NH, USA

The current documentation file (in the _documentation directory) is also out of date and needs to be updated.

What you need to do is:
* Open the "Processors" settings page of the index you want to add the glossary to.
* Enable the "Glossary processor" processor.
* In the "Processor settings" section, open the "Glossary processor" tab and enable the field you want to use for the glossary.
* Save the index.
* Add a facet to the view or Search API Page that points to the "Glossary AZ" field that corresponds to the field above.
* Set the facet to use "Glossary AZ" widget.
* Work through all of the options that include "Glossary" in their name, enable the ones that you want.
* Save the facet.
* In the block layout settings, use the "Place block" option to open the block selection, and add the glossary facet you created above; adjust the block visibility settings as necessary.

I was fumbling in the dark a bit, but this seems to work.

🇺🇸United States DamienMcKenna NH, USA

Ran into this today, the workaround was to disable the drag UI and just edit the weights manually.

🇺🇸United States DamienMcKenna NH, USA

Marking the existing work as RTBC as it works really well.

🇺🇸United States DamienMcKenna NH, USA

While testing the latest MR it gave an error that dynamic properties was deprecated, so adding the $adminCache property resolves the error.

I would suggest creating a follow-on issue to rework some of the logic to properly use DI for \Drupal::cache(), and some of the other things that are loaded via services.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna made their first commit to this issue’s fork.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna created an issue.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna created an issue.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna created an issue.

🇺🇸United States DamienMcKenna NH, USA

Please don't mark something RTBC if you haven't checked the test pipeline, because unfortunately these changes broke a lot of tests. Also, it seems to have added a cspell issue.

🇺🇸United States DamienMcKenna NH, USA

Please try naming the field something different, e.g. "meta_tags", see if that works. If it ends up being a compatibility issue we can add a note to the docs and via hook_requirements().

🇺🇸United States DamienMcKenna NH, USA

How did you create the field without the typical "field_" prefix? I wonder if there's a collision happening somehow?

🇺🇸United States DamienMcKenna NH, USA

Thank you for creating this issue.

Test coverage to confirm the backup works is 100% the way to go.

🇺🇸United States DamienMcKenna NH, USA

I'm sorry the module hasn't been working for you. Please help us make it better by testing the current dev release and reporting issues that show up. Thank you.

🇺🇸United States DamienMcKenna NH, USA

Going to give it a few days for people to test before I tag this release, just to make sure there aren't any regressions.

🇺🇸United States DamienMcKenna NH, USA

Going to give it a few days for people to test before I tag this release, just to make sure there aren't any regressions.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna changed the visibility of the branch 8.x-1.x to hidden.

🇺🇸United States DamienMcKenna NH, USA

Committed. Thanks everyone!

🇺🇸United States DamienMcKenna NH, USA

Committed! Thanks everyone!

🇺🇸United States DamienMcKenna NH, USA

Committed. Thanks.

🇺🇸United States DamienMcKenna NH, USA

There's a regression in the tests against D11, that needs to be fixed then it'll be ready to go.

🇺🇸United States DamienMcKenna NH, USA

Committed. Thank you!

🇺🇸United States DamienMcKenna NH, USA

Meta tags that allow multiple values will automatically have a note added to their description.

🇺🇸United States DamienMcKenna NH, USA

Committed. Thank you!

🇺🇸United States DamienMcKenna NH, USA

Committed.

🇺🇸United States DamienMcKenna NH, USA

damienmckenna created an issue.

🇺🇸United States DamienMcKenna NH, USA

Committed.

🇺🇸United States DamienMcKenna NH, USA

Committed. Thank you everyone for digging through this.

🇺🇸United States DamienMcKenna NH, USA

Ok.. so at some point today the default build changed from 10.3 to 11.0. I'll do a separate issue to update the tests to also test 10.3, but otherwise this is ready to go.

🇺🇸United States DamienMcKenna NH, USA

The v2 upgrades fail because the d9 fixtures file was removed. That makes sense.

🇺🇸United States DamienMcKenna NH, USA

I've changed it so that phpcs tests can fail, will deal with that later: 📌 Resolve phpcs issues in 2.0.x / 2.1.x Active

🇺🇸United States DamienMcKenna NH, USA

The providerSource() change means we can't have the tests run against 10.2 anymore, though the rest of the codebase should be compatible. I guess that will have to be a limitation we deal with, and we'll have to disable OPT_IN_TEST_PREVIOUS_MINOR.

🇺🇸United States DamienMcKenna NH, USA

Should there be a change notice for this? Or maybe an 11.1 tag?

🇺🇸United States DamienMcKenna NH, USA

Thanks for the patch, this resolved the problem for me.

It might be worth turning this into a merge request.

🇺🇸United States DamienMcKenna NH, USA

#26 results in this error when loading core/install.php:

TypeError: Symfony\Component\DependencyInjection\Container::set(): Argument #2 ($service) must be of type ?object, string given, called in /var/www/html/docroot/core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php on line 47 in Symfony\Component\DependencyInjection\Container->set() (line 146 of /var/www/html/vendor/symfony/dependency-injection/Container.php).

🇺🇸United States DamienMcKenna NH, USA

Can you please confirm the version of Metatag that is being used, which Metatag submodules are being used, and whether you're also using Schema.org Metatag and its submodules?

🇺🇸United States DamienMcKenna NH, USA

I think it should be a module.links.task.yml item.

🇺🇸United States DamienMcKenna NH, USA

Committed, will deal with the faulty tests in 📌 Fix tests in 8.x-2.x branch Active .

🇺🇸United States DamienMcKenna NH, USA

Waiting for the test run to finish.

🇺🇸United States DamienMcKenna NH, USA

I'm going to throw this together.

🇺🇸United States DamienMcKenna NH, USA

That is good to know, thank you koosvdkolk!

I opened a separate issue so we can document using HTML Purifier: 📌 Document how to use HTML Purifier instead of core filters Active

🇺🇸United States DamienMcKenna NH, USA

There's also seckit which also can set the CSP headers.

Production build 0.71.5 2024