This is already how it works, I mixed up how two different text formats were set up and didn't see the selector.
In that case, I would propose:
* Remove the custom Metatag base field.
* Update the default configuration to use the existing fields.
Updated patch for 4.1.6 for the missing 'use' statement.
We need different issues for these core & token changes, so I'll open some.
Changing it to "default" would work too, though it would be my second suggestion; my primary objection is to the word "fallback".
Committed. Will refine it in other tickets.
Needs to be turned into a merge request. It might also be worth adding test coverage.
Marking this "postponed" as there might not be anything we need to do in Metatag for it.
An alternative solution to this was committed in ✨ Add placeholder to clear / unset inherited value Closed: duplicate , whereby you can distinguish between the two requests of "I want to revert to the default for this one meta tag" and "I don't want this meta tag to be output".
Thank you for the improvements.
I recreated the MR from scratch against the 2.2.x branch, just waiting for the tests to finish.
damienmckenna → changed the visibility of the branch 3488276-moar-attributes to hidden.
damienmckenna → changed the visibility of the branch 2.2.x to hidden.
damienmckenna → changed the visibility of the branch 3488276-attributes to active.
damienmckenna → changed the visibility of the branch 3488276-attributes to hidden.
damienmckenna → changed the visibility of the branch 2.2.x to hidden.
damienmckenna → made their first commit to this issue’s fork.
This needs some manual cleanup - no AI please.
Thanks for putting this together, it looks good.
I added a follow-on issue for this because it's confusing for site visitors: #3546520: (optionally?) Sort all shipping prices by cost →
How to set up permissions on gitlab projects so that others can access them.
The MR should point to a semver branch rather than an unconventional naming scheme, that's what the d.o infrastructure works best with.
I'm going to try porting this to Playwright today.
aangel: Could you please follow the semver practice of having an x.y.z branch? Feel free to ping me if you'd like to discuss approaches. Thank you.
This is a reasonable start - after it's committed we can do some bug testing to see if there any issues.
Bumping the priority as this is causing problems for WIP sites trying to upgrade to Commerce v3, which is needed for other improvements.
Thank you for the fix, I've confirmed it's working now.
The issue URL was: https://new.drupal.org/contribution-record/11423778
I think this is a problem with the Bootstrap Sass theme because it includes several files in the js directory from other sources - it has Bootstrap v4.0.0-beta, jQuery and Popper, and its own copy of the barrio.js file from the Barrio theme.
You should move this to the Bootstrap Sass theme and submit a patch to it that removes its extra JS files.
For anyone who wants it, this is a version of the patch for 8.x-1.x
damienmckenna → created an issue.
damienmckenna → created an issue. See original summary → .
This is related to 🐛 Profile validation email generated by authorize.net doesn't include the customer email Postponed: needs info .
damienmckenna → created an issue.
Rerolled.
damienmckenna → created an issue.
Tagging to make it easier to find this issue.
ARGH!
I found it!
On the "Order type" edit form there was a checkbox labeled "Enable shipping for this order type" that was disabled. I enabled that checkbox and then the fields showed as expected.
I aded a MR that clarifies the setup instructions.
I added youtube://l/ patterns to the media_internet_field_value plugin.
damienmckenna → created an issue.
Committed. Thanks everyone, and Anybody ;-)
damienmckenna → changed the visibility of the branch 3272202-add-none-placeholder to hidden.
tostinni: That's a great point - please add a separate issue to extend tags to provide the "none" option. Thank you.
FYI I used Entity Extra Field → to create an "extra" field that output the variation's price - not as clean as having a dedicated formatter, but it worked.
damienmckenna → created an issue.
Committed.
damienmckenna → changed the visibility of the branch 3541817-replace-annotations to hidden.
Committed. Thank you.