NH, USA
Account created on 25 January 2007, over 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States damienmckenna NH, USA

Should this be a feature request?

🇺🇸United States damienmckenna NH, USA

The idea with Metatag is to define defaults for each entity type at the global level using tokens to pull in values from the entities. Take a look at Configuration → Search and metadata → Metatag, and customize the configuration for each entity type. You can also override the entity type configuration on a per bundle basis via the "Add default meta tags" page, so that e.g. different content types could have slightly different values based upon the fields available. In theory this should cover most scenarios, especially if you have a few fields on the entity type/bundle for a summary/description and a thumbnail image. IMHO most sites don't need the Metatag field on content types, they should leverage the defaults, fields and tokens.

Also, if you add the Token OR module you can have either-or logic within each token, useful for setting a failover default if a field isn't filled in.

🇺🇸United States damienmckenna NH, USA

Does metatag [module] need the [full metatag] field to be present to pull from the description and image base fields for metadata?

No, Metatag can just use tokens in a global configuration to generate meta tags for content entities based upon those few fields, so removing the Metatag field for now would probably be the best bet.

🇺🇸United States damienmckenna NH, USA

Thank you for putting together a merge request for this, it looks good.

🇺🇸United States damienmckenna NH, USA

XB shouldn't be doing weight things like that via hook_entity_base_field_info, it should just add the field via Field API.

🇺🇸United States damienmckenna NH, USA

I wasn't able to reproduce this. I wonder if it was because of 🐛 Invalid NULL value in json_widget.js Active ?

🇺🇸United States damienmckenna NH, USA

This needs an update script to fix existing fields that have the wrong size.

🇺🇸United States damienmckenna NH, USA

You are completely correct, these need to be supported. Let's add test coverage too.

🇺🇸United States damienmckenna NH, USA

Committed. Thanks everyone.

🇺🇸United States damienmckenna NH, USA

damienmckenna changed the visibility of the branch 8.x-1.x to hidden.

🇺🇸United States damienmckenna NH, USA

The current merge request doesn't do anything useful, so I've closed it.

🇺🇸United States damienmckenna NH, USA

Committed. Thank you.

🇺🇸United States damienmckenna NH, USA

Good catch, thank you.

🇺🇸United States damienmckenna NH, USA

Sure, that's definitely doable. I would strongly recommend changing the multi-value separator to something other than a comma, though.

🇺🇸United States damienmckenna NH, USA

I created a merge request to let the tests run so we can see how the change behaves against different core branches.

🇺🇸United States damienmckenna NH, USA

I wonder would removing the field from the advanced section resolve the problem instead? That's an option on the field widget.

🇺🇸United States damienmckenna NH, USA

This resolves the problem with 10.5.0.

I think we should create a new minor branch (1.1.x) for this fix, then update 1.0.x to limit its compatibility to <10.5 and <11.2, then the new 1.1.x branch requires 10.5 or 11.2.

🇺🇸United States damienmckenna NH, USA

FYI while this probably would have fallen under PSA-2023-07-12 , this should have been reported privately as a security issue and then discussed with the Drupal Security Team. Please try to keep this in mind if similar issues show up again. Thank you.

🇺🇸United States damienmckenna NH, USA

On a website I'm using this with I'm seeing some unexpected behavior where terms are being placed under incorrect parent items. For example, I have one term which does not have a parent in the database, but it is placed under a term which isn't even in the vocabulary that the first term comes from.

🇺🇸United States damienmckenna NH, USA

On a local barebones 11.1.x install with the latest Facets 3.0.x I could not reproduce the problem that this resolves.

We might need to dig into it a little more and add test coverage to confirm exactly what behavior we're after, because I wonder how much of it is a data problem?

🇺🇸United States damienmckenna NH, USA

Would it be worth a separate issue to simplify the implementation logic so the extra $databases[..]['dependencies'] logic could be automatic based upon the class hierarchy rather than needing to be explicitly defined?

🇺🇸United States damienmckenna NH, USA

This works great, once you set the processors to the correct order, e.g.:
* Show parents
* URL handler
* Transform entity ID to label
* Build hierarchy tree

Marking RTBC to get the maintainer to take a look.

🇺🇸United States damienmckenna NH, USA

This works great - there's no reason the library should be loaded on every page.

🇺🇸United States damienmckenna NH, USA

IMHO this is a bug report, and when enabled is the expected behavior.

I've been pulling my hair out over this, trying to work out why the term hierarchy is not shown, only for it to be a problem with the module.

Thank you for this fix!

🇺🇸United States damienmckenna NH, USA

FYI I'm getting lots of this error after trying the change:

Deprecated function: Invalid characters passed for attempted conversion, these have been ignored in Drupal\Component\Utility\Number::intToAlphadecimal() (line 80 of core/lib/Drupal/Component/Utility/Number.php).

🇺🇸United States damienmckenna NH, USA

FYI the separate provider module has been deprecated in favor of this issue, though the current MR doesn't apply against the 3.x branch.

🇺🇸United States damienmckenna NH, USA

I tried modifying the playwright.config.js file as follows:

  reporter: [
    'html',
    {
      host: 'damiend10.ddev.site'
    },
  ],

(where "damiend10.ddev.site" is my hostname)

.. but it doesn't make any difference, it still shows the error.

🇺🇸United States damienmckenna NH, USA

Please check to see if you still have the metatag.tokens.inc file in your metatag directory - it was deleted in 2.1.1, but it might still be present.

🇺🇸United States damienmckenna NH, USA

damienmckenna changed the visibility of the branch 3.0.x to hidden.

🇺🇸United States damienmckenna NH, USA

Let's make this a minor UI improvement by making it not required but improving the help text to better indicate when it should be added.

🇺🇸United States damienmckenna NH, USA

Thank you for taking up that responsibility!

I'm not personally interested in it, but maybe others might be?

🇺🇸United States damienmckenna NH, USA

Thank you for the patch you've provided so far.

As a reminder, please set the "Assigned" field to "Unassigned" after you're finished your work, that way others can know that you're finished and that it's ready to review.

🇺🇸United States damienmckenna NH, USA

Per 💬 Schema.org: Service Active we need to make sure these attributes are included too:

* serviceType
* areaServed
* description

🇺🇸United States damienmckenna NH, USA

Thank for reporting this.

This would be a feature request to extend the existing structure with these new attributes.

🇺🇸United States damienmckenna NH, USA

I'm sorry but with D7 in EOL we won't be digging into this anymore.

🇺🇸United States damienmckenna NH, USA

Note: I missed that there is an update script that adds an initial attribute for each custom tag already in the system, apologies for my oversight and thank you for taking care of that already.

The other issues still remain though.

🇺🇸United States damienmckenna NH, USA

FYI I think we should postpone further discussion here until 📌 [Policy] Define explicit Drupal 10 end of life date of 2026 December regardless of Drupal 12 release Active is decided upon, as it might make it moot.

🇺🇸United States damienmckenna NH, USA

While this is still being worked on, I created a separate MR that improves the JS output of the checkbox widget: Add missing classes to checkbox widget so it renders correctly Active

🇺🇸United States damienmckenna NH, USA

In my local testing this is working better than the current 3.0.0 branch - checkboxes float correctly beside the labels, labels don't wrap underneath the checkbox, etc.

🇺🇸United States damienmckenna NH, USA

It might be worth reverting this change to avoid breaking backwards compatibility.

🇺🇸United States damienmckenna NH, USA

The functionality works for me locally, but the wording and option name may need to be adjusted to make it more readable.

🇺🇸United States damienmckenna NH, USA

I've created a merge request that adds a new option for rendering the token output as markup.

🇺🇸United States damienmckenna NH, USA

For the short term I think we should prioritize data elements that are required per specifications, e.g. 🐛 ProfilePage is missing mainEntity Active .

🇺🇸United States damienmckenna NH, USA

I'm sorry you're running into that problem.

What version of Metatag were you using before updating? What version of PHP are you using? Do you have Drush available to use it to rebuild the caches? Are you able to see what errors are logged to the database or to the server logs?

🇺🇸United States damienmckenna NH, USA
+      $message = [
+        t('Entry has been skipped due to duplicate policy.'),
+        $entry['title'],
+      ];
+      \Drupal::logger('bibcite_import')
+        ->error(implode("\n", $message));

This part should be simplified as follows:

\Drupal::logger('bibcite_import')
  ->error(t('Entry has been skipped due to duplicate policy: @title', [
    '@title' => $entry['title'],
  ]);
🇺🇸United States damienmckenna NH, USA

Thanks for clarifying that.

Let's remove the existing functionality and update the docs accordingly.

🇺🇸United States damienmckenna NH, USA

I think this is the correct status.

🇺🇸United States damienmckenna NH, USA

Thank you for working on this, it will be a great improvement once it's finished.

Testing this locally I see some issues:

  • The existing standard process of the custom tag's machine name being used as the "name" attribute is removed, so this will break backwards compatibility.
  • It doesn't indicate that the new attributes are required, otherwise no "name" attribute will be output.
  • It doesn't indicate that the name and value fields should be required, otherwise they will be excluded from the output.
  • No indication is given that the extra attributes cannot be edited through the defaults or per-entity forms, they're fixed values for all uses of that custom tag.

So it still needs a little work but is almost there.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

For completeness sake can someone please clarify if this went into 11.2 or if it's delayed until 11.3? Also, given the importance of this new functionality it might be worth tagging for the release notes / highlights. Thank you.

Production build 0.71.5 2024