🇺🇸United States @damienmckenna

damienmckenna → changed the visibility of the branch 3.0.x to hidden.

Let's make this a minor UI improvement by making it not required but improving the help text to better indicate when it should be added.

Thank you for taking up that responsibility!

I'm not personally interested in it, but maybe others might be?

Thank you for the patch you've provided so far.

As a reminder, please set the "Assigned" field to "Unassigned" after you're finished your work, that way others can know that you're finished and that it's ready to review.

Per 💬 Schema.org: Service Active we need to make sure these attributes are included too:

* serviceType
* areaServed
* description

Let's combine this with #3172246: Additional fields to Service Object → .

Thank for reporting this.

This would be a feature request to extend the existing structure with these new attributes.

I'm sorry but with D7 in EOL we won't be digging into this anymore.

Note: I missed that there is an update script that adds an initial attribute for each custom tag already in the system, apologies for my oversight and thank you for taking care of that already.

The other issues still remain though.

FYI I think we should postpone further discussion here until 📌 [Policy] Define explicit Drupal 10 end of life date of 2026 December regardless of Drupal 12 release Active is decided upon, as it might make it moot.

While this is still being worked on, I created a separate MR that improves the JS output of the checkbox widget: ✨ Add missing classes to checkbox widget so it renders correctly Active

In my local testing this is working better than the current 3.0.0 branch - checkboxes float correctly beside the labels, labels don't wrap underneath the checkbox, etc.

damienmckenna → created an issue.

It might be worth reverting this change to avoid breaking backwards compatibility.

The functionality works for me locally, but the wording and option name may need to be adjusted to make it more readable.

I've created a merge request that adds a new option for rendering the token output as markup.

Am working on this.

damienmckenna → created an issue.

For the short term I think we should prioritize data elements that are required per specifications, e.g. 🐛 ProfilePage is missing mainEntity Active .

I'm sorry you're running into that problem.

What version of Metatag were you using before updating? What version of PHP are you using? Do you have Drush available to use it to rebuild the caches? Are you able to see what errors are logged to the database or to the server logs?

+      $message = [
+        t('Entry has been skipped due to duplicate policy.'),
+        $entry['title'],
+      ];
+      \Drupal::logger('bibcite_import')
+        ->error(implode("\n", $message));

This part should be simplified as follows:

\Drupal::logger('bibcite_import')
  ->error(t('Entry has been skipped due to duplicate policy: @title', [
    '@title' => $entry['title'],
  ]);

Thanks for clarifying that.

Let's remove the existing functionality and update the docs accordingly.

I think this is the correct status.

damienmckenna → created an issue.

Thank you for working on this, it will be a great improvement once it's finished.

Testing this locally I see some issues:

• The existing standard process of the custom tag's machine name being used as the "name" attribute is removed, so this will break backwards compatibility.
• It doesn't indicate that the new attributes are required, otherwise no "name" attribute will be output.
• It doesn't indicate that the name and value fields should be required, otherwise they will be excluded from the output.
• No indication is given that the extra attributes cannot be edited through the defaults or per-entity forms, they're fixed values for all uses of that custom tag.

So it still needs a little work but is almost there.

Done: https://www.drupal.org/project/metatag/releases/2.1.1 →

damienmckenna → created an issue.

For completeness sake can someone please clarify if this went into 11.2 or if it's delayed until 11.3? Also, given the importance of this new functionality it might be worth tagging for the release notes / highlights. Thank you.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue.

damienmckenna → created an issue. See original summary → .

The 404 error is related to a HF problem: https://discuss.huggingface.co/t/persistent-404-not-found-errors-with-pu...

After I connected the correct API key face🤦‍♂️ it still doesn't work and gives this error instead:

Could not load the embeddings engine to get the dimensions. Please check the configuration.Client error: `POST https://api-inference.huggingface.co/models/intfloat/e5-mistral-7b-instruct` resulted in a `404 Not Found` response: Not Found

Steps so far:
* Sign up at https://huggingface.co and go through the steps to confirm the account.
* Open the profile page.
* In the sidebar open the "Access tokens" page: https://huggingface.co/settings/tokens
* Click on "Create new token".
* Provide a name for the token and select the appropriate permissions and click "Create token".
* Once the token is generated, copy the string.
* On the Keys admin page (admin/config/system/keys) click "Add key".
* Fill in a key name and description as appropriate.
* Set the "Key type" to "Authentication".
* Set the "Key provider" as appropriate for the individual scenario; a simple option is to set it to "Configuration".
* Set the "Value" as appropriate for the individual scenario; a simple option is to paste in the API key generated earlier.
* Click "Save" to save the API key.
* Open the Huggingface admin page (admin/config/ai/providers/huggingface).
* On the "Huggingface Access Token" field select the API key / token item that was created above.
* Complete the reset of the setup as necessary.

Note, it's not clear what permissions are necessary.

I opened a separate issue for the endpoint issue: ✨ Document what the endpoint should be set to Active

Right now you have to guess what the endpoint value should be - it might be useful to provide a selector?

damienmckenna → created an issue.

It might be best to have a selector to choose the engine that is used, e.g. "faiss" or "lucene".

FWIW manually changing it to "faiss" lets it save without errors.

damienmckenna → created an issue.

Problem: When setting up an initial environment for testing it's not clear what the "endpoint" value should be?

damienmckenna → created an issue.

Steps so far:
* Sign up at https://admin.mistral.ai.
* Open the "La Platforme" page.
* In the sidebar, under "Workspace" section, open "API keys".
* If the account has not enabled API access yet, click through to update the account to either "Experiment" mode or a paid subscription.
* Back on the API keys page (https://console.mistral.ai/api-keys) click "Create new key".
* Provide a name for the API key and an expiration date, if desired; click "Create new key".
* Once the API key is generated, copy the string.
* On the Keys admin page (admin/config/system/keys) click "Add key".
* Fill in a key name and description as appropriate.
* Set the "Key type" to "Authentication".
* Set the "Key provider" as appropriate for the individual scenario; a simple option is to set it to "Configuration".
* Set the "Value" as appropriate for the individual scenario; a simple option is to paste in the API key generated earlier.
* Click "Save" to save the API key.
* Open the Huggingface admin page (admin/config/ai/providers/huggingface).
* On the "Huggingface Access Token" field select the API key item that was created above.
* Complete the reset of the setup as necessary.

damienmckenna → created an issue.

Good work, thank you for putting that together.

There are a few minor Markdown issues, e.g. it goes from a level 1 heading to level 3, then splits up a sequence of level 3 headings with a level 2 heading.

damienmckenna → created an issue.

damienmckenna → created an issue.

I wonder if this is simpler - is "verify_ssl" the wrong attribute to pass to Guzzle?

For what it's worth, I changed StandardConnector.php to this:

  protected function getClientOptions(): array {
    return [
      'base_uri' => $this->configuration['url'],
      'verify_ssl' => $this->configuration['ssl_verification'],
      'verify' => $this->configuration['ssl_verification'],
    ];
  }

and now it gives this error:

OpenSearch\Exception\UnauthorizedHttpException: in OpenSearch\Exception\HttpExceptionFactory::create() (line 24 of /home/mysite/vendor/opensearch-project/opensearch-php/src/OpenSearch/Exception/HttpExceptionFactory.php).

damienmckenna → created an issue.

#2 as a patch.

damienmckenna → created an issue.

damienmckenna → changed the visibility of the branch 3428801-automated-drupal-11 to hidden.

Done: https://www.drupal.org/project/agls/releases/2.0.0 →

Committed, thank you.

Thank you. Looks good!

damienmckenna → created an issue.

This is a documentation issue - the project's docs → need to make it more clear.

I added a breakpoint at the top of MetatagFirehose::formElement() and it shows that $element['#weight'] exists and has a value of 0:

I changed the field's order on the form display settings for that content type and its weight did not change.

I examined EntityFormDisplay::buildForm() and after it runs foreach($this->getComponents() the Metatag field's is correct:

This implies a bug in Form API or maybe the admin theme, not Metatag.

Could this not also cause regressions if the computedValue() is legitimately being triggered during a batch?

I wonder if there is some other custom or contrib code that is triggering the computedValue() logic when hook_entity_delete() is triggered? Maybe something is regenerating JSONAPI data or something?