🇺🇸United States @DamienMcKenna

What are the errors like if MetatagApiTest.php doesn't have phpcs:ignoreFile?

Nothing else to worry about for now.

Thank you for updating the merge request.

Now we just need some test coverage to make sure zeroes are handled properly.

I tested patch #4 but it doesn't retain the "class" attribute, something is removing it. I think the definition also needs an entry for the span tag.

I think the best way forward would be to put some time into Extended HTML Filter → and make it a required dependency for the submodules that require the "style" attribute.

DamienMcKenna → created an issue.

DamienMcKenna → created an issue.

DamienMcKenna → created an issue.

As a reminder - the "assigned" field is for indicating that you are actively working on something, once you're done please update the field to "unassigned". Thank you.

I worked out a fix for this - the config schema needed to use a "sequence", not a "mapping".

Done: https://www.drupal.org/project/cincopa/releases/8.x-1.3 →

DamienMcKenna → created an issue.

Fixed directly.

Committed. Thank you.

Committed.

Committed.

Committed.

DamienMcKenna → created an issue.

DamienMcKenna → created an issue.

Thank you for pointing that out, I opened a new issue to deal with it: 📌 Improve UX for overriding meta tags per entity bundle Active

DamienMcKenna → created an issue.

The current 1.14.0 milestone: https://github.com/jquery/jquery-ui/milestone/4

The jQuery UI roadmap hasn't been updated in over seven years: https://jqueryui.pbworks.com/w/page/12138038/Roadmap

Thank you for the update.

Should this issue be refocused on the jQuery 4 plan for D11 with remaining tasks identified and then a separate task for updating to a final jQuery 4 release for a future core release?

Given that 11.0.0-rc1 was released already, should the sub-issues be listed in another plan issue and this one closed?

What is remaining on this issue?

Core maintainers, do you agree with mondrake's comment about the return type?

It's the end of July, 11.0.0-rc1 is out already, what's the plan here?

10.3.0 is out already, does that mean it's too late to backport this issue and it should go back to being "fixed"?

The merge requests need to be updated to the latest changes on their respective branches.

With jQuery 4 still in beta, does this mean Drupal 11 is being delayed from the original release plan of the week of July 29th?

I still have not received a response from the maintainer.

Moving to the project ownership issue, per the standard process to adopt unmaintained projects → .

The last release was in June 2023, not June 2024.

So yes, anything in the current dev branch will be in the next release.

Committed.

Thank you for working on this.

I found some documentation around this API change: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-41....

I think we should add this to beta2 and indicate it requires core 10.3, per this updated patch.

DamienMcKenna → created an issue. See original summary → .

I'm considering leaving this one as "won't fix" and leave this merge request here for people who want to use it.

you need to review the output's raw code, not view it through a GUI tool that collapses whitespace.

Ah. The reason was that the Panelizer integration was removed in #3305586: Remove Panelizer support → .

Is the problem with Page Manager pages or Panelizer pages?

I was informed that the root problem was in fact a browser plugin rather than the browser itself. As such, we might consider this a feature request rather than a bug report?

All you should need to do is load the view thats bundled with the test module and examine its output.

Patch #60 includes the contents of additional-fields-article-schema-3099610-59.patch, doubling the size of the patch.

This also needs to be moved to the 3.0.x branch.

Lastly, can someone please update the issue summary to make it more clear what is being added?

Thank you.

The MR is empty, and the patch needs a slight improvement for coding standards. It might also be worth using !is_numeric() rather than just != to make the intent more clear. Lastly, I think there should be test coverage for this change.

There's already a VideoObject type, so I think this needs to be redone to use it?

I think this is ok?

Looks good. But I think it needs some API documentation.

This should go into a 3.1.x branch.

I think this should go into a new 3.1.x branch.

This is the wrong approach - the parent PropertyTypeBase class shouldn't know about individual tags.

Looks pretty good, but it needs a test file to make sure the functionality works.

This looks good, thank you.

It needs to go into a new 3.1.x branch.

Moving this to the 3.0.x branch.

Thank you both for finishing this off.

I think this needs to go into a 3.1.x release.

Proposed changes, in patch format.

DamienMcKenna → created an issue.

-    if (!empty($max_pub_date)) {
+    if ($max_pub_date !== NULL) {

Per the comment above it, this line needs to check to exclude zeroes too, which is why it used !empty() before; I think it'd be fine to revert it to !empty().

I fixed the issues and committed the changes directly. Thanks for spotting that.

A lot of things have changed in PHP over the years since I created #5, and some of the suggested changes might break compatibility with older releases of PHP.

Putting it back to "needs review" because of the above.

Adding Extatic who worked on another ticket that this absorbed.

Ah yes, thanks for the reminder.

Extatic: You'll get issue credit on the other issue. Thank you for your work on this.

Thank you for putting this together.

With a quick look I think this is the correct approach.

Due to drupalci being shut down, this needs to be turned into a merge request for the 3.0.x branch, then we can confirm whether it still works.

Wrong method to get the node bundle.

Committed. Thank you.

Committed, with a minor change to the README.md file and I updated composer.json to use v2. Thank you all.

Thank you for opening this issue and for providing a merge request.

Please see the changes made in 🐛 Error rendering breadcrumb list Fixed and 🐛 Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup.... Active , the change on this issue should match the change from the others.

Thank you.

Committed. This will be in the next release.

Good work! Committed. Thank you.

Don't assume the Contact module is installed.

Thank you for providing the merge request with the proposed changes.

Moving this to the 3.0.x branch.

Committed. Thank you.

DamienMcKenna → created an issue.

Thank you for the fixes, I've committed patch #8.

Thank you!

Can you please update the gitlab-ci config to not ignore failing phpcs and cspell tests? Thank you.

I don't see why method_exists($this->renderer, 'renderPlain') wouldn't work? method_exists() can take either a class name or an object.

Does more interrogating of $text need to be done before it's passed to renderPlain()? I wonder what the data looks like?

Leaving this for someone else to work on, don't have time to continue on it today.