Originally written by bmelvin1, with a minor change by me.
For some reason it failed creating the issue fork - it doesn't seem to be possible to access it?
Code written by an ex employee of Berklee (who doesn't seem to have a d.o account), with some formatting & comment improvements by me.
This patch was written by bmelvin1 and another developer at Berklee, and rerolled & improved by me.
Am seeing this bug happen in the current 8.x-3.0 release sometimes. We've used Feeds to import content since the site launched 2.5 years ago. Most of the time the feed content is unpublished correctly. However, the last item that was removed from the feed (sometime since July) was not unpublished as expected. Incidentally, the feed XML currently contains zero items, all of the feed content is unpublished as expected except for the last one.
damienmckenna → changed the visibility of the branch 2.2.x to hidden.
I can't find the string "ai_info" in either this module or the main ai module?
I created a new index named "aiindex" and the error still happens, so maybe it's something internal in the module?
I worked out the sequence if events - if the sqlite extension is working correctly when the configuration is first created it then doesn't try to recreate it during any other steps (indexing, etc). To fix the problem I first got the sqlite extension working ;-) then I deleted the index in Search API then re-imported the configuration, it then was able to connect to the database file and created the necessary table.
It might be worth adding some extra checks to verify the index is working correctly, e.g. it should show on admin/config/search/search-api/index/INDEXNAME whether the index can be connected to.
When saving the index would it be useful to check the index table exists, and if not to create it?
At what point is it supposed to create the table? I see SQLiteVectorClient::createCollection() where it has this code:
public function createCollection(
string $collection_name,
int $dimension,
SQLite3 $connection,
): void {
$escaped_collection_name = $this->escapeIdentifierForSql($collection_name);
// 1. Create the main table for metadata
$create_main_table_sql = "CREATE VIRTUAL TABLE IF NOT EXISTS {$escaped_collection_name} USING vec0 (
id INTEGER PRIMARY KEY AUTOINCREMENT,
content TEXT,
drupal_entity_id TEXT,
drupal_long_id TEXT,
server_id TEXT,
index_id TEXT,
embedding float[{$dimension}]
);";
if (!$connection->exec($create_main_table_sql)) {
throw new CreateCollectionException(message: "Failed to create metadata table '{$collection_name}': " . $connection->lastErrorMsg());
}
}
I added a breakpoint there but it doesn't get triggered when editing the index or indexing the content.
The error still happens once I made sure the extension could load.
Turns out there were earlier errors related to the sqlite extension not loading correctly. I'll report back, but it seems like not a problem with the module.
Might be able to do this after #3550326: Fix phpcs issues → is done.
@gooney0: I think it'd be simpler for someone to fix the bug.
A hasty patch just to show what we're thinking of.
I updated the path in the included README.md file and added notes on the project page.
Not sure about this. Adding the composer.libraries.json file won't result in the necessary library being added.
That said, it could be useful as another approach to let people know about the dependencies. It should be updated to also list jsoneditor.
Out of respect for Dave I'm giving him some time to respond, failing that I'll pursue other options.
From AcceptJsPaymentMethodTest::setUp():
'api_login' => getenv('COMMERCE_AUTHNET_TEST_API_LOGIN'),
'transaction_key' => getenv('COMMERCE_AUTHNET_TEST_TRANSACTION_KEY'),
'client_key' => getenv('COMMERCE_AUTHNET_TEST_CLIENT_KEY'),
I emailed Dave, hopefully he'll make the change soon and we can take care of this.
Committed, thanks everyone!
This will be in the 1.1.0 release.
I didn't try it yet, it wasn't clear how I would set it up.
There's another issue where they're working on allowing hook_install() to be used at the same time as a config sync: 🐛 Allow an install hook in profiles installing from configuration Needs work
damienmckenna → changed the visibility of the branch 3536891-commerce3 to hidden.
The module already will work with Commerce v3. If you run into specific problems using it with Commerce v3, please open a new issue.
damienmckenna → made their first commit to this issue’s fork.
Is this why the form validation doesn't seem to work on the phone number field, but does on certain others? I opened this issue on Commerce Shipping: 🐛 auto_recalculate doesn't trigger if phone number changed Active
This may be related to this bug with the Address module: 🐛 Address validation doesn't run for form elements, only entity fields Active
Done: https://www.drupal.org/project/ckeditor_media_resize/releases/1.0.1 →
Additional work will go towards the 1.1.0 release.
I tried this as a post_update script and it doesn't work:
/**
* Set the dependencies on config objects.
*/
function ckeditor_media_resize_post_update_config_dependencies() {
$updater = \Drupal::classResolver(ConfigEntityUpdater::class);
$config_names = [
'image.style.cke_media_resize_large',
'image.style.cke_media_resize_medium',
'image.style.cke_media_resize_small',
'image.style.cke_media_resize_xl',
];
// Fix the configurations if the dependency is not set.
foreach ($config_names as $config_name) {
$config = \Drupal::configFactory()->getEditable($config_name);
if ($config) {
$dependencies = $config->get('dependencies');
if (empty($dependencies['enforced']['module'])) {
$dependencies['enforced']['module'][] = 'ckeditor_media_resize';
$config->save();
}
}
}
}
damienmckenna → made their first commit to this issue’s fork.