@mgifford: That's amazing work, thanks to everyone involved!
Should we list all of the accessibility tasks under one priority category, or list them individually based upon their individual importance?
I think this should go into a minor release, given that it will bump the requirements to 10.3.
Using this module with patch #7, I am noticing on our site, when a user adds a product to their cart, it generates separate status messages for all the products in the cart, including products that were already in the cart and not added in that request, so that the user sees multiple status messages on the screen, only one of which is true/relevant.
It might be worth adding a separate issue about this.
Is this what you were thinking of? I can turn it into a merge request if it's correct.
LGTM - making the form logic generic will only help in the long run.
Did you forget to post code along with this?
damienmckenna → made their first commit to this issue’s fork.
FYI because the module's composer constraints allow individual site maintainers to upgrade their site to a secure version of the dependency (enshrined/svg-sanitize) it fits within the jurisdiction of PSA-2011-002 → so no advisory is needed for this. That said, I've tagged this as a "security improvement" as it is important to encourage site owners to upgrade, and many won't until their modules require it.
Bumping the priority of this as it could lead to problems for the site.
This problem was fixed in 1.0.1.
@fishfree: That would be a feature request as the original intent was to support the form.
Drupal 9 is no longer supported, so this is no longer an issue.
I fixed these in 📌 Fix test failures in 2.1.x Active .
Please see if 🐛 UTF-8 character handling in meta tag tidy() Active helps with this issue.
Thank you for the additional fixes!
Do you have an example of a token that triggers the problem?
The current test failure is that old MetatagViewsTokenTest failure.
FYI there's a related issue where the number of files is different to the number of records: ✨ Provide indication if file count is different to expected Active
damienmckenna → created an issue.
Adding the appropriate tag.
This needs to be turned into a merge request so we can see how the tests are affected.
I wonder if we should move this to the Token module?
This was already done in 📌 Move functions from metatag.tokens.inc to metatag.module Active .
Yay!
The field test failure stems from https://www.drupal.org/node/3386762 → .
How about one of these approaches? (created as patches as it's easier to review them individually before going through the effort to create a MR)
Note: I haven't tested them yet, I need to have a meeting for a bit but will follow up afterwards.
damienmckenna → created an issue.
damienmckenna → made their first commit to this issue’s fork.
Committed.
damienmckenna → created an issue.
Out of interest have you done any debugging to see why $string isn't a string in the first place? We might need to extend the API to force it to be a string.
Committed. Thank you!
This will bump the module to require 10.3 or newer..
damienmckenna → created an issue.
damienmckenna → created an issue.
That should cover it.
damienmckenna → created an issue.
I updated the MR with a minor change from bmelvin1 that has been running on a production site since November '24; the main difference is that it extends FieldTargetBase instead of Number.
I think it might be worthwhile to rename the existing atk_sitemap.spec.js file to atk_xmlsitemap.spec.js, just to separate them.
damienmckenna → made their first commit to this issue’s fork.
I opened 📌 Rename "fallback" recipe attribute to "default_value" Active to fix the naming convention.
damienmckenna → created an issue.
Out of interest why was the attribute name "fallback" used rather than e.g. "default_value" or just "default", a naming convention used in other subsystems?
Ah yes, thank you - 📌 Avoid incorrect and unecessary menu_link_content entity saving Active .
So is the thumbnail fix all that this issue needs to be responsible for?
damienmckenna → created an issue.
The error stems from this core change: 🐛 Disallow saving the current default revision as a non-default revision Active
The error in the output for TokenMenuUiContentModerationTest is:
Drupal\Core\Entity\EntityStorageException: An existing default revision of the 'menu_link_content' entity type can not be changed to a non-default revision. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
The MR fixes the issue with the thumbnail generation, but there are still errors in TokenMenuUiContentModerationTest.
Related: 📌 Fix tests on 8.x-1.x branch Active
MR created.
damienmckenna → created an issue.
A fixed patch, after some local testing.
How about "$fieldname-wordcount"?
The Smart Trim has some token logic that could be repurposed to handle what we need.
It has been a while, should Chris be given comaintainership if he's still interested?
The test are failing for other reasons, see 📌 Fix automated test failures Active .
damienmckenna → created an issue.
The info.yml change doesn't make sense - "search_api" is a module from the "search_api" package, so the definition was already correct.
There's an existing issue for this problem with an RTBC patch: 🐛 The configuration property processor_id doesn't exist Active
Related: 🐛 Views filter schema Active
Related: 🐛 Views filter schema Active
There's an existing issue for this, please help with it: 🐛 Views filter schema Active
There's an existing issue for this: 🐛 Config schema fix Active
damienmckenna → created an issue.
Following on from karens' comment #4 above, we should have some logic to handle scenarios where 'breadcrumb' is output without a "@type" value and add it. I'm just not sure if that should be in the main module or a submodule - could we add some extra validation in SchemaWebPageBreadcrumb to indicate that the "@type" value must be set?
I created the merge request with help from jedihe!
This will need some test coverage to make sure it works as expected and doesn't break in the future.
Going to work on this today.
damienmckenna → created an issue.