NH, USA
Account created on 25 January 2007, almost 19 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue. See original summary .

🇺🇸United States damienmckenna NH, USA

@fjgarlin: Is there a current plan on when you & the team will start migrating projects? Thank you.

🇺🇸United States damienmckenna NH, USA

I used convertmoduleoop, will see how the tests work.

🇺🇸United States damienmckenna NH, USA

Bumping the priority for this as it's currently nearly impossible to index an existing site.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

Thank you for the MR.

The tests appear to be failing badly, it might be worth some manual testing to confirm there aren't unintended problems.

🇺🇸United States damienmckenna NH, USA

Also, I noticed that if I break the command (or the ssh connection breaks and I have to reconnect to the server) and re-run the command it starts over from the start again, rather than continuing from where it was. Is this intended?

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

FYI patch #8 resolves the issue, it might be worth committing it and refactoring in a separate issue.

🇺🇸United States damienmckenna NH, USA

FWIW this is working well for us on a prod site, thank you.

🇺🇸United States damienmckenna NH, USA

FYI I ran into a similar problem and realized that ProcessedText::preRenderText() was doing a whole load of work if the string was blank, which seemed unnecessary: Return early in preRenderText() if text is blank Active

🇺🇸United States damienmckenna NH, USA

The MR simply returns early if the string is empty.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

My suggestion is that for now release this as-is with the test line commented out and then work on the one failing test separately, just to be able to move on.

🇺🇸United States damienmckenna NH, USA

The test that fails was last edited in #3255904: Remove the WebformAssertLegacyTrait , but it actually comes from #3094270: Add support for webform variants .

🇺🇸United States damienmckenna NH, USA

WebformVariantOverrideTest passes locally but fails on gitlabci. Hrm..

🇺🇸United States damienmckenna NH, USA

Ok, I see that now.

Is there normally such a variation in how long the tests take to run? When I added the _PHPUNIT_CONCURRENT line initially the tests ran in <20 minutes, now it's hitting twice that and timing out.

🇺🇸United States damienmckenna NH, USA

The dependency issue showed up when I ran all of the tests locally, maybe it was a dependency of another dependency so it was my fault it failed locally.

The fact that it's failing at 189 tests and not finishing them all suggests it's not running the tests concurrently per the _PHPUNIT_CONCURRENT setting - does the issue fork need to be updated?

🇺🇸United States damienmckenna NH, USA

I added a missing test dependency and changed the tests to run concurrently, that allowed them to finish in ~18 minutes instead of timing out after ~30 minutes. The tests are now green.

🇺🇸United States damienmckenna NH, USA

This is related to a security issue, so adding the "Security improvements" tag for visibility.

🇺🇸United States damienmckenna NH, USA

damienmckenna made their first commit to this issue’s fork.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

Given that in gitlab the README.md file will become the project page's description, the README.md needs to be updated too.

🇺🇸United States damienmckenna NH, USA

You never know.

On my site I was actually having problems getting v2 to run on a site with 11.1, but solved it by hardcoding composer.json to require 2.0.1. For now.

🇺🇸United States damienmckenna NH, USA

That's fair. And thanks for the article.

🇺🇸United States damienmckenna NH, USA

The MR moves entity_reference_revisions_field_views_data().

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

FWIW the media item that fails was listed as a dependency on a node.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

While the deprecation isn't necessary until 12.0, this is compatible with older versions, so there's no harm in committing this change.

🇺🇸United States damienmckenna NH, USA

The MR moves message_views_data_alter().

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

The MR moves redirect_404_views_data().

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

The MR moves all views hooks to the corresponding module file.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

I did some digging and the files did import correctly, so it seems to be just the media.

🇺🇸United States damienmckenna NH, USA

This is what the media item looks like:

_meta:
  version: '1.0'
  entity_type: media
  uuid: 3684febe-bcda-476e-a760-d299732d4c46
  bundle: image
  default_langcode: en
  depends:
    bd257a36-061d-451a-8369-1a48bcf2fe5b: file
default:
  status:
    -
      value: true
  uid:
    -
      target_id: 1
  name:
    -
      value: video.png
  created:
    -
      value: 1524570214
  revision_translation_affected:
    -
      value: true
  path:
    -
      alias: ''
      langcode: en
      pathauto: 1
  field_media_image:
    -
      entity: bd257a36-061d-451a-8369-1a48bcf2fe5b
      alt: ''
      title: ''
      width: 100
      height: 75

This is what the file object looks like:

_meta:
  version: '1.0'
  entity_type: file
  uuid: bd257a36-061d-451a-8369-1a48bcf2fe5b
  default_langcode: en
default:
  uid:
    -
      target_id: 1
  filename:
    -
      value: video.png
  uri:
    -
      value: 'public://media-icons/generic/video.png'
  filemime:
    -
      value: image/png
  filesize:
    -
      value: 16552
  status:
    -
      value: true
  created:
    -
      value: 1524570214
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

Please open a new issue and we'll work on this.

🇺🇸United States damienmckenna NH, USA

datetime_range, not daterange.

🇺🇸United States damienmckenna NH, USA

Fixed the info file's duplicate 'use' statement.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

FYI this left us in a situation where the [node:summary] token no longer outputs anything, so I opened a new issue to discuss it: 📌 node:summary token relies on non-default field in 11.3+ Active

🇺🇸United States damienmckenna NH, USA

Postponing this as we need a way forward, beyond just removing the token: 📌 node:summary token relies on non-default field in 11.3+ Active

🇺🇸United States damienmckenna NH, USA

Postponing this as we need a way forward, beyond just removing the token: 📌 node:summary token relies on non-default field in 11.3+ Active

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

Replacing [node:summary] with [node:body] is incorrect for two reasons:
* For sites with a "body" field we won't want to output the entire thing.
* The automatic creation of the body field was removed in 11.3 per 📌 Stop automatic storage creation of body field Active .

Postponing this until core updates.

🇺🇸United States damienmckenna NH, USA

The automatic creation of the body field was removed in 📌 Stop automatic storage creation of body field Active .

Also related: 🌱 [Meta] Deprecate text_with_summary Active

🇺🇸United States damienmckenna NH, USA

Honestly, sites should switch to Symfony Mailer as it's being merged (slowly) into core.

🇺🇸United States damienmckenna NH, USA

Please migrate the issues for the Contrib Half Hour project , thank you.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA
🇺🇸United States damienmckenna NH, USA

Thank you for spotting that. Let's close this one.

🇺🇸United States damienmckenna NH, USA

Should this be closed as there are several stable releases available?

🇺🇸United States damienmckenna NH, USA

This is how I've used it on a few projects.

🇺🇸United States damienmckenna NH, USA

Thank you for providing this patch.

The Drupal 7 version of this module is no longer supported.

🇺🇸United States damienmckenna NH, USA

I think the original request here was for a Views field.

I did not realize BookManager::getBookParents existed, so that's probably a good starting point.

The getBookImmediateParent() method is good, thank you, but it could probably be renamed to just getParent().

🇺🇸United States damienmckenna NH, USA

Ran into this myself.

WIP code:

services:
  mymodule.address_subscriber:
    class: Drupal\mymodule\EventSubscriber\AddressSubscriber
    tags:
      - { name: event_subscriber }

namespace Drupal\mymodule\EventSubscriber;

use Drupal\address\Event\AddressFormatEvent;
use Drupal\address\Event\AddressEvent;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Logic for interacting with the address system..
 */
class AddressSubscriber implements EventSubscriberInterface {

  /**
   * {@inheritdoc}
   */
  public static function getSubscribedEvents() {
    $events = [
      AddressEvents::ADDRESS_FORMAT => 'formatAddress',
    ];
    return $events;
  }

  /**
   * Move the organization to after the name fields.
   *
   * @param \Drupal\address\Event\AddressFormatEvent $event
   *   The address format event.
   */
  public function formatAddress(AddressFormatEvent $event) {
    $definition = $event->getDefinition();

    $replacements = [
      '%organization\n%givenName %familyName\n' => '%givenName %familyName\n%organization\n',
      '%organization\n%familyName %givenName %additionalName\n' => '%familyName %givenName %additionalName\n%organization\n',
    ];

    foreach ($replacements as $from => $to) {
      if (strpos($definition['format'], $from) != FALSE) {
        $event->setDefinition(str_replace($definition['format'], $to));
        break;
      }
    }
  }

}

When I go through the checkout process this loads the first time the address is shown on the checkout process. However, if I use the selector to change the address to a different country the event isn't called. Shouldn't it be called for every address format? Did I do something wrong with my code or is there a bug in the module?

🇺🇸United States damienmckenna NH, USA

Originally written by bmelvin1, with a minor change by me.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

For some reason it failed creating the issue fork - it doesn't seem to be possible to access it?

🇺🇸United States damienmckenna NH, USA

Code written by an ex employee of Berklee (who doesn't seem to have a d.o account), with some formatting & comment improvements by me.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

This patch was written by bmelvin1 and another developer at Berklee, and rerolled & improved by me.

🇺🇸United States damienmckenna NH, USA

damienmckenna created an issue.

🇺🇸United States damienmckenna NH, USA

Let's add some test coverage.

🇺🇸United States damienmckenna NH, USA

I created a MR with the new PW test file.

Production build 0.71.5 2024