- Issue created by @heddn
- Status changed to Needs review
almost 2 years ago 2:48pm 12 September 2023 - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - First commit to issue fork.
- π§πͺBelgium herved
I'm expanding the scope to all views plugins if you agree.
Opened MR and here is a static patch for composer.PS: looks like the pipeline is broken on 3.0.x branch :\
- π§πͺBelgium borisson_ Mechelen, π§πͺ
I'm not sure we want to add a config schema for views plugins at this time, core views are not yet validated either yet.
- heddn Nicaragua
core views are not yet validated either
This doesn't feel true. The whole reason I opened this issue in the first place is due to test coverage failing validation.
- π§πͺBelgium herved
I work on 3 drupal sites running core 10.3, all passing config_inspector check, this is one of the remaining issues.
Drupal core is fully compliant AFAIK, and phpunit is configured to fail if such issues are found (in \Drupal\Core\Config\Development\ConfigSchemaChecker). - Status changed to Needs work
5 months ago 9:44am 28 January 2025 - π§πͺBelgium herved
This no longer applies to 3.x
It looks like the facets_area views plugin was removed in 3.0.0-beta2, commit: https://git.drupalcode.org/project/facets/-/commit/c2f70843a5764450659bb...
And there were many other changes, moving back to needs work - π§πͺBelgium herved
MR rebased, static patch attached:
- Deletedviews.area.facets_area
-views.area.facets_summary_area
andviews.filter.facets_summary_filter
should be now in facets_summaryNote that
views.filter.facets_filter
should now in theory be in facets_exposed_filters but is in facets.
I left it as-is for now. - Status changed to Needs review
3 days ago 8:46pm 3 July 2025 - πΊπΈUnited States damienmckenna NH, USA
FYI it might be worth adding test coverage for the facets_demo module as a base to work from for this.
- πΊπΈUnited States damienmckenna NH, USA
WIP test coverage for the facets_demo module.
- πΊπΈUnited States damienmckenna NH, USA
Should the views schema definition go in the facets_exposed_filters module?
- π³π±Netherlands mike.vindicate
borisson_ β credited michael.acampora β .
- π§πͺBelgium borisson_ Mechelen, π§πͺ
@michael.acampora worked in the related issue on similar things, that issue is now closed as duplicate so crediting here.