Views filter schema

Created on 12 September 2023, over 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @heddn
  • Status changed to Needs review over 1 year ago
  • Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Waiting for branch to pass
  • First commit to issue fork.
  • Pipeline finished with Failed
    7 months ago
    Total: 651s
    #286655
  • 🇧🇪Belgium herved

    I'm expanding the scope to all views plugins if you agree.
    Opened MR and here is a static patch for composer.

    PS: looks like the pipeline is broken on 3.0.x branch :\

  • 🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    I'm not sure we want to add a config schema for views plugins at this time, core views are not yet validated either yet.

  • heddn Nicaragua

    core views are not yet validated either

    This doesn't feel true. The whole reason I opened this issue in the first place is due to test coverage failing validation.

  • 🇧🇪Belgium herved

    I work on 3 drupal sites running core 10.3, all passing config_inspector check, this is one of the remaining issues.
    Drupal core is fully compliant AFAIK, and phpunit is configured to fail if such issues are found (in \Drupal\Core\Config\Development\ConfigSchemaChecker).

  • Status changed to Needs work 2 months ago
  • 🇧🇪Belgium herved

    This no longer applies to 3.x

    It looks like the facets_area views plugin was removed in 3.0.0-beta2, commit: https://git.drupalcode.org/project/facets/-/commit/c2f70843a5764450659bb...
    And there were many other changes, moving back to needs work

  • 🇧🇪Belgium herved

    MR rebased, static patch attached:
    - Deleted views.area.facets_area
    - views.area.facets_summary_area and views.filter.facets_summary_filter should be now in facets_summary

    Note that views.filter.facets_filter should now in theory be in facets_exposed_filters but is in facets.
    I left it as-is for now.

  • Pipeline finished with Success
    2 months ago
    Total: 992s
    #412066
Production build 0.71.5 2024