@heddn

heddn → made their first commit to this issue’s fork.

https://www.drupal.org/project/migrate_plus/releases/6.0.4 → does include the BC fix now too.

Test coverage added.

Essentially the same tests before/after. #4 makes sense. LGTM.

heddn → made their first commit to this issue’s fork.

Thanks for your contributions.

heddn → made their first commit to this issue’s fork.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

Let's face it, field collection support probably won't happen.

Tests are failing on errors around EntityReferenceTestTrait. We also might want to just set the minimum Drupal core version to 10.1 and remove some of the BC logic in the latest MR. That said, I'll let another maintainer comment about jumping the minimum supported version.

This should have a rebase now that Gitlab CI testing is enabled.

Drupal 9 is no longer supported.

Drupal 10 support was added to the module.

Drupal 9 support was added to the module.

heddn → made their first commit to this issue’s fork.

While ddev/docker does indeed support env variables natively, other hosting providers like Pantheon and the wild-west of bare metal and shared hosting do not have solutions in this space. Providing a core-supported option here might be the impetus for folks like Pantheon to switch from proprietary secrets text files to env variables.

I could easily see us taking the base added here and doing a lot of special things in follow-ups. Like injecting the DB credentials for the primary/default DB automatically. Or providing an env variable override process for settings and config. But the base logic/support would be needed first.

I think the error you are facing is more closely related to 🐛 access() on null when permission is not properly configured. Needs work .

Opened 📌 Fix eslint errors Needs review as a hopefully much easier to review follow-up.

heddn → created an issue.

Thanks for all your contributions here. It made it really easy to commit things at the end.

I felt the JS changes are too risky in this "enable gitlab ci" issue. We can resurrect them in a follow-up clean-up task. JS style linting fix stuffs do not break the build in gitlab, they are just thrown as warnings. Better to solve in a dedicated issue.

heddn → made their first commit to this issue’s fork.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

heddn → created an issue.

heddn → created an issue.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

Not sure what extra testing we want to do here. I tested this coming from 🐛 Error when removing a menu Needs work and it solved the problem perfectly.

I am using this patch on the 1.x branch, not 2.x. It is only assigned to 2.x because typically develop happens on the latest branch and is backported to earlier. If that isn't the case here, we can easily just move it to 1.x, commit things and leave 2.x for a later point.

The accessibility here is improved with the new patch. Some of links in #17 are a bit confusing, but I think the question is if we are following https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/al.... Do we need to combine the 2 issues together? The patch in ✨ Accessiblity - Remove aria and alertdialog from module Active only removes a bunch of hunks, it doesn't really add any hunks.

I do know that the complaints by Lighthouse tests are much improved after applying the latest patch here.

Tests are passing green on D11. Nothing is showing up in phpstan that raises red flags. Waiting (a while) to hear from some live testers. but this is looking pretty good.

This takes a slightly different approach. But same result.

See https://git.drupalcode.org/project/smart_ip/-/jobs/2176448

heddn → created an issue.

I think this should be marked as done.

We're moving along to Drupal 11 at this point. I don't think this issue is needed any longer.

heddn → made their first commit to this issue’s fork.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

heddn → created an issue.

Nice enhancements!

NW for some minor feedback.

This is blocked on duration_field having a stable release.

This seems blocked on IEF providing a D11 release.

heddn → made their first commit to this issue’s fork.

Thanks for your contributions.

heddn → made their first commit to this issue’s fork.

Thanks for your contributions.

We're seeing test failures again.

MR needs some fixes. It has a .orig file as part of it. Plus it could use a rebase.

Thanks for your contributions.

Thanks for your contributions.

heddn → made their first commit to this issue’s fork.

Thanks for the contributions.

Thank you everyone for sticking with this issue.

This is likely one of the longest running requests in the migrate plus queue. Let's land it and make incremental improvements on what we have here.

Thanks for your contributions!

heddn → made their first commit to this issue’s fork.

Thanks for your contributions.

heddn → made their first commit to this issue’s fork.

this module only has an optional dependency on migrate plus. If another module depends on the migrate plus config entities, then it should list migrate plus as a dependency. this module won't have a hard dependency on plus though.

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

https://git.drupalcode.org/issue/migrate_drupal_d8-3462203/-/jobs/2152485 is green.

heddn → created an issue.

heddn → made their first commit to this issue’s fork.

heddn → made their first commit to this issue’s fork.