re #35: A small side note, stating that tests found regressions is kinda of saying that the tests are doing their job. No one likes random failures but if a test finds issues, it isn't necessarily the tests fault. I sense some resistance to the performance testing addition. We should be embracing these things.
Posted an question, but otherwise, I think this is pretty close.
phenaproxima → credited heddn → .
Thanks for your work here.
Thanks for the reroll.
I did some more git research. That class was introduced in https://git.drupalcode.org/project/group_content_menu/-/commit/1fe9ade51... on the 8.x-1.x branch but not included in a tag. Later it was removed in https://git.drupalcode.org/project/group_content_menu/-/commit/89e2ce193... before 3.0.0 was released.
Can we test if a cache clear before running updates resolves the issue or not? Something is caching that the storage handler needs to exist. But I'm not sure the easiest way to introduce that cache clear.
Oops. Posted now.
Posted feedback on MR.
Seems like a relatively helpful change.
Let's keep those issues separate for the time being.
Posted feedback on the MR.
The items being migrated are reasonable and checks just another box on the upgrade from D7. I made some very minor phpcs and test fixes. So let's just RTBC this thing.
https://www.drupal.org/project/webform_group → is a thing.
Can we add tests?
This has tests and multiple folks have manually tested this. LGTM.
Let's combine all this work into one JS code standards task 🐛 Fix stylelint warnings Needs work .
This module supports D11, but in the 2.x branch.
Needs work because needs a rebase.
+1 on #17/18.
Can we convert this to an MR at this point?
This module support Drupal 10. I think this issue got left open in the shuffle.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it needs a reroll/rebase. Additionally, we'll need some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it could need a reroll/rebase. Additionally, we'll need an MR opened and some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it could need a reroll/rebase. Additionally, we'll need an MR opened and some tests.
This module now supports 10.2 and the linked MR needs a rebase (probably because the problem is already fixed). If this is still an issue, feel free to re-open and rebase.
This needs a rebase and the base of the MR needs to change to 2.x. See review https://git.drupalcode.org/project/diff#contribution-guidelines.
I posted on the MR, but I don't think this change is strictly needed. Config queries always operate with no security. If my understanding here is in error, feel to re-open with an explanation.
heddn → made their first commit to this issue’s fork.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it might need a reroll/rebase. Additionally, we'll need an MR opened and some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Specifically we'll want to see some tests.
heddn → made their first commit to this issue’s fork.
Can we post some screenshots of the before/after?
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Specifically, we'll need some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is a decidedly old contribution, it likely needs a reroll/rebase. Additionally, we'll need some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is a decidedly old contribution, it likely needs a reroll/rebase. Additionally, we'll need an MR opened.
heddn → made their first commit to this issue’s fork.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is a decidedly old contribution, it likely needs a reroll/rebase. Additionally, we'll need an MR opened and some tests.
This is decidedly out of date. Let's just close it.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is a decidely old contribution, it might be good to confirm it is still an issue. Additinally, we'll need an MR opened and some tests.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Specifically, we'll need an MR opened and some tests.
Also, please review https://git.drupalcode.org/project/diff#contribution-guidelines.
For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Specifically, we'll need an MR opened and some tests.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.
Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5 → . If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.