@heddn

There were a couple issues. All are resolved now and fixed over in 🐛 Fix failing PHPunit tests Active .

Another slack thread: https://drupal.slack.com/archives/C1BMUQ9U6/p1752176458373939

TLDR; this one says that for the hook classes that were added to 11.1, the hook order classes didn't make it into the latest security release. that leads to a problem if you need to use them.

+1 from me.

In the mean time, the final point of issue queue triage can already start. It would help give this offering more credibility.

+1 on the concept.

@sidgrafix can you confirm if the attached fix resolves the issue w/ 1.4?

heddn → made their first commit to this issue’s fork.

heddn → created an issue.

This module does support multilingual. See tests that exercise this feature set: https://git.drupalcode.org/project/group_context_path_prefix/-/blob/1.0....

I install lb_plus → and install it in a default manner. Then attempt to place a block. Because there is no default value, it results in an InvalidArgumentException with the form.

heddn → made their first commit to this issue’s fork.

There's a lot of mocking going on. Wouldn't a kernel or functional test be an easier solution here?

This could use a screenshot of what this looks like.

Thanks for the fixes.

heddn → made their first commit to this issue’s fork.

Thanks for the fixes here. Updating the issue title and description helped a lot.

Thanks everyone for their contributions on this issue.

Can you provide steps to reproduce?

Merged/fixed. Thanks for the fixes here. Also good to know that temp filesystem being backed by system tmp folder is a good thing.

Thanks for adding test coverage and the fixes here.

Hmm, but TranslationManager actually is a combination of both TranslationInterface and TranslatorInterface. How should this be handled?

I was able to use the inspiration from ✨ Support Migrate Tools' "includes" in migrations Active after all. Granting credit. Thanks for finding this bug quickly. A new release coming shortly.

I misread the issue title. But path_redirect_import will need to update its constructor to support this module's changes.

heddn → created an issue.

Needs a rebase

It seems to be happening because the group content menu entity has its own pre-delete. By the time the entity gets to _menu_link_content_'s predelete, things are already all cleaned up. My guess is we need to implement our own predelete hook and remove _menu_link_content_. And call its if the entity is not a gcm.

This is the primary failure in 🐛 Fix failing PHPunit tests Active .

heddn → made their first commit to this issue’s fork.

Thanks for these fixes.

heddn → made their first commit to this issue’s fork.

Thanks for adding tests here.

Can we add tests for this?

I think this got resolved in 📌 Fix remaining code quality findings Active .

This module doesn't support that old version of drush any longer.

Thanks for the contributions.

Can someone report if the last little changes still keep things happy and working?

heddn → made their first commit to this issue’s fork.

This is a duplicate of 🐛 hook_config_schema_info_alter injected optional migrate_plus config schema Active .

I didn't notice this was opened until just now. But 📌 Fix remaining code quality findings Active is getting pretty close. I'll likely close this as duplicate.

heddn → created an issue.

Let's reduce the scope here to _only_ phpcs. We can pick up other code quality stuffs in a follow-up. Otherwise it gets too complicated to review.

This causes tests to fail.

Thanks for the fix here.

Thanks for the contribution here.

heddn → made their first commit to this issue’s fork.

Could we add test coverage?

Let's include test coverage for new features. And add some docs for how to use this configuration parameter.

heddn → made their first commit to this issue’s fork.

Thanks for writing tests in this space.

This needs a rebase.

Thanks for the fix.

heddn → made their first commit to this issue’s fork.

Thanks for the candid feedback and collaboration on this ticket.

Thanks for the fix here.

Reverted the commit as it broke tests. More work needed.

heddn → made their first commit to this issue’s fork.

I'm going to merge this anyway. We can always revert it pretty easily if it causes issues. And performance fixes are a thing too.

+++ b/migrate_plus.module
@@ -78,6 +79,11 @@ function migrate_plus_migration_plugins_alter(array &$migrations): void {
+    if ($source_urls && $migrations[$id]['source']['plugin'] === 'url') {

We should check on the class level. If someone does a custom url class that extends migrate_plus, this wouldn't catch it. But if this did a class instanceof check, then we'd be fine.

Thanks for you thoughtful bug report and fix.

heddn → made their first commit to this issue’s fork.

Thanks for the improved docs.

heddn → made their first commit to this issue’s fork.

Thanks for your contributions.

Some comments posted below on the code. As far as tests, we are constantly attempting to increase test coverage. Functional tests can mock guzzle responses or work with real test endpoints. Meaning, you could create a test controller/form in a test module that returns all the expected outputs.

1. +++ b/src/Plugin/migrate_plus/authentication/Cookie.php
   @@ -0,0 +1,106 @@
   + * Provides cookie authentication for the HTTP resource to another Drupal 8 site.
   

   Let's not put versions in comments. Makes maintenance easier if we don't have to keep abreast of versions in the code.

2. +++ b/src/Plugin/migrate_plus/authentication/Cookie.php
   @@ -0,0 +1,106 @@
   +      'base_url' => $this->configuration['domain'],
   

   if we make this a "url" config option, then we can divine the domain name from it.

3. +++ b/src/Plugin/migrate_plus/authentication/Cookie.php
   @@ -0,0 +1,106 @@
   +    $loginClient->post($this->configuration['domain'] . '/user/login', [
   

   can we make this more drupal agnostic and have the url be to the login URL?

4. +++ b/src/Plugin/migrate_plus/authentication/Cookie.php
   @@ -0,0 +1,106 @@
   +    if ($this->configuration['rest']) {
   

   this is very tied to drupal paths. more generic is better as it become more usable across different scenarios.

Very reasonable fix and a good find. Thanks for your contributions.

Thanks everyone for your contributions on this issue.

Thanks for your contributions.

heddn → made their first commit to this issue’s fork.

I'm not sure what is the cause of this. If there are specific steps to reproduce, please re-open.

Updating credit

Can we add tests that show this broken and it fixed?

Thanks for this addition.

This can be marked as duplicate to ✨ Shared configuration not available when using migrate plus config entities Fixed .

I don't think we can improve since the value is optional.

After reviewing https://www.drupal.org/project/migrate_plus/issues/3502423 ✨ Support Migrate Tools' "includes" in migrations Active , I think we can do better.

Should we change these topics to migrate_tools instead?

Hopefully I caught everyone who contributed to this issue. Thanks for all your work on it.

Thanks for the contribution here.

heddn → made their first commit to this issue’s fork.

This could use a rebase.

Could we add a test for this?

Drush 9 is no longer supported. I think we can mark this as outdated.