- Issue created by @herved
- π§πͺBelgium herved
There is another issue, several processor schemas are not defined/missing after π Config schema fix Active :
- hide_active_items_processor
- hide_1_result_facet
- list_item
- show_only_deepest_level_items_processor
- translate_entity_aggregated_fields
- uid_to_username_callbackShould we extend the scope here?
- πΊπΈUnited States damienmckenna NH, USA
The demo module requires views_ajax_history β but it's not listed in composer.json so the tests fail.
- πΊπΈUnited States damienmckenna NH, USA
It then failed because views_filters_summary was required.
There are still some actual test failures:
Drupal\Tests\facets\Unit\FacetSource\FacetSourcePluginManagerTest:
Facet Source Plugin Manager (Drupal\Tests\facets\Unit\FacetSource\FacetSourcePluginManager) β Construct β Get definitions β Invalid definitions with onlyΒ·id β β Error: Unknown named parameter $id β΄ β Invalid definitions with onlyΒ·display_id β β Error: Unknown named parameter $display_id β΄ β Invalid definitions with onlyΒ·label β β Error: Unknown named parameter $label β΄ β Invalid definitions with noΒ·label β β Error: Unknown named parameter $id
Drupal\Tests\facets\Kernel\FacetManager\DefaultFacetManagerTest:
Default Facet Manager (Drupal\Tests\facets\Kernel\FacetManager\DefaultFacetManager) β Get enabled facets β Get facets by facet source id β Alter query cacheability metadata β Build cacheability metadata with 0 β β Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema β β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 β /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215 β΄ β Build cacheability metadata with 1 β β Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema β β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 β /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215 β΄ β Build cacheability metadata with 2 β β Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for facets.facet.mars with the following errors: facets.facet.mars:processor_configs.fpc_build_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_post_query_processor.settings missing schema, facets.facet.mars:processor_configs.fpc_sort_processor.settings missing schema β β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:206 β /builds/issue/facets-3544226/vendor/symfony/event-dispatcher/EventDispatcher.php:56 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Config.php:232 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:487 β /builds/issue/facets-3544226/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239 β /builds/issue/facets-3544226/tests/src/Kernel/FacetManager/DefaultFacetManagerTest.php:215 β΄
- π§πͺBelgium herved
I didn't dig much further tbh because if I'm not mistaken the report is the same as 3.0.x https://git.drupalcode.org/project/facets/-/pipelines/582244
So this is probably out of scope here and deserves its own issue?
Thanks for looking into it. - πΊπΈUnited States damienmckenna NH, USA
The issues in DefaultFacetManagerTest appear to be more missing schema, this time in the facets_processors_collection test module, so is relevant for this issue; I don't know about the other one, I haven't dug into it yet.