πŸ‡³πŸ‡±Netherlands @mike.vindicate

Account created on 30 October 2009, over 14 years ago
  • Webdeveloper at iOΒ  …
#

Recent comments

πŸ‡³πŸ‡±Netherlands mike.vindicate

Attached a patch that can be used for Drupal 10.2. Thanks for fixing the issue.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Forgot to add the services part in #9, re-added in this patch.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Attached patch fixes a deprecation for php 8.2 that came in with the last patch, it's a small fix and thanks for the patch in #7 @bburg.

Deprecated function: Creation of dynamic property Drupal\domain_language\DomainLanguageOverrider::$currrentUser is deprecated in Drupal\domain_language\DomainLanguageOverrider->initiateContext()

πŸ‡³πŸ‡±Netherlands mike.vindicate

Added patch that fixes the warning and allows to edit, when updating from version 3.0.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Added patch that applies to version 3.1.0 which has support for CKEditor 4 and 5. We probably want to start a whole new version (4) of this module where support is dropped for CKEditor 4. Tweaked some minor things to the requirement, so that it only checks if CKEditor contrib is installed.

Since changes are made to the info.yml file, you can use this package: https://packagist.org/packages/orakili/composer-drupal-info-file-patch-h.... Then you should be able to install the patch.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Added patch derived from the MR.

πŸ‡³πŸ‡±Netherlands mike.vindicate

The patch works as expected, but this will break some Drupal 9 installations prior to 9.2 and Drupal 8. Both of these versions are unsupported, but the info file should reflect this as well.
See: https://www.drupal.org/node/3158256 β†’

πŸ‡³πŸ‡±Netherlands mike.vindicate

Can confirm the patch from @linhnm fixes the problem with duplicate crumbs and the patch applies cleanly. Thanks @linhnm for providing it.

πŸ‡³πŸ‡±Netherlands mike.vindicate

This works with version 1.5, but version 1.5 won't install via composer since it relies on jquery_ui_accordion:^1.1. The dependency in composer.json should be updated to ^2.0.
https://git.drupalcode.org/issue/paragraphs_jquery_ui_accordion-3288992/...

πŸ‡³πŸ‡±Netherlands mike.vindicate

Attached patch that implements solution to skip simple pass reset when guardian is used for guarded accounts.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Merge request functionally works as intended, there is only only issue with the "FootnotesFilterPluginTest". In D10 "classy" is deprecated so changed it to "stark". See the attached patched, which is derived from the MR.

πŸ‡³πŸ‡±Netherlands mike.vindicate

Can confirm that the fork fixes the issue's. Also checked if Classy is needed, but can't find anything and looks good in Claro.

The only caveat maybe is that D8 support is completely dropped, but that's EOL anyway. If it's still needs to be supported this could be 2.0 version.

πŸ‡³πŸ‡±Netherlands mike.vindicate

The patch provided by the update bot is enough to make the module compatible with D10.

πŸ‡³πŸ‡±Netherlands mike.vindicate

The module with the patch works as intended. It's nice to have the option to update to Drupal 10 and keep using CKeditor 4 version until it's ready for CKeditor 5.

Production build 0.69.0 2024