Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 15 June 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @jrglasgow opened merge request.
  • Comment almost 2 years ago →
    🇺🇸United States justcaldwell Austin, Texas

    I was able to successfully install and manually test the module using the issue fork. All filtering worked as expected. No errors.

    Screenshot of filter_perms running on D10 → .

    However, I noticed that the composer.json lists classy as a dependency. Doesn't seem necessary, and since Classy has been removed in Drupal 10 → , I suspect installing filter_perms with Composer will either 1) fail or 2) unnecessarily install the contrib version of Classy → .

    I'm off to test that next.

  • Comment almost 2 years ago →
    🇺🇸United States justcaldwell Austin, Texas

    Installing via Composer succeeds, but the classy dependency in composer.json causes Composer to install the contrib versions of both Classy → and Stable → (since Classy depends on it).

    composer require 'drupal/filter_perms:dev-3297235-automated-drupal-10'
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 0 updates, 0 removals
  - Locking drupal/classy (1.0.2)
  - Locking drupal/filter_perms (dev-3297235-automated-drupal-10 ce43b81)
  - Locking drupal/stable (2.0.0)

    The classy dependency should be removed from composer.json, though there's no real need for a composer.json file in this project at all.

  • Comment almost 2 years ago →
    🇺🇸United States justcaldwell Austin, Texas

    Okay, with class removed, filter_perms installs via Composer as expected:

    Lock file operations: 1 install, 0 updates, 0 removals
  - Locking drupal/filter_perms (dev-3297235-automated-drupal-10 afa70db)

    This should be good to RTBC with another set of eyes.

  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇳🇱Netherlands mike.vindicate

    Can confirm that the fork fixes the issue's. Also checked if Classy is needed, but can't find anything and looks good in Claro.

    The only caveat maybe is that D8 support is completely dropped, but that's EOL anyway. If it's still needs to be supported this could be 2.0 version.

  • Comment over 1 year ago →
    🇺🇸United States justcaldwell Austin, Texas

    Thanks for the review/RTBC @mike.vindicate!

    I think I'll merge and release this as 8.x-1.x-alpha2. Folks can still use alpha1 if they're stuck on Drupal 8 for some reason.

  • Comment over 1 year ago →
    System Message
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States justcaldwell Austin, Texas
  • Comment over 1 year ago →
    🇺🇸United States justcaldwell Austin, Texas

    Adjusting credit.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024