- First commit to issue fork.
- @jrglasgow opened merge request.
- 🇺🇸United States justcaldwell Austin, Texas
I was able to successfully install and manually test the module using the issue fork. All filtering worked as expected. No errors.
Screenshot of filter_perms running on D10 → .
However, I noticed that the composer.json lists classy as a dependency. Doesn't seem necessary, and since Classy has been removed in Drupal 10 → , I suspect installing filter_perms with Composer will either 1) fail or 2) unnecessarily install the contrib version of Classy → .
I'm off to test that next.
- 🇺🇸United States justcaldwell Austin, Texas
Installing via Composer succeeds, but the classy dependency in composer.json causes Composer to install the contrib versions of both Classy → and Stable → (since Classy depends on it).
composer require 'drupal/filter_perms:dev-3297235-automated-drupal-10' Loading composer repositories with package information Updating dependencies Lock file operations: 3 installs, 0 updates, 0 removals - Locking drupal/classy (1.0.2) - Locking drupal/filter_perms (dev-3297235-automated-drupal-10 ce43b81) - Locking drupal/stable (2.0.0)
The classy dependency should be removed from composer.json, though there's no real need for a composer.json file in this project at all.
- 🇺🇸United States justcaldwell Austin, Texas
Okay, with class removed, filter_perms installs via Composer as expected:
Lock file operations: 1 install, 0 updates, 0 removals - Locking drupal/filter_perms (dev-3297235-automated-drupal-10 afa70db)
This should be good to RTBC with another set of eyes.
- Status changed to RTBC
almost 2 years ago 1:13pm 8 March 2023 - 🇳🇱Netherlands mike.vindicate
Can confirm that the fork fixes the issue's. Also checked if Classy is needed, but can't find anything and looks good in Claro.
The only caveat maybe is that D8 support is completely dropped, but that's EOL anyway. If it's still needs to be supported this could be 2.0 version.
- 🇺🇸United States justcaldwell Austin, Texas
Thanks for the review/RTBC @mike.vindicate!
I think I'll merge and release this as 8.x-1.x-alpha2. Folks can still use alpha1 if they're stuck on Drupal 8 for some reason.
-
justcaldwell →
committed ddd03d3a on 8.x-1.x authored by
jrglasgow →
Issue #3297235 by Project Update Bot: Automated Drupal 10 compatibility...
-
justcaldwell →
committed ddd03d3a on 8.x-1.x authored by
jrglasgow →
- Status changed to Fixed
over 1 year ago 11:30pm 15 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.