- 🇯🇴Jordan Anas_maw
You are missing templates/facets-item-list.html.twig changes
Here is a new patch that solves the issue - 🇯🇴Jordan Anas_maw
Please ignore my previous patch, here is the right one
- last update
over 1 year ago 424 pass, 2 fail - @codebymikey opened merge request.
- First commit to issue fork.
- last update
over 1 year ago 415 pass, 4 fail - last update
over 1 year ago 413 pass, 4 fail - @codebymikey opened merge request.
- last update
over 1 year ago 413 pass, 4 fail Rerolled the patch to support D10 as well as ensure that the tests pass.
- last update
over 1 year ago 421 pass, 2 fail - last update
over 1 year ago 421 pass, 2 fail - last update
over 1 year ago 432 pass - last update
over 1 year ago 432 pass Upload latest patch with all the tests passing. Patch #75 had a bug where it was making use of the jQuery
:checkbox
pseudo-selector.- 🇬🇧United Kingdom rossb89 Bristol
This is great! I realised that javascript was being used to render this facet style ... which was no good for us on this project which is making heavy use of tailwind and associated templates.
The patch applies cleanly and appears to do what it say on the tin, so far so good.
- 🇧🇪Belgium matthiasm11
Using patch #76 to have the select element instead of generating it through javascript. Works fantastic and is so much cleaner!
It is also compatible with the Chosen module (tested with 4.x), out of the box.One remark though: it is not compatible with selecting multiple values, so in the facet config
Ensure that only one result can be displayed
should be set to TRUE to avoid unexpected results. Not sure how to fix this, since the page already reloads when selecting the first item, so you have no time to select the second item. (unless you do this after the page reload) Maybe we should only reload if the select element becomes unfocused AND changed AND isMultiple? - 🇳🇿New Zealand jonathan_hunt
The patch applies for me ok on Facets 2.0.7. This patch is very useful as I have several sites where bots are aggressively indexing all search facet links. I hope that changing the facets to genuine form checkboxes will reduce the bot impacts.
- 🇳🇿New Zealand jonathan_hunt
fwiw, this change has stopped the bots smashing our facet links. It would be great if this patch could be committed.
Id like to echo #81. This patch really helps with bots hitting our site as well. Can this be merged?
- Status changed to Needs work
4 months ago 9:49pm 28 August 2024 - 🇧🇪Belgium matthiasm11
Patch #76 doesn't apply anymore due to conflicting tests in v2.0.8. Attaching a patch without changed tests.
Tests should be looked into, marked the issue as "Needs work". - 🇳🇿New Zealand jonathan_hunt
Patch applies to Facets 2.0.9, thanks @matthiasm11