- 🇮🇹Italy drein
To be honest, I also meet this problem on the homepage of the site, with the nodes. My Screen Reader reads me first the author and then the title of the node. I would like it to work like the other themes, first the title and then the author, but not being a programmer I don't know where to get my hands. Clearly, I will solve the problem with a view that acts as a homepage, but it's not the solution.
- 🇺🇸United States mikemiles86
The previously provided patch had an error in it, where a change was made to a regex validator by mistake. Update patch removing that error.
- 🇫🇷France mably
Rebased and slightly modified the original path disabling Ajax on right click.
It's not perfect on an a11y point of view, but doesn't seem to have any side effect and is better than nothing.
- 🇫🇷France mably
It looks like simply switching from "mousedown" to "mouseup" could fix the accessibility problem (context menu available on right click) without being affected by the auto-click on submit browser behavior.
- 🇫🇷France mably
@neclimdul even if you use
'#type' => 'button'
in your form, Drupal still generates aninput
of typesubmit
. - 🇺🇸United States neclimdul Houston, TX
rebased. Doubt back porting to d7 tag means much now so removing.
- 🇺🇸United States neclimdul Houston, TX
I suspect we need to fix media's buttons then. Without looking at the interface, I suspect they shouldn't be submit and just buttons since what your describing sounds like an interactive action, not a form submission.
What you're describing of triggering the first submit button is expected HTML behavior outlined in the HTML spec and I believe required by WCAG?
- 🇫🇷France mably
We are being hit by the side effects described in comment #145.
Media library fields are being submitted when users use the enter key on any fields of the form.
How could we fix that?
- 🇺🇸United States mikemiles86
I have a Drupal 10.4.x site that still requires this patch. I've re-rolled the patch from #206 to apply to 10.4.x
Inter-diff from last patch added as well.
- 🇩🇪Germany Anybody Porta Westfalica
Just wanted to leave a note here, that we need something similar, but not for the alt-text, but for a subset of fields of the media entity to override in the referencing media reference field wiget.
https://www.drupal.org/project/media_library_media_modify → is close, but implements its own field type, which is a problem for existing sites. Instead, it should be a field widget for the existing media references.
- 🇮🇳India lavanyatalwar
Hi @wxactly,
Thanks for the merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them. - 🇺🇸United States chrissnyder Maryland
> I don't think we will backport this on 2.x branch.
A backport to the 2.x branch would be welcome. Should I open a new ticket to patch the 2.x branch or add a patch to this issue for 2.x?
- 🇺🇸United States charles belov San Francisco, CA, US
I'm not seeing a color background to the focused item, I'm seeing the same gray background on both the Report and Structure, as shown in my screen print.
But since you asked... And thank you for asking:
I suggest, just as Drupal inverts the colors on the active tab in the first row (Active Manage is black on white, other tabs are white on black), that you invert the colors on the active tab in the second row (Active Reports would be white on black, other tabs would remain black on white).
I also suggest that you not override the browser's default focus indicator with site-specific styling, but let the browser show its default focus outline, which varies by browser, just as the Drupal website does as of April 23, 2025. This would reduce cognitive load on the part of the user, as they would not have to figure out what the focus indicator was and could instead rely on the normal appearance of the focus indicator in their browser.
- 🇺🇸United States wxactly
Thanks all - this has been merged into the latest version of the module.
-
wxactly →
committed f9156fdc on 3.x authored by
lavanyatalwar →
Issue #3438534 by kwfinken: Accessibility Issue with links
-
wxactly →
committed f9156fdc on 3.x authored by
lavanyatalwar →
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States smustgrave
Just following up if this should be re-open,. if no follow up in 3 months could be closed
- 🇳🇿New Zealand quietone
The Drupal core Accessibility → core gate states that a goal of core is to conform to WCAG 2.1. That standard has recommendations, https://www.w3.org/WAI/WCAG21/Techniques/general/G200, for this case.
There is an item here to add a sniff for target=_blank. But there are valid cases for using _blank so adding a sniff to to warn about it's use could be disruptive when running commit-code-check.sh.
Therefor, I think everything is done here.
Thanks everyone!
- 🇫🇷France dydave
Super nice Charles (@Charles Belov)! That's very helpful, thanks a lot!
OK, no problem, it seems you have well identified the issue 👍
Sorry, but I'm still trying to understand the problem here 😅
I have tried reproducing the steps you detailed above at #3 and here is a screenshot of the result :
Browse to the reports page and use the tab key until the focus is on "Structure"It would seem the styles for identifying an active link and the ones for the
focus
state, would be slightly different: I'm seeing a different background color for thefocus
state and the active one is bold and underlined, as you can see on the screenshot above (the "Structure"/focused and "Reports"/active menu links) .Could you please let me know what the problem could be exactly with the different styles: active and focused?
It would help greatly speeding up the resolution process if we could have a very clear understanding of the styles or elements to be fixed.
Expected result: the focus is clearly indicated and is well distinguished from the active tab, and both are well distinguished from other tabs (3:1 contrast)
Would you know how that would translate in terms of CSS?
Would you have any suggestions in terms of the changes for the color contrast?
Or any of the other styles really, whether bold or underlined...Any suggestions, advice or recommendations would be greatly appreciated.
Thanks in advance! - 🇺🇸United States charles belov San Francisco, CA, US
Testing with Drupal Version 11.1.7-dev on simplytest.me.
Yes, the issue still exists.
Steps:
1. Go to Simplytest.me
2. Create a website using 11.1-dev
3. Login as admin
4. Go to manage, reports
5. Press the tab key until the focus is on StructureExpected result: the focus is clearly indicated and is well distinguished from the active tab, and both are well distinguished from other tabs (3:1 contrast)
Actual result: the focus and active tabs are styled identically and have 1.09:1 contrast with other tabs.
- Issue created by @the_g_bomb
- 🇮🇳India prashant.c Dharamshala
- Rebased the branch with 11.x
- Reviewed the changes, was able to search the module by machine name as well as the human-readable name
- Attaching the GIF
- Keeping in NW as Accessibility review and change records are pending
- 🇮🇳India prashant.c Dharamshala
prashant.c → made their first commit to this issue’s fork.
- 🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- 🇮🇳India snehal-chibde
Hello, I have tested the MR on local on Gin Theme version 4.0.x, and its working as expected .
Added before and after screenshots for reference.