Just another +1 here for all the same reasons everyone has already stated.
griffynh → credited bhogue → .
This seems to work for me, but I'm not entirely sure what you're after and this is my first exposure at Experience Builder.
This is what I added to the CSS
.example-flexbox-break > [data-xb-component-id="slot"] {
flex: auto;
}
I'm going to take a stab at this.
Looking into this at NEDCamp. Adding the issue tag.
I've reviewed the changes and can confirm all instances of "staging area" have been replaced. It could always be futzed with more, but this seems like it's been thoroughly de-jargonized.
Sorry, @anybody, I don't have the expertise to provide a fix for this particular issue.
I just added a little spacing between the results and the icons when stacked. They looked a little squished.
bhogue → made their first commit to this issue’s fork.
I'm picking this up today as part of NEDCamp's contribution day
Thanks for the information. Seems like something the maintainers would want to note for users, not just for transparency but primarily because it's essentially a breaking change.
bhogue → created an issue.
I am also running `linkit_media_library`
bhogue → created an issue.
It's not terribly nice looking, but I can confirm it works. Too bad it didn't do anything to fix the problem I have, but that's another story.
Sorry, I discovered I had to update the patch I was using from https://www.drupal.org/project/facets/issues/3052574 🐛 Facets with AJAX not working in most of situations Needs review
The combination of patches that others have mentioned does not work for me. I'm able to open the Media Library, but the linkit modal stays open and over the media library when I do so. I can still pick a media entity and click Insert, but no link is created. At most, the link field in the modal gets populated with something like /media/123456, but clicking the green check to apply it to the text that I had previously selected instead inserts a link that looks like /media/123456 and places it at the very beginning of the WYSIWYG.
bhogue → created an issue.
I get this too, but seemingly only when I run cron. And it appears about 20 times. It will happen on any page, node or not, when I run cron.
+1 on this. It's completely unclear how to correctly configure this.
Just wanted to confirm that this is an issue for me too.
On our site, we have a field that lets the user assign an id
to our Section Paragraph. On sections on which this field has a value, we lose the edit controls (they're not just hidden — they aren't even in the markup) while others without a value in the id
field are still editable. When I remove the id
from our Section markup, the controls return. Once I do that, I can clear out the value from the id
field and save the page, replace the id
in our markup, reload the page, and the controls are still there for that particular Section.
bhogue → created an issue.
bhogue → created an issue.
bhogue → created an issue.
Confirming that the patch in #7 worked to solve this issue for me.
Additionally, I believe both https://www.drupal.org/project/drupal/issues/3310058 → and https://www.drupal.org/project/drupal/issues/3422047 📌 Handle malformed module info in the translation status form Active are trying to solve the same issue seen here.
Was getting this error upon editing and saving a LB page on 10.3.1:
Error: Call to undefined method Drupal\layout_builder_st\InlineBlockEntityOperations::getPluginBlockId() in Drupal\layout_builder\InlineBlockEntityOperations->saveInlineBlockComponent() (line 259 of /var/www/html/docroot/core/modules/layout_builder/src/InlineBlockEntityOperations.php)
I uninstalled layout_builder_st
, but was still getting the error, although this time pointing to `layout_builder`:
Error: Call to undefined method Drupal\layout_builder\InlineBlockEntityOperations::getPluginBlockId() in Drupal\layout_builder\InlineBlockEntityOperations->saveInlineBlockComponent() (line 259 of /var/www/html/docroot/core/modules/layout_builder/src/InlineBlockEntityOperations.php).
I then updated from #43 version of this patch to the version from #44 and issue was resolved.
None of these patches will apply cleanly on 10.3.1.
bhogue → created an issue.
bhogue → created an issue.
Agree with #27. Not fixed. I had to grant the "Access the content blocks overview page" as well as permissions to Create/Delete/Edit for each block.
The patch from this other issue seems to have fixed the problem for me.
https://www.drupal.org/project/drupal/issues/3449851#comment-15654085 🐛 Replace LogicException with trigger_error in LangcodeRequiredIfTranslatableValues constraint RTBC
I can confirm that the patch in #2 fixes the issue. Was unable to send test email, now can send test email successfully. Thank you!
bhogue → created an issue.
Maybe no new information here, but I'm also having this issue and being driven crazy by it, so I'll include what I've seen just in case.
My CKE5 content is a simple <drupal-media>
element with a link added and the "Convert line breaks into HTML" text filter is near the top of the list. This is what the source looks like:
<a href="/node/106"><drupal-media data-entity-type="media" data-entity-uuid="3b055276-978a-445d-83e5-5ac8c217030a"> </drupal-media></a>
This is the rendered output:
<div class="c-basic-text o-wysiwyg">
<p>
<a href="/node/106"><br></a>
</p>
<article class="media media--type-image media--view-mode-default">
<p>
<img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
</p>
</article>
<p></p>
</div>
Note the <p>
that precedes the <article>
. It contains an <a>
that contains only a <br>
and which of course results in a duplicate link (which is bad practice). None of these elements were present in the CKE5 source.
I figured out (as others have) that if I turned off the "Convert line breaks into HTML" text filter, the image link began working as expected and the rendered output looked like this:
<div class="c-basic-text o-wysiwyg">
<a href="/node/106">
<article class="media media--type-image media--view-mode-default">
<img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
</article>
</a>
</div>
So that solves it! But I don't want to turn off the filter completely because that might mess up existing content that relies on the line breaks being converted, so instead I moved the "Convert line breaks into HTML" text filter to the bottom of the filter list. That results in this rendered output:
<div class="c-basic-text o-wysiwyg">
<p>
<a href="/node/106"></a>
</p>
<a href="/node/106" data-once="lifespan_extlink">
<article class="media media--type-image media--view-mode-default">
<img loading="lazy" src="/system/files/styles/large/private/2024-06/img_0243_0.jpeg?itok=eeSOaOLy" width="480" height="360" alt="Kittens">
<br>
</article>
</a>
</div>
If you're playing along, you can see that we have an image link that works, but now the duplicate link is back. This time it does not have a <br>
in it. Instead, a <br>
mysteriously appears after the <img>
. Again, neither the extra link nor the <br>
were present in the CKE5 source.
Another wrinkle: I noticed that if I add an image caption to the linked <drupal-media>
element, I get this rendered output:
<div class="c-basic-text o-wysiwyg">
<figure role="group" class="caption">
<a href="/node/106">
<p></p>
<article class="o-img-wrapper">
<img class="media media--type-image media--view-mode-default" src="/system/files/2024-06/img_0243_0.jpeg" alt="Kittens" loading="lazy">
<br>
</article>
</a>
<p>
<a href="/node/106" data-once="lifespan_extlink"></a>
</p>
<figcaption>test caption</figcaption>
</figure>
</div>
Of note here is that the image link is correctly formed and works, but we again have a duplicate link and a <br>
following the <img>
.
My default display for images does not include any link. This is happening on 10.2.x.
Again, as others have already noted, it seems like turning the filter off if is currently the best option for getting a correctly linked image and no problematic markup.
Issue was trying to use 2.x version of module instead of 3.x version
bhogue → created an issue.
Looks good. Thank you!
I intend to take a stab at this.
So, after reading through all of this, I'm still confused as to what this "fixed" issue means for us.
Should I have a version that I bump, or should I use version: VERSION
, or should I not have a version key at all? For my purposes, I'm not talking about a custom module, but my custom theme's main.css
and .js
files identified in my libraries.yml
.
Provided what agarzola has said (particularly in #106 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed ), I'm leaning toward removing the version key altogether, but it would be nice to have some definitive documentation around this considering how often it causes issues for folks.
closing because this is a issue with recaptcha itself and not this module
bhogue → created an issue.
bhogue → created an issue.
After following the steps in #66, I checked the option to "Edit each Media item after upload." I then added 3 images and supplied 2 out of 3 with alt text during the upload process. The process completed and it brought me to the Edit screen for the first newly uploaded item with this Error text:
Notice: Only variables should be passed by reference in Drupal\media_bulk_upload\Form\MediaBulkUploadForm->batchFinished() (line 517 of modules/contrib/media_bulk_upload/src/Form/MediaBulkUploadForm.php).
Drupal\media_bulk_upload\Form\MediaBulkUploadForm->batchFinished(1, Array, Array, '1 sec') (Line: 457)
_batch_finished() (Line: 99)
_batch_page(Object) (Line: 52)
Drupal\system\Controller\BatchController->batchPage(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
and when I clicked "Close and stop editing items," I got this error:
Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing ("node") to generate a URL for route "entity.node.canonical". in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 187 of core/lib/Drupal/Core/Routing/UrlGenerator.php).
Drupal\Core\Routing\UrlGenerator->getInternalPathFromRoute('entity.node.canonical', Object, Array, Array) (Line: 300)
Drupal\Core\Routing\UrlGenerator->generateFromRoute('entity.node.canonical', Array, Array, 1) (Line: 108)
Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute('entity.node.canonical', Array, Array, ) (Line: 765)
Drupal\Core\Url->toString() (Line: 150)
Drupal\Core\Form\FormSubmitter->redirectForm(Object) (Line: 95)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('media_image_edit_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
But the items were successfully uploaded with the alt text that I provided.
I agree with philalonso's assessment in #10 📌 Scheduler Project - Update Categories Needs review
I'd like to propose adding the following categories to the list
- Content Display - Twig is, after all, singularly concerned with content display; Twig Tweak is just an expansion of that
- Developer Tools
I'd advocate for these categories:
- Content Editing Experience - because standardized, consistent data structures can contribute to a streamlined authoring experience
- Search Engine Optimization (SEO) - structured data contributes to good SEO
- Site Structure - structured data is what it's all about
I'd like to propose adding the following categories to the list
- Content Display -
- Content Editing Experience - because it can enhance typical admin pages like /content etc
- Site Search - because exposed filters are often used for advanced search both in the admin and frontend
I'd like to propose adding the following categories to the list
- Administration Tools - because this feature is only available via the admin
- Content Editing Experience
I'd like to propose adding the following categories to the list
- Access Control - because it's possible that some site content is hidden/unavailable to users who do not consent
I'd like to propose adding the following categories to the list
- Developer Tools
- Security - because it can help identify code deprecations
- Performance - because identifying/remediating things like code deprecations can lead to better performance
Considering the reduced categories list, I'd like to propose adding the following categories
- Access Control
- Administration Tools
- Security
I'd like to propose adding the following categories to the list
Access Control - because it expands access possibilities
Administration Tools - because it provides greater control/granularity over access
Site Structure - because it helps users define navigation content
I'd like to propose adding the following categories to the list
- Content Display
- Media - in addition to being an image, Icon could easily be its own Media Type
- Content Editing Experience - because icons can be applied to help quickly identify things like Paragraphs
I'd like to propose adding the following categories to the list
- Administration Tools - because it relates to configuration of the site
- Import and Export - because it is excluding data from the site
- Access Control - because it restricts access to chosen configuration
I didn't get to
let's make the slideshow actually work
from #34 📌 Update project detail page layout & elements Needs work , but I think I hit all the other asks.
bhogue → made their first commit to this issue’s fork.
Confirming that this worked for me. I checked screen widths up to 5000px; 4 columns were maintained.
bhogue → made their first commit to this issue’s fork.
This still isn't working for me ...
I am trying to exclude layout pages from displaying breadcrumbs, so this is what I'm putting in the "Paths to be excluded while generating segments" field:
node\/[0-9]+\/layout
But when I go to /node/8/layout, the breadcrumb is still there.
I am using version 2.0.6 of the module.
I tried the module as-is, then I tried patching using MR!31, then I tried downloading 31.patch and applying that way. Nothing seems to work. What am I missing?
Further confirmation here. Works on 10.2.4.
bhogue → created an issue.
Seeing the same here with Drupal 10.2.2. Alt text is optional, using core Image widget, but still no option to enable decorative in the form display settings.
thanks! that's good to know!
bhogue → created an issue.
Using MR from #21, this solved the problem for us.
Can we make it more clear if the credentials.json file has to be named credentials.json or if it can be anything.json?
Change where Account Access Management can be found in GA4 dashboard
bhogue → made their first commit to this issue’s fork.
Same here. Fresh install. Created first CT. Got error on new CT node creation. Created first MT. No longer receive error.
Just adding another confirmation that the patch in #5 worked for me
Here's a patch to simply allow the plugin to be installed on Drupal 10
Confirming patch from #9 fixed the issue for me
@kascarobert This is an upgrade from `4.0.0-alpha2` to `4.0` that was happening at the same time as many other module updates as directed by the Upgrade Status module in order to prepare for and get to D10.
I believe that you are right that I had a "ginormous" queue because I remember at one point seeing that the config page was reporting a queue of something in the millions, although there was no feedback about the error or a possible timeout from drush. Once I completed my workaround, the module was reporting the queue was at 0.
bhogue → created an issue.
this was the result of old code remaining despite updating through Composer. "/src/EventSubscriber" no longer exists.
bhogue → created an issue.
bhogue → created an issue.
bhogue → created an issue.
While following this guide, I ran into an issue in which I instinctively used foo.html.twig as my template file instead of just foo.twig.
This resulted in this error:
Drupal\sdc\Exception\InvalidComponentException: Unable to find the Twig template for the component "mytheme:mycomponent"
Perhaps this distinction should be more explicitly called out?
Sorry, just figured out this is a problem with our custom styles. Closing.
bhogue → created an issue.
At least in my case, I was getting the error because I applied an unrelated patch ( https://www.drupal.org/project/drupal/issues/2784233 ✨ Allow multiple vocabularies in the taxonomy filter Needs work ) to add some view functionality and then removed it, but some of the patched config was left behind.
I get this error, but only after I've updated my site and modules from 9.4.x to 9.5.x.
If I go to a node edit page for a node that has a Media entity and click "Add media," nothing happens. No error is presented, even though I have seen Ajax errors generate error messages in the admin UI. An Ajax error does show up in the console, but it's very unhelpful and simply points to line 448 of ajax.js, which is inside this function: Drupal.Ajax.prototype.error = function (xmlhttprequest, uri, customMessage) {
Then, in the dblog, the error is as the original poster said:
TypeError: Drupal\Core\Render\Element::children(): Argument #1 ($elements) must be of type array, null given, called in /var/www/html/web/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php on line 957 in Drupal\Core\Render\Element::children() (line 72 of /var/www/html/web/core/lib/Drupal/Core/Render/Element.php)
I have tried uninstalling several Media-related modules like media_library_edit and dropzonejs, and I also toggled off JS aggregation, none of which has helped.
BTW, I created a module for this: admin_menu_levels →
bhogue → created an issue.
I tested the patch in #16 and am getting:
Warning: preg_match(): Unknown modifier 't' in Drupal\easy_breadcrumb\EasyBreadcrumbBuilder->build() (line 510 of modules/contrib/easy_breadcrumb/src/EasyBreadcrumbBuilder.php).