Allow to set an aria-label on the iframe element

harlor → credited dweinberger → .

I have tested the changes locally. The new field works as expected. The code looks good to me. There is another issue for the unit test error: https://www.drupal.org/project/spa/issues/3512289 📌 Fix tests Active

Indeed - good catch!

I get this error when running the module with this patch on D11

Fatal error: Declaration of Drupal\spa\Plugin\Block\SpaBlock::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\Core\Block\BlockBase::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state): void in /var/www/html/repos/spa/src/Plugin/Block/SpaBlock.php on line 124

I do not get that error when running the patch with D10

@bhogue, I think your issue is caused by 🐛 Block Plugins don't store their context mappings on submit Needs work .

It's a bit weird that BlockBase does now specify a return type when PluginFormInterface does not. But as a workaround it should be totally fine to add this return type in SpaBlock.

I opened a separate issue for that: ✨ Allow to set an aria-label on the iframe element Active