🇩🇪Germany @Antonín Slejška

antonín slejška → created an issue.

The patch issue-3202896-7.patch and the diff drupal-3202896-MR9357-11.x--20240828-1.diff look good for me.

The following change solves the problem on our sites: https://git.drupalcode.org/issue/menu_block-3465931/-/commit/9248fe00ca0...

I have not done any tests to see what the effects of this change are. But I hope it helps to localize and understand the problem.

Antonín Slejška → created an issue.

Thank You! 🙏

We use the patch on multiple sites (in production). It works as expected.

I have tested the changes locally. It works for me.

Antonín Slejška → created an issue.

I have:

1. added the template page--user--general (it is used in: https://www.drupal.org/project/email_tfa/issues/3247198 📌 Integration with gin_login module Needs review ),
2. reviewed the code (it looks good to me),
3. tested it on our websites (it works).

I have updated the merge request to be compatible with email_tfa 2.0.

I have added the methods setSitemaps and getSitemaps to the GeneratorInterface. It works: https://git.drupalcode.org/issue/simple_sitemap-3432628/-/pipelines/126371
But I'm not sure, if it is the best solution. Why not to use 'extend'?

Hi @gbyte, I have implemented it, as you suggested. It works by me locally, but it causes the following issues:
https://git.drupalcode.org/issue/simple_sitemap-3432628/-/jobs/1132670

Antonín Slejška → created an issue.

To delete all private or shared tempstores is recently not possible. See:

• the issue 2475719 ✨ Ability to delete/retrieve all items in a PrivateTempStore for a given owner or all owners Needs work ,
• the class DatabaseStorageExpirable,
• the class DatabaseStorage.

Thanks, @clarkssquared, for the review!

Antonín Slejška → created an issue.

Antonín Slejška → created an issue.

Antonín Slejška → created an issue.

The merge request to be reviewed: https://git.drupalcode.org/project/tsk/-/merge_requests/1

Antonín Slejška → created an issue.

I get the following error message after composer update:
Cannot apply patch #3150540 Config in en (patches/core/3150540-30.patch)!

I have started a new test for 3150540-30.patch. The test failed: https://www.drupal.org/pift-ci-job/2657165 →

Thank you @noorulshameera! I have commited and pushed your patch:
https://git.drupalcode.org/project/inxmail_xml/-/commit/af04fa3250a29435...