Enable to add new routes (pages)

Hello,
I have tested the MR 6 patch and it works perfectly with the 2.x branch.
I think you could merge it perfectly without affecting the expected module performance.
Also I think it is very good approach and solution.
Could you please check this issue and try to merge?

I have added a file as documentation of the new hook in the MR gin_login.api.php

This would need a 2.x branch

I have generated a new RM on the 2.x branch.

https://git.drupalcode.org/project/gin_login/-/merge_requests/33

I have:

1. added the template page--user--general (it is used in: https://www.drupal.org/project/email_tfa/issues/3247198 📌 Integration with gin_login module Needs review ),
2. reviewed the code (it looks good to me),
3. tested it on our websites (it works).

Giuseppe87 → changed the visibility of the branch 3246426-enable-to-add-on-2.0.x to hidden.

Giuseppe87 → changed the visibility of the branch 3246426-enable-to-add-on-2.0.x to active.

Giuseppe87 → changed the visibility of the branch 3246426-enable-to-add-on-2.0.x to hidden.

Giuseppe87 → changed the visibility of the branch 3246426-enable-to-add-on-2.0.x to active.

Despite the pipeline saying the MR being mergeable, I had a conflict and can't apply the patch. I rebased the issue.

Can anyone help to merge this request? thank you very much.

saschaeggi → closed merge request !6

Thanks everyone involved here, pushed to 2.0.x 🎉

Automatically closed - issue fixed for 2 weeks with no activity.

For folks wanting this with the TFA module → , this entry gets it working:

/**
 * Implements hook_gin_login_route_definitions_alter().
 */
function MY_MODULE_gin_login_route_definitions_alter(array &$route_definitions):void {
  $route_definitions['tfa.entry'] = [
    'page' => 'page__tfa',
    'template' => 'page--user--general',
    'preprocess functions' => ['gin_login_preprocess_ginlogin'],
  ];
}

@jhedstorm you can create a new issue with an MR to contribute this back to gin_login