🇺🇸United States @jhedstrom

Thanks all! I'll cut a new release shortly.

jhedstrom → made their first commit to this issue’s fork.

For folks wanting this with the TFA module → , this entry gets it working:

/**
 * Implements hook_gin_login_route_definitions_alter().
 */
function MY_MODULE_gin_login_route_definitions_alter(array &$route_definitions):void {
  $route_definitions['tfa.entry'] = [
    'page' => 'page__tfa',
    'template' => 'page--user--general',
    'preprocess functions' => ['gin_login_preprocess_ginlogin'],
  ];
}

This patch fixes the fatal error, which is great, but it has downstream PHP warning/notice issues as the underlying responsive image code expects certain metadata (width, height) to always be set.

Warning: Undefined array key "width" in template_preprocess_responsive_image() (line 209 of core/modules/responsive_image/responsive_image.module).
template_preprocess_responsive_image(Array, 'responsive_image', Array)

jhedstrom → created an issue.

Thanks! I've added you as a maintainer.

Adding a patch as well for use with composer.

jhedstrom → created an issue.

Other core field types don't appear to have a category anymore, so simply removing this resolves the assertion error.

Attaching a patch for use with composer.

jhedstrom → created an issue.

The official PHP Docker images also have this issue (sqlite v3.40.1) and don't even offer the latest Ubuntu LTS at this time as an option...

Attaching a patch for use with composer.json in the mean time.

The MR needs the latest 8.x-1.x merged in as there is a conflict.

Hi @bluegeek9! I've added you as a maintainer. Thanks for helping out!

Note that the sub-request approach also breaks the canonical url meta tag (which gets set to the parent node, not the sub page).

I've released 1.4 that contains this update.

This MR updates the README as well.

I updated the project page with a note about this issue. Thanks all for digging in and figuring this out!

I added 🐛 Redirect support breaks redirects to Active .

jhedstrom → created an issue.

Note that this issue causes redirects to <front> not to work. Disabling the redirect_support option allows them to work again.

+++ b/src/AutoEntityLabelManager.php
@@ -199,11 +199,14 @@ public function hasOptionalAutoLabel() {
+    return $not_applied && ($required || $optional) && !$title_preserved && !$entity_id;

This change makes it such that entity labels are not updated, they only trigger on new content...

This is an attempt at refactoring, it gets the custom title working, but probably has many other ramifications for projects that rely on the sub-request approach. This also works with the aforementioned easy breadcrumb issue. I didn't commit this to the issue fork, as it's more of a PoC for now.

Processing these as a sub request has additional ramifications around breadcrumbs. For instance, the Easy Breadcrumb module tries to match the path as the canonical one, not the sub path, making the pages have the same breadcrumb as the parent node.

This is a duplicate of 🐛 Context exception when trying to create url (Drupal 10 is broken!) RTBC .

This resolves the issue I was seeing.

#2 also resolves this with Gin and Layout Builder. I'm bumping to Major is it makes LB un-usable. A test may be tricky since this seems to only be surfaced by Contrib modules...

bluegeek9 → credited jhedstrom → .

Moving to NR and adding a patch for use with composer.

Thanks all! I'll cut a new release shortly.

Since this is critical, do we want to commit the current fix (all tests are passing) and deal with the fallout/ideal fix in a follow-up?

Patch for composer. There's a branch in gitlab, but I'm not seeing the button to open a MR.

jhedstrom → created an issue.

jhedstrom → made their first commit to this issue’s fork.

Thanks all!

jhedstrom → made their first commit to this issue’s fork.

Thanks!

jhedstrom → made their first commit to this issue’s fork.

Thanks!

jhedstrom → made their first commit to this issue’s fork.

Thanks all!

jhedstrom → made their first commit to this issue’s fork.

Thanks all!

jhedstrom → made their first commit to this issue’s fork.

Thanks!

jhedstrom → made their first commit to this issue’s fork.

Done!

Thanks all!

jhedstrom → made their first commit to this issue’s fork.

Thanks!

jhedstrom → made their first commit to this issue’s fork.

smustgrave → credited jhedstrom → .

jhedstrom → created an issue.

jhedstrom → created an issue.

Thanks!

Thanks!

Thank you!

jhedstrom → created an issue.

It wasn't, but in order to commit, the failing unit test needs to be updated to pass with this change.

mcdruid → credited jhedstrom → .

jhedstrom → created an issue.

jhedstrom → created an issue.

jhedstrom → created an issue.

jhedstrom → created an issue.

There should be a test to demonstrate this issue/fix.

These have been taken care of in other issues I think.

Thanks all!

jhedstrom → made their first commit to this issue’s fork.

jhedstrom → created an issue.

jhedstrom → created an issue.