Contrib.social

Wrong return value of deliver function in notifier plugin Email.php

Open on Drupal.org →
Created on 5 June 2023, almost 2 years ago
Updated 3 November 2023, over 1 year ago

Problem/Motivation

We wanted to use the return value from \Drupal\message_notify\Plugin\Notifier\Email::deliver to indicate if a mail got send or not. Even when we corrupted the mail server settings and the mail doesn't got send we received a TRUE. The reason is that the return value is set by the isset() function and even if the value in $result['result'] is false isset() will return true.

Proposed resolution

Return the value from $result['result'] when set or FALSE when not.

🐛 Bug report
Status

Fixed

Version

1.3

Component

Code

Created by

🇩🇪Germany atropoides Hamburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024