- Issue created by @sahil.goyal
- First commit to issue fork.
- Assigned to himanshu_jhaloya
- 🇮🇳India himanshu_jhaloya Indore
Fixed the PHPCS issue and applied the patch
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 5:22am 30 January 2023 - Assigned to Charchil Khandelwal
- Status changed to Needs work
about 2 years ago 8:47am 30 January 2023 - 🇮🇳India Charchil Khandelwal
FILE: ...rupal\modules\workflow_participants\src\Access\RevisionCheck.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
24 | ERROR | The array declaration extends to column 89 (the limit
| | is 80). The array content should be split up over
| | multiple lines
----------------------------------------------------------------------FILE: ...les\workflow_participants\tests\src\Functional\NonNodeUiTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
49 | ERROR | The array declaration extends to column 87 (the limit
| | is 80). The array content should be split up over
| | multiple lines
----------------------------------------------------------------------Need to work on this issue.
Thanks! - @charchil-khandelwal opened merge request.
- 🇮🇳India Charchil Khandelwal
All the errors and warnings are fixed now.
And also created MR for this.
Please review. - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 3:52am 28 April 2023 - 🇵🇭Philippines paraderojether
Hi Charchil Khandelwal
I reviewed MR!10, and confirmed it fixes all the errors and warnings reported by phpcs. Drupal core version 9.5.8, Workflow participants 3.0.x-dev.
I added screenshots for reference.
Thank You. - Status changed to Needs work
almost 2 years ago 3:29pm 20 May 2023 - First commit to issue fork.
- last update
almost 2 years ago 30 pass, 2 fail - Status changed to Needs review
almost 2 years ago 3:43pm 20 May 2023 - 🇮🇳India bharath-kondeti Hyderabad
Addressed review comments from the MR.
- First commit to issue fork.
- last update
over 1 year ago 31 pass - @jhedstrom opened merge request.
- last update
over 1 year ago 31 pass - last update
over 1 year ago 31 pass - last update
over 1 year ago 31 pass -
jhedstrom →
committed 72c99d08 on 3.0.x
Issue #3337439 by jhedstrom, himanshu_jhaloya, sahil.goyal, Charchil...
-
jhedstrom →
committed 72c99d08 on 3.0.x
- Status changed to Fixed
over 1 year ago 8:32pm 1 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.