There is already a page for the posted comments ( https://www.drupal.org/admin/content/comment → ), even if that does not allow to filter comments by content type of the parent node.
This issue asks for a similar view, but for comments.
Request for page on d.o to list pages with recently-added comments.
I published 🐛 JS error related to Drupal.behaviors Active and confirmed the account. No other posts/comments needed to be published.
These offers need to be created in the project issue queue, even when the person asking for more permissions is already co-maintainer or maintainer. As per
Offering to become a project owner, maintainer, or co-maintainer →
, they can be moved in the
Drupal.org project ownership queue →
, 14 days after the offer was posted/moved in the project queue, if the offer has not been declined by maintainers (including the project owner).
Remember to give the project link, when the issue is moved.
- The following points are just a start and don't necessarily encompass all of the changes that may be necessary
- A specific point may just be an example and may apply in other places
- A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
- The single review points are not ordered, not even by importance
src/Form/GenerateReadmeForm.php
The parent class already defines the $configFactory and the $messenger properties which are initialized using the methods the parent class makes available.
if (
(str_starts_with($path, 'modules/custom') ||
str_starts_with($path, 'modules/contrib')) &&
substr_count($path, '/') > 2
) {
continue;
}
As per coding standards →
, the if() conditions are written on a single line.
Always use curly braces even in situations where they are technically optional. Having them increases readability and decreases the likelihood of logic errors being introduced when new lines are added. The opening curly should be on the same line as the opening statement, preceded by one space. The closing curly should be on a line by itself and indented to the same level as the opening statement.
avpaderno → created an issue.
avpaderno → created an issue.
avpaderno → changed the visibility of the branch 3429891-automated-drupal-11 to hidden.
avpaderno → created an issue.
phjou has logged in at least once this week. I am going to contact him, later.
Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
- For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
- Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
The typical path to confirming users usually involves reviewing the content created on this site. In this case, you have not created any content except this post, so there is no content to review.
I am postponing this issue, for now. After you have posted some content on this site, you may want to add a comment to this issue to request a new review.
Please see Become a confirmed user for information on the role and how it is granted.
Thank you and welcome!
I published 🐛 Access custom blocks in draft mode Active (which was created before this request) and confirmed the account.
Furthermore, creating projects on drupal.org does not require having the account confirmed.
Please see the duplicate issues you created and what it has been told you.
The typical path to confirming users involves reviewing the content you created on drupal.org. In your case, you just created these requests, which are not counted as content to review. Creating duplicates of this issue does not get your account confirmed.
avpaderno → created an issue. See original summary → .
Since patches are no longer tested, a merge request must be provided.
avpaderno → made their first commit to this issue’s fork.
Since patches are no longer tested, a merge request must be provided.
avpaderno → changed the visibility of the branch 3460435-gitlab-ci-reports to hidden.
avpaderno → made their first commit to this issue’s fork.
avpaderno → made their first commit to this issue’s fork.
Since patches are no longer tested, a merge request must be provided.
avpaderno → changed the visibility of the branch 3427025-gitlab-ci-reports to hidden.
avpaderno → changed the visibility of the branch 3166154-gitlab-ci-reports to hidden.
avpaderno → changed the visibility of the branch 8.x-1.x to hidden.
Since patches are no longer tested, a merge request must be provided.
avpaderno → changed the visibility of the branch 3368542-gitlab-ci-reports to hidden.
I changed ownership as requested.
paalj is the new project owner.
What is the correct account? https://www.drupal.org/u/fnoks → does not exist.
I published #3523918: Add the possibility to disable machine name field on form and overview per vocabulary → . aimevp confirmed the account.
avpaderno → changed the visibility of the branch 8.x-1.x to hidden.
Is this still an issue for supported releases?
Since patches are no longer testes, a merge request must be provided.
Since patches are no longer tested, a merge request needs to be provided.
No PHP_CodeSniffer error/warning has been reported by GitLab CI before doing any change.
avpaderno → changed the visibility of the branch 3358998-gitlab-ci-reports to hidden.
avpaderno → changed the visibility of the branch 3358998-dev to hidden.
avpaderno → changed the visibility of the branch 3349221-gitlab-ci-reports to hidden.
The merge request fixes all the PHP_CodeSniffer errors/warnings reported by GitLab CI.
Since patches are no longer tested, a merge request needs to be provided.
avpaderno → changed the visibility of the branch 3370016-fix-issues-by-phpcs to hidden.
avpaderno → changed the visibility of the branch 3370016-gitlab-ci-reports to hidden.
avpaderno → changed the visibility of the branch multi_region-3370016-3370016-fix-issues-by-phpcs to hidden.
I am closing this issue, since it has been created about three years ago, and no maintainer has been successfully added using this issue.