🇮🇹Italy @apaderno

I am postponing this task for reverting the changes done.

apaderno → created an issue.

This is the message I used.

Hello Mike,

I am contacting you because Julian ( https://www.drupal.org/u/anybody → ) offered to become co-maintainer for Asset Injector ( https://www.drupal.org/project/asset_injector → ), a project you created for which you are project owner and maintainer.

May you post a comment on https://www.drupal.org/project/projectownership/issues/3452223 → about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue. In the case you accept the offer, you can also add Julian as co-maintainer, but it is not necessary as project moderators can add co-maintainers/maintainers to any project.
Without a comment posted on that issue in the next 14 days, Julian will be probably made co-maintainer.

Project moderators will not remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.

A last note: This offer is about being co-maintainer, which for us means somebody who does not have all the drupal.org permissions on the project. Even though that could mean having just a single permission, we expect a co-maintainer to have the following permissions on the project: Write to VCS, Edit project, Maintain issues, Administer releases.

Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator

The status has been changed because we are waiting for a reply.

Only pookmish can add/remove co-maintainers. Since he logged in at least once this week, I am going to contact him.

Truly, this issue aims to add compatibility only with Drupal 10.

@dcimorra Project moderators will not add as co-maintainers/maintainers people who cannot opt projects into security advisory coverage → .
I sometimes contact the project maintainers also in those cases, but that does not mean I am going to make an exception to what reported in Offering to become a project owner, maintainer, or co-maintainer → .

I apologize I did not make that clear earlier.

Since I contacted the project owner, the issue can also stay here, as the project owner got the issue link.

As project moderator, I can contact the project maintainer before 14 days; sometimes I could contact the maintainers even in the case the person who offered to be co-maintainer/maintainer cannot opt projects into security advisory policy (which does not mean that person will be added as co-maintainer/maintainer).

What I forgot to do is posting a comment explaining in which cases project moderators adds co-maintainers/maintainers to dcimorra.

apaderno → created an issue.

apaderno → created an issue.

• The following points are just a start and don't necessarily encompass all the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issues, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

imagelightbox.module

    $output .= '<p>' . (string) new TranslatableMarkup('<a href="@GIT"> git.drupalcode.org</a>', [
      '@GIT' => 'https://git.drupalcode.org/project/imagelightbox',
    ]) . '</p>';

The correct placeholder for URL starts with : (similarly to the placeholder used for another link). It must also be wrapped on double quotation marks, as reported on FormattableMarkup::placeholderFormat().

:variable: Return value is escaped with \Drupal\Component\Utility\Html::escape() and filtered for dangerous protocols using UrlHelper::stripDangerousProtocols(). Use this when using the "href" attribute, ensuring the attribute value is always wrapped in quotes

src/Plugin/Field/FieldFormatter/ImagelightboxFormatter.php

The \Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter class is not part of the public API and cannot be used as parent class for classes implemented by a contributed module, differently from \Drupal\image\Plugin\Field\FieldFormatter\ImageFormatterBase which is a base class and therefore part of the public API.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

There are no posts/comments to publish. The only post created is this one.

This is the message I sent to Edvinas Baranauskas.

Hello Edvinas,

I am contacting you because Daniel ( https://www.drupal.org/u/dcimorra → ) offered to become maintainer for Simple Cron ( https://www.drupal.org/project/simple_cron/ → ), a project you created for which you are project owner and sole maintainer.

May you post a comment on https://www.drupal.org/project/projectownership/issues/3453929 → about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue. In the case you accept the offer, you can also add Daniel as maintainer.
Without a comment posted on that issue in the next 14 days, Daniel will be probably made maintainer.

Neither project moderators nor site moderators will remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.

A last note: This offer is about being maintainer, which for us means somebody with all the drupal.org permissions on the project: Write to VCS, Edit project, Administer maintainers, Maintain issues, Administer releases. A person who does not have all those permissions is a co-maintainer.

Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator

The status has been changed because we are waiting for a reply.

The project link is https://www.drupal.org/project/simple_cron/ → .
Edvinas Baranauskas logged in at least once in the past six months. I am going to contact him.

In case the previous comments have not been noticed: This application has been created by kushan4157 who is the only maintainer who can make commits for the project, until this application is not closed.

We do not review what all the project maintainers/co-maintainers collectively understand about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API.
This application is about kushan4157, not the project used in this application, even thought we use that project to check what kushan4157 understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API.

(Let's include the .md files.)

apaderno → changed the visibility of the branch 3349806-fix-php_codesniffer-warnings_errors to active.

apaderno → changed the visibility of the branch 3349806-fix-php_codesniffer-warnings_errors to hidden.

apaderno → changed the visibility of the branch 3349806-fix-phpcs-warnings-errors to hidden.

@Rushikesh Yet, it is mattbloomfield who needs to post a comment if he is still interested to co-maintain this module.

Since the AdaptiveTheme theme (the theme linked in this project's page) has been already changed not to use this module, I do not see why mattbloomfield should be a co-maintainer for this project, considering he decided not to use it for that theme.

Yes, those similar names are confusing, but the fault is on who created the more recent project. (This module has been created on December 5, 2013, while the AT Tool 2.0 → module has been created on October 12, 2020, almost seven years later.)

It now works.

It gives the same error.

The feed from 1xINTERNET Lo más destacado: conocimientos, inspiración y entretenimiento seems to be broken, because of error "Attribute without value" on line 52.

bbrala → credited apaderno → .

apaderno → created an issue.

I added the feed to Planet Drupal ( https://www.drupal.org/aggregator/sources/2068 → ).

Perfect!

(The Drupal 11.x tag has been added.)

But can't posts with those ancient tags (4.5, 4.6, 4.7, etc.) be re-tagged with a "Drupal 6.x or older" tag, and then those old tags deleted?

Yes, they can. There are few people who can do that, though; probably they all have the administrator role and few time to follow this issue queue.

Asking on Slack is probably the quicker way to reach them.

Removing the taxonomy terms for old Drupal versions would remove that taxonomy term from forum posts. I know those posts are probably old enough not to be taken as new posts, but I would prefer to still be able to search between Drupal 4.x posts, if necessary.

Since Drupal 9.x and Drupal 10.x are already added to the Drupal version field, Drupal 11.x should be added too.

This task requires somebody who can administer taxonomy terms on drupal.org. As site moderator, I can only delete or rename issue tags.

Notice that this project does not use its Git repository, not even to create pages on drupal.org.
Creating issue forks to add content pages is not how pages are added to drupal.org.

Should not it be at least right after Upgrading Drupal? I would not want Composer is used for every question about upgrading Drupal just because that is the first sub-forum they see listed.

I apologize for the delay: I had to switch back to Firefox, to be able to review Planet Drupal feeds.

The feed passed validation, but the feed shows articles in their full length.
May you provide a summary of the articles on the feed? Articles on Planet Drupal should give a summary of what the article is about; if then people are interested in reading the full article, they read it on the site.

I apologize: I had to switch back to Firefox to be able to review feeds.

amazee.io Unveils Self-Sign-Up is about a service the organization provide; the article does not describe how that service has been implemented (if implemented on a Drupal site).
When I add the feed to Planet Drupal, that article will not be included. (Still, the feed would match the requirements. I note that to remember which articles are not suitable on Planet Drupal and to say which actions will be done to add the feed to Planet Drupal before I do them.)

shelane does not have the Administer maintainers permission which, despite its name, it is necessary (together the Write to VCS permission) to be able to change the default branch (and other tasks I do not recall).

Actually, to redirect users when the maintenance mode is enabled, the module should subscribe to a different event, which is created when a site is in maintenance mode and the logged-in user is not allowed to access a site in maintenance mode. This simplifies the code, as the event subscriber can be sure those conditions are met.

The active developer on this project, who has done the last commit nine months ago, is not a developer for AdaptiveTheme. This means he probably did not notice the changes done on that theme.

As a side note for what the issue summary reports: To update an existing project, where AT Tools 2.0 is already a requirement, you would not use composer require, but composer update.

@mudd I just run composer require drupal/at_tool:2.0.3 in a project where no other modules are required. composer info drupal/at_tool shows me the following information.

name     : drupal/at_tool
descrip. : Tools to support Adaptivetheme 8.x and sub-themes, includes the AT Theme Generator.
keywords : 
versions : * 2.0.3
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0+) (OSI approved) https://spdx.org/licenses/GPL-2.0+.html#licenseText
homepage : https://www.drupal.org/project/at_tool
source   : [git] https://git.drupalcode.org/project/at_tool.git 2.0.3
dist     : [zip] https://ftp.drupal.org/files/projects/at_tool-2.0.3.zip 2.0.3
path     : /home/kiamlaluno/test/vendor/drupal/at_tool
names    : drupal/at_tool

support
source : http://git.drupal.org/project/at_tool.git
issues : https://www.drupal.org/project/issues/at_tool
irc : irc://irc.freenode.org/drupal-contribute

requires
drupal/adaptivetheme ^5.0
drupal/core ^9.3 || ^10

If I instead run composer require drupal/at_tool in a project where no other modules are required, composer info drupal/at_tool shows me the following information.

name     : drupal/at_tool
descrip. : Tools to support Adaptivetheme 8.x and sub-themes, includes the AT Theme Generator.
keywords : 
versions : * 3.1.2
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0+) (OSI approved) https://spdx.org/licenses/GPL-2.0+.html#licenseText
homepage : https://www.drupal.org/project/at_tool
source   : [git] https://git.drupalcode.org/project/at_tool.git 3.1.2
dist     : [zip] https://ftp.drupal.org/files/projects/at_tool-3.1.2.zip 3.1.2
path     : /home/kiamlaluno/test/vendor/drupal/at_tool
names    : drupal/at_tool

support
source : http://git.drupal.org/project/at_tool.git
issues : https://www.drupal.org/project/issues/at_tool
irc : irc://irc.freenode.org/drupal-contribute

requires
drupal/adaptivetheme ^7.0
drupal/core ^10 || ^11

In any cases, Composer should not complain that drupal/adaptivetheme ^9.3 || ^10 is not installed, since it shows drupal/adaptivetheme ^5.0 or drupal/adaptivetheme ^7.0 as requirement.

This issue queue is for reporting changes that should be done on documentation guides, not to report bugs or issues on sites running on Drupal.

There aren't posts/comments to publish.

(This happens because the new branch has been created after this issue was created.)

For the 2.x branch is necessary to create a new issue, since in this issue is not possible to create an issue fork for that branch.

Hello Alex,

I am contacting you because Shelane ( https://www.drupal.org/u/shelane → ), who is already co-maintainer, offered to become maintainer for Views Bootstrap ( https://www.drupal.org/project/views_bootstrap → ), a project for which you are maintainer.

May you post a comment on https://www.drupal.org/project/projectownership/issues/3452710 → about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue. In the case you accept the offer, you can also give to Shelane the only permission she misses to be maintainer.
Without a comment posted on that issue in the next 14 days, Shelane will be probably made maintainer.

Neither project moderators nor site moderators will remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.

I am contacting all the people who can administer co-maintainers/maintainers for the project.

Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator

This is the message I sent to mrded.

Hello Dmitry,

I am contacting you because Shelane ( https://www.drupal.org/u/shelane → ), who is already co-maintainer offered to become maintainer for Views Bootstrap ( https://www.drupal.org/project/views_bootstrap → ), a project you created for which you are project owner and maintainer.

May you post a comment on https://www.drupal.org/project/projectownership/issues/3452710 → about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue. In the case you accept the offer, you can also give to Shelane the only permission she misses to be maintainer.
Without a comment posted on that issue in the next 14 days, Shelane will be probably made maintainer.

Neither project moderators nor site moderators will remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.

I am contacting all the people who can administer co-maintainers/maintainers for the project.

Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator

The status has been changed because we are waiting for a reply.

(I am going to contact the second maintainer.)

I will contact both mrded, who logged in after my comment I posted on June 5, 2024, and aburrows.

@shelane You have been added as co-maintainer, not maintainer. For our official documentation that means a permission less than what a maintainer should have.
Did you give a link to this issue when you contacted the maintainers?

Given than in 🐛 Use the maintenance_mode service Active the class dependencies will be changed, I am postponing this. The class will probably need just two or three cache tags.

apaderno → created an issue.

That is not really an issue is what returned from Formatter::linkFile($file_entity) is already a translated string; otherwise, $link_to_file = new TranslatableMarkup('@link_to_file', ['@link_to_file' => Formatter::linkFile($file_entity)]); will always show a link in English.

If Formatter::linkFile($file_entity) returns a translated string, then it is not necessary TranslatableMarkup, but FormattableMarkup

Just a little note: Code like new TranslatableMarkup('@link_to_file', ['@link_to_file' => Formatter::linkFile($file_entity)]); does not get translations. What the people who translate on localize.drupal.org see as text to translate is @link_to_file, and since that is a placeholder, they would just put @link_to_file because placeholders are not translated.

apaderno → created an issue.

In a directory containing Drupal 11 files, grep -irn "=&" ./ --include=*.module --include=*.php --include=*.inc --include=*.install --include=*.theme| wc -l returned 93, while grep -irn "=&" ./ --include=*.module --include=*.php --include=*.inc --include=*.install --include=*.theme| wc -l returned 328.

Truly, the first command also count lines like the following ones.

./core/modules/ckeditor5/tests/src/Kernel/SmartDefaultSettingsTest.php:1357:          'To maintain the capabilities of this text for
mat, <a target="_blank" href="/admin/help/ckeditor5#migration-settings">the CKEditor 5 migration</a> did the following: Enabled thes
e plugins: (<em class="placeholder">Link, Block quote, Code, List</em>). Added these tags/attributes to the Source Editing Plugin\'s
 <a target="_blank" href="/admin/help/ckeditor5#source-editing">Manually editable HTML tags</a> setting: &lt;cite&gt; &lt;dl&gt; &lt;dt&gt; &lt;dd&gt; &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol type=&quot;1 A I&quot;&gt; &lt;h2 id=&quot;jump-*&quot;&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;. Additional details are available in your logs.',
./core/modules/ckeditor5/tests/src/Kernel/SmartDefaultSettingsTest.php:1401:          'As part of migrating to CKEditor 5, it was found that the <em class="placeholder">A CKEditor 4 configured to have span styles</em> text format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;span class=&quot;llama&quot;&gt;. The text format must be saved to make these changes active.',
./core/modules/ckeditor5/tests/src/Kernel/SmartDefaultSettingsTest.php:1406:          'To maintain the capabilities of this text format, <a target="_blank" href="/admin/help/ckeditor5#migration-settings">the CKEditor 5 migration</a> did the following:  Added these tags/attributes to the Source Editing Plugin\'s <a target="_blank" href="/admin/help/ckeditor5#source-editing">Manually editable HTML tags</a> setting: &lt;span class=&quot;llama&quot;&gt;. Additional details are available in your logs.',
./core/modules/ckeditor5/tests/src/Kernel/ValidatorsTest.php:553:          'The following tag is not valid HTML: <em class="placeholder">&lt;blockquote class=&quot;&quot;&gt;</em>.',

apaderno → created an issue.

For a list of all the available cache contexts (from Drupal core), see Cache contexts → . For cache tags, I did not find a list, but on #2145751-30: Introduce ENTITY_TYPE_list:BUNDLE cache tag and add it to single bundle listing → , I noticed there is a tag for configuration objects, which I guess is invalidated when that configuration object is changed.

(I corrected the example given in the IS, since that is an example of cache context, not cache tag.)

apaderno → created an issue.

apaderno → changed the visibility of the branch 3454259-d7-validate-the-redirect-url-only-when-necessary to hidden.

I committed the changes directly to the project branch because the issue fork branch was not updated and I was not able to update it. (The issue fork UI allows to update the fork only from the default branch, which is not the Drupal 7 branch.)

We do not create redirects from a project page to another. The Replaced by field has been added to point people to the replacing project.

I added i-trokhanenko as maintainer.

The Aggregator module still returns an error.

The feed from 1xINTERNET Lo más destacado: conocimientos, inspiración y entretenimiento seems to be broken, because of error "Attribute without value" on line 52.

Since the Aggregator module cannot parse the feed XML, that is probably the default value used for the URL.