Do not post comments here and request to become a confirmed user. That is not the right way and will only result in your comment being flagged as spam. Instead, provided you've already created some content on Drupal.org, open an issue → in the site moderators issue queue and request the role.
I published the issue; the account was already confirmed by fskreuz.
I added socialnicheguru as maintainer, since the project is not covered by Drupal’s security advisory policy.
This issue queue is for reporting changing that must be done in documentation hosted on drupal.org. It is not a queue for support on external sites.
I published the issue. No other posts/comments needed to be published.
I published two comments and confirmed the account.
Is the account used to create this application shared account?
avpaderno → created an issue.
Thank you for the patch! The merge request has been merged.
Tests are failing because 📌 Add the missing @group annotation to test classes Active . The other GitLab CI jobs are not failing, so the provided patch is good to go.
I added misterkay as maintainer, since the project is not covered by the security advisory policy.
Can you provide an example of action which would be a good example for this project?
I agree that a too simple code would not help much, but a single too complex example could not help either.
This issue has been created in the queue for a Drupal 4.0 module.
This bug has been reported for a Drupal 4.0 module, which does not have any release for Drupal 9.
Welcome to drupal.org! Please notice there is no need to add your name to the title of all the posts you create.
There are no posts/comments to publish.
Projects with commits cannot be deleted.
Since the plan described here is to remove the documentation comments and replace them with an external file, I would say this is a won't fix. Documentation in code is preferable because it requires editing a single file, instead of two or more files, which makes the process easier and less prone to mistakes.
I am not sure moving the information in Markdown files has any pro using api.drupal.org does not have. api.drupal.org is able to provide a list of classes, methods, functions, and constant that Markdown files are not able to provide.
I published the unpublished issues and confirmed the account.
I removed that account from any organization list.
The project link is https://www.drupal.org/project/logout_redirect → .
hardik_patel_12 logged in at least once in the past three months.
I published 🐛 Can't Install on Drupal 11.1.1 Active and confirmed the account.
The project owner logged in on drupal.org at least once in the past six months. I will be able to handle this offer tomorrow.
I added ivnish as co-maintainer, since no comment has been posted to accept/decline the offer. Almost three weeks passed since I contacted jordik.
Since the project is not covered by the security advisory policy, I added jaydeep_patel as co-maintainer.
I deleted the project as requested.
I confirmed the account.
@anzelkiel I would suggest that, if you think to add new features, this is the perfect time for doing it. The more code you write, more changes will the application get to be approved.
Since the Markdown coding standards → are still to be written, correctly adhering to README.md template → is not required.
If there is important information that is missing in the README file, that could be requested to be added, by pointing out which information is missing.
Improved formatting; changed the order used to provide some details.
- The following points are just a start and don't necessarily encompass all the changes that may be necessary
- A specific point may just be an example and may apply in other places
- A review is about code that does not follow the coding standards, contains possible security issues, or does not correctly use the Drupal API; the single points are not ordered, not even by importance
src/Controller/NodePieChartController.php
Since that class does not use any method from the parent class, it does not need to use ControllerBase as parent class. Controllers do not need to have a parent class; as long as they implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface, they are fine.
$query = \Drupal::database()
->select("node_field_data", "nfd")
->condition("nfd.type", $type_id)
->condition("nfd.status", 1)
->countQuery();
Controllers need to inject their dependencies, not use \Drupal methods to get them.
I added jastraat as co-maintainer.
I added poker10 as co-maintainer.
@anzelkiel Wait for a reviewer to report any change that should be done. It could also be the response is not Change these lines in these files.
src/Form/SettingsForm.php
$form['api_access_tokens'] = [
'#type' => 'textarea',
'#title' => $this->t('Enter your API access token'),
'#default_value' => $apiKey,
'#description' => $this->t('Get API access tokens from sender.net <a href="@url" target="_blank">account</a>.', ['@url' => 'https://app.sender.net/settings/tokens']),
'#required' => TRUE,
];
The correct placeholder for URL starts with :. It must also be wrapped on double quotation marks, as reported on FormattableMarkup::placeholderFormat().
:variable: Return value is escaped with \Drupal\Component\Utility\Html::escape() and filtered for dangerous protocols using UrlHelper::stripDangerousProtocols(). Use this when using the "href" attribute, ensuring the attribute value is always wrapped in quotes
catch (\Exception $e) {
watchdog_exception('sender_net', $e);
$this->messenger->addError($this->t('Unable to load groups. Please check your API access token and try again.'));
}
Since the module can be installed on Drupal 11 too, it cannot use watchdog_exception(), which does not exist in Drupal 11. The following code needs to replace the line calling watchdog_exception('sender_net', $e).
\Drupal::logger('sender_net')->log(RfcLogLevel::ERROR, '%type: @message in %function (line %line of %file).', Error::decodeException($e));
Instead of \Drupal::logger() an injected service should be used.
src/Form/SubscriptionForm.php
Is there any reason to use a separate class for the plugin form?
src/SenderNetApi.php
watchdog_exception('sender_net', $th);
$this->logger->error('API request failed: @message', ['@message' => $th->getMessage()]);
Only one of those lines is necessary, since both lines log an error message. See also my previous note on watchdog_exception().
Added a point about changing status when the status is "Active."
rushikesh raval is correct: Without the applicant changing the status from Active to Needs review, we do not change the issue status. It also means this application is not ready for review.
I am also changing the priority, since the applicant has not posted any comment.
This application has been created on November 11, 2024. After that, the applicant has not posted any comment.
Let's change the application priority and status. It should not be reviewed, nor its status changed, until the applicant changes the status.
Since the status has not been changed from the applicant, and the status was Active, this application cannot be yet reviewed.
At the reviewers: Please note what the issue summary says. I re-wrote to make it clearer.
This module takes over the Accessibility toolkit → module to improve it in the near future. It is currently compatible with Drupal 10 and Drupal 11.
The first step is verifying there are significant changes between https://git.drupalcode.org/project/accesstools/-/tree/1.1.x?ref_type=heads and https://git.drupalcode.org/project/a11y/-/tree/2.x?ref_type=heads. The presence of the a11y directory is not significative, as it contains duplicate files.
avpaderno → made their first commit to this issue’s fork.
Actually, I cannot even get to a service page when I search for file_system, the service name.
If I enter FileSystemInterface in the Search drupal 11.x search box, I get only a result: the interface itself.
Drupal\Core\File\FileSystemInterface, which would take to the service page, is not shown.
The link in the issue summary shows a Sorry, api/drupal/core%21core.services.yml/service/Drupal%5CCore%5CFile%5CFileSystemInterface/11.x cannot be found. message. If I try to search for any service defined in the core.services.yml file, the search box does not show the service I am looking for.
This is the message I sent.
Hello chen,
I am contacting you because Jaydeep ( https://www.drupal.org/u/jaydeep_patel → ) offered to become co-maintainer for Smarty Admin ( https://www.drupal.org/project/smarty_admin → ), a project you created for which you are project owner and sole maintainer.
May you post a comment on https://www.drupal.org/project/projectownership/issues/3492649 💬 Offering for co-maintain Smarty Admin Theme Active about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue.
Without a comment posted on that issue in the next 14 days, Jaydeep will be probably made co-maintainer.Project moderators will not remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.
I am contacting all the people who can administer co-maintainers/maintainers for the project.
As last note: This offer is about being co-maintainer, which for us means somebody who does not have all the drupal.org permissions on the project. Even though being co-maintainers could mean having just a single permission, we expect a co-maintainer to have the following permissions on the project: Write to VCS, Edit project, Maintain issues, Administer releases.
If there is any reason for not giving all those permissions, please explain that on https://www.drupal.org/project/projectownership/issues/3492649 💬 Offering for co-maintain Smarty Admin Theme Active .Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator
The status has been changed because we are waiting for a reply.
Please post a comment after 14 days, if your offer has not been declined. It will show you are still interested in maintaining this project and it will serve as reminder an action is required for this offer.
At the time I am posting this comment, the project is not covered by the security advisory policy.
I am going to contact moxihang, who logged it at least once on drupal.org in the past six months.
This is the message I sent.
Hello Jay,
I am contacting you because Frank ( https://www.drupal.org/u/mably → ) offered to become maintainer for Textfield Counter ( https://www.drupal.org/project/textfield_counter → ), a project you created for which you are project owner and maintainer.
May you post a comment on https://www.drupal.org/project/projectownership/issues/3494055 💬 Offering to maintain Textfield Counter Needs review about accepting or declining the offer? Please do not reply via email; we need a reply on the offer issue.
Without a comment posted on that issue in the next 14 days, Frank will be probably made maintainer.Project moderators will not remove the existing maintainers/co-maintainers; the project owner will not be replaced either. Maintainers cannot change the project owner; co-maintainers/maintainers can only be removed/added by people who have the permission to administer co-maintainers/maintainers.
As last note: This offer is about being maintainer, which for us means somebody with all the drupal.org permissions on the project: Write to VCS, Edit project, Administer maintainers, Maintain issues, Administer releases. A person who does not have all those permissions is a co-maintainer.
If there is any reason for not giving all those permissions, please explain that on https://www.drupal.org/project/projectownership/issues/3494055 💬 Offering to maintain Textfield Counter Needs review .Best regards,
Alberto Paderno
-- Drupal.org project moderator
-- Drupal.org site moderator
The status has been changed because we are waiting for a reply.
Please post a comment after 14 days, if your offer has not been declined. It will show you are still interested in maintaining this project and it will serve as reminder an action is required for this offer.
hook_admin_menu_cache_info() is thought for modules that use a specific cache bin to store their data. This module implements a cache backend; it does not use a cache bin for its own data.
The APCu extension is no longer used to cache PHP opcode. If implementing hook_admin_menu_cache_info() made sense with the APC extension, no longer supported, it does not make sense with the APCu extension.
The feed passes validation, but there is just an article that has been created in the past three months and three weeks. The other articles would not be shown on Planet Drupal because they are too old.
Only jaypan can add/remove maintainers/co-maintainers. I will contact him around 10 AM my time. (It is midnight right now, for me.)
The report shows warnings/errors for 37 files, but the merge request changes more files.
avpaderno → changed the visibility of the branch 3359279-gitlab-ci-reports to hidden.
avpaderno → changed the visibility of the branch 3359279-fixes to hidden.
avpaderno → made their first commit to this issue’s fork.