- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:38am 22 March 2023 - First commit to issue fork.
- Merge request !2Issue #3349518: Drupal Coding Standards Issues | phpcs ā (Open) created by Unnamed author
- Status changed to Needs work
over 1 year ago 7:43am 22 March 2023 - š®š³India hardikpandya
RTBC for the patch provided by @samit.310@gmail.com. The MR removes the comment entirely which is inappropriate and hence marking this as Needs Work.
- š®š³India rassoni Bangalore
@hardikpandya I have removed the code because the code is commented.
Commented out code should be simply removed.
PHPCS throw commented code issue which is unnecessary.
- Status changed to Needs review
over 1 year ago 4:23pm 22 March 2023 - š®š¹Italy apaderno Brescia, š®š¹
The MR is correct: Commented out code should be removed, except in the case the code is planned to be re-added, but in that case there should be a
@todo
comment saying that. - Status changed to Needs work
3 months ago 7:14am 20 August 2024 Hi @Rassoni,
I have applied the changes you committed on MR!2, some errors were still reported. Please see below:
ā content_moderation_node_grants git:(1.0.x) curl https://git.drupalcode.org/project/content_moderation_node_grants/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 881 0 881 0 0 3029 0 --:--:-- --:--:-- --:--:-- 3157 patching file src/Plugin/views/filter/UpdatableFilter.php ā content_moderation_node_grants git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig content_moderation_node_grants FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/content_moderation_node_grants/content_moderation_node_grants.module --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/content_moderation_node_grants/content_moderation_node_grants.node_grants.inc ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------ 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Session\AccountInterface. ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ Time: 224ms; Memory: 10MB
Kindly check
Thanks,
JakeThanks for looking into the issue.
Can the @todo comment be left in for future reference?
- Merge request !4Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3349518-gitlab-ci-reports to hidden.
- Status changed to Needs review
3 months ago 7:32pm 20 August 2024