#Coding standards

As a bonus, I have corrected the spelling error (UK -> US) so that job is green now.

I'm happy to help with setting up the phpcs.xml file if you want, depending on your views of the two points in #5

But I will let someone else write the proper short descriptions of the classes, someone who knows about this project. Over to you ...

The reason for the reduced number of faults compared to the output shown in the issue summary are due to two things:

1. The DrupalPractice standard is not included by default in the gitlab pipeline phpcs job. Only the Drupal set of rules is used. If you would like the pipeline job to check against best practices, then the way to do this is to have a phpcs.xml.dist file in the project folder, and to specify both sets of standards. Here is an example
2. The reason that the long lines in README are not reported is that .md files are not included by default. Again this can be changed by adding 'md' as an extension, see this example

Automatically closed - issue fixed for 2 weeks with no activity.

I don't see any PHCS issues in the gitlab pipelines, I'll close this down

dejan0 → changed the visibility of the branch 3373541-fix-the-issues to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

shyam-sawhney → changed the visibility of the branch 3373541-fix-the-issues to active.

Starting point, the pipeline phpcs summary shows

--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[ ] Drupal.Commenting.ClassComment.Short                                   15
[x] SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null  7
[x] SlevomatCodingStandard.PHP.ShortList.LongListUsed                      1
--------------------------------------------------------------------------------
A TOTAL OF 23 SNIFF VIOLATIONS WERE FOUND IN 3 SOURCES

Initial push on MR4 now has

----------------------------------------------------------------------
SOURCE                                                           COUNT
----------------------------------------------------------------------
Drupal.Commenting.ClassComment.Short                             15
----------------------------------------------------------------------
A TOTAL OF 15 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE
----------------------------------------------------------------------

I will work on this more tomorrow.

flashwebcenter → closed merge request !13

Thanks for everyone that was involved, sorry for the delay. I merged the PR and will work on the Drupal 11 support https://www.drupal.org/project/config_token/issues/3505745 💬 Drupal 11 version Active

Work is not needed, the line is a duplicate.

This is now partially outdated, in the sense that annotations are deprecated in PHPUnit 10 in favor of PHP attributes, and there is no one to one mapping in all cases.

See https://github.com/sebastianbergmann/phpunit/issues/4502

I think the standard should still exist, and the usecase in the IS should nowadays be an enum, which already doesn't require comments on each property.

I think we can close this as won't fix, given the lack of interest on this issue in the past 11 years.

Is there interest in changing the standard?

This appears to be removing one assertion entirely instead of updating it to not use t().

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Converting to new issue template

I've been thinking this should be discussed in Coding Standards to find a resolution. There are two existing issues about inheritdoc and I picked one of those.

Automatically closed - issue fixed for 2 weeks with no activity.

  *   - "create".
   *   - "update".
   *   - "delete".

We sure this is an improvement? Seems odd to have periods after a single word.

This is reducing type accuracy as mentioned by @mstrelan, but mixing inheritdoc and documentation is not allowed. What's the best way forward here?

Used the script provided and believe all instances have been found.

Automatically closed - issue fixed for 2 weeks with no activity.

LGTM, thanks

Automatically closed - issue fixed for 2 weeks with no activity.

andresalvarez → closed merge request !176

Thank you for providing an issue fork that includes the intended fixes. If you are finished with your work could you please create a merge request from the changes, set the status to "needs review" and set the "assigned" field to "Unassigned"? Thank you.

Merged in 2.0.x

trackleft2 → changed the visibility of the branch 8.x-1.x to hidden.

trackleft2 → changed the visibility of the branch 3450457-fix-coding-standards to hidden.

Add commit with standard code enhancement

Automatically closed - issue fixed for 2 weeks with no activity.