#Coding standards

Rebase and change in EntityDefinitionUpdateMultipleTypesTest.php

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Since patches are no longer tested, a merge request must be provided.

All looks good and it was RTBC before that last change, so setting that again now.

I wonder how long you will have to keep rebasing this MR before it gets committed. This really is 'low hanging fruit' and the simplest of changes, so hopefully a Core maintainer will pick this up and merge it?

Another rebase and new failure in ThemeSettingsForm

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This is now merged
thanks

No PHP_CodeSniffer error/warning has been reported by GitLab CI before doing any change.

avpaderno → changed the visibility of the branch 3358998-gitlab-ci-reports to hidden.

avpaderno → changed the visibility of the branch 3358998-dev to hidden.

avpaderno → changed the visibility of the branch 3349221-gitlab-ci-reports to hidden.

Reviewed last commit https://git.drupalcode.org/project/drupal/-/merge_requests/11510/diffs?c... and seem fine

Thank you all for your work on this, unfortunately the work here is outdated and has been handled is separate issues elsewhere including:

• 📌 Fix ESLint Errors following Drupal coding standards and best practices Active
• 🐛 Coding standards and best practices Active

If you have time, we could use your review the following issues if still open when you read this.

1. 📌 Delete unused color.js file and remove from library definitions. Active
2. 📌 Fix stylelint issues. Active

longwave → closed merge request !11518

Let's ship this before it needs yet another reroll.

Committed f0f2901 and pushed to 11.x. Thanks!

Try this again lol, additional changes seem fine. Restoring status