#Coding standards

Changing this to fixing the violations that are currently ignored by // phpcs:ignore Drupal.NamingConventions.ValidVariableName.LowerCamelName

No longer postponed. I rebased onto 11.x

📌 add gitlabci Active

Automatically closed - issue fixed for 2 weeks with no activity.

Seems straight forward to me and non disruptive

Thanks folks - marking this as a duplicate of 📌 Add gitlabci Active

Not transferring credit because I don't give credit for PHPCS issues for those who already have such credits, these are great first issues, but not for established contributors.

zenphp → closed merge request !11

Hi @nilesh.addweb,

I applied MR!2, it was applied smoothly and fixed the phpcs issue in comment #9.

➜  cache_control_headers git:(1.0.x) curl https://git.drupalcode.org/project/cache_control_headers/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1699    0  1699    0     0   2380      0 --:--:-- --:--:-- --:--:--  2379
patching file README.md
patching file src/EventSubscriber/CacheControlResponseSubscriber.php
➜  cache_control_headers git:(1.0.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cache_control_headers
➜  contrib

I will now move the status to Reviewed and tested by the community
Thank you.

Hi @clarkssquared,

Thanks for the review! The patch has been applied cleanly. Let's wait for the other users to review it.

curl https://git.drupalcode.org/project/webform_simplify/-/merge_requests/15.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 42403    0 42403    0     0  76127      0 --:--:-- --:--:-- --:--:-- 76127
Checking patch js/settings_form.js...
Checking patch src/Annotation/WebformSimplifyElement.php...
Checking patch src/EventSubscriber/WebformRouteSubscriber.php...
Checking patch src/Form/WebformSimplifySettingsForm.php...
.
.
.
Applied patch js/settings_form.js cleanly.
Applied patch src/Annotation/WebformSimplifyElement.php cleanly.
Applied patch src/EventSubscriber/WebformRouteSubscriber.php cleanly.
Applied patch src/Form/WebformSimplifySettingsForm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/BooleanBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkboxes.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ContainerBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Date.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Defaults.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Email.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Fieldset.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Hidden.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ManagedFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Number.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/NumericBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/OptionsBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ProcessedText.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Radios.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Search.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Select.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Telephone.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextField.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Textarea.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Url.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformActions.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAddress.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAudioFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAutocomplete.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCompositeBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformDocumentFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformFlexbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformImageFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkup.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkupBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformName.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformRadiosOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSelectOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformVideoFile.php cleanly.
Applied patch src/WebformElementAlter.php cleanly.
Applied patch src/WebformSettingsAlter.php cleanly.
Applied patch src/WebformSimplifyElementManager.php cleanly.
Applied patch webform_simplify.install cleanly.
Applied patch webform_simplify.module cleanly.

I applied the MR !15 but it skipped

➜  webform_simplify git:(main) ✗ curl https://git.drupalcode.org/project/webform_simplify/-/merge_requests/15.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 42403    0 42403    0     0  58096      0 --:--:-- --:--:-- --:--:-- 58567
Skipped patch 'js/settings_form.js'.
Skipped patch 'src/Annotation/WebformSimplifyElement.php'.
Skipped patch 'src/EventSubscriber/WebformRouteSubscriber.php'.
Skipped patch 'src/Form/WebformSimplifySettingsForm.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/BooleanBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Checkbox.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Checkboxes.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ContainerBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Date.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/DateBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/DateTime.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Defaults.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Email.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Fieldset.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Hidden.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ManagedFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Number.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/NumericBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/OptionsBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ProcessedText.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Radios.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Search.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Select.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Telephone.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/TextBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/TextField.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Textarea.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Url.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformActions.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAddress.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAudioFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAutocomplete.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformCompositeBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformDocumentFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformFlexbox.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformImageFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformMarkup.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformMarkupBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformName.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformRadiosOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformSelectOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformTime.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformVideoFile.php'.
Skipped patch 'src/WebformElementAlter.php'.
Skipped patch 'src/WebformSettingsAlter.php'.
Skipped patch 'src/WebformSimplifyElementManager.php'.
Skipped patch 'webform_simplify.install'.
Skipped patch 'webform_simplify.module'.
➜  webform_simplify git:(main) ✗ 

Closing out was 100% correct.

These type of tickets are well known to be seen as credit farming issues. Most of the users here have been told about this before so I have informed the DA so a member should be reaching out. My recommendation for all is to take a pause on contribution, read up on the policy around good vs bad contribution and go from there.

At this time I am asking that members of “AddWeb Solution Pvt. Ltd” and “cmsMinds” avoid modules from our company until such adjustments have been made.

Thanks

In reviewing my current codebase, I can't seem to get drupal/coder 8.3.24 due to the following dependency chain:

• drush/drush requires chi-teck/drupal-code-generator:^3.0, which installs v3.2 (at the time of this writing)
• chi-teck/drupal-code-generator 3.2 requires drupal/coder:3.2.23

I have Drush 12.5.2 installed which, at the time of this writing, is the latest version. I'm currently running Drupal 10.3.

Can somebody advise me on how to update? Alternatively I could update my phpcs.dist.xml file to reference globally installed drupal/coder sniffs as well, where I have 8.3.24 installed. However, that doesn't seem like the best approach and is less portable if other devs working on the same project don't also have the sniffs installed globally in the same location as me.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

avpaderno → changed the visibility of the branch 3372800-gitlab-ci-reports to hidden.

avpaderno → changed the visibility of the branch 3372800-phpcs to hidden.

avpaderno → changed the visibility of the branch 3358836-gitlab-ci-reports to hidden.

The issue fork is 15 commits behind the upstream repository.

MR !4 fixes the PHP_CodeSniffer errors/warnings reported by GitLab CI.

avpaderno → changed the visibility of the branch 3353332-fix-the-issues to hidden.

Let's create a merge request, now that patches are no longer tested.

Automatically closed - issue fixed for 2 weeks with no activity.

That means the status is still Needs work.

avpaderno → changed the visibility of the branch 3355535-gitlab-ci-reports to hidden.

Let's create a merge request, now that patches are no longer tested.

MR !1 fixed all the PHP_CodeSniffer errors/warnings.

Let's create a merge request, now that patches are no longer tested.

@abhiyanshu, I just completed applying multiple changes to the project, and released a new alpha9 version. If you are still willing to run the task on this issue queue, you can grab the latest version just released, run phpcs again and apply the suggested fixes. Let me know if you are willing to do that. I can also go over this task. Many thanks!

I tried the patch but it is failing from my end. Please review it.

<stdin>:20: trailing whitespace.
I hope you love Font Awesome. If you've found it useful, 
<stdin>:22: trailing whitespace.
Fort Awesome (https://fortawesome.com). 
<stdin>:23: trailing whitespace.
It makes it easy to put the perfect icons on your website. 
<stdin>:82: trailing whitespace.
<!-- End footer Section -->  
<stdin>:93: trailing whitespace.
<!-- End footer Section -->  
Checking patch config/install/yg_photography.settings.yml...
error: while searching for:

#banner Section For User pages and Not found pages
banner_image: 'themes/yg_flexy/top-banner.jpg'





error: patch failed: config/install/yg_photography.settings.yml:8
error: config/install/yg_photography.settings.yml: patch does not apply
Checking patch css/font-awesome/HELP-US-OUT.txt...
Checking patch templates/block/block--system-branding-block.html.twig...
Checking patch templates/block/instagram-without-api-image.html.twig...
Checking patch templates/field--entity-reference-revisions.html.twig...
Checking patch templates/layout/html.html.twig...
Checking patch templates/layout/page--401.html.twig...
Hunk #1 succeeded at 73 (offset -5 lines).
Checking patch templates/layout/page--403.html.twig...
Hunk #1 succeeded at 133 (offset -5 lines).
Checking patch templates/layout/page--404.html.twig...
Hunk #1 succeeded at 133 (offset -8 lines).
Checking patch templates/layout/page.html.twig...
Hunk #1 succeeded at 56 (offset -7 lines).
Checking patch templates/paragraph/paragraph--about_me.html.twig...
Checking patch templates/paragraph/paragraph--about_me_page.html.twig...
Checking patch templates/paragraph/paragraph--about_us.html.twig...
Checking patch templates/paragraph/paragraph--banner.html.twig...
Checking patch templates/paragraph/paragraph--client_testimonials.html.twig...
Checking patch templates/paragraph/paragraph--contact.html.twig...
Checking patch templates/paragraph/paragraph--contact_details.html.twig...
Checking patch templates/paragraph/paragraph--counter.html.twig...
Checking patch templates/paragraph/paragraph--counters.html.twig...
Checking patch templates/paragraph/paragraph--our_team.html.twig...
Checking patch templates/paragraph/paragraph--portfolio.html.twig...
Checking patch templates/paragraph/paragraph--team_member.html.twig...
Checking patch templates/user-login-form.html.twig...
Checking patch templates/views/views-view-fields--client_testimonials.html.twig...
Checking patch templates/views/views-view-fields--portfolio.html.twig...
Checking patch templates/views/views-view-fields--portfolio_tags.html.twig...
Checking patch templates/views/views-view-fields--sliders.html.twig...
Checking patch templates/views/views-view-unformatted--client_testimonials.html.twig...
Checking patch templates/views/views-view-unformatted--portfolio_tags.html.twig...
Checking patch templates/views/views-view-unformatted--sliders.html.twig...
Checking patch yg_photography.info.yml...
warning: yg_photography.info.yml has type 100644, expected 100755
error: while searching for:

libraries:
  - yg_photography/global-styling



error: patch failed: yg_photography.info.yml:15
error: yg_photography.info.yml: patch does not apply
Checking patch yg_photography.theme...
error: while searching for:
<?php
use Drupal\Component\Utility\Xss;
use Drupal\Core\Template\Attribute;
use Drupal\Component\Utility\SafeMarkup;
use Drupal\Core\Database\Database;
use Drupal\file\Plugin\Core\Entity\FileInterface;
use Drupal\user\Entity\User;

/**
 * Implements hook_preprocess_html().
 */
function yg_photography_preprocess_html(&$variables) {
  $node=\Drupal::routeMatch()->getParameter('node');
  if($node){
     if ($node == "slider") {
      $variables['head_title']['title'] = "Page Not Found";
    }   
  }
  foreach ($variables['user']->getRoles() as $role) {
     $variables['attributes']['class'][] = 'role-' . $role;
   }
  
}

/**
 * Implements hook_preprocess_page().
 */
function yg_photography_preprocess_page(&$variables) {
  // header Section variables
  $variables['twitter'] = theme_get_setting('twitter');
  $variables['facebook'] = theme_get_setting('facebook');
  $variables['instagram'] = theme_get_setting('instagram');
  $variables['pinterest'] = theme_get_setting('pinterest');
  $variables['vimeo'] = theme_get_setting('vimeo');
 
  // Bannner Image Settings
   $fid = theme_get_setting('banner_image');
   if(is_array($fid)){
    $query = \Drupal::database()->select('file_managed', 'm');
      $query->fields('m', ['filename','uri']);
      $query->condition('fid',$fid[0]);
      $results = $query->execute()->fetchAll();
    foreach($results as $data){
      $uri=$data->uri;
    }
    $variables['banner_image']=file_create_url($uri);
   }
   else{
    $path=base_path().$fid;
    $variables['banner_image']=$path;
   }
   
}


/**
 * Implements hook_preprocess_menu().
 */
function yg_photography_preprocess_menu(&$variables, $hook) {
  if ($hook == 'menu__main') { // We're doing that for main menu.
    // Get the current path.
    $current_path = \Drupal::request()->getRequestUri();
    $items = $variables['items'];

error: patch failed: yg_photography.theme:1
error: yg_photography.theme: patch does not apply

@tzatziki Could you please look into this MR?

Hi,
I've tested MR !3 on Drupal 10.3.x.

The MR is applied Cleanly...

Test Result:
The phpcs issues were fixed after the updated changes.

RTBC+1

Thanks!

Hi, patch was applied cleanly.

curl https://git.drupalcode.org/project/ckeditor5_dark_mode/-/merge_requests/1.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6314    0  6314    0     0  11343      0 --:--:-- --:--:-- --:--:-- 11846
Checking patch README.md...
Checking patch css/dark.css...
Applied patch README.md cleanly.
Applied patch css/dark.css cleanly.

Tested with phpcs after applying patch, did not encounter any errors.

I have updated MR !2 and fixed phpcs issue mention in #9. Please review it.

Hi,
I have fixed issues mention in #4 and committed changes. Please review it.

nilesh.addweb → made their first commit to this issue’s fork.

Hi, I can confirm that provided MR!1 resolves the phpcs issues successfully. Getting no phpcs errors after applying this MR. RTBC+1

nilesh.addweb → made their first commit to this issue’s fork.

Closing in favor of 🐛 Fix issues reported by phpcs. RTBC .

Thanks a lot for great help!

Hi @Deepthi kumari,

I applied the patch you provided, it was applied successfully, however, there are still errors that were reported. Please see below:

tideways git:(8.x-1.x) curl https://www.drupal.org/files/issues/2020-03-12/tideways-codingstandard-2885376-4.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9030  100  9030    0     0  29420      0 --:--:-- --:--:-- --:--:-- 30506
patching file src/Install.php
patching file src/StackMiddleWare/Tideways.php
patching file tideways.services.yml
➜  tideways git:(8.x-1.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig tideways

FILE: ...site/drupal-orgissue-v9/web/modules/contrib/tideways/tideways.services.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...Demo-site/drupal-orgissue-v9/web/modules/contrib/tideways/tideways.install
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 10 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced
    |       |     with use statements
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/tideways/tideways.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
 1 | WARNING | [ ] "core_version_requirement" property is missing in the
   |         |     info.yml file
 5 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../Demo-site/drupal-orgissue-v9/web/modules/contrib/tideways/src/Install.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first
    |         |     wrong one is
    |         |     Drupal\Core\StringTranslation\StringTranslationTrait.
 10 | WARNING | [ ] The class short comment should describe what the class does
    |         |     and not simply repeat the class name
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-orgissue-v9/web/modules/contrib/tideways/src/StackMiddleWare/Tideways.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Site\Settings.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 160ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @Diego_Mow,

Both patches you applied was applied unsuccessfully and both patches resulted to multiple errors. Please see below:

With md patch:

cloudflare git:(8.x-1.x) curl https://www.drupal.org/files/issues/2021-06-20/3017018-5--with-md-changes.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 28235  100 28235    0     0  87211      0 --:--:-- --:--:-- --:--:-- 91080
patching file README.md
Hunk #2 FAILED at 29.
Hunk #3 succeeded at 50 with fuzz 1 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file README.md.rej
patching file cloudflare.install
Hunk #1 succeeded at 48 (offset -7 lines).
Hunk #2 succeeded at 60 (offset -7 lines).
patching file docs/disclaimers.md
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 20 (offset -4 lines).
1 out of 2 hunks FAILED -- saving rejects to file docs/disclaimers.md.rej
patching file docs/enterprise_setup.md
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file docs/enterprise_setup.md.rej
patching file docs/freetier_setup.md
Hunk #1 FAILED at 2.
Hunk #2 succeeded at 16 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file docs/freetier_setup.md.rej
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/ApiRateLimitCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 succeeded at 81 (offset 2 lines).
Hunk #2 succeeded at 98 with fuzz 2 (offset 2 lines).
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/ComposerDependenciesCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/CredentialCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/DailyTagPurgeLimitCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 succeeded at 83 with fuzz 2 (offset 3 lines).
Hunk #2 succeeded at 102 with fuzz 2 (offset 5 lines).
can't find file to patch at input line 327
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/EventSubscriber/ClientIpRestore.php b/src/EventSubscriber/ClientIpRestore.php
|index 197beb0..0ea33c7 100644
|--- a/src/EventSubscriber/ClientIpRestore.php
|+++ b/src/EventSubscriber/ClientIpRestore.php
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
4 out of 4 hunks ignored
patching file src/Form/SettingsForm.php
Hunk #1 succeeded at 18 with fuzz 1 (offset -2 lines).
patching file src/Form/ZoneSelectionForm.php
Hunk #1 succeeded at 14 (offset -2 lines).
Hunk #2 FAILED at 239.
1 out of 2 hunks FAILED -- saving rejects to file src/Form/ZoneSelectionForm.php.rej
patching file src/State.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #2 succeeded at 56 with fuzz 2 (offset 8 lines).
Hunk #3 succeeded at 81 (offset 3 lines).
patching file tests/src/Functional/CloudFlareAdminSettingsFormTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Functional/CloudFlareAdminSettingsInvalidFormTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Functional/ComposerDependencyTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Unit/ClientIpRestoreTest.php
Hunk #1 FAILED at 23.
Hunk #2 FAILED at 89.
2 out of 2 hunks FAILED -- saving rejects to file tests/src/Unit/ClientIpRestoreTest.php.rej
patching file tests/src/Unit/StateTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #2 succeeded at 67 with fuzz 1 (offset 3 lines).
Hunk #3 succeeded at 104 (offset 6 lines).
Hunk #4 succeeded at 138 (offset 6 lines).

Without md patch:

cloudflare git:(8.x-1.x) ✗ curl https://www.drupal.org/files/issues/2021-06-20/3017018-5--without-md-changes.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16901  100 16901    0     0  51848      0 --:--:-- --:--:-- --:--:-- 53147
patching file cloudflare.install
Hunk #1 succeeded at 48 (offset -7 lines).
Hunk #2 succeeded at 60 (offset -7 lines).
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/ApiRateLimitCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 succeeded at 81 (offset 2 lines).
Hunk #2 succeeded at 98 with fuzz 2 (offset 2 lines).
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/ComposerDependenciesCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 63.
1 out of 1 hunk FAILED -- saving rejects to file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/ComposerDependenciesCheck.php.rej
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/CredentialCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file modules/cloudflarepurger/src/Plugin/Purge/DiagnosticCheck/DailyTagPurgeLimitCheck.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 succeeded at 83 with fuzz 2 (offset 3 lines).
Hunk #2 succeeded at 102 with fuzz 2 (offset 5 lines).
can't find file to patch at input line 144
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/EventSubscriber/ClientIpRestore.php b/src/EventSubscriber/ClientIpRestore.php
|index 197beb0..0ea33c7 100644
|--- a/src/EventSubscriber/ClientIpRestore.php
|+++ b/src/EventSubscriber/ClientIpRestore.php
--------------------------
File to patch: y
y: No such file or directory
Skip this patch? [y] y
Skipping patch.
4 out of 4 hunks ignored
patching file src/Form/SettingsForm.php
Hunk #1 succeeded at 18 with fuzz 1 (offset -2 lines).
patching file src/Form/ZoneSelectionForm.php
Hunk #1 succeeded at 14 (offset -2 lines).
Hunk #2 FAILED at 239.
1 out of 2 hunks FAILED -- saving rejects to file src/Form/ZoneSelectionForm.php.rej
patching file src/State.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #2 succeeded at 56 with fuzz 2 (offset 8 lines).
Hunk #3 succeeded at 81 (offset 3 lines).
patching file tests/src/Functional/CloudFlareAdminSettingsFormTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Functional/CloudFlareAdminSettingsInvalidFormTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Functional/ComposerDependencyTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tests/src/Unit/ClientIpRestoreTest.php
Hunk #1 FAILED at 23.
Hunk #2 FAILED at 89.
2 out of 2 hunks FAILED -- saving rejects to file tests/src/Unit/ClientIpRestoreTest.php.rej
patching file tests/src/Unit/StateTest.php
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #2 succeeded at 67 with fuzz 1 (offset 3 lines).
Hunk #3 succeeded at 104 (offset 6 lines).
Hunk #4 succeeded at 138 (offset 6 lines).

Kindly check

Thanks,
Jake

Hi @atul_ghate,

The changes you committed on MR !1 was applied not-so successfully, but it fixed all errors.

markdown_field_formatter git:(1.0.0-beta1) curl https://git.drupalcode.org/project/markdown_field_formatter/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3664    0  3664    0     0  10441      0 --:--:-- --:--:-- --:--:-- 10682
patching file markdown_field_formatter.info.yml
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file markdown_field_formatter.info.yml.rej
patching file src/Plugin/Field/FieldFormatter/MarkdownFileFormatter.php
➜  markdown_field_formatter git:(1.0.0-beta1) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig markdown_field_formatter
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @chaitanyadessai,

The patch you provided did fix the errors.

readmore_extrafield git:(3.1.x) ✗ curl https://www.drupal.org/files/issues/2024-07-23/3348047-8.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1603  100  1603    0     0   6515      0 --:--:-- --:--:-- --:--:--  6735
patching file src/Plugin/ExtraField/Display/ReadmoreExtrafield.php
patching file tests/src/FunctionalJavascript/ReadMoreExtraFieldFunctionalJavascriptTest.php
➜  readmore_extrafield git:(3.1.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig readmore_extrafield
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

smulvih2 → closed merge request !2

Committed and attributed!

Thanks for all your work on this! Merged wth 1.0.x-dev and will be included in next release.

Hi @silvi.addweb,

I applied patch #5, it was applied smoothly and fixed some of the phpcs issues.

However, I still encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  file_browser git:(8.x-1.x) curl https://www.drupal.org/files/issues/2024-06-04/file_browser-33710580-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6662  100  6662    0     0   8791      0 --:--:-- --:--:-- --:--:--  8788
patching file file_browser.install
patching file file_browser.module
patching file src/Plugin/Block/ImageEmbedBlock.php
patching file src/Plugin/views/field/FileBrowserPreview.php
patching file tests/src/Functional/InstallTest.php
➜  file_browser git:(8.x-1.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml file_browser

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/file_browser/tests/src/Functional/InstallTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 22 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
-------------------------------------------------------------------------------------------------------------------------------------------------

Time: 316ms; Memory: 12MB

➜  contrib

Thank you.

Hi @dineshkumarbollu,

I applied patch #2 but encountered some errors.

➜  workbench_notifier git:(8.x-1.x) curl https://www.drupal.org/files/issues/2023-04-14/codingstandards-2.patch | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10400  100 10400    0     0  59503      0 --:--:-- --:--:-- --:--:-- 59770
Checking patch README.md...
error: README.md: No such file or directory
Checking patch src/EventSubscriber/StateTransitionSubscriber.php...
Checking patch src/Form/WorkbenchNotifierConfigurationForm.php...
Checking patch workbench_notifier.info.yml...
➜  workbench_notifier git:(8.x-1.x) ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml workbench_notifier

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/workbench_notifier/workbench_notifier.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
  1 | WARNING | "core_version_requirement" property is missing in the info.yml file
  9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/workbench_notifier/src/Form/WorkbenchNotifierConfigurationForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 19 WARNINGS AFFECTING 18 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   8 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\Entity\Role.
  38 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  39 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  40 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  44 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  49 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  49 | WARNING | [ ] Only string literals should be passed to t() where possible
  54 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  54 | WARNING | [ ] Only string literals should be passed to t() where possible
  64 | WARNING | [x] A comma should follow the last multiline array item. Found: 'workbench_notifier_transitions'
  89 | WARNING | [ ] Only string literals should be passed to t() where possible
 125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 138 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 147 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 164 | WARNING | [ ] Role::loadMultiple calls should be avoided in classes, use dependency injection instead
 181 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 182 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 192 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 204 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 221 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/workbench_notifier/src/EventSubscriber/StateTransitionSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 6 WARNINGS AFFECTING 13 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------
   6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\workbench_moderation\Event\WorkbenchModerationEvents.
   7 | WARNING | [x] Unused use statement
   8 | WARNING | [x] Unused use statement
   9 | WARNING | [x] Unused use statement
  21 | ERROR   | [x] Visibility must be declared on method "getSubscribedEvents"
  44 | ERROR   | [ ] Missing parameter type
  46 | ERROR   | [ ] Missing parameter type
  48 | ERROR   | [ ] Missing parameter type
  50 | ERROR   | [ ] Missing parameter type
  52 | ERROR   | [ ] Missing parameter type
  59 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  84 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 114 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 179ms; Memory: 10MB

➜  contrib

Please check and advise.

Thank you.

Hi @bhaveshdas,

I tried to apply MR35 but encountered an error.

➜  colorbox git:(2.0.2) ✗ curl https://git.drupalcode.org/project/colorbox/-/merge_requests/35.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 25376    0 25376    0     0  33424      0 --:--:-- --:--:-- --:--:-- 33389
Checking patch colorbox.post_update.php...
error: while searching for:
 * Post-update functions for Colorbox.
 */

use Drupal\Core\Entity\Entity\EntityViewDisplay;
use Drupal\Core\Entity\Entity\EntityFormDisplay;

/**
 * Saves the image style dependencies into form and view display entities.

error: patch failed: colorbox.post_update.php:5
error: colorbox.post_update.php: patch does not apply
Checking patch colorbox.theme.inc...
error: while searching for:
 * Colorbox theme functions.
 */

use Drupal\Component\Utility\Crypt;
use Drupal\file\Entity\File;
use Drupal\image\Entity\ImageStyle;
use Drupal\Component\Utility\Xss;
use Drupal\responsive_image\Entity\ResponsiveImageStyle;

/**
 * Prepares variables for colorbox formatter templates.

error: patch failed: colorbox.theme.inc:5
error: colorbox.theme.inc: patch does not apply
Checking patch js/colorbox.js...
error: while searching for:
      };

      $(once('init-colorbox', '.colorbox', context))
        .each(function() {
        // Only images are supported for the "colorbox" class.
        // The "photo" setting forces the href attribute to be treated as an image.
        var extendParams = {
          photo: true
        };
        // If a title attribute is supplied, sanitize it.
        var title = $(this).attr('title');

error: patch failed: js/colorbox.js:27
error: js/colorbox.js: patch does not apply
Checking patch src/ColorboxAttachment.php...
error: while searching for:

namespace Drupal\colorbox;

use Drupal\Core\Extension\ModuleHandlerInterface;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Installer\InstallerKernel;
use Drupal\Core\StringTranslation\StringTranslationTrait;


error: patch failed: src/ColorboxAttachment.php:2
error: src/ColorboxAttachment.php: patch does not apply
Checking patch src/Form/ColorboxSettingsForm.php...
error: while searching for:

use Drupal\Core\Asset\LibraryDiscoveryInterface;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;
use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\Core\Extension\ModuleExtensionList;

/**
 * General configuration form for controlling the colorbox behaviour..

error: patch failed: src/Form/ColorboxSettingsForm.php:4
error: src/Form/ColorboxSettingsForm.php: patch does not apply
Checking patch src/Plugin/Field/FieldFormatter/ColorboxFormatter.php...
error: while searching for:

namespace Drupal\colorbox\Plugin\Field\FieldFormatter;

use Drupal\Core\Asset\LibraryDiscoveryInterface;
use Drupal\Core\Entity\EntityStorageInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;
use Drupal\Core\Field\FieldItemListInterface;
use Drupal\Core\Field\FieldDefinitionInterface;
use Drupal\Core\Link;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Session\AccountInterface;
use Drupal\Core\Url;
use Drupal\image\Entity\ImageStyle;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Cache\Cache;
use Drupal\colorbox\ElementAttachmentInterface;
use Drupal\image\Plugin\Field\FieldFormatter\ImageFormatterBase;

/**
 * Plugin implementation of the 'colorbox' formatter.

error: patch failed: src/Plugin/Field/FieldFormatter/ColorboxFormatter.php:2
error: src/Plugin/Field/FieldFormatter/ColorboxFormatter.php: patch does not apply
Checking patch src/Plugin/Field/FieldFormatter/ColorboxResponsiveFormatter.php...
error: src/Plugin/Field/FieldFormatter/ColorboxResponsiveFormatter.php: No such file or directory
Checking patch styles/default/colorbox_style.js...
Checking patch styles/plain/colorbox_style.js...
Checking patch styles/stockholmsyndrome/colorbox_style.js...
Checking patch templates/colorbox-responsive-formatter.html.twig...
error: templates/colorbox-responsive-formatter.html.twig: No such file or directory
➜  colorbox git:(2.0.2) ✗

Please check and advise.
Thank you

Hi,

Please Review MR!1. Thank you.

atul_ghate → made their first commit to this issue’s fork.

Hi @Sourav_Paul,

I applied MR!1 and it was applied smoothly. However, I still encountered some issues after I ran

</code>.

<code>➜  ckeditor5_dark_mode git:(1.0.0) curl https://git.drupalcode.org/project/ckeditor5_dark_mode/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2045    0  2045    0     0   4789      0 --:--:-- --:--:-- --:--:--  4789
patching file README.md
patching file css/dark.css
➜  ckeditor5_dark_mode git:(1.0.0) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor5_dark_mode

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/ckeditor5_dark_mode/css/dark.css
-----------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------
 104 | ERROR | [x] Selectors must be on a single line
 105 | ERROR | [x] Blank lines are not allowed between class names
 106 | ERROR | [ ] Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

Time: 125ms; Memory: 10MB

➜  contrib

Thank you.

Hi,

I fixed the remaining phpcs issues.

Please review. Thank you.

@tzatziki Kindly review changes & merge it..

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

I have tested MR 1 and it is working properly with no errors found.
I will move it forward to RTBC.

RTBC+1

Thankyou !!

Hi,

Please review MR!1. Thank you.

Hi @avpaderno,

I have addressed some of your reviews.

Please check and advise. Thank you.

Committed! Thank you! 🍻

phpcs is green

Hello,

I have fixed all the above mentioned errors and warnings. Please check.

I mean:

$array = ['foo', 'bar'];

[$foo, $bar] = $array;

See https://stitcher.io/blog/array-destructuring-with-list-in-php

@a.aaronjake please review.

At the recent coding standards meeting mstrelan reported that 'we need to use attributes' and not annotations. See the meeting issue for the full discussion, #3458726: Coding Standards Meeting Tuesday 2024-07-16 2100 UTC →

The suggestion was that our docs should point to PHPUnit docs. I currently disagree with that because of the '@group'. There is no documentation to explain how that is used in Drupal. Sometimes it is upper case and sometime it is not. That should be made clear to developers.

Extra examples are usually beneficial so I added that. I don't think it necessary to do more because the style and spacing doesn't change.

I have applied the patch cleanly, and the above errors are resolved.
Please check the Screenshots for the same.

atul_ghate → made their first commit to this issue’s fork.

Hi @dineshkumarbollu @Manoj Raj.r,

Applied the patch @dineshkumarbollu provided, it was applied successfully but there still errors reported. Please see below:

livechat git:(8.x-3.x) curl https://www.drupal.org/files/issues/2023-04-18/codingstandards-3354770-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5487  100  5487    0     0  31074      0 --:--:-- --:--:-- --:--:-- 38104
patching file README.md
patching file config/install/livechat.settings.yml
patching file config/schema/livechat.schema.yml
patching file css/livechat.css
patching file livechat.info.yml
patching file src/Controller/LivechatController.php
patching file src/Form/HideLiveChatSettingsForm.php
➜  livechat git:(8.x-3.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig livechat

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 51 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Controller/LivechatController.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\JsonResponse.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 261ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @dineshkomarbollu,

The latest changes you committed on MR !5 was patched not-so successfully, few errors were still reported. Please see below:

system_tags git:(2.0.1) curl https://git.drupalcode.org/project/system_tags/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17469    0 17469    0     0  29792      0 --:--:-- --:--:-- --:--:-- 30328
patching file README.md
patching file modules/theme/system_tags_theme.module
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file src/Annotation/SystemTagFinder.php
patching file src/Config/SystemPageConfigOverrider.php
patching file src/Config/SystemTagDefinitions.php
patching file src/Entity/SystemTag.php
patching file src/Entity/SystemTagInterface.php
patching file src/Form/SystemTagDeleteForm.php
patching file src/Form/SystemTagForm.php
patching file src/Plugin/Condition/SystemTags.php
patching file src/Plugin/SystemTagFinder/SystemTagBlockFinder.php
patching file src/Plugin/SystemTagFinder/SystemTagNodeFinder.php
patching file src/SystemTagAccessControlHandler.php
patching file src/SystemTagFinder/SystemTagFinderInterface.php
patching file src/SystemTagFinder/SystemTagFinderManager.php
patching file src/SystemTagFinder/SystemTagFinderManagerInterface.php
patching file src/SystemTagFinder/SystemTagFinderPluginBase.php
Hunk #2 FAILED at 95.
Hunk #3 FAILED at 106.
2 out of 3 hunks FAILED -- saving rejects to file src/SystemTagFinder/SystemTagFinderPluginBase.php.rej
patching file src/SystemTagHelper.php
patching file src/SystemTagHelperInterface.php
patching file src/SystemTagHtmlRouteProvider.php
patching file src/SystemTagListBuilder.php
patching file src/TwigExtension/SystemTagsTwigExtension.php
Hunk #1 FAILED at 3.
Hunk #2 FAILED at 40.
2 out of 2 hunks FAILED -- saving rejects to file src/TwigExtension/SystemTagsTwigExtension.php.rej
patching file system_tags.tokens.inc
patching file tests/src/Functional/DefaultSystemTagsTest.php
➜  system_tags git:(2.0.1) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig system_tags

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/tests/src/Functional/DefaultSystemTagsTest.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\system_tags\Config\SystemTagDefinitions.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/system_tags.module
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult.
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/modules/theme/system_tags_theme.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  8 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
 56 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "_system_tag_node_suggestions" but expected
    |       |     "system_tags_theme__system_tag_node_suggestions"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/src/Plugin/Condition/SystemTags.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 48 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/src/SystemTagFinder/SystemTagFinderPluginBase.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 63 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/system_tags/src/TwigExtension/SystemTagsTwigExtension.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-------------------------------------------------------------------------------------------------------------------------------------

Time: 405ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @akshaydalvi212,

The patch you provided was applied cleanly and confirmed fixed all reported issues.

d8_recaptcha_v3 git:(3.0.x) curl https://www.drupal.org/files/issues/2023-04-17/3352575-8.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7907  100  7907    0     0  33770      0 --:--:-- --:--:-- --:--:-- 35617
patching file config/install/d8_recaptcha_v3.settings.yml
patching file d8_recaptcha_v3.libraries.yml
patching file d8_recaptcha_v3.links.menu.yml
patching file d8_recaptcha_v3.module
patching file d8_recaptcha_v3.routing.yml
patching file src/Controller/customRCController.php
patching file src/Form/SettingsForm.php
➜  d8_recaptcha_v3 git:(3.0.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig d8_recaptcha_v3
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @sakthi_dev,

The patch you provided was applied successfully, there is only one file that HUNKED at 69(offset 2 lines) and 2 files with 1 warning each were reported. Please see below:

clinic_zymphonies_theme git:(2.0.1) curl https://www.drupal.org/files/issues/2023-04-20/phpcs-3352106-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  106k  100  106k    0     0   233k      0 --:--:-- --:--:-- --:--:--  239k
patching file clinic_zymphonies_theme.info.yml
Hunk #1 succeeded at 69 (offset 2 lines).
patching file clinic_zymphonies_theme.libraries.yml
patching file clinic_zymphonies_theme.theme
patching file config/install/clinic_zymphonies_theme.settings.yml
patching file config/optional/block.block.clinic_zymphonies_theme_page_title.yml
patching file includes/fontawesome/css/fontawesome-all.css
patching file includes/owl/assets/owl.carousel.css
patching file includes/smartmenus/sm-core-css.css
patching file js/custom.js
patching file templates/layout/page.html.twig
➜  clinic_zymphonies_theme git:(2.0.1) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig clinic_zymphonies_theme

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/themes/contrib/clinic_zymphonies_theme/css/global.css
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/themes/contrib/clinic_zymphonies_theme/css/media.css
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------

Time: 610ms; Memory: 22MB

Kindly check

Thanks,
Jake

Hi @Akram Khan,

The patch you provided was applied successfully, but there is a file that has 2 errors reported. Please see below:

markdown_field_formatter git:(1.0.0-beta1) curl https://www.drupal.org/files/issues/2023-04-24/3355535-10.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2687  100  2687    0     0  30198      0 --:--:-- --:--:-- --:--:-- 34448
patching file markdown_field_formatter.info.yml
patching file src/Plugin/Field/FieldFormatter/MarkdownFileFormatter.php
➜  markdown_field_formatter git:(1.0.0-beta1) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig markdown_field_formatter

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/markdown_field_formatter/src/Plugin/Field/FieldFormatter/MarkdownFileFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is League\CommonMark\CommonMarkConverter.
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 134ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi sourabhjain,

Applied the patch you provided, there are only 2 files that were not patched successfully, but report shows 6 files need to be fixed. Please see below:

media_remote git:(1.x) curl https://www.drupal.org/files/issues/2022-08-09/3302374-4.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17014  100 17014    0     0  54179      0 --:--:-- --:--:-- --:--:-- 56903
patching file README.md
Hunk #1 succeeded at 53 (offset 6 lines).
patching file media_remote.module
Hunk #1 succeeded at 183 (offset 85 lines).
patching file src/Plugin/Field/FieldFormatter/MediaRemoteBoxFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteDacastFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteDropboxFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteGoogleFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteNPRFormatter.php
patching file src/Plugin/media/Source/MediaRemoteSource.php
patching file tests/src/FunctionalJavascript/Formatters/BuzzsproutFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/DocumentcloudFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/DropboxFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/GoogleFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/NPRFormatterTest.php
patching file tests/src/FunctionalJavascript/MediaRemoteFunctionalJavascriptTestBase.php
➜  media_remote git:(1.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig media_remote

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/tests/src/FunctionalJavascript/Formatters/NPRFormatterTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Public method name "NPRFormatterTest::testNPR" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/tests/src/FunctionalJavascript/Formatters/QuickbaseFormatterTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 20 | WARNING | Unused variable $page.
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteArcGISFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
  90 | ERROR | [x] Expected 1 blank line after function; 2 found
  98 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  99 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 100 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
 108 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 116 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 124 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
 137 | ERROR | [x] Expected 1 blank line after function; 0 found
 138 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteMsFormsFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
 93 | ERROR | [x] Expected 1 blank line after function; 2 found
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteApplePodcastsFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 32 | WARNING | [x] A comma should follow the last multiline array item. Found: 'https://podcasts.apple.com/us/podcast/[episode-title]/[id]?i=[token]'
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteLoomFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
  83 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  84 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  85 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
  93 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 102 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 111 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 823ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @himanshu_jhaloya,

The changes you committed on MR !4 was applied successfully and confirmed it fixed all errors.

node_access_grants git:(8.x-3.0) curl https://git.drupalcode.org/project/node_access_grants/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3790    0  3790    0     0   5919      0 --:--:-- --:--:-- --:--:--  6025
patching file README.md
patching file node_access_grants.module
patching file node_access_grants.services.yml
patching file src/NodeAccessGrantsCollection.php
patching file src/NodeAccessGrantsInterface.php
➜  node_access_grants git:(8.x-3.0) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig node_access_grants
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @everyone,

The patch @chaitanyadessai provided confirmed removed the unused variable as raised by comment #5, but one error were still reported that needs to be fixed. Please see below:

readmore_extrafield git:(3.1.x) curl https://www.drupal.org/files/issues/2023-05-13/3348047-6.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1440  100  1440    0     0   5198      0 --:--:-- --:--:-- --:--:--  5373
patching file src/Plugin/ExtraField/Display/ReadmoreExtrafield.php
patching file tests/src/FunctionalJavascript/ReadMoreExtraFieldFunctionalJavascriptTest.php
➜  readmore_extrafield git:(3.1.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig readmore_extrafield

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/readmore_extrafield/src/Plugin/ExtraField/Display/ReadmoreExtrafield.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 221ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi @nitin_lama,

Applied your latest changes on MR !3, obviously it did not patch successfully and errors were still thrown. Please see below:

 publication_date git:(78e5aa5) curl https://git.drupalcode.org/project/publication_date/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11739    0 11739    0     0  34351      0 --:--:-- --:--:-- --:--:-- 35252
patching file publication_date.module
patching file publication_date.post_update.php
patching file src/Plugin/Field/FieldType/PublicationDateItem.php
patching file src/Plugin/Field/FieldWidget/TimestampDatetimeWidget.php
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 24.
2 out of 2 hunks FAILED -- saving rejects to file src/Plugin/Field/FieldWidget/TimestampDatetimeWidget.php.rej
patching file tests/src/Functional/PublicationDateTest.php
➜  publication_date git:(78e5aa5) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig publication_date

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/publication_date/publication_date.install
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Messenger\MessengerInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/publication_date/tests/src/Functional/PublicationDatePreExistingContentTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\Entity\BaseFieldOverride.
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/publication_date/publication_date.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeInterface.
 22 | ERROR | [ ] The text '@deprecated will be removed before Publication Date 2.0.0. The behaviour of the module for unpublished entities has been changed in' does not match
    |       |     the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 389ms; Memory: 12MB

Kindly check

Thanks,
Jake

Hi @arpitk,

Applied the patch you provided, it was applied not-so successfully and errors were still reported. Please see below:

doi_search git:(1.0.x) ✗ curl https://www.drupal.org/files/issues/2023-05-05/Fixed-the-issues-reported-by-phpcs-3353332-13.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14347  100 14347    0     0   117k      0 --:--:-- --:--:-- --:--:--  129k
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/README.txt b/README.txt
|index 2bb2490..6516625 100644
|--- a/README.txt
|+++ b/README.txt
--------------------------
File to patch: README.md
patching file README.md
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file README.md.rej
patching file doi_search.module
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 12.
Hunk #3 FAILED at 57.
3 out of 3 hunks FAILED -- saving rejects to file doi_search.module.rej
patching file src/Controller/DoiSearchController.php
patching file src/DoiSearchManager.php
patching file src/Form/SearchForm.php
➜  doi_search git:(1.0.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig doi_search

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/README.md
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
 10 | WARNING | Line exceeds 80 characters; contains 99 characters
 14 | WARNING | Line exceeds 80 characters; contains 87 characters
 18 | WARNING | Line exceeds 80 characters; contains 100 characters
------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/templates/doi-search-reference.html.twig
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/templates/doi-search-page.html.twig
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/templates/doi-search-result.html.twig
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 33 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/doi_search.module
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 6 | ERROR | Wrong function doc comment end; expected "*/", found "**/"
--------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/doi_search/src/Controller/DoiSearchController.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\doi_search\DoiSearchManager.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

Time: 195ms; Memory: 10MB

Kindly check

Thanks,
Jake

Hi

The patch provided in the comment #2, was confirmed can be applied successfully. However it is false that it did fix all errors. Please see below:

ceremai git:(master) ✗ curl https://www.drupal.org/files/issues/2023-05-19/3361446-2-Drupal_coding_standard_Phpcs.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 57080  100 57080    0     0   121k      0 --:--:-- --:--:-- --:--:--  124k
patching file README.md
patching file README.txt
patching file ceremai.info.yml
patching file ceremai.theme
patching file config/install/ceremai.settings.yml
patching file css/advanced.css
patching file css/bootstrap-3.3.7.css
patching file css/bootstrap.css
patching file css/colorscheme.css
patching file css/component.css
patching file css/content.css
patching file css/custom.css
patching file css/footer.css
patching file css/header.css
patching file css/styles.css
➜  ceremai git:(master) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ceremai

FILE: ...erns/Demo-site/drupal-orgissue-v9/web/themes/contrib/ceremai/ceremai.theme
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\block\Entity\Block.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/system/page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 276 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...eb/themes/contrib/ceremai/templates/node/node--article--slider-1.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...pal-orgissue-v9/web/themes/contrib/ceremai/templates/block/block.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 66 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 3.46 secs; Memory: 58.01MB

Kindly check

Thanks,
Jake

Hi @everyone,

Also confirmed MR!1 fixed all reported errors.

qtools_transport_profiler git:(1.0.x) curl https://git.drupalcode.org/project/qtools_transport_profiler/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4465    0  4465    0     0  14843      0 --:--:-- --:--:-- --:--:-- 15238
patching file src/Controller/ErrorReportController.php
patching file src/Controller/RequestReportController.php
patching file src/Form/ReportFilterForm.php
patching file src/PerformanceService.php
patching file src/ReportService.php
patching file src/TransportServiceWrapper.php
➜  qtools_transport_profiler git:(1.0.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qtools_transport_profiler
zsh: command not found: phpcs
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qtools_transport_profiler
➜  contrib git:(master) ✗

RTBC +1 also from me.

Thanks,
Jake

Hi @bhaveshads,

I have applied the latest MR !14 again to the Varbase Components module against 2.0.x-dev on my D10 local, and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/

Please see the attached file for reference.

I'm moving this now to ‘RTBC’.

Thank you!

why do you wanna correct the js style with phpcs? I remind you that PHPS is NOT for js and css. if you want to fix it with PHPCBF, it will be totally wrong. I think you just run phpcfb without testing. Example of fixing true vs TRUE, false vs FALSE not working with js.
The module is passed to Phpcs with ci on gitlab. you don't need to repair it.

lazzyvn → closed merge request !12

Hetal.Solanki , sarwan_verma, Sourav_Paul if you propose some changes in a code - please test the code manually before creating MR.
Fixing the code with automated tool have zero sense if module become broken after that.
Thanks.

I have applied the MR !3 and it resolves the errors.
Please check the screenshot for the same.

I have applied the MR !1 and it resolves the issues.
Please check the screenshot for the same.

I tested with MR 53. Found these errors. Please check

FILE: ...ontrib/migrate_tools/src/Drush/Commands/MigrateToolsCommands.php
----------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
104 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
104 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
108 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
108 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
258 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
258 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
263 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
263 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
453 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
453 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
467 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
467 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
551 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
551 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
560 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
560 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
777 | ERROR | [x] The first parameter of a multi-line function
| | declaration must be on the line after the opening
| | bracket
777 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
781 | ERROR | [x] Multi-line function declarations must have a
| | trailing comma after the last parameter
781 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 4.86 secs; Memory: 20MB

Hi,
I have resolved conflict from upstream and updated MR. Please review it.

nilesh.addweb → made their first commit to this issue’s fork.

I am facing an error while applying "elasticsearch_connector-coding-standard-updates-3346008-2" patch.
Please check the screenshot for the same.

Hi, I have Fixed Remaining PHPCS Issues.
Could you please review it.

Thankyou !!

I applied MR!35 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/colorbox-3459188/

FILE: /var/www/html/drupal-contri-d10/modules/custom/colorbox-3459188/src/Form/ColorboxSettingsForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------
 61 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 62 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 63 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 64 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 64 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 64 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/colorbox-3459188/src/Plugin/Field/FieldFormatter/ColorboxResponsiveFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 13 LINES
-------------------------------------------------------------------------------------------------------------------------------------
 106 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 107 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 108 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 109 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 110 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 111 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 112 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 113 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 114 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 115 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 116 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 117 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 118 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
 118 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 118 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/colorbox-3459188/src/Plugin/Field/FieldFormatter/ColorboxFormatter.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 13 LINES
---------------------------------------------------------------------------------------------------------------------------
 106 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 107 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 108 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 109 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 110 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 111 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 112 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 113 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 114 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 115 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 116 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 117 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
 118 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2
 118 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 118 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/colorbox-3459188/styles/stockholmsyndrome/colorbox_style.js
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Opening brace must be the last content on the line
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

Time: 578ms; Memory: 14MB

Hey , I have fixed remaining phpcs issues.
Could you please review it.

Thankyou !!

I applied MR!14 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/varbase_components-3372800/

FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/manipulator.js
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/data.js
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/event-handler.js
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/selector-engine.js
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/button.js
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/modal.js
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/tooltip.js
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/scrollspy.js
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/carousel.js
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/toast.js
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/backdrop.js
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/component-functions.js
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/focustrap.js
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/config.js
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/sanitizer.js
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/scrollbar.js
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/index.js
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/swipe.js
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/template-factory.js
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/alert.js
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/tab.js
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/popover.js
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/collapse.js
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dropdown.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
  10 | ERROR | [x] Opening brace must be the last content on the line
 290 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 293 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 4
 293 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 293 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/offcanvas.js
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/base-component.js
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/popperjs/popper.js
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Opening brace must be the last content on the line
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

Time: 1.06 secs; Memory: 32MB

I have fixed remaining errors.
Please review again.
Thanks.!!

I have fixed remaining errors.
Please review again.
Thanks.!!

I HAVE fixed remaining warnings.
Kindly review again.
Thanks!!

i have tested MR 53. i FOUND SOME WARNING. i fixed all of warning using PHPCBF COMMAND.
Thanks!!

Fixed most of the issues reported by phpcs in the same MR.

The below are the remaining issues to be fixed.

$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/comment_notify

FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.install
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 109 | WARNING | Unused variable $entity_type.
--------------------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/README.md
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------
 14 | WARNING | Line exceeds 80 characters; contains 87 characters
 45 | WARNING | Line exceeds 80 characters; contains 84 characters
 61 | WARNING | Line exceeds 80 characters; contains 83 characters
 88 | WARNING | Line exceeds 80 characters; contains 83 characters
-------------------------------------------------------------------------------------------------


FILE: /Users/vinmayi.nidubrolu/projects/drupal103/drupal/modules/contrib/comment_notify/comment_notify.module
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------
 22 | WARNING | Global constants should not be used, move it to a class or interface
 23 | WARNING | Global constants should not be used, move it to a class or interface
 24 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------------------------------

Time: 459ms; Memory: 16MB

Kindly please check and advise.

Thanks!

Hi, I've fixed some PHPCS issues, but one warning remains.
Can someone take a look at it?

Thankyou !!

FILE: /var/www/html/drupal-contri-d10/modules/custom/address_suggestion-3463031/js/build/addressSuggestion.js
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------

Time: 728ms; Memory: 14MB

I tried to apply the patch, but it failed and gave me the error, please check:-

Checking patch .eslintrc.json...
error: while searching for:
    "no-unused-vars": ["warn"],
    "operator-linebreak": ["error", "after", { "overrides": { "?": "ignore", ":": "ignore" } }]
  }
}
error: patch failed: .eslintrc.json:49
error: .eslintrc.json: patch does not apply
Checking patch .gitlab/issue_templates/default.md...
error: while searching for:
### Problem/Motivation

#### Steps to reproduce
```
  Given 
   When 
   Then 
```

### Proposed resolution


error: patch failed: .gitlab/issue_templates/default.md:1
error: .gitlab/issue_templates/default.md: patch does not apply
Checking patch .gitlab/merge_request_templates/default.md...
error: while searching for:
- [ ] Automated unit/functional testing coverage
- [ ] Developer Documentation support on feature change/addition
- [ ] User Guide Documentation support on feature change/addition
- [ ] Accessibility and Readability
- [ ] Code review from 1 Varbase core team member
- [ ] Full testing and approval

error: patch failed: .gitlab/merge_request_templates/default.md:5
error: .gitlab/merge_request_templates/default.md: patch does not apply
Checking patch .stylelintignore...
error: while searching for:
modules/varbase_tour/*.json
modules/varbase_tour/*.install
modules/varbase_tour/*.module
modules/varbase_tour/*.lock
error: patch failed: .stylelintignore:33
error: .stylelintignore: patch does not apply
Checking patch README.md...
error: while searching for:
Provides core components required by other features.


### Varbase Default content
Provides starter default content for varbase.

### Varbase Admin
Manage administration configurations.

### Varbase Page
Provides Basic page content type and related configuration.

### Varbase Security
Manages general security configurations, with password policy,
 username enumeration prevention, security kit and review.

### Varbase Tour
Provide Tours for varbase.

### Varbase Development
Development Environment Modules and Features, make sure to disable
 this feature in production.

### Varbase Internationalization
Languages, and translation support.

### Varbase Webform
Provide webforms features and settings.

### Varbase Updates Helper
Provides a UI to review Varbase Updates that are made available in every
version.

error: patch failed: README.md:6
error: README.md: patch does not apply
Checking patch composer.json...
error: while searching for:
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    "assets": {
      "type": "composer",
      "url": "https://asset-packagist.org"
    }
  },
  "require": {
    "composer/installers": "~1.0 || ~2.0",
    "oomphinc/composer-installers-extender": "~1.0 || ~2.0",
    "cweagans/composer-patches": "~1.0",
    "drupal/core": "~9.0",
    "vardot/entity-definition-update-manager": "~1.0",
    "vardot/module-installer-factory": "~1.0",
    "drupal/config_update": "~1.0",
    "drupal/config_ignore": "~2.0",
    "drupal/config_inspector": "~1.0",
    "drupal/ctools": "~3.0",
    "drupal/token": "~1.0",
    "drupal/token_filter": "~1.0",
    "drupal/page_manager": "4.0-beta6",
    "drupal/panels": "~4.0",
    "drupal/bootstrap_layouts": "5.2",
    "drupal/layout_builder_restrictions": "~2.0",
    "drupal/ds": "~3.0",
    "drupal/views_bootstrap": "~4.0",
    "drupal/field_group": "~3.0",
    "drupal/smart_trim": "~1.0",
    "drupal/advanced_text_formatter": "~2.0",
    "drupal/allowed_formats": "~1.0",
    "drupal/block_class": "~1.0",
    "drupal/menu_block": "~1.0",
    "drupal/block_content_permissions": "~1.0",
    "drupal/views_infinite_scroll": "~2.0",
    "drupal/entity": "~1.0",
    "drupal/entity_clone": "~1.0",
    "drupal/entity_usage": "~2.0",
    "drupal/entityqueue": "~1.0",
    "drupal/entityqueue_form_widget": "~2.0",
    "drupal/inline_entity_form": "1.0-rc11",
    "drupal/ultimate_cron": "~2.0",
    "drupal/persistent_login": "1.3",
    "drupal/userprotect": "~1.0",
    "drupal/admin_audit_trail": "~1.0",
    "drupal/login_destination": "~2.0",
    "drupal/betterlogin": "~1.0",
    "drupal/email_registration": "1.1",
    "drupal/config_perms": "~2.0",
    "drupal/roleassign": "~1.0",
    "drupal/prevent_homepage_deletion": "~1.0",
    "drupal/admin_toolbar": "~3.0",
    "drupal/tour_ui": "~1.0",
    "drupal/coffee": "~1.0",
    "drupal/responsive_preview": "~1.0",
    "drupal/views_bulk_operations": "~4.1",
    "drupal/views_bulk_edit": "~2.0",
    "drupal/revision_log_default": "~1.0",
    "drupal/webform": "~6.0",
    "drupal/webform_views": "~5.0",
    "drupal/default_content": "2.0.x-dev",
    "drupal/better_normalizers": "~1.0",
    "drupal/content_lock": "~2.0",
    "drupal/node_edit_protection": "~1.0",
    "drupal/rabbit_hole": "~1.0",
    "drupal/yoast_seo": "~1.0",
    "drupal/fast_404": "~2.0",
    "drupal/diff": "~1.0",
    "drupal/masquerade": "~2.0",
    "drupal/menu_admin_per_menu": "~1.0",
    "drupal/drd_agent": "~3.0",
    "drupal/devel": "~4.0",
    "drupal/stage_file_proxy": "~1.0",
    "drupal/update_helper": "3.0.2",
    "drupal/checklistapi": "~2.0",
    "drupal/username_enumeration_prevention": "~1.0",
    "drupal/password_policy": "~3.0",
    "drupal/genpass": "~1.0",
    "drupal/seckit": "~2.0",
    "drupal/security_review": "1.x-dev",
    "drupal/honeypot": "~2.0",
    "drupal/antibot": "~2.0",
    "drupal/shield": "~1.0",
    "drupal/flood_control": "~2.0",
    "drupal/captcha": "~1.0",
    "drupal/recaptcha": "~3.0",
    "drupal/length_indicator": "~1.0",
    "drupal/maxlength": "~2.0",
    "drupal/menu_position": "1.0-beta1",
    "drupal/taxonomy_access_fix": "~3.0",
    "drupal/better_exposed_filters": "~5.0",
    "drupal/autocomplete_deluxe": "~2.0",
    "drupal/extlink": "~1.0",
    "drupal/link_attributes": "~1.0",
    "drupal/entity_reference_revisions": "~1.0",
    "drupal/viewsreference": "~2.0",
    "drupal/vmi": "~3.0 || 3.0.x-dev",
    "drupal/jquery_ui_accordion": "~1.0",
    "drupal/reroute_email": "~2.0"
  },
  "suggest": {
    "bower-asset/objectfitpolyfill": "~2.0: Provides JavaScript library necessary for the Object Fit Polyfill",
    "bower-asset/jqueryui-touch-punch": "0.2.3 Required to use by drupal/jquery_ui_touch_punch module."
  },
  "extra": {
    "installer-types": [
      "bower-asset",
      "npm-asset"
    ],
    "drupal-libraries": {
      "libraries": [
        {"name": "objectfitpolyfill", "package": "bower-asset/objectfitpolyfill"},
        {"name": "jquery-ui-touch-punch", "pack
error: patch failed: composer.json:20
error: composer.json: patch does not apply
Checking patch config/managed/editoria11y/permissions/user.permissions.anonymous.yml...
error: config/managed/editoria11y/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch config/managed/editoria11y/permissions/user.permissions.authenticated.yml...
error: config/managed/editoria11y/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch config/managed/editoria11y/permissions/user.permissions.content_admin.yml...
error: config/managed/editoria11y/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch config/managed/editoria11y/permissions/user.permissions.editor.yml...
error: config/managed/editoria11y/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch config/managed/editoria11y/permissions/user.permissions.seo_admin.yml...
error: config/managed/editoria11y/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch config/managed/editoria11y/permissions/user.permissions.site_admin.yml...
error: config/managed/editoria11y/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch config/managed/editoria11y/recipes/editoria11y.settings.yml...
error: config/managed/editoria11y/recipes/editoria11y.settings.yml: already exists in working directory
Checking patch config/optional/block_class.settings.yml...
error: config/optional/block_class.settings.yml: already exists in working directory
Checking patch config/optional/config_ignore.settings.yml...
error: while searching for:
ignored_config_entities:
  - "webform.webform.*"
  - "xmlsitemap.xmlsitemap.*"

error: patch failed: config/optional/config_ignore.settings.yml:1
error: config/optional/config_ignore.settings.yml: patch does not apply
Checking patch config/optional/rabbit_hole.settings.yml...
error: config/optional/rabbit_hole.settings.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.captcha_cron.yml...
error: config/optional/ultimate_cron.job.captcha_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.content_lock_timeout_cron.yml...
error: config/optional/ultimate_cron.job.content_lock_timeout_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.field_cron.yml...
error: config/optional/ultimate_cron.job.field_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.file_cron.yml...
error: config/optional/ultimate_cron.job.file_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.honeypot_cron.yml...
error: config/optional/ultimate_cron.job.honeypot_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.layout_builder_cron.yml...
error: config/optional/ultimate_cron.job.layout_builder_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.node_cron.yml...
error: config/optional/ultimate_cron.job.node_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.password_policy_cron.yml...
error: config/optional/ultimate_cron.job.password_policy_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.persistent_login_cron.yml...
error: config/optional/ultimate_cron.job.persistent_login_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.redirect_404_cron.yml...
error: config/optional/ultimate_cron.job.redirect_404_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.scheduler_cron.yml...
error: config/optional/ultimate_cron.job.scheduler_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.simple_sitemap_cron.yml...
error: config/optional/ultimate_cron.job.simple_sitemap_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.system_cron.yml...
error: config/optional/ultimate_cron.job.system_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.ultimate_cron_cron.yml...
error: config/optional/ultimate_cron.job.ultimate_cron_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.update_cron.yml...
error: config/optional/ultimate_cron.job.update_cron.yml: already exists in working directory
Checking patch config/optional/ultimate_cron.job.webform_cron.yml...
error: config/optional/ultimate_cron.job.webform_cron.yml: already exists in working directory
Checking patch config/optional/varbase_core.general_settings.yml...
error: while searching for:
welcome_status: 1

error: patch failed: config/optional/varbase_core.general_settings.yml:1
error: config/optional/varbase_core.general_settings.yml: patch does not apply
Checking patch config/permissions/user.permissions.anonymous.yml...
error: config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch config/permissions/user.permissions.authenticated.yml...
error: config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch config/permissions/user.permissions.content_admin.yml...
error: config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch config/permissions/user.permissions.editor.yml...
error: config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch config/permissions/user.permissions.seo_admin.yml...
error: config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch config/permissions/user.permissions.site_admin.yml...
error: config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch config/schema/varbase_core.schema.yml...
error: config/schema/varbase_core.schema.yml: already exists in working directory
Checking patch config/update/varbase_core_update_9002.yml...
error: while searching for:
          access:
            type: perm
            options:
              perm: 'access media overview'
          cache:
            type: tag
            options: {  }
          query:
            type: views_query
            options:
              disable_sql_rewrite: false
              distinct: false
              replica: false
              query_comment: ''
              query_tags: {  }
          exposed_form:
            type: bef
            options:
              submit_button: Filter
              reset_button: false
              reset_button_label: Reset
              exposed_sorts_label: 'Sort by'
              expose_sort_order: true
              sort_asc_label: Asc
              sort_desc_label: Desc
              text_input_required: 'Select any filter and click on Apply to see results'
              text_input_required_format: full_html
              bef:
                general:

error: patch failed: config/update/varbase_core_update_9002.yml:2018
error: config/update/varbase_core_update_9002.yml: patch does not apply
Checking patch drupalci.yml...
error: drupalci.yml: No such file or directory
Checking patch includes/helpers.inc...
error: includes/helpers.inc: already exists in working directory
Checking patch includes/updates.inc...
error: includes/updates.inc: already exists in working directory
Checking patch includes/updates/v8.inc...
error: includes/updates/v8.inc: already exists in working directory
Checking patch includes/updates/v9.inc...
error: includes/updates/v9.inc: already exists in working directory
Checking patch logo.png...
error: logo.png: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_admin/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_admin/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_admin/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.editor.yml...
error: modules/varbase_admin/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_admin/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_admin/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_admin/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_admin/includes/helpers.inc...
error: modules/varbase_admin/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_admin/includes/updates.inc...
error: modules/varbase_admin/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_admin/includes/updates/v8.inc...
error: modules/varbase_admin/includes/updates/v8.inc: already exists in working directory
Checking patch modules/varbase_admin/includes/updates/v9.inc...
error: modules/varbase_admin/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_admin/varbase_admin.info.yml...
error: while searching for:
name: "Varbase Admin"
description: "Manage administration configurations."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - varbase_core:varbase_core
  - drupal:shortcut

error: patch failed: modules/varbase_admin/varbase_admin.info.yml:1
error: modules/varbase_admin/varbase_admin.info.yml: patch does not apply
Checking patch modules/varbase_admin/varbase_admin.install...
error: while searching for:
use Drupal\Core\Config\InstallStorage;
use Drupal\user\Entity\User;
use Drupal\user\RoleInterface;
use Drupal\shortcut\Entity\Shortcut;
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;
use Drupal\user\UserInterface;

/**
 * Implements hook_install().
 */
function varbase_admin_install() {

  // Processer for install: in varbase_admin.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_admin');

  // Install optional configs.

error: patch failed: modules/varbase_admin/varbase_admin.install:8
error: modules/varbase_admin/varbase_admin.install: patch does not apply
Checking patch modules/varbase_admin/varbase_admin.module...
error: while searching for:
    && isset($form['display']['display_submitted'])
    && isset($form['display']['display_submitted']['#default_value'])) {

    // Uncheck the default display submitted auther option.
    $form['display']['display_submitted']['#default_value'] = 0;
  }


error: patch failed: modules/varbase_admin/varbase_admin.module:57
error: modules/varbase_admin/varbase_admin.module: patch does not apply
Checking patch modules/varbase_default_content/content/block_content/b137b5b9-7a08-4f18-9ce9-66a6a3a06954.yml...
error: while searching for:
  content_translation_created:
    - value: 1594907136
  body:
    - value: "<style type=\"text/css\">.varbase-welcome-block img {\r\n    margin-top: 10px;\r\n  }\r\n</style>\r\n<p>Here's some information for you to get started.</p>\r\n\r\n<p>&nbsp;</p>\r\n\r\n<div class=\"row text-muted varbase-welcome-block\">\r\n<div class=\"col-md-6\">\r\n<div class=\"row\">\r\n<div class=\"col-2 col-xs-2\"><img alt=\"Flexible Content and Fields\" src=\"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAKEAAABtCAIAAABGGZYuAAAACXBIWXMAABYlAAAWJQFJUiTwAAALxUlEQVR42u2dbVCTVxbHjyGSQkIwxGCUKEgg8lIjWJFEW6rGWYoOKtoRFlbtutv6wqzrF2vLtDN2doeu2BldumjV3a7V+jqudmQVdYy4jCURUDGsipFEkVCiIYnEBBqahP1w2ZRCTAJ5f7z/8UOMj8/z3PvLuS/n3nPuuIGBAfCNrLaBizLVP+rkcrUBsPyozYtTl2dOi2NEor+O8xHjYxJFebUMfRZwWQwqBVe9f1QjU9mr/cs1gohwsk8Y9/VbsnZUM2mUouzphdmJMTQM2H+yWG31bc/2XLorVxvK8vnFQi7JF4/55/U2APhwycxNolQM2M8ih5FyZrC/3fg2AOyvfWC1DXifsdU2cFKqBICFaZNxjQdKkeHkEmGi1mi+06HzPmN1T5/WaC4VpUSGk3FdB1CrshIA4LhEQfLRA6YxabiWAysqZdDGSLguCC/MGDPGwoyxQmA29YqUU2c0f1vfdkPR/exFn3fvHM+kLcuctvj1KUE7j3glGJ+79aTs9E0f3bzreZ9UoSk7ffPMlkU8djRuqwOjv5yX+eEpf7tyH/fHgVGn3mTo+8kPD7p6r6u334IZB0DPe/v99iy9yYwZB0A//mTF42pPmsHekV92e3vgihUAxn39lrM32/fXPtAaHTRNsVGv4WoNbcbnmzu2n2pCn0uEifypMcMu6O23fPZdM67ZUGVstQ0gwGX5/BVvxDuc9XfqTbhaQ5jx9/KnAFAqSikWcnHdhYpGN67ec/kuABRmJ+KKIyZjvcksVxsEXBbeokVYxr39VgDAu2gJ3lZjYcZYmDEWZoyFGWNhxliY8aspn+/nslhtTw2Dq40ms+Wh2jB5QuSk6MG1KQaVgkNmQo+x1WYDgNvt2mut6galxuH64zDl8TmZ8TEpkyckTKRhJ1rwMrZYbbIO/aUW1VGJEgBO3HiEvkcB5jHU8GGrkD19/bfbdQBQI1OhP+h7Hpv+blbCyxa1sALDuFNvOny9DaEFABRans5hcGOj4hhUJ/8RLV7tKsrSGc2Pu42tXc9PNz6Wqw3l1bLyapmAy9osSp2dwMSQAsm4U2/ac+keMkGEVpQ+ZQx7jGNolBgaZXYCs1jI1RnNF1tUpxsfSxUaqULDY9M/WZaBSQeA8VC63sUQQ6MUC7nFQq79EWsP1GHS/mZs3+7j06qPY1B3FWVtzU2zk87jcz5bmYn7aZ8zblRqkPnuXD1nacZUX7+fnfQfjkhrZKoGpeZPq2bnzGBjcj7xgdTe7wKAbqNZwGXVlS3xA+ChpE+VLizL52uN5s3fSLadaLRYbRiel+1439XWqiv3/Wa+Dl40jFQs5L6dwkYGrTeZK9cIcLvtHTu22gY+/7es6sp9Jo3iZ/N9mUELuCypQpP3xWWd0YwResrYahvYeKj+aL2CSaOc3SIKBicUOYz01XvzSkUpWqO5oFLsEjMrioIZO9PGQ/WStmcCLku8/Z3g8TKSw0ibRKluYp4YFeGft6JHjHfu8wlGxvuutiLAX703jxwWdCtUQzE7GYJFhpMX+SUb3EdL+SE25jomUaI+uKIwy0PAcnXPvxof60wOYkTzM6fOS4od8/03iVKf9/YflSg3Hqp38kPcsSIzKTbqwDW5jyox6jXyb4TcJbM4wcnYcU7Uh2pDQaXYK33wthON9vWGl6lhR/6YR8gWq23joXqpQlMiTPw4f5aTK3v7LXqTWd3j5bBKdnTEJHpEELZznXpT7q7Lefw4ssNx1u+/vg4Au4uzPQSsM5pdAgaA7262jzm4Bg3BRDsvHpUoV2UlOPGWR4aTI8PJwdll+rs/rrjQojWaS4SJnjspJW3P3Llsf+0DD4dgB9fPB4D3v/4e+0ZcM36oNqCZ0rYlM/32ElqPp7k8djRK87rrQguG6oyxvZU+uH5+EHYwLjr+JTOZNMpRiVKu7sFcX8r4YosKtdLBmWfKZYu9uzgbAD76fwg81nDGVttAxfkWAPhjbnqIFmZ2ApPHpsvVhluPtRitA8bIiEM9t/gnyzIA4LhUidEOZ2w34mWzp4V0eZAp18hUOGXFcMayDp3WaM7jcwgwfUSmfPh6G6b7C8YXWzoB4NcCIiSB4E9loAE2niv/zNhqG0BzYmJsiiOHkYqypwOArEOPAQNak5B16AAA1QsxJEqfUiVuXXugLgjf7b/lBQGwY9RQi9KnEIYxjx3NxDE1Qxk3KjWoXohUsLmJLEx3sK222gZQRiaCFWxBCrtGptq7Tog36pLQeio3NopgBUtm0wHgrgoPu4Dc/EQLACNTm46UxWq71NLpo/OMXy876/7FpaIUl8excmKoAHATOzUBSE+0JgDIiHfN+OC1B9tPNQXDgdVV4taCSrHza5BHVqrQYMakR5oX7lxnsdrsIcXBIK3R7HLhIY/PwYDB7ueaRHexQfWpoU8bZBvW8cLD6BiH3I4A94UXJ0htT1/gXzrBGRN4Z0ymGwPJV4KxMCmWqGVDOWWwSAxqOLFLGDH+VY9fHRxqBechcl4RTvg1yNjlIXJBmH5+QYoLR3Rwnoznf5EzpjEv3FGZzC7sODKcnMfnuBPY4jctdBWNiJxco/KS+kEBWD/mxEQCwEM3PJRbc9N4bHowVBOTRtm7Tuh8/yhOMfCzHXNj6QBwrVXtMglEHIN6ZouoU29qdnu8eq1V7abp71w9x817Tp4QyZ/KcOm0edxtxHQHGccxIgGgQemu7z6OQR3V3k03GXs9zUhr13MAOPxBDs7cRgIAYVKs1mgm2C5GNDlOmEjDdkwCAPRLJ9IuRovVViNTMWkUPHEaZLw4bQoA7BXfJ0yp6tueAbF2mnrKOJlNZ9IoUoWGMJ4QFCRBpJ2mXvCBFAkSAaDpUTcBitTbb5EqNEwahWA7TT1ljJrrPZfuEqBItfe6cEPtgHEym85jRxMgctditVVcaAGAdW8lY7q/YAwAny6fBQB/Phfax8xfaukkQBS1rxhnxod8ED42YheMAeDT5RkhbcrYiF0zzoxnCpNi5WrD+eaOkCuJzmhGJyBgI3bGGAAqCucAwPZTTSG3bvPhyUYA2Ll6DjZiF4wZVMrOwjn2KgsVnW/ukCo0Ai4rsCnUQ4MxACydNVWYFCtVaPZ57N2cPCHSnctKhB7lqOjUm1ArXVGYhYmOlONmraJwzoq/iqvErdncWE/W5uwJs5xftvbNJE+64eJ9/0Gfc8ovBH+NByaPwEgxqJS/r38TANYeqPNwKvXlGkGpKOVl/yrgsg5/kDPmZEIWq62gUqzFWz6cynH+aqTb7do1++u8ksUa5Y4e9mXEeLInt7Vnrg6tGvebHTvLXz10KlWWP6u8+k5Bpfjg+vmeuPhR7mjvujsQ4KA9CiGox1xDVSxMLF2cqjWaV1ZeDR7/l85oFu28iAF7hzEAbFqUcmRDDuqbj0kUAX/jTr0J9cElwkQM2DuMUaN9ZEMOgxpeXi3bdqIxUFsJLFbbMYkid9dl5LD8OH8WBuw1xgjz/t/OB4AamSrvi8t1D9T+b59XV9WWV8vQ5upNolQMz6P5sUNFR4QD
error: patch failed: modules/varbase_default_content/content/block_content/b137b5b9-7a08-4f18-9ce9-66a6a3a06954.yml:24
error: modules/varbase_default_content/content/block_content/b137b5b9-7a08-4f18-9ce9-66a6a3a06954.yml: patch does not apply
Checking patch modules/varbase_default_content/varbase_content/disabled_varbase_heroslider_media_content/disabled_varbase_heroslider_media_content.info.yml...
error: while searching for:
type: module
hidden: TRUE
package: Varbase
core_version_requirement: ^9
description: "Varbase default content which varbase heroslider media is disabled"
dependencies: []

error: patch failed: modules/varbase_default_content/varbase_content/disabled_varbase_heroslider_media_content/disabled_varbase_heroslider_media_content.info.yml:2
error: modules/varbase_default_content/varbase_content/disabled_varbase_heroslider_media_content/disabled_varbase_heroslider_media_content.info.yml: patch does not apply
Checking patch modules/varbase_default_content/varbase_content/enabled_varbase_heroslider_media_content/enabled_varbase_heroslider_media_content.info.yml...
error: while searching for:
type: module
hidden: TRUE
package: Varbase
core_version_requirement: ^9
description: "Varbase default content when varbase heroslider media is enabled"
dependencies: []

error: patch failed: modules/varbase_default_content/varbase_content/enabled_varbase_heroslider_media_content/enabled_varbase_heroslider_media_content.info.yml:2
error: modules/varbase_default_content/varbase_content/enabled_varbase_heroslider_media_content/enabled_varbase_heroslider_media_content.info.yml: patch does not apply
Checking patch modules/varbase_default_content/varbase_default_content.info.yml...
error: while searching for:
type: module
hidden: TRUE
package: Varbase
core_version_requirement: ^9
description: "Provides starter default content for varbase."
dependencies:
  - drupal:block

error: patch failed: modules/varbase_default_content/varbase_default_content.info.yml:2
error: modules/varbase_default_content/varbase_default_content.info.yml: patch does not apply
Checking patch modules/varbase_default_content/varbase_default_content.install...
error: while searching for:
  try {
    $path_alias_query = \Drupal::entityQuery('path_alias');
    $path_alias_query->condition('alias', '/node', '=');
    $alias_ids = $path_alias_query->execute();

    if (count($alias_ids) > 0) {
      foreach ($alias_ids as $alias_id) {

error: patch failed: modules/varbase_default_content/varbase_default_content.install:27
error: modules/varbase_default_content/varbase_default_content.install: patch does not apply
Checking patch modules/varbase_development/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_development/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_development/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_development/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_development/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_development/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_development/config/permissions/user.permissions.editor.yml...
error: modules/varbase_development/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_development/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_development/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_development/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_development/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_development/varbase_development.info.yml...
error: while searching for:
name: "Varbase Development"
description: "Development Environment Modules and Features, make sure to disable this feature in production."
type: module
package: Varbase
core_version_requirement: ^9
dependencies: []
install:
  - dblog

error: patch failed: modules/varbase_development/varbase_development.info.yml:1
error: modules/varbase_development/varbase_development.info.yml: patch does not apply
Checking patch modules/varbase_development/varbase_development.install...
error: while searching for:
 */
function varbase_development_install() {

  // Processer for install: in varbase_development.info.yml file using ModuleInstallerFactory.
  // --------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_development');

  // Install optional configs.

error: patch failed: modules/varbase_development/varbase_development.install:13
error: modules/varbase_development/varbase_development.install: patch does not apply
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.editor.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_internationalization/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_internationalization/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_internationalization/includes/helpers.inc...
error: modules/varbase_internationalization/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_internationalization/includes/updates.inc...
error: modules/varbase_internationalization/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_internationalization/includes/updates/v8.inc...
error: modules/varbase_internationalization/includes/updates/v8.inc: already exists in working directory
Checking patch modules/varbase_internationalization/includes/updates/v9.inc...
error: modules/varbase_internationalization/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_internationalization/varbase_internationalization.info.yml...
error: while searching for:
name: "Varbase Internationalization"
description: "Varbase internationalization, languages, and translation support."
type: module
package: Varbase
core_version_requirement: ^9
dependencies: []
install:
  - language
  - locale

error: patch failed: modules/varbase_internationalization/varbase_internationalization.info.yml:1
error: modules/varbase_internationalization/varbase_internationalization.info.yml: patch does not apply
Checking patch modules/varbase_internationalization/varbase_internationalization.install...
error: while searching for:
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_install().
 */
function varbase_internationalization_install() {

  // Processer for install: in varbase_internationalization.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_internationalization');

  // ---------------------------------------------------------------------------

error: patch failed: modules/varbase_internationalization/varbase_internationalization.install:8
error: modules/varbase_internationalization/varbase_internationalization.install: patch does not apply
Checking patch modules/varbase_page/config/optional/pathauto.pattern.hierarchical_paths_for_basic_pages.yml...
error: while searching for:
pattern: "[node:menu-link:parents:join-path]/[node:title]"
selection_criteria:
  e8a66397-ab44-4e98-b407-ef082a104e4e:
    id: node_type
    bundles:
      page: page
    negate: false

error: patch failed: modules/varbase_page/config/optional/pathauto.pattern.hierarchical_paths_for_basic_pages.yml:9
error: modules/varbase_page/config/optional/pathauto.pattern.hierarchical_paths_for_basic_pages.yml: patch does not apply
Checking patch modules/varbase_page/config/optional/rabbit_hole.behavior_settings.node.page.yml...
error: modules/varbase_page/config/optional/rabbit_hole.behavior_settings.node.page.yml: already exists in working directory
Checking patch modules/varbase_page/config/optional/rabbit_hole.behavior_settings.node_type_page.yml...
error: modules/varbase_page/config/optional/rabbit_hole.behavior_settings.node_type_page.yml: No such file or directory
Checking patch modules/varbase_page/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_page/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_page/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_page/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_page/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_page/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_page/config/permissions/user.permissions.editor.yml...
error: modules/varbase_page/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_page/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_page/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_page/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_page/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_page/includes/helpers.inc...
error: modules/varbase_page/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_page/includes/updates.inc...
error: modules/varbase_page/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_page/includes/updates/v9.inc...
error: modules/varbase_page/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_page/varbase_page.info.yml...
error: while searching for:
name: "Varbase Page"
description: "Provides Basic page content type and related configuration."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - varbase_core:varbase_core
install:
  - text
  - editor
  - ckeditor
  - menu_ui
  - page_manager
  - rabbit_hole

error: patch failed: modules/varbase_page/varbase_page.info.yml:1
error: modules/varbase_page/varbase_page.info.yml: patch does not apply
Checking patch modules/varbase_page/varbase_page.install...
error: while searching for:
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_install().
 */
function varbase_page_install() {

  // Processer for install: in varbase_page.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_page');

  // Install optional configs.
  ModuleInstallerFactory::importConfigsFromScanedDirectory('varbase_page', '/^.*(settings.yml)$/i');

  // ---------------------------------------------------------------------------
  // Entity updates to clear up any mismatched entity and/or field definitions
  // And Fix changes were detected in the entity type and field definitions.

error: patch failed: modules/varbase_page/varbase_page.install:8
error: modules/varbase_page/varbase_page.install: patch does not apply
Checking patch modules/varbase_security/config/optional/password_policy.password_policy.default_policy.yml...
error: while searching for:
id: default_policy
label: "Default policy"
password_reset: 0
langcode: en
policy_constraints:
  - id: password_policy_history_constraint
    history_repeats: 0
  - id: password_username
    disallow_username: true
  - id: password_length
    character_length: 8
    character_operation: minimum
  - id: character_types
    character_types: 4
  - id: password_policy_character_constraint
    character_count: 1
    character_type: special
  - id: password_policy_character_constraint
    character_count: 1
    character_type: numeric
  - id: password_policy_character_constraint
    character_count: 1
    character_type: uppercase
  - id: password_policy_character_constraint
    character_count: 1
    character_type: lowercase
roles:
  authenticated: authenticated
  editor: editor

error: patch failed: modules/varbase_security/config/optional/password_policy.password_policy.default_policy.yml:1
error: modules/varbase_security/config/optional/password_policy.password_policy.default_policy.yml: patch does not apply
Checking patch modules/varbase_security/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_security/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_security/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_security/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_security/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_security/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_security/config/permissions/user.permissions.editor.yml...
error: modules/varbase_security/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_security/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_security/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_security/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_security/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_security/includes/helpers.inc...
error: modules/varbase_security/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_security/includes/updates.inc...
error: modules/varbase_security/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_security/includes/updates/v9.inc...
error: modules/varbase_security/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_security/src/Form/PasswordSuggestionsSettingsForm.php...
Checking patch modules/varbase_security/varbase_security.info.yml...
error: while searching for:
name: "Varbase Security"
description: "Manages general security configurations, with password policy, username enumeration prevention, security kit and review."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - varbase_core:varbase_core
install:

error: patch failed: modules/varbase_security/varbase_security.info.yml:1
error: modules/varbase_security/varbase_security.info.yml: patch does not apply
Checking patch modules/varbase_security/varbase_security.install...
error: while searching for:
 * Install, update and uninstall functions for the Varbase Security.
 */

use Symfony\Component\Yaml\Yaml;
use Drupal\Core\Config\InstallStorage;
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_install().
 */
function varbase_security_install() {

  // Processer for install: in varbase_security.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_security');

  // Install optional configs.

error: patch failed: modules/varbase_security/varbase_security.install:5
error: modules/varbase_security/varbase_security.install: patch does not apply
Checking patch modules/varbase_security/varbase_security.module...
error: while searching for:
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_form_FORM_ID_alter() for user_form().
 */
function varbase_security_form_user_form_alter(&$form, &$form_state) {
  if (\Drupal::moduleHandler()->moduleExists('password_policy')) {
    if (isset($form['account']['password_policy_status'])) {
      // Hide the password policy status table.
      unset($form['account']['password_policy_status']);
    }
  }
}

/**
 * Implements hook_element_info_alter().
 */

error: patch failed: modules/varbase_security/varbase_security.module:8
error: modules/varbase_security/varbase_security.module: patch does not apply
Checking patch modules/varbase_tour/.csscomb.json...
error: while searching for:
      "$viewport"
    ]
  ]
}
error: patch failed: modules/varbase_tour/.csscomb.json:489
error: modules/varbase_tour/.csscomb.json: patch does not apply
Checking patch modules/varbase_tour/.eslintignore...
error: while searching for:
**/*.min.js
gulpfile.js
**/node_modules
.md
error: patch failed: modules/varbase_tour/.eslintignore:1
error: modules/varbase_tour/.eslintignore: patch does not apply
Checking patch modules/varbase_tour/.eslintrc.json...
error: while searching for:
    "no-unused-vars": ["warn"],
    "operator-linebreak": ["error", "after", { "overrides": { "?": "ignore", ":": "ignore" } }]
  }
}
error: patch failed: modules/varbase_tour/.eslintrc.json:49
error: modules/varbase_tour/.eslintrc.json: patch does not apply
Checking patch modules/varbase_tour/.gitignore...
error: modules/varbase_tour/.gitignore: No such file or directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_tour/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_tour/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_tour/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.editor.yml...
error: modules/varbase_tour/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_tour/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_tour/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_tour/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_tour/css/theme/tour.admin.theme.css...
error: while searching for:
  background-image: none;
}
.joyride-tip-guide .button:focus {
  border-color: #68a3cf;
  outline: #c1e0ff solid 2px;
  box-shadow: none;
}
.joyride-tip-guide .button-action:before {

error: patch failed: modules/varbase_tour/css/theme/tour.admin.theme.css:59
error: modules/varbase_tour/css/theme/tour.admin.theme.css: patch does not apply
Checking patch modules/varbase_tour/css/theme/tour.default.theme.css...
error: while searching for:
  left: auto;
}
.joyride-tip-guide .button {
  position: relative;
  display: inline-block;
  box-sizing: border-box;
  /* 3 */
  padding: 0.25em 1.5em;
  -webkit-appearance: none;
  /* 3 */
  -moz-appearance: none;
  /* 2 */
  cursor: pointer;
  transition: all 0.1s;
  /* 1 */
  text-align: center;
  text-decoration: none;
  color: #333;
  /* 4 */
  border: 1px solid #a6a6a6;
  border-radius: 0;
  background-color: #f2f1eb;
  text-shadow: 0 1px rgba(255, 255, 255, 0.6);
  font-size: 0.875rem;
  font-weight: 600;
  line-height: normal;
  -webkit-font-smoothing: antialiased;
  /* 6 */
}
.joyride-tip-guide .button:hover,
.joyride-tip-guide .button:focus {

error: patch failed: modules/varbase_tour/css/theme/tour.default.theme.css:11
error: modules/varbase_tour/css/theme/tour.default.theme.css: patch does not apply
Checking patch modules/varbase_tour/includes/helpers.inc...
error: modules/varbase_tour/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_tour/includes/updates.inc...
error: modules/varbase_tour/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_tour/includes/updates/v9.inc...
error: modules/varbase_tour/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_tour/package.json...
error: while searching for:
  "main": "gulpfile.js",
  "engines": {
    "yarn": ">= 1.6",
    "node": ">= 16.0"
  },
  "scripts": {
    "theme:init": "gulp",

error: patch failed: modules/varbase_tour/package.json:6
error: modules/varbase_tour/package.json: patch does not apply
Checking patch modules/varbase_tour/scss/theme/tour.default.theme.scss...
error: while searching for:
}

.shepherd-element {
  z-index: 999;



  .button {
    display: inline-block;

error: patch failed: modules/varbase_tour/scss/theme/tour.default.theme.scss:123
error: modules/varbase_tour/scss/theme/tour.default.theme.scss: patch does not apply
Checking patch modules/varbase_tour/templates/welcome-modal.html.twig...
error: while searching for:
          <div class="text-center">
            <h3>{{ 'Welcome to'|t }} <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAG4AAAAhCAYAAAA4VZ5CAAAACXBIWXMAAAsTAAALEwEAmpwYAAA4UGlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPD94cGFja2V0IGJlZ2luPSLvu78iIGlkPSJXNU0wTXBDZWhpSHpyZVN6TlRjemtjOWQiPz4KPHg6eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iQWRvYmUgWE1QIENvcmUgNS41LWMwMTQgNzkuMTUxNDgxLCAyMDEzLzAzLzEzLTEyOjA5OjE1ICAgICAgICAiPgogICA8cmRmOlJERiB4bWxuczpyZGY9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMiPgogICAgICA8cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgICAgICAgICB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8iCiAgICAgICAgICAgIHhtbG5zOmRjPSJodHRwOi8vcHVybC5vcmcvZGMvZWxlbWVudHMvMS4xLyIKICAgICAgICAgICAgeG1sbnM6cGhvdG9zaG9wPSJodHRwOi8vbnMuYWRvYmUuY29tL3Bob3Rvc2hvcC8xLjAvIgogICAgICAgICAgICB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIKICAgICAgICAgICAgeG1sbnM6c3RFdnQ9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZUV2ZW50IyIKICAgICAgICAgICAgeG1sbnM6dGlmZj0iaHR0cDovL25zLmFkb2JlLmNvbS90aWZmLzEuMC8iCiAgICAgICAgICAgIHhtbG5zOmV4aWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20vZXhpZi8xLjAvIj4KICAgICAgICAgPHhtcDpDcmVhdGVEYXRlPjIwMTctMDktMjFUMTU6MDY6MTgrMDM6MDA8L3htcDpDcmVhdGVEYXRlPgogICAgICAgICA8eG1wOk1vZGlmeURhdGU+MjAxNy0wOS0yMVQxNTowNzowMSswMzowMDwveG1wOk1vZGlmeURhdGU+CiAgICAgICAgIDx4bXA6TWV0YWRhdGFEYXRlPjIwMTctMDktMjFUMTU6MDc6MDErMDM6MDA8L3htcDpNZXRhZGF0YURhdGU+CiAgICAgICAgIDx4bXA6Q3JlYXRvclRvb2w+QWRvYmUgUGhvdG9zaG9wIENDIChNYWNpbnRvc2gpPC94bXA6Q3JlYXRvclRvb2w+CiAgICAgICAgIDxkYzpmb3JtYXQ+aW1hZ2UvcG5nPC9kYzpmb3JtYXQ+CiAgICAgICAgIDxwaG90b3Nob3A6Q29sb3JNb2RlPjM8L3Bob3Rvc2hvcDpDb2xvck1vZGU+CiAgICAgICAgIDx4bXBNTTpJbnN0YW5jZUlEPnhtcC5paWQ6ZjY0NmU3MTQtZGNmNC00OGMzLWEwY2ItN2I2N2NiNGUwYjcwPC94bXBNTTpJbnN0YW5jZUlEPgogICAgICAgICA8eG1wTU06RG9jdW1lbnRJRD54bXAuZGlkOmY2NDZlNzE0LWRjZjQtNDhjMy1hMGNiLTdiNjdjYjRlMGI3MDwveG1wTU06RG9jdW1lbnRJRD4KICAgICAgICAgPHhtcE1NOk9yaWdpbmFsRG9jdW1lbnRJRD54bXAuZGlkOmY2NDZlNzE0LWRjZjQtNDhjMy1hMGNiLTdiNjdjYjRlMGI3MDwveG1wTU06T3JpZ2luYWxEb2N1bWVudElEPgogICAgICAgICA8eG1wTU06SGlzdG9yeT4KICAgICAgICAgICAgPHJkZjpTZXE+CiAgICAgICAgICAgICAgIDxyZGY6bGkgcmRmOnBhcnNlVHlwZT0iUmVzb3VyY2UiPgogICAgICAgICAgICAgICAgICA8c3RFdnQ6YWN0aW9uPnNhdmVkPC9zdEV2dDphY3Rpb24+CiAgICAgICAgICAgICAgICAgIDxzdEV2dDppbnN0YW5jZUlEPnhtcC5paWQ6ZjY0NmU3MTQtZGNmNC00OGMzLWEwY2ItN2I2N2NiNGUwYjcwPC9zdEV2dDppbnN0YW5jZUlEPgogICAgICAgICAgICAgICAgICA8c3RFdnQ6d2hlbj4yMDE3LTA5LTIxVDE1OjA3OjAxKzAzOjAwPC9zdEV2dDp3aGVuPgogICAgICAgICAgICAgICAgICA8c3RFdnQ6c29mdHdhcmVBZ2VudD5BZG9iZSBQaG90b3Nob3AgQ0MgKE1hY2ludG9zaCk8L3N0RXZ0OnNvZnR3YXJlQWdlbnQ+CiAgICAgICAgICAgICAgICAgIDxzdEV2dDpjaGFuZ2VkPi88L3N0RXZ0OmNoYW5nZWQ+CiAgICAgICAgICAgICAgIDwvcmRmOmxpPgogICAgICAgICAgICA8L3JkZjpTZXE+CiAgICAgICAgIDwveG1wTU06SGlzdG9yeT4KICAgICAgICAgPHRpZmY6T3JpZW50YXRpb24+MTwvdGlmZjpPcmllbnRhdGlvbj4KICAgICAgICAgPHRpZmY6WFJlc29sdXRpb24+NzIwMDAwLzEwMDAwPC90aWZmOlhSZXNvbHV0aW9uPgogICAgICAgICA8dGlmZjpZUmVzb2x1dGlvbj43MjAwMDAvMTAwMDA8L3RpZmY6WVJlc29sdXRpb24+CiAgICAgICAgIDx0aWZmOlJlc29sdXRpb25Vbml0PjI8L3RpZmY6UmVzb2x1dGlvblVuaXQ+CiAgICAgICAgIDxleGlmOkNvbG9yU3BhY2U+NjU1MzU8L2V4aWY6Q29sb3JTcGFjZT4KICAgICAgICAgPGV4aWY6UGl4ZWxYRGltZW5zaW9uPjExMDwvZXhpZjpQaXhlbFhEaW1lbnNpb24+CiAgICAgICAgIDxleGlmOlBpeGVsWURpbWVuc2lvbj4zMzwvZXhpZjpQaXhlbFlEaW1lbnNpb24+CiAgICAgIDwvcmRmOkRlc2NyaXB0aW9uPgogICA8L3JkZjpSREY+CjwveDp4bXBtZXRhPgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC
error: patch failed: modules/varbase_tour/templates/welcome-modal.html.twig:85
error: modules/varbase_tour/templates/welcome-modal.html.twig: patch does not apply
Checking patch modules/varbase_tour/varbase_tour.info.yml...
error: while searching for:
name: "Varbase Tour"
description: "Provide Tours for varbase."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - drupal:tour

error: patch failed: modules/varbase_tour/varbase_tour.info.yml:1
error: modules/varbase_tour/varbase_tour.info.yml: patch does not apply
Checking patch modules/varbase_tour/varbase_tour.install...
error: while searching for:
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_install().
 */
function varbase_tour_install() {

  // Processer for install: in varbase_tour.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_tour');

  // Install optional configs.

error: patch failed: modules/varbase_tour/varbase_tour.install:8
error: modules/varbase_tour/varbase_tour.install: patch does not apply
Checking patch modules/varbase_tour/varbase_tour.module...
error: while searching for:

    // When the url is NOT an admin route or in the admin theme.
    if (!\Drupal::service('router.admin_context')->isAdminRoute()) {
      // Then attach the seven tour styling library.
      // And attach the varbase tour default theme library.
      $page['#attached']['library'][] = 'seven/tour-styling';
      // $page['#attached']['library'][] = 'varbase_tour/admin-theme';
      $page['#attached']['library'][] = 'varbase_tour/default-theme';
    }


error: patch failed: modules/varbase_tour/varbase_tour.module:14
error: modules/varbase_tour/varbase_tour.module: patch does not apply
Checking patch modules/varbase_tour/yarn.lock...
error: modules/varbase_tour/yarn.lock: No such file or directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.editor.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_update_helper/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_update_helper/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_update_helper/drush.services.yml...
error: modules/varbase_update_helper/drush.services.yml: No such file or directory
Checking patch modules/varbase_update_helper/src/Commands/VarbaseUpdateHelperCommands.php...
error: while searching for:
  /**
   * {@inheritdoc}
   */
  public function setLogger(LoggerInterface $logger) {
    parent::setLogger($logger);
    $this->commandHelper->setLogger($logger);
  }

error: patch failed: modules/varbase_update_helper/src/Commands/VarbaseUpdateHelperCommands.php:32
error: modules/varbase_update_helper/src/Commands/VarbaseUpdateHelperCommands.php: patch does not apply
Checking patch modules/varbase_update_helper/varbase_update_helper.info.yml...
error: while searching for:
name: "Varbase Updates Helper"
description: "Provides a UI to review Varbase Updates that are made available in every version."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - checklistapi:checklistapi
  - update_helper:update_helper

error: patch failed: modules/varbase_update_helper/varbase_update_helper.info.yml:1
error: modules/varbase_update_helper/varbase_update_helper.info.yml: patch does not apply
Checking patch modules/varbase_update_helper/varbase_update_helper.install...
error: while searching for:
 */

use Drupal\update_helper_checklist\Entity\Update;

/**
 * Implements hook_install().

error: patch failed: modules/varbase_update_helper/varbase_update_helper.install:6
error: modules/varbase_update_helper/varbase_update_helper.install: patch does not apply
Checking patch modules/varbase_update_helper/varbase_update_helper.module...
Checking patch modules/varbase_update_helper/varbase_update_helper.services.yml...
error: while searching for:
    class: Drupal\varbase_update_helper\Routing\RouteSubscriber
    tags:
      - { name: event_subscriber }

error: patch failed: modules/varbase_update_helper/varbase_update_helper.services.yml:3
error: modules/varbase_update_helper/varbase_update_helper.services.yml: patch does not apply
Checking patch modules/varbase_webform/config/permissions/user.permissions.anonymous.yml...
error: modules/varbase_webform/config/permissions/user.permissions.anonymous.yml: already exists in working directory
Checking patch modules/varbase_webform/config/permissions/user.permissions.authenticated.yml...
error: modules/varbase_webform/config/permissions/user.permissions.authenticated.yml: already exists in working directory
Checking patch modules/varbase_webform/config/permissions/user.permissions.content_admin.yml...
error: modules/varbase_webform/config/permissions/user.permissions.content_admin.yml: already exists in working directory
Checking patch modules/varbase_webform/config/permissions/user.permissions.editor.yml...
error: modules/varbase_webform/config/permissions/user.permissions.editor.yml: already exists in working directory
Checking patch modules/varbase_webform/config/permissions/user.permissions.seo_admin.yml...
error: modules/varbase_webform/config/permissions/user.permissions.seo_admin.yml: already exists in working directory
Checking patch modules/varbase_webform/config/permissions/user.permissions.site_admin.yml...
error: modules/varbase_webform/config/permissions/user.permissions.site_admin.yml: already exists in working directory
Checking patch modules/varbase_webform/includes/helpers.inc...
error: modules/varbase_webform/includes/helpers.inc: already exists in working directory
Checking patch modules/varbase_webform/includes/updates.inc...
error: modules/varbase_webform/includes/updates.inc: already exists in working directory
Checking patch modules/varbase_webform/includes/updates/v8.inc...
error: modules/varbase_webform/includes/updates/v8.inc: already exists in working directory
Checking patch modules/varbase_webform/includes/updates/v9.inc...
error: modules/varbase_webform/includes/updates/v9.inc: already exists in working directory
Checking patch modules/varbase_webform/varbase_webform.info.yml...
error: while searching for:
name: "Varbase Webform"
description: "Provide webforms features and settings."
type: module
package: Varbase
core_version_requirement: ^9
dependencies:
  - webform:webform
install:

error: patch failed: modules/varbase_webform/varbase_webform.info.yml:1
error: modules/varbase_webform/varbase_webform.info.yml: patch does not apply
Checking patch modules/varbase_webform/varbase_webform.install...
error: while searching for:
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;

/**
 * Implements hook_install().
 */
function varbase_webform_install() {

  // Processer for install: in varbase_webform.info.yml file using ModuleInstallerFactory.
  // ---------------------------------------------------------------------------.
  ModuleInstallerFactory::installList('varbase_webform');

  // Install optional configs.

error: patch failed: modules/varbase_webform/varbase_webform.install:8
error: modules/varbase_webform/varbase_webform.install: patch does not apply
Checking patch package.json...
error: while searching for:
  "main": "gulpfile.js",
  "engines": {
    "yarn": ">= 1.6",
    "node": ">= 12.0"
  },
  "scripts": {
    "theme:init": "gulp",

error: patch failed: package.json:6
error: package.json: patch does not apply
Checking patch src/Drush/Commands/VarbaseCoreCommands.php...
error: src/Drush/Commands/VarbaseCoreCommands.php: already exists in working directory
Checking patch src/Form/VarbaseGeneralSettingsForm.php...
error: while searching for:
    $config = $this->config('varbase_core.general_settings');
    $form['settings']['welcome_status'] = [
      '#type' => 'checkbox',
      '#default_value' => $config->get('welcome_status'),
      '#title' => $this->t('Allow site to show welcome message'),
      '#description' => $this->t('This option will allow to display Varbase\'s welcome message on the homepage by adding <code>?welcome

to the URL. This option is automatically disabled after closing the welcome message. Check this then navigate to @front_page_with_welcome to see the welcome message again.', ['@front_page_with_welcome' => $front_page_with_welcome]),
];

return parent::buildForm($form, $form_state);
}

error: patch failed: src/Form/VarbaseGeneralSettingsForm.php:34
error: src/Form/VarbaseGeneralSettingsForm.php: patch does not apply
Checking patch varbase_core.info.yml...
error: while searching for:
name: "Varbase Core"
description: "Provides core components required by other features."
type: module
core_version_requirement: ^9
package: Varbase
configure: varbase_core.settings_index
components:
- varbase_admin
- varbase_default_content
- varbase_development
- varbase_internationalization
- varbase_page
- varbase_security
- varbase_tour
- varbase_webform
- varbase_update_helper
dependencies:
- drupal:user
- drupal:node

error: patch failed: varbase_core.info.yml:1
error: varbase_core.info.yml: patch does not apply
Checking patch varbase_core.install...
error: while searching for:
* Install, update and uninstall functions for the Varbase core module.
*/

use Symfony\Component\Yaml\Yaml;
use Drupal\Core\Config\InstallStorage;
use Drupal\file\Entity\File;
use Drupal\embed\Entity\EmbedButton;
use Drupal\update_helper_checklist\Entity\Update;
use Vardot\Entity\EntityDefinitionUpdateManager;
use Vardot\Installer\ModuleInstallerFactory;
use Drupal\Core\File\FileSystemInterface;

/**
* Implements hook_install().
*/
function varbase_core_install() {

// Processer for install: in varbase_core.info.yml file using ModuleInstallerFactory.
// --------------------------------------------------------------------------.
ModuleInstallerFactory::installList('varbase_core');

error: patch failed: varbase_core.install:5
error: varbase_core.install: patch does not apply
Checking patch varbase_core.module...
error: while searching for:
*/

use Drupal\Core\Form\FormStateInterface;
use Vardot\Entity\EntityDefinitionUpdateManager;

// To have all varbase core general and global tokens.
\Drupal::moduleHandler()->loadInclude('varbase_core', 'inc', 'varbase_core.tokens');

/**
* Implements hook_FORM_ID_form_alter().

error: patch failed: varbase_core.module:6
error: varbase_core.module: patch does not apply
Checking patch varbase_core.services.yml...
error: varbase_core.services.yml: already exists in working directory
Checking patch yarn.lock...
error: while searching for:
# yarn lockfile v1

"@ampproject/remapping@^2.1.0":
version "2.1.2"
resolved "https://registry.yarnpkg.com/@ampproject/remapping/-/remapping-2.1.2.tgz..."
integrity sha512-hoyByceqwKirw7w3Z7gnIIZC3Wx3J484Y3L/cMpXFbr7d9ZQj2mODrirNzcJa+SM3UlpWXYvKV4RlRpFXlWgXg==
dependencies:
"@jridgewell/trace-mapping" "^0.3.0"

"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.16.7":
version "7.16.7"
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.16.7.tgz#4..."
integrity sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg==
dependencies:
"@babel/highlight" "^7.16.7"

"@babel/compat-data@^7.13.11", "@babel/compat-data@^7.16.8", "@babel/compat-data@^7.17.0", "@babel/compat-data@^7.17.7":
version "7.17.7"
resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.17.7.tgz..."
integrity sha512-p8pdE6j0a29TNGebNm7NzYZWB3xVZJBZ7XGs42uAKzQo8VQ3F0By/cQCtUEABwIqw5zo6WA4NbmxsfzADzMKnQ==

"@babel/core@^7.8.4", "@babel/core@~7":
version "7.17.8"
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.17.8.tgz#3dac27c190ebc..."
integrity sha512-OdQDV/7cRBtJHLSOBqqbYNkOcydOgnX59TZx4puf41fzcVtN3e/4yqY8lMQsK+5X2lJtAdmA+6OHqsj1hBJ4IQ==
dependencies:
"@ampproject/remapping" "^2.1.0"
"@babel/code-frame" "^7.16.7"
"@babel/generator" "^7.17.7"
"@babel/helper-compilation-targets" "^7.17.7"
"@babel/helper-module-transforms" "^7.17.7"
"@babel/helpers" "^7.17.8"
"@babel/parser" "^7.17.8"
"@babel/template" "^7.16.7"
"@babel/traverse" "^7.17.3"
"@babel/types" "^7.17.0"
convert-source-map "^1.7.0"
debug "^4.1.0"
gensync "^1.0.0-beta.2"
json5 "^2.1.2"
semver "^6.3.0"

"@babel/generator@^7.17.3", "@babel/generator@^7.17.7":
version "7.17.7"
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.17.7.tgz#8da..."
integrity sha512-oLcVCTeIFadUoArDTwpluncplrYBmTCCZZgXCbgNGvOBBiSDDK3eWO4b/+eOTli5tKv1lg+a5/NAXg+nTcei1w==
dependencies:
"@babel/types" "^7.17.0"
jsesc "^2.5.1"
source-map "^0.5.0"

"@babel/helper-annotate-as-pure@^7.16.7":
version "7.16.7"
resolved "https://registry.yarnpkg.com/@babel/helper-annotate-as-pure/-/helper-ann..."
integrity sha512-s6t2w/IPQVTAET1HitoowRGXooX8mCgtuP5195wD/QJPV6wYjpujCGF7JuMODVX2ZAJOf1GT6DT9MHEZvLOFSw==
dependencies:
"@babel/types" "^7.16.7"

"@babel/helper-builder-binary-assignment-operator-visitor@^7.16.7":
version "7.16.7"
resolved "https://registry.yarnpkg.com/@babel/helper-builder-binary-assignment-ope..."
integrity sha512-C6FdbRaxYjwVu/geKW4ZeQ0Q31AftgRcdSnZ5/jsH6BzCJbtvXvhpfkbkThYSuutZA7nCXpPR6AD9zd1dprMkA==
dependencies:
"@babel/helper-explode-assignable-expression" "^7.16.7"
"@babel/types" "^7.16.7"

"@babel/helper-compilation-targets@^7.13.0", "@babel/helper-compilation-targets@^7.16.7", "@babel/helper-compilation-targets@^7.17.7":
version "7.17.7"
resolved "https://registry.yarnpkg.com/@babel/helper-compilation-targets/-/helper-..."
integrity sha512-UFzlz2jjd8kroj0hmCFV5zr+tQPi1dpC2cRsDV/3IEW8bJfCPrPpmcSN6ZS8RqIq4LXcmpipCQFPddyFA5Yc7w==
dependencies:
"@babel/compat-data" "^7.17.7"
"@babel/helper-validator-option" "^7.16.7"
browserslist "^4.17.5"
semver "^6.3.0"

"@babel/helper-create-class-features-plugin@^7.16.10", "@babel/helper-create-class-features-plugin@^7.16.7", "@babel/helper-create-class-features-plugin@^7.17.6":
version "7.17.6"
resolved "https://registry.yarnpkg.com/@babel/helper-create-class-features-plugin/..."
integrit
error: patch failed: yarn.lock:2
error: yarn.lock: patch does not apply

The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

Resolved in 3.0.1 release.
Thank you for your contribution.

Rebased and made minor changes to make pipelines green for all.

Hi

I applied the updated MR !20 after commit #14 and I can still see many PHPCS issues:

➜  views_remote_data git:(1.0.x) curl https://git.drupalcode.org/project/views_remote_data/-/merge_requests/20.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6783    0  6783    0     0  13277      0 --:--:-- --:--:-- --:--:-- 13647
patching file 'tests/src/Kernel/Events/RemoteDataQueryEventTest.php'
patching file 'tests/src/Kernel/Plugin/views/ViewsPluginTestBase.php'
patching file 'tests/src/Kernel/Plugin/views/argument/PropertyArgumentTest.php'
patching file 'tests/src/Kernel/Plugin/views/field/PropertyFieldTest.php'
patching file 'tests/src/Kernel/Plugin/views/filter/PropertyFilterTest.php'
patching file 'tests/src/Kernel/Plugin/views/query/RemoteDataQueryTest.php'
patching file 'tests/src/Kernel/Plugin/views/sort/PropertySortTest.php'
➜  views_remote_data git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_remote_data 

FILE: ...ta_pokeapi/config/install/core.entity_view_display.node.pokemon.teaser.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 35 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...a_pokeapi/config/install/core.entity_view_display.node.pokemon.default.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 34 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ontrib/views_remote_data/tests/modules/views_remote_data_pokeapi/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  5 | WARNING | Line exceeds 80 characters; contains 119 characters
  6 | WARNING | Line exceeds 80 characters; contains 119 characters
 11 | WARNING | Line exceeds 80 characters; contains 111 characters
 16 | WARNING | Line exceeds 80 characters; contains 89 characters
--------------------------------------------------------------------------------


FILE: ...ws_remote_data/tests/src/Kernel/Events/RemoteDataLoadEntitiesEventTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  8 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Component\Serialization\Json.
 26 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../Projects/d10/drupal_local/web/modules/contrib/views_remote_data/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 119 characters
--------------------------------------------------------------------------------

Time: 754ms; Memory: 12MB

➜  contrib git:(main) ✗ 

HI

I also cloned the module and the dedicated version and applied the patch and confirmed that it fixes PHPCS isses.

➜  search_api_weaviate git:(1.0.x) curl https://www.drupal.org/files/issues/2023-11-01/phpcs-issue-fixes_1.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6189  100  6189    0     0  13859      0 --:--:-- --:--:-- --:--:-- 14130
patching file search_api_weaviate.module
patching file 'src/Plugin/search_api/backend/SearchApiWeaviateBackend.php'
➜  search_api_weaviate git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml search_api_weaviate 
➜  contrib git:(main) ✗ 

However, for maintainer's convenience can you create a merge request with your patch so that they can easily merge it once it passes the community? moving this ticket to needs work for that.

eugene_bsk → changed the visibility of the branch 3462349-fix-phpcs-errors to active.

eugene_bsk → changed the visibility of the branch 3462349-fix-phpcs-errors to hidden.

@hetalsolanki
Did you test changes?

Error: Call to undefined method Drupal\redirects_fixer\BatchManager::configFactory() in Drupal\redirects_fixer\BatchManager->__construct() (line 128 of modules/contrib/redirects_fixer/src/BatchManager.php).

Thanks, @quietone, I agree that doing this without an invented method makes more sense.
The new example just has the slight downside that it doesn’t include an example for destructuring an associative array.
Do you think just adding `[1 => $hotter] = $stars;` would help, maybe preceded by a comment explaining that this is how you’d destructure an associative array? Or do we add a second, associative array? (Or is the majority against adding an example for associative destructuring?)

Does this now need to cover the shorthand array destructuring syntax?

Could you please elaborate, what syntax do you mean?