#Coding standards

cspell was random, re-running fixed it.

Additional change seems fine to me.

Change required in ElementInfoManager.php.

📌 Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard, pt 1 Active has been merged, so unpostponing this now.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thanks for the merge. That's really useful information about the 'avoid commit conflicts' tag, I was unaware that there was a procedure to assist with that. Very useful.

catch → closed merge request !11513

This looks fine. There were a couple where I wondered about using @code instead of quotes, but this is all inline comments and not making anything worse.

Given the amount of commit conflicts this had, it might have been worth adding the 'avoid commit conflicts' tag and pinging people in slack about it, we could have made it an 11.2 rc target too for when there was a bit less volume of commits maybe too.

Committed/pushed to 11.x, thanks!

@immaculatexavier, the MR looks fine. The only thing is to remember to check that tests are passing before setting an issue to Needs Review. There was a failing test, which I presume, is why this was set back to Needs work. In this case the solution was simply to rerun the failing linting test. Then, since that passed the next step was to start the tests. All that is from the GitLab UI.

I reran test failing tests and tests are passing now.

Please review the patch

Automatically closed - issue fixed for 2 weeks with no activity.