#Coding standards

Hi @akashkumar07,
I've updated the constructor parameter details and verified the code with PHPCS — no warnings or errors were reported.
Please review and let me know if anything else needs to be addressed.
Thanks..

Hi @Vinodhini
There are couple of small changes required related to coding standard in the MR.
Thanks!

Superseded by 📌 Fix the issues reported by phpcs Needs work .

vinodhini.e → made their first commit to this issue’s fork.

Hi

I reviewed MR!26, applied to Popup message 3.x-dev, and confirmed it fixes the issue reported by phpcs.

➜  popup_message git:(3.x) curl https://git.drupalcode.org/project/popup_message/-/merge_requests/26.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4553    0  4553    0     0   3944      0 --:--:--  0:00:01 --:--:--  3966
patching file popup_message.module
patching file 'src/Enum/PopupMessageDefaultValues.php'
patching file 'src/EventSubscriber/PopupMessageSubscriber.php'
patching file 'src/Form/PopupMessageSettingsForm.php'
➜  popup_message git:(3.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig popup_message
➜  contrib git:(main) ✗

Moving this to RTBC.
Thank you.

I think neograph734 is correct: That documentation page says to use Commerce (contrib).

I do not think that documentation page says something contrary to the documentation about module packages we have on drupal.org.

codebymikey → closed merge request !4

Thanks for all the work done on this guy!

Hi,

After reviewing and applied the latest changes under MR!3 to the Backup and Migrate: BackBeaver module against 2.0.0-beta2 and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,yml backup_migrate_backbeaver

Please see the attached file for reference.

I'm moving this now to ‘RTBC’.

Thank you!

When I install the theme in a DrupalPod instance running D10.3 and with this patch applied and then view the homepage, I get this error:

Drupal\Core\Render\Component\Exception\InvalidComponentException: [items[1].text] Object value found, but a string is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).

and when I run phpcs I get this:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/themes/contrib/prototype

FILE: /var/www/html/repos/prototype/components/02-components/page-title/page-title.css
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: /var/www/html/repos/prototype/components/05-pages/basic/basic.css
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /var/www/html/repos/prototype/prototype.theme
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 211 | WARNING | Hook implementations should not duplicate @param documentation
--------------------------------------------------------------------------------

I can confirm that I get no output when running the above command (on a DrupalPod instance running D10.3.14).

I'm going to move the changes for HookOrder to another issue. Assigning to myself for that and to review other local changes before pushing.